)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"37499834fb8b012805336070199ea3595758c507","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b94d88d5_f9e6c6a9","updated":"2025-06-03 10:05:21.000000000","message":"I tested as Depends-On here: https://zuul.opendev.org/t/openstack/build/804e1ea399cf49fe8b65a31875b2d3e9 and it seems to work correctly. The python-observabilityclient got cloned from git as I wanted.","commit_id":"36a31cc74a00ded83da64e2c2afd436fad18d4cb"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"4e204c02347221fb83b8ecda02de878495eb7951","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c2fd75b2_4a945ab4","updated":"2025-06-23 18:36:55.000000000","message":"I decided to try adding the functionality into the devstack-plugin-prometheus, which might be a bit better fit, since observabilityclient is basically the openstack prometheus client right now. So let\u0027s hold this in WIP and based on how that review turns out I\u0027ll either mark this as ready for review or close it.","commit_id":"77713f5c6f25c3dd3c5aa962dd8d21a7dcf9e72f"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"5ef5debc471ae9be82f67e94a8a95544d325da93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cd392104_64c86624","updated":"2025-06-23 15:42:46.000000000","message":"code looks good, thanks Jaromir!","commit_id":"77713f5c6f25c3dd3c5aa962dd8d21a7dcf9e72f"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c18ab96c267181a497c03b127da519ae5b2dc264","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b9ec9353_70f4fe78","updated":"2025-06-23 15:38:41.000000000","message":"recheck","commit_id":"77713f5c6f25c3dd3c5aa962dd8d21a7dcf9e72f"}],"lib/libraries":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8121f1180383980473ab3c5fa68f58b75f8a9437","unresolved":true,"context_lines":[{"line_number":130,"context_line":"    #"},{"line_number":131,"context_line":"    # python client libraries we might need from git can go here"},{"line_number":132,"context_line":"    _install_lib_from_source \"python-barbicanclient\""},{"line_number":133,"context_line":"    _install_lib_from_source \"python-observabilityclient\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    # etcd (because tooz does not have a hard dependency on these)"},{"line_number":136,"context_line":"    pip_install etcd3gw"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"4b6ae725_10776ae5","line":133,"updated":"2025-06-03 11:15:25.000000000","message":"Do you want this installed in *all* environments? I\u0027m surprised even barbicanclient is here, tbh.","commit_id":"fa1bd3d79447f4b89a9f341b11bba18eff890389"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"ccebfc9420e99836e10b1c5dee4477924c6ed732","unresolved":true,"context_lines":[{"line_number":130,"context_line":"    #"},{"line_number":131,"context_line":"    # python client libraries we might need from git can go here"},{"line_number":132,"context_line":"    _install_lib_from_source \"python-barbicanclient\""},{"line_number":133,"context_line":"    _install_lib_from_source \"python-observabilityclient\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    # etcd (because tooz does not have a hard dependency on these)"},{"line_number":136,"context_line":"    pip_install etcd3gw"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7659d7b7_e28ade82","line":133,"in_reply_to":"4b6ae725_10776ae5","updated":"2025-06-03 12:36:29.000000000","message":"Do these always install? Even when not specified in LIBS_FROM_GIT? From the comment here https://opendev.org/openstack/devstack/src/branch/master/lib/libraries#L87 I understood that this will install the library only when specified in LIBS_FROM_GIT.\n\nIt\u0027s a dependency for Aetos and an optional dependency for Aodh and Watcher (and possibly others in the future). So this doesn\u0027t need to be install every time. The ultimate goal here right now is, that I wanted to test unreleased content in a tempest job. The beginning of that is here: https://review.opendev.org/c/openstack/telemetry-tempest-plugin/+/951387\n\nI\u0027ll try to do 2 devstack deployments. One with python-observability specified in the LIBS_FROM_GIT and one without it and see what happens. I\u0027ll be back in about an hour.","commit_id":"fa1bd3d79447f4b89a9f341b11bba18eff890389"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d29a41abe4fbc93037632bd3de5a1e7a874e2cb5","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    #"},{"line_number":131,"context_line":"    # python client libraries we might need from git can go here"},{"line_number":132,"context_line":"    _install_lib_from_source \"python-barbicanclient\""},{"line_number":133,"context_line":"    _install_lib_from_source \"python-observabilityclient\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    # etcd (because tooz does not have a hard dependency on these)"},{"line_number":136,"context_line":"    pip_install etcd3gw"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"8b99c706_ea9dd11f","line":133,"in_reply_to":"52b64f9a_aee3f936","updated":"2025-06-23 15:57:33.000000000","message":"Ah, indeed. There\u0027s a call to `use_library_from_git` in `_install_lib_from_source` that will prevent this being installed unless requested. Thanks for validating this.","commit_id":"fa1bd3d79447f4b89a9f341b11bba18eff890389"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"29ee238e77a8a4dd4df3641dbde553fac2d6a9a1","unresolved":true,"context_lines":[{"line_number":130,"context_line":"    #"},{"line_number":131,"context_line":"    # python client libraries we might need from git can go here"},{"line_number":132,"context_line":"    _install_lib_from_source \"python-barbicanclient\""},{"line_number":133,"context_line":"    _install_lib_from_source \"python-observabilityclient\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    # etcd (because tooz does not have a hard dependency on these)"},{"line_number":136,"context_line":"    pip_install etcd3gw"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"52b64f9a_aee3f936","line":133,"in_reply_to":"7659d7b7_e28ade82","updated":"2025-06-03 16:22:11.000000000","message":"Here is how my 2 VMs look. First one is with the python-observabilityclient specified inside the LIBS_FROM_GIT, the second one is without it. When specified, it got installed from git as expected, when not specified, I don\u0027t see the client in the environment. https://paste.opendev.org/show/bFh4dsMwKY7JoKOTO8pJ/ So I don\u0027t think this always installs the library.","commit_id":"fa1bd3d79447f4b89a9f341b11bba18eff890389"}]}