)]}'
{".zuul.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e55aca5556d37dbce503a3ff628b424818ab9642","unresolved":true,"context_lines":[{"line_number":584,"context_line":"        # virt driver."},{"line_number":585,"context_line":"        NOVA_LIBVIRT_TB_CACHE_SIZE: 128"},{"line_number":586,"context_line":"        ENABLE_ZSWAP: true"},{"line_number":587,"context_line":"        OVN_AGENT_EXTENSIONS: \u0027metadata\u0027"},{"line_number":588,"context_line":"      devstack_local_conf:"},{"line_number":589,"context_line":"        post-config:"},{"line_number":590,"context_line":"          $NEUTRON_CONF:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b67495ab_d64e330a","line":587,"updated":"2025-07-10 05:35:38.000000000","message":"I\u0027m not comfortable with needed another variable here, shouldn\u0027t this rather be made the default in lib/neutron* code?","commit_id":"f8cc782e547254114ef687f8ad69bc226e37dec7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bfc4e6ea5d672ca5fe015613acd6fdc4332adf2b","unresolved":true,"context_lines":[{"line_number":584,"context_line":"        # virt driver."},{"line_number":585,"context_line":"        NOVA_LIBVIRT_TB_CACHE_SIZE: 128"},{"line_number":586,"context_line":"        ENABLE_ZSWAP: true"},{"line_number":587,"context_line":"        OVN_AGENT_EXTENSIONS: \u0027metadata\u0027"},{"line_number":588,"context_line":"      devstack_local_conf:"},{"line_number":589,"context_line":"        post-config:"},{"line_number":590,"context_line":"          $NEUTRON_CONF:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7ed27873_3c666c00","line":587,"in_reply_to":"49dfc56f_b2e16a8d","updated":"2025-07-10 06:25:21.000000000","message":"I\u0027m not talking about the default in neutron, but in devstack, like here: https://opendev.org/openstack/devstack/src/branch/master/lib/neutron_plugins/ovn_agent#L100","commit_id":"f8cc782e547254114ef687f8ad69bc226e37dec7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e3e22d522420067cf13038c584357dfc85fd4c07","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        # virt driver."},{"line_number":585,"context_line":"        NOVA_LIBVIRT_TB_CACHE_SIZE: 128"},{"line_number":586,"context_line":"        ENABLE_ZSWAP: true"},{"line_number":587,"context_line":"        OVN_AGENT_EXTENSIONS: \u0027metadata\u0027"},{"line_number":588,"context_line":"      devstack_local_conf:"},{"line_number":589,"context_line":"        post-config:"},{"line_number":590,"context_line":"          $NEUTRON_CONF:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ee79c39f_8887eb0a","line":587,"in_reply_to":"7ed27873_3c666c00","updated":"2025-07-10 07:14:31.000000000","message":"That would make sense, let me update it. Thanks for this proposal, that will make the CI definitions shorter and easier.","commit_id":"f8cc782e547254114ef687f8ad69bc226e37dec7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a463337246d8011b1ba0c7082a13b2bd2e163f14","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        # virt driver."},{"line_number":585,"context_line":"        NOVA_LIBVIRT_TB_CACHE_SIZE: 128"},{"line_number":586,"context_line":"        ENABLE_ZSWAP: true"},{"line_number":587,"context_line":"        OVN_AGENT_EXTENSIONS: \u0027metadata\u0027"},{"line_number":588,"context_line":"      devstack_local_conf:"},{"line_number":589,"context_line":"        post-config:"},{"line_number":590,"context_line":"          $NEUTRON_CONF:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"49dfc56f_b2e16a8d","line":587,"in_reply_to":"b67495ab_d64e330a","updated":"2025-07-10 06:17:21.000000000","message":"The agent \"extensions\" is an agent (anyone) generic variable added in 2016 [1]. We can\u0027t provide a default value to this variable.\n\n[1]https://github.com/openstack/neutron/blob/master/neutron/conf/agent/agent_extensions_manager.py","commit_id":"f8cc782e547254114ef687f8ad69bc226e37dec7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cb0946f31057e472fa3f3a750dd50bb1caa7eaaa","unresolved":true,"context_lines":[{"line_number":584,"context_line":"        # virt driver."},{"line_number":585,"context_line":"        NOVA_LIBVIRT_TB_CACHE_SIZE: 128"},{"line_number":586,"context_line":"        ENABLE_ZSWAP: true"},{"line_number":587,"context_line":"        OVN_AGENT_EXTENSIONS: \u0027metadata\u0027"},{"line_number":588,"context_line":"      devstack_local_conf:"},{"line_number":589,"context_line":"        post-config:"},{"line_number":590,"context_line":"          $NEUTRON_CONF:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4db17874_d24b9a52","line":587,"updated":"2025-07-10 10:05:10.000000000","message":"this can be dropped again now?","commit_id":"5a29b2453137f927d588b9e0fde1acd212cf489e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a6103e0a8d9183bf05e8f15d628af721c8e5857c","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        # virt driver."},{"line_number":585,"context_line":"        NOVA_LIBVIRT_TB_CACHE_SIZE: 128"},{"line_number":586,"context_line":"        ENABLE_ZSWAP: true"},{"line_number":587,"context_line":"        OVN_AGENT_EXTENSIONS: \u0027metadata\u0027"},{"line_number":588,"context_line":"      devstack_local_conf:"},{"line_number":589,"context_line":"        post-config:"},{"line_number":590,"context_line":"          $NEUTRON_CONF:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"68d446fd_83833232","line":587,"in_reply_to":"4db17874_d24b9a52","updated":"2025-07-17 09:42:38.000000000","message":"Done","commit_id":"5a29b2453137f927d588b9e0fde1acd212cf489e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cb0946f31057e472fa3f3a750dd50bb1caa7eaaa","unresolved":true,"context_lines":[{"line_number":622,"context_line":"        # Neutron services"},{"line_number":623,"context_line":"        q-svc: true"},{"line_number":624,"context_line":"        q-ovn-metadata-agent: false"},{"line_number":625,"context_line":"        q-ovn-agent: true"},{"line_number":626,"context_line":"        # Swift services"},{"line_number":627,"context_line":"        s-account: true"},{"line_number":628,"context_line":"        s-container: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e6ad0527_a186180a","line":625,"updated":"2025-07-10 10:05:10.000000000","message":"I didn\u0027t think of checking this earlier, but this could as well be changed in the defaults here https://opendev.org/openstack/devstack/src/branch/master/stackrc#L78","commit_id":"5a29b2453137f927d588b9e0fde1acd212cf489e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a6103e0a8d9183bf05e8f15d628af721c8e5857c","unresolved":false,"context_lines":[{"line_number":622,"context_line":"        # Neutron services"},{"line_number":623,"context_line":"        q-svc: true"},{"line_number":624,"context_line":"        q-ovn-metadata-agent: false"},{"line_number":625,"context_line":"        q-ovn-agent: true"},{"line_number":626,"context_line":"        # Swift services"},{"line_number":627,"context_line":"        s-account: true"},{"line_number":628,"context_line":"        s-container: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c4c164bf_fdc43ed9","line":625,"in_reply_to":"e6ad0527_a186180a","updated":"2025-07-17 09:42:38.000000000","message":"Done","commit_id":"5a29b2453137f927d588b9e0fde1acd212cf489e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"153f3e52a32f0e28dbbaaab5ee40c0e0cacc5504","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d549c8af_1fa9f3a9","updated":"2025-07-02 20:08:01.000000000","message":"lgtm","commit_id":"f8cc782e547254114ef687f8ad69bc226e37dec7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"31ff9e995f4d6167148bf9c419001487bda8784f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cdbc4bff_d13a3e94","updated":"2025-07-09 14:36:39.000000000","message":"ping fellow reviewers","commit_id":"f8cc782e547254114ef687f8ad69bc226e37dec7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bc9b7bfd2ab6f37ed60d46014601c5536a0a814c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4d095493_f04de3cc","updated":"2025-07-17 10:02:25.000000000","message":"recheck zuul error","commit_id":"6180e73702cfef2011c32f315cde97128a4b7eec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d4f58ae6117ac8d09ce424bcb3f1432e3701321f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d4d8114e_68bfbeaf","updated":"2025-07-19 04:34:13.000000000","message":"recheck zuul fixed","commit_id":"6180e73702cfef2011c32f315cde97128a4b7eec"}],"lib/neutron_plugins/ovn_agent":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cb0946f31057e472fa3f3a750dd50bb1caa7eaaa","unresolved":true,"context_lines":[{"line_number":98,"context_line":"# OVN agent configuration"},{"line_number":99,"context_line":"# The OVN agent is configured, by default, with the \"metadata\" extension."},{"line_number":100,"context_line":"OVN_AGENT_CONF\u003d$NEUTRON_CONF_DIR/plugins/ml2/ovn_agent.ini"},{"line_number":101,"context_line":"OVN_AGENT_EXTENSIONS\u003d${OVN_AGENT_EXTENSIONS:-\"metadata\"}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# If True (default) the node will be considered a gateway node."},{"line_number":104,"context_line":"ENABLE_CHASSIS_AS_GW\u003d$(trueorfalse True ENABLE_CHASSIS_AS_GW)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"e58935be_6cf0d17b","line":101,"range":{"start_line":101,"start_character":45,"end_line":101,"end_character":55},"updated":"2025-07-10 10:05:10.000000000","message":"nit: the quotes are not needed and should be dropped to avoid confusion, cf. L92","commit_id":"5a29b2453137f927d588b9e0fde1acd212cf489e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a6103e0a8d9183bf05e8f15d628af721c8e5857c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"# OVN agent configuration"},{"line_number":99,"context_line":"# The OVN agent is configured, by default, with the \"metadata\" extension."},{"line_number":100,"context_line":"OVN_AGENT_CONF\u003d$NEUTRON_CONF_DIR/plugins/ml2/ovn_agent.ini"},{"line_number":101,"context_line":"OVN_AGENT_EXTENSIONS\u003d${OVN_AGENT_EXTENSIONS:-\"metadata\"}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# If True (default) the node will be considered a gateway node."},{"line_number":104,"context_line":"ENABLE_CHASSIS_AS_GW\u003d$(trueorfalse True ENABLE_CHASSIS_AS_GW)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"73325929_977c9e4f","line":101,"range":{"start_line":101,"start_character":45,"end_line":101,"end_character":55},"in_reply_to":"e58935be_6cf0d17b","updated":"2025-07-17 09:42:38.000000000","message":"Done","commit_id":"5a29b2453137f927d588b9e0fde1acd212cf489e"}]}
