)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a44bebb6c2afde7fd689300b55c0b461c2e85072","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Parse openstackclient output to get EC2 and S3 urls."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some OSes don\u0027t support exactly url take by additional"},{"line_number":10,"context_line":"openstackclient arguments. Therefore"},{"line_number":11,"context_line":"Ic46a9989321cf6310c56edeeb737c603a4f9c1ed is reworked."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_2f82ecff","line":9,"updated":"2014-06-05 05:57:20.000000000","message":"sorry but neither of these bugs clearly explain what is going on, and why this fixes it for someone who doesn\u0027t have any context (i.e. me :)\n\ncan you please make it a priori evident from the change description what this is doing","commit_id":"df6ce59b83fbdfc5184d12b5f16aeb6d866f3760"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"342f84c0cbe8ba916016825e52f1df88d6f78d39","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Parse openstackclient output to get EC2 and S3 urls."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some OSes don\u0027t support exactly url take by additional"},{"line_number":10,"context_line":"openstackclient arguments. Therefore"},{"line_number":11,"context_line":"Ic46a9989321cf6310c56edeeb737c603a4f9c1ed is reworked."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_fbb27de3","line":9,"in_reply_to":"1ae5cdf2_2f82ecff","updated":"2014-06-05 11:13:55.000000000","message":"Done","commit_id":"df6ce59b83fbdfc5184d12b5f16aeb6d866f3760"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"07f6cee2db338c0ce5578bef74405e6f598fa197","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix following problems:"},{"line_number":10,"context_line":"1 Usage value format parameter in \u0027openstack endpoint show\u0027 is"},{"line_number":11,"context_line":"not compatible with Python 2.6. See Bug#1322931 and Review#95916."},{"line_number":12,"context_line":"This fix doesn\u0027t use any additional parameters to avoid compatibility"},{"line_number":13,"context_line":"problems, but parses output."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ae5cdf2_be88e371","line":11,"updated":"2014-06-05 11:44:53.000000000","message":"Isn\u0027t the problem really that *cliff* does not support python2.6 correctly until [1] is fixed, so you need to use this alternative way to get the format.  It seems we could revert this change once [1] has been committed? \n\n[1] https://review.openstack.org/#/c/95916/","commit_id":"449a221afcc08d2ba5c9c36b1a124f788adc3436"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"22a86f9cae9c036dd65f4a9e07782b9e2b9e8c81","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix following problems:"},{"line_number":10,"context_line":"1 Usage value format parameter in \u0027openstack endpoint show\u0027 is"},{"line_number":11,"context_line":"not compatible with Python 2.6. See Bug#1322931 and Review#95916."},{"line_number":12,"context_line":"This fix doesn\u0027t use any additional parameters to avoid compatibility"},{"line_number":13,"context_line":"problems, but parses output."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ae5cdf2_0d142fe7","line":11,"in_reply_to":"1ae5cdf2_338dd7d3","updated":"2014-06-06 08:12:03.000000000","message":"Done","commit_id":"449a221afcc08d2ba5c9c36b1a124f788adc3436"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"0f14b40927d4d12241ae4168c23a242ab84148bd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix following problems:"},{"line_number":10,"context_line":"1 Usage value format parameter in \u0027openstack endpoint show\u0027 is"},{"line_number":11,"context_line":"not compatible with Python 2.6. See Bug#1322931 and Review#95916."},{"line_number":12,"context_line":"This fix doesn\u0027t use any additional parameters to avoid compatibility"},{"line_number":13,"context_line":"problems, but parses output."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ae5cdf2_c159428f","line":11,"in_reply_to":"1ae5cdf2_be88e371","updated":"2014-06-05 20:35:16.000000000","message":"Yeah, as it\u0027s mentioned in #1322931, i onsider the Python compatibility problem shold be resolved in cliff.\n\nBut:\n\n1 As i see Bug#1322931 has many affected persons, so i supposed any fastest way to fix the problem is preffered.\n\n2 Also there is Bug #1323430. It\u0027s reason is usage old cliff with newest DevStack. I can not understand how and why people can do it, but this bug exists. This fix prevents this bug occurence as well.\n\nBut in fact as so much time has passed, but no fix is commited, the best way is to fix the compatibility problem in cliff only.","commit_id":"449a221afcc08d2ba5c9c36b1a124f788adc3436"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"646b9bbeb3f73ffd300102aa0e6cf29c95d9e1ca","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix following problems:"},{"line_number":10,"context_line":"1 Usage value format parameter in \u0027openstack endpoint show\u0027 is"},{"line_number":11,"context_line":"not compatible with Python 2.6. See Bug#1322931 and Review#95916."},{"line_number":12,"context_line":"This fix doesn\u0027t use any additional parameters to avoid compatibility"},{"line_number":13,"context_line":"problems, but parses output."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ae5cdf2_338dd7d3","line":11,"in_reply_to":"1ae5cdf2_c159428f","updated":"2014-06-05 21:57:42.000000000","message":"\u003e Yeah, as it\u0027s mentioned in #1322931, i onsider the Python compatibility problem shold be resolved in cliff.\n\nI\u0027m fine with fixing this the way you have; just in the long term, once cliff is fixed, it would be nice to use the simpler way.  I\u0027d just like a comment so the next person who tries that doesn\u0027t have to figure out all the little problems like you already did :)","commit_id":"449a221afcc08d2ba5c9c36b1a124f788adc3436"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"07f6cee2db338c0ce5578bef74405e6f598fa197","unresolved":false,"context_lines":[{"line_number":19,"context_line":"$(cmd). An error of the first command is ignored, empty output is passed"},{"line_number":20,"context_line":"to input of the second command."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The technique used for parsing is identical with ones used in other"},{"line_number":23,"context_line":"parts of DevStack. See for example getting EC2_ACCESS_KEY in eucarc."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Therefore Ic46a9989321cf6310c56edeeb737c603a4f9c1ed is reworked."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ae5cdf2_be3d4391","line":22,"updated":"2014-06-05 11:44:53.000000000","message":"So you\u0027re also saying that if we revert this change, then we need to deal with \"openstack endpoint show -f value -c publicurl s3\" failing due to it returning !0\n\nI feel this all deserves a comment","commit_id":"449a221afcc08d2ba5c9c36b1a124f788adc3436"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"0f14b40927d4d12241ae4168c23a242ab84148bd","unresolved":false,"context_lines":[{"line_number":19,"context_line":"$(cmd). An error of the first command is ignored, empty output is passed"},{"line_number":20,"context_line":"to input of the second command."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The technique used for parsing is identical with ones used in other"},{"line_number":23,"context_line":"parts of DevStack. See for example getting EC2_ACCESS_KEY in eucarc."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Therefore Ic46a9989321cf6310c56edeeb737c603a4f9c1ed is reworked."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ae5cdf2_dcada59c","line":22,"in_reply_to":"1ae5cdf2_be3d4391","updated":"2014-06-05 20:35:16.000000000","message":"This command returns empty output, but also it return an error. Bash catches errors from last command of a command expression and since error handling is set in stack.sh bash hands off the control flow to an error handler.\n\nWe can use var \u003d $(openstack .. -f value .. | xargs) or any other simple way to bypass bash error catcher and to deliver the empty output to the local variable.\n\nBtw, xargs also trim spaces from it\u0027s arguments.\n\nFinally, my preffered way to fix this set of bugs is to fix cliff, and to use -f value with xargs here.\n\nWhat do you think about this?","commit_id":"449a221afcc08d2ba5c9c36b1a124f788adc3436"}],"tools/create_userrc.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"07f6cee2db338c0ce5578bef74405e6f598fa197","unresolved":false,"context_lines":[{"line_number":125,"context_line":"fi"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"export -n SERVICE_TOKEN SERVICE_ENDPOINT OS_SERVICE_TOKEN OS_SERVICE_ENDPOINT"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"EC2_URL\u003d$(openstack endpoint show ec2 | awk \u0027/ publicurl / { print $4 }\u0027)"},{"line_number":130,"context_line":"if [[ -z $EC2_URL ]]; then"},{"line_number":131,"context_line":"    EC2_URL\u003dhttp://localhost:8773/services/Cloud"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1ae5cdf2_1efc77b7","line":128,"updated":"2014-06-05 11:44:53.000000000","message":"What about a comment here\n\n# we use awk because the simpler \"openstack endpoint show -f value -c publicurl ec2\" fails on python 2.6 until https://review.openstack.org/#/c/95916/ is fixed.  Note that a !0 exit is expected if the endpoint is not found, so the simple version needs to handle that","commit_id":"449a221afcc08d2ba5c9c36b1a124f788adc3436"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"0f14b40927d4d12241ae4168c23a242ab84148bd","unresolved":false,"context_lines":[{"line_number":125,"context_line":"fi"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"export -n SERVICE_TOKEN SERVICE_ENDPOINT OS_SERVICE_TOKEN OS_SERVICE_ENDPOINT"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"EC2_URL\u003d$(openstack endpoint show ec2 | awk \u0027/ publicurl / { print $4 }\u0027)"},{"line_number":130,"context_line":"if [[ -z $EC2_URL ]]; then"},{"line_number":131,"context_line":"    EC2_URL\u003dhttp://localhost:8773/services/Cloud"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1ae5cdf2_1ca1cd93","line":128,"in_reply_to":"1ae5cdf2_1efc77b7","updated":"2014-06-05 20:35:16.000000000","message":"I can add any comment after we have decided how to fix the problems.","commit_id":"449a221afcc08d2ba5c9c36b1a124f788adc3436"}]}