)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"43455a6d59d36cd73074fb9363bb46737bb57b24","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This variable will be used, initially, in the grenade jobs. It will"},{"line_number":16,"context_line":"be used to test the migration from the OVN Metadata agent to the"},{"line_number":17,"context_line":"OVN agent."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This variable will be removed in 2026.2, along with the OVN Metadata"},{"line_number":20,"context_line":"agent, that is set as deprecated and marked for removal."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ac4a5e54_a58905e9","line":17,"updated":"2025-12-17 17:16:02.000000000","message":"im not familary with this new agent but adding this flag to thelp with \nmigration testing sound resonable\n---\nlater\ni see https://bugs.launchpad.net/neutron/+bug/1998608\nso https://bugs.launchpad.net/neutron/+bug/2112313 is deprecating the standaloen metadta agent in favor of folding that into the new ovn agent.","commit_id":"9a0db4f4999e2aa5923ed32452f1d2e41ae4ea55"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0303a7a9e4910256c77b186ad69ccfaad9423ee5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2c56f5cc_1419c552","updated":"2025-07-17 08:56:03.000000000","message":"Nova tests are failing (jobs affected:  tempest-full-py3, devstack-platform-ubuntu-jammy or nova-ceph-multistore).\n\nTests: https://zuul.opendev.org/t/openstack/build/61d7370a71494a2192ee60cfc4eb6cc3/logs\n* test_verify_hostname_allows_fqdn\n* test_tagged_attachment","commit_id":"81804d398bdc694b9d2c10805b63c3f1e96d9fdc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a02dbe63aa864e0a973dc65ec3a44087ec22a806","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b0521035_c6991b11","updated":"2025-07-17 06:36:16.000000000","message":"recheck tempest-full-py3","commit_id":"81804d398bdc694b9d2c10805b63c3f1e96d9fdc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d9f8416ef104e58e414ae7b0094ef54af1952afa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"92b2f1b3_d5763f1d","updated":"2025-07-17 10:15:13.000000000","message":"recheck zuul issue","commit_id":"81804d398bdc694b9d2c10805b63c3f1e96d9fdc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2ac39bfde4d41321241b7f0bdd2a504db31bad11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad8755ee_42633abe","in_reply_to":"2c56f5cc_1419c552","updated":"2025-07-17 10:01:16.000000000","message":"This is not a problem in Nova but in this patch: the OVN agent is not being spawned.","commit_id":"81804d398bdc694b9d2c10805b63c3f1e96d9fdc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8f78c3c89e6a43939c507cdba28b671ce8b3a7e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"790e5717_8378d9e5","updated":"2025-08-08 14:21:25.000000000","message":"ping fellow reviewers","commit_id":"6146f5dbe50c7a7edd6dfc51c56f7fa864c1d515"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dfbb3c97eeb6cfcfdf4e93e59f59c41dde85fa1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3e5ea2f0_dfc30fbe","updated":"2025-11-26 19:45:41.000000000","message":"lgtm","commit_id":"9a0db4f4999e2aa5923ed32452f1d2e41ae4ea55"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fc1fdeac4612c8aa3339e0c447d45663dbf7a5d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"de7bea05_30721ae7","updated":"2025-12-17 17:24:10.000000000","message":"the next patch also looks fine so +w","commit_id":"9a0db4f4999e2aa5923ed32452f1d2e41ae4ea55"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"43455a6d59d36cd73074fb9363bb46737bb57b24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"91c76730_22db883c","updated":"2025-12-17 17:16:02.000000000","message":"this is tested with the next patch here \nhttps://review.opendev.org/c/openstack/neutron/+/955188\n\nthe logs have routed bug it pass the last time it ran\nill loop back to this wonce i review the second patch in the series","commit_id":"9a0db4f4999e2aa5923ed32452f1d2e41ae4ea55"}],"lib/neutron_plugins/ovn_agent":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c9bc2a78ac58f40917a60c97619d3ce36c302a08","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"function is_ovn_metadata_agent_enabled {"},{"line_number":312,"context_line":"    if is_service_enabled q-ovn-metadata-agent neutron-ovn-metadata-agent \u0026\u0026 [[ \"$TARGET_ENABLE_OVN_AGENT\" \u003d\u003d \"False\" ]]; then"},{"line_number":313,"context_line":"        return 1"},{"line_number":314,"context_line":"    fi"},{"line_number":315,"context_line":"    return 0"},{"line_number":316,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"8e36781c_031746b7","line":313,"range":{"start_line":313,"start_character":8,"end_line":313,"end_character":16},"updated":"2025-07-17 11:28:13.000000000","message":"I\u0027m thinking in python terms... this should be the opposite.","commit_id":"81804d398bdc694b9d2c10805b63c3f1e96d9fdc"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5ff4e2360e7bfcc908d1a9c97342b355da91ef66","unresolved":true,"context_lines":[{"line_number":105,"context_line":"# the first one (OVN Metadata agent) and enabling the second (OVN agent)."},{"line_number":106,"context_line":"# This variable will be removed in 2026.2, along with the OVN Metadata agent"},{"line_number":107,"context_line":"# removal."},{"line_number":108,"context_line":"TARGET_ENABLE_OVN_AGENT\u003d${TARGET_ENABLE_OVN_AGENT:-False}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# If True (default) the node will be considered a gateway node."},{"line_number":111,"context_line":"ENABLE_CHASSIS_AS_GW\u003d$(trueorfalse True ENABLE_CHASSIS_AS_GW)"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"b72131b2_0a7e6f91","line":108,"updated":"2025-08-04 19:47:50.000000000","message":"nit: better use `trueorfalse` for bool vars","commit_id":"b830ec22c124d4725d2ef4fa105000f67079e850"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0c38e77ac8d46d0a77669374a87505d1e79781bc","unresolved":false,"context_lines":[{"line_number":105,"context_line":"# the first one (OVN Metadata agent) and enabling the second (OVN agent)."},{"line_number":106,"context_line":"# This variable will be removed in 2026.2, along with the OVN Metadata agent"},{"line_number":107,"context_line":"# removal."},{"line_number":108,"context_line":"TARGET_ENABLE_OVN_AGENT\u003d${TARGET_ENABLE_OVN_AGENT:-False}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# If True (default) the node will be considered a gateway node."},{"line_number":111,"context_line":"ENABLE_CHASSIS_AS_GW\u003d$(trueorfalse True ENABLE_CHASSIS_AS_GW)"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"395d0def_17a37a8d","line":108,"in_reply_to":"b72131b2_0a7e6f91","updated":"2025-08-06 06:31:28.000000000","message":"Done","commit_id":"b830ec22c124d4725d2ef4fa105000f67079e850"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5ff4e2360e7bfcc908d1a9c97342b355da91ef66","unresolved":true,"context_lines":[{"line_number":321,"context_line":"        return 0"},{"line_number":322,"context_line":"    fi"},{"line_number":323,"context_line":"    return 1"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"}"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"56828fb5_f45880d5","line":324,"updated":"2025-08-04 19:47:50.000000000","message":"nit: stray empty line","commit_id":"b830ec22c124d4725d2ef4fa105000f67079e850"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0c38e77ac8d46d0a77669374a87505d1e79781bc","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        return 0"},{"line_number":322,"context_line":"    fi"},{"line_number":323,"context_line":"    return 1"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"}"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"e5ffd691_5e799cd7","line":324,"in_reply_to":"56828fb5_f45880d5","updated":"2025-08-06 06:31:28.000000000","message":"Done","commit_id":"b830ec22c124d4725d2ef4fa105000f67079e850"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ce6551847546e1ae65f1d53bfdf6b150c3a9cbbb","unresolved":true,"context_lines":[{"line_number":315,"context_line":"    return 1"},{"line_number":316,"context_line":"}"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"function is_ovn_agent_enabled {"},{"line_number":319,"context_line":"    if is_service_enabled q-ovn-agent neutron-ovn-agent || [[ \"$TARGET_ENABLE_OVN_AGENT\" \u003d\u003d \"True\" ]]; then"},{"line_number":320,"context_line":"        enable_service q-ovn-agent"},{"line_number":321,"context_line":"        return 0"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"65766f8b_a3fd445e","line":318,"updated":"2025-08-12 17:09:36.000000000","message":"Shouldn\u0027t a function called \"is_*_enabled\" be a const function (read values without changing the state)?","commit_id":"6146f5dbe50c7a7edd6dfc51c56f7fa864c1d515"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8ec417c7464978d0419b9621b64257cbb75e9b8e","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    return 1"},{"line_number":316,"context_line":"}"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"function is_ovn_agent_enabled {"},{"line_number":319,"context_line":"    if is_service_enabled q-ovn-agent neutron-ovn-agent || [[ \"$TARGET_ENABLE_OVN_AGENT\" \u003d\u003d \"True\" ]]; then"},{"line_number":320,"context_line":"        enable_service q-ovn-agent"},{"line_number":321,"context_line":"        return 0"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"6dd50156_8571995c","line":318,"in_reply_to":"65766f8b_a3fd445e","updated":"2025-11-18 07:55:48.000000000","message":"Any time the variable `TARGET_ENABLE_OVN_AGENT` is set, the q-ovn-agent service should be enabled, regardless of the value.\n\nThis is a temporary parameter, just needed during the migration of the OVN agent. Once this migration is finished, we\u0027ll rely again on the explicit configuration of the q-ovn-agent service only.","commit_id":"6146f5dbe50c7a7edd6dfc51c56f7fa864c1d515"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"43455a6d59d36cd73074fb9363bb46737bb57b24","unresolved":true,"context_lines":[{"line_number":105,"context_line":"# the first one (OVN Metadata agent) and enabling the second (OVN agent)."},{"line_number":106,"context_line":"# This variable will be removed in 2026.2, along with the OVN Metadata agent"},{"line_number":107,"context_line":"# removal."},{"line_number":108,"context_line":"TARGET_ENABLE_OVN_AGENT\u003d$(trueorfalse False TARGET_ENABLE_OVN_AGENT)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# If True (default) the node will be considered a gateway node."},{"line_number":111,"context_line":"ENABLE_CHASSIS_AS_GW\u003d$(trueorfalse True ENABLE_CHASSIS_AS_GW)"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"50edae2a_4dd0c000","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":68},"updated":"2025-12-17 17:16:02.000000000","message":"i proably would have gon with a shorter name\n\n```\nENABLE_OVN_AGENT\u003d$(trueorfalse False ENABLE_OVN_AGENT)\n```\n\nor \n\n```suggestion\nOVN_AGENT_ENABLE\u003d$(trueorfalse False OVN_AGENT_ENABLE)\n```\n\nbut given this is tempoeray ifm ok with the longer name ever if it make shte condtions and usage less nice","commit_id":"9a0db4f4999e2aa5923ed32452f1d2e41ae4ea55"}]}