)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"faf63cc390dd4cd4f2fbbe7ce978343893bb5a26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"94680576_cf567562","updated":"2025-08-06 12:43:21.000000000","message":"[2001:4800:7818:103:be76:4eff:fe04:357d] SERVICE_HOST is not IPv6 which means devstack cannot deploy services on IPv6 addresses.\n\nodd when you checked locally oslo apprently did not supprot []\n\nso i guess htere is a place wehre we need to account for it something being wrapped and sometiems not\n\nwe shoudl alaso likely increase the log output of this since there is limited info to go on form the ci logs","commit_id":"cb4bb216255dee933bf978db3927cc2c919397ad"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"08ff69de1392754ce60d2c93152ba834794093f9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22b3c9d8_26ff9322","updated":"2025-08-06 11:13:35.000000000","message":"we dicussed the merrits of this vs maintianing the old code and updating the script to properly activate the devstack venv if it exists\n\nThat is effectivly adding this\n# TODO(frickler): make this use stackrc variables\nif [ -x /opt/stack/data/venv/bin/python ]; then\n    PYTHON\u003d/opt/stack/data/venv/bin/python\nelse\n    PYTHON\u003d${PYTHON:-python3}\nfi\nhttps://github.com/openstack/devstack/blob/master/tools/memory_tracker.sh#L17-L22\n\nim ok with the current approch to unblock the oslo gate in the short term\n\nwe proably want to actuly adress frikler\u0027s todo and update stackrc to properly config the PYTHON variable adn then make sure we use $PYTHON in the tools consistently however that like need wider agreement on if that is the dierction we want to have.\n\ni.e. shoudl the tools be freeestanding, should they use the stackrc vars and/or functions/funtions_common and should they run in the context of the global venv if that is enabled.\n\ni think its better to deffer that converstaion to a followup once oslo is unblocked given how close we are to the non client lib freeze.","commit_id":"cb4bb216255dee933bf978db3927cc2c919397ad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6bf3dc038a6afaa9a5d0bda96e06ebc9cfce2e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"969d13d8_d0528c2f","in_reply_to":"22b3c9d8_26ff9322","updated":"2025-08-06 17:18:54.000000000","message":"Acknowledged","commit_id":"cb4bb216255dee933bf978db3927cc2c919397ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f02ff6e9da858ab10115688135ea6deb379a7e32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"020b3d11_4aa6098e","updated":"2025-08-08 15:37:44.000000000","message":"lgtm","commit_id":"67fa02fc5fd6a8786baff61695a578338462b3d3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5fe70efc23a0ebef781624f52c4535923b72f48a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2f3de09a_d99aaedd","updated":"2025-08-08 04:55:47.000000000","message":"recheck I wonder we should remove jammy job","commit_id":"67fa02fc5fd6a8786baff61695a578338462b3d3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"831e7fa76ea517a30976ab888483540289e7bd26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f5071503_720959a8","updated":"2025-08-08 12:47:48.000000000","message":"recheck a different job failed this time","commit_id":"67fa02fc5fd6a8786baff61695a578338462b3d3"}],"tools/verify-ipv6-only-deployments.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"50969c1b9ca6529d8bb01595aaf1f4c910209379","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ebb54b6f_38522426","updated":"2025-08-07 16:50:52.000000000","message":"I should probably rename this to simply `verify-ipv6-address.py`","commit_id":"cfb8e6f14b6e691d7050d7979dd3d3f9a23fc059"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8479a7233e4a043d453e8f1eec1272d377c1e4c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"50fc372c_0f9e6084","in_reply_to":"ebb54b6f_38522426","updated":"2025-08-07 16:52:06.000000000","message":"Done","commit_id":"cfb8e6f14b6e691d7050d7979dd3d3f9a23fc059"}],"tools/verify-ipv6-only-deployments.sh":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4366b997c9930a52b282ca10b50841a4f0b8f47b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        echo $TUNNEL_IP_VERSION \"TUNNEL_IP_VERSION is not set to 6 so TUNNEL_ENDPOINT_IP cannot be an IPv6 address.\""},{"line_number":34,"context_line":"        exit 1"},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"    if ! python3 ${TOP_DIR}/tools/verify-ipv6-only-deployments.py \"$_service_host\"; then"},{"line_number":37,"context_line":"        echo $SERVICE_HOST \"SERVICE_HOST is not IPv6 which means devstack cannot deploy services on IPv6 addresses.\""},{"line_number":38,"context_line":"        exit 1"},{"line_number":39,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"e16c828a_73c43ad7","line":36,"updated":"2025-08-07 12:45:44.000000000","message":"i mean you could have also set the exit code in the python script but sur negating it here is more corerct as you are correctly return 0 when it valid.","commit_id":"cfb8e6f14b6e691d7050d7979dd3d3f9a23fc059"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"50969c1b9ca6529d8bb01595aaf1f4c910209379","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        echo $TUNNEL_IP_VERSION \"TUNNEL_IP_VERSION is not set to 6 so TUNNEL_ENDPOINT_IP cannot be an IPv6 address.\""},{"line_number":34,"context_line":"        exit 1"},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"    if ! python3 ${TOP_DIR}/tools/verify-ipv6-only-deployments.py \"$_service_host\"; then"},{"line_number":37,"context_line":"        echo $SERVICE_HOST \"SERVICE_HOST is not IPv6 which means devstack cannot deploy services on IPv6 addresses.\""},{"line_number":38,"context_line":"        exit 1"},{"line_number":39,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"c33e1fb2_abe82d96","line":36,"in_reply_to":"e16c828a_73c43ad7","updated":"2025-08-07 16:50:52.000000000","message":"That would be a bit odd. Currently I return 0 (ok) if the provided IP address is an IPv6 address and I return 1 (error) if not. IMO that\u0027s expected behavior.","commit_id":"cfb8e6f14b6e691d7050d7979dd3d3f9a23fc059"}]}
