)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a54c9e5d616e9996fcd336d1ac4148ca88c6e0c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e8b05a5f_f1891f74","updated":"2025-09-28 11:50:56.000000000","message":"With a two nodes devstack using the following config on both nodes\n```\nVIRT_DRIVER\u003dfake\nNUMBER_FAKE_NOVA_COMPUTE\u003d5\n\nNOVA_NUM_CELLS\u003d2\nFAKE_NOVA_COMPUTE_DISTRIBUTE_CELLS\u003dtrue\n```\nresults in:\n\n```\n+-----------+--------------------------------------+-----------+\n| Cell Name |              Cell UUID               |  Hostname |\n+-----------+--------------------------------------+-----------+\n|   cell1   | e11aa031-70a6-4d97-bcae-3accdd0d8329 |    aio1   |\n|   cell2   | 577890b4-ad47-4665-9c89-19aca93c580c |    aio2   |\n|   cell1   | e11aa031-70a6-4d97-bcae-3accdd0d8329 |    aio3   |\n|   cell2   | 577890b4-ad47-4665-9c89-19aca93c580c |    aio4   |\n|   cell1   | e11aa031-70a6-4d97-bcae-3accdd0d8329 |    aio5   |\n|   cell1   | e11aa031-70a6-4d97-bcae-3accdd0d8329 | compute11 |\n|   cell2   | 577890b4-ad47-4665-9c89-19aca93c580c | compute12 |\n|   cell1   | e11aa031-70a6-4d97-bcae-3accdd0d8329 | compute13 |\n|   cell2   | 577890b4-ad47-4665-9c89-19aca93c580c | compute14 |\n|   cell1   | e11aa031-70a6-4d97-bcae-3accdd0d8329 | compute15 |\n+-----------+--------------------------------------+-----------+\n```","commit_id":"0e3004636c2d5526365deea2dbc6d043514cc844"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"27dcc0ad15be6676994587a4fab998f7e33e69a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6ec58032_a4cebef0","updated":"2025-12-17 17:33:05.000000000","message":"i would prefer ot ues trueorfalse so that this will work with 1,y,true ectra like the other boolean options and a shorter name but im ok with this as well\nsome comment inlineif you agree feel free to bing me to review again","commit_id":"0e3004636c2d5526365deea2dbc6d043514cc844"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"793c0fda07ceeab2d9680edc2ecc798d2a3593c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bc48f897_ee61ee8a","updated":"2026-02-03 16:37:17.000000000","message":"ping gibi about the open comments","commit_id":"0e3004636c2d5526365deea2dbc6d043514cc844"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5482f7acd88e6c6f6b3ab47acf0b6370c569770c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"607177cb_50d1ca67","in_reply_to":"e8b05a5f_f1891f74","updated":"2025-09-28 12:27:15.000000000","message":"Or with 15 fake computes per devstack node and 5 nova cells:\n```\n+-----------+--------------------------------------+------------+\n| Cell Name |              Cell UUID               |  Hostname  |\n+-----------+--------------------------------------+------------+\n|   cell1   | c4dd8bef-bc44-47cc-bc39-0d5d3b9e3ed3 |    aio1    |\n|   cell5   | ec866444-619d-4c81-b603-2a7afd1ed19c |   aio10    |\n|   cell1   | c4dd8bef-bc44-47cc-bc39-0d5d3b9e3ed3 |   aio11    |\n|   cell2   | b20a0f2c-a767-4de7-95ce-7a6ac945010f |   aio12    |\n|   cell3   | 341efd07-19d7-4dbe-a078-384cf92af150 |   aio13    |\n|   cell4   | abc39452-e8a1-4553-a777-906d5ab2cbaa |   aio14    |\n|   cell5   | ec866444-619d-4c81-b603-2a7afd1ed19c |   aio15    |\n|   cell2   | b20a0f2c-a767-4de7-95ce-7a6ac945010f |    aio2    |\n|   cell3   | 341efd07-19d7-4dbe-a078-384cf92af150 |    aio3    |\n|   cell4   | abc39452-e8a1-4553-a777-906d5ab2cbaa |    aio4    |\n|   cell5   | ec866444-619d-4c81-b603-2a7afd1ed19c |    aio5    |\n|   cell1   | c4dd8bef-bc44-47cc-bc39-0d5d3b9e3ed3 |    aio6    |\n|   cell2   | b20a0f2c-a767-4de7-95ce-7a6ac945010f |    aio7    |\n|   cell3   | 341efd07-19d7-4dbe-a078-384cf92af150 |    aio8    |\n|   cell4   | abc39452-e8a1-4553-a777-906d5ab2cbaa |    aio9    |\n|   cell1   | c4dd8bef-bc44-47cc-bc39-0d5d3b9e3ed3 | compute11  |\n|   cell5   | ec866444-619d-4c81-b603-2a7afd1ed19c | compute110 |\n|   cell1   | c4dd8bef-bc44-47cc-bc39-0d5d3b9e3ed3 | compute111 |\n|   cell2   | b20a0f2c-a767-4de7-95ce-7a6ac945010f | compute112 |\n|   cell3   | 341efd07-19d7-4dbe-a078-384cf92af150 | compute113 |\n|   cell4   | abc39452-e8a1-4553-a777-906d5ab2cbaa | compute114 |\n|   cell5   | ec866444-619d-4c81-b603-2a7afd1ed19c | compute115 |\n|   cell2   | b20a0f2c-a767-4de7-95ce-7a6ac945010f | compute12  |\n|   cell3   | 341efd07-19d7-4dbe-a078-384cf92af150 | compute13  |\n|   cell4   | abc39452-e8a1-4553-a777-906d5ab2cbaa | compute14  |\n|   cell5   | ec866444-619d-4c81-b603-2a7afd1ed19c | compute15  |\n|   cell1   | c4dd8bef-bc44-47cc-bc39-0d5d3b9e3ed3 | compute16  |\n|   cell2   | b20a0f2c-a767-4de7-95ce-7a6ac945010f | compute17  |\n|   cell3   | 341efd07-19d7-4dbe-a078-384cf92af150 | compute18  |\n|   cell4   | abc39452-e8a1-4553-a777-906d5ab2cbaa | compute19  |\n+-----------+--------------------------------------+------------+\n```","commit_id":"0e3004636c2d5526365deea2dbc6d043514cc844"}],"lib/nova":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4e88c98248adfdb334661125c79a7bc47b6de7cb","unresolved":true,"context_lines":[{"line_number":1091,"context_line":"                # available cells equally"},{"line_number":1092,"context_line":"                local cell_index"},{"line_number":1093,"context_line":"                cell_index\u003d$(((i - 1) % NOVA_NUM_CELLS + 1))"},{"line_number":1094,"context_line":"                iniset_rpc_backend nova $NOVA_CPU_CONF DEFAULT \"nova_cell${cell_index}\""},{"line_number":1095,"context_line":"            fi"},{"line_number":1096,"context_line":"            # Avoid process redirection of fake host configurations by"},{"line_number":1097,"context_line":"            # creating or modifying real configurations. Each fake"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"00dafd60_6a4e9e95","line":1094,"updated":"2025-09-28 11:07:54.000000000","message":"this needs to be set in the compute instance specific fake_conf below","commit_id":"2e085f54bac070221777ca9205ca30056945514d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e024eef80349515b798a26ed696360cbf0d54728","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"                # available cells equally"},{"line_number":1092,"context_line":"                local cell_index"},{"line_number":1093,"context_line":"                cell_index\u003d$(((i - 1) % NOVA_NUM_CELLS + 1))"},{"line_number":1094,"context_line":"                iniset_rpc_backend nova $NOVA_CPU_CONF DEFAULT \"nova_cell${cell_index}\""},{"line_number":1095,"context_line":"            fi"},{"line_number":1096,"context_line":"            # Avoid process redirection of fake host configurations by"},{"line_number":1097,"context_line":"            # creating or modifying real configurations. Each fake"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"c2c9fdf7_080ecb83","line":1094,"in_reply_to":"00dafd60_6a4e9e95","updated":"2025-09-28 11:08:18.000000000","message":"Done","commit_id":"2e085f54bac070221777ca9205ca30056945514d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"27dcc0ad15be6676994587a4fab998f7e33e69a5","unresolved":true,"context_lines":[{"line_number":77,"context_line":"# then the NUMBER_FAKE_NOVA_COMPUTE number of computes on a given host are"},{"line_number":78,"context_line":"# distributed across all available nova cells equally. Otherwise all computes"},{"line_number":79,"context_line":"# on a given host connected to the same cell index defined by NOVA_CPU_CELL"},{"line_number":80,"context_line":"FAKE_NOVA_COMPUTE_DISTRIBUTE_CELLS\u003d${FAKE_NOVA_COMPUTE_DISTRIBUTE_CELLS:\"\"}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"NOVA_API_PASTE_INI\u003d${NOVA_API_PASTE_INI:-$NOVA_CONF_DIR/api-paste.ini}"},{"line_number":83,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9ce02337_3f6478b1","line":80,"updated":"2025-12-17 17:33:05.000000000","message":"i would personally do this instead.\n\n```suggestion\nFAKE_NOVA_COMPUTE_DISTRIBUTE_CELLS\u003d$(trueorfalse False FAKE_NOVA_COMPUTE_DISTRIBUTE_CELLS)\n```\n\ni woudl also consider a shorter name\n\n`NOVA_DISTRIBUTE_CELLS` or `NOVA_FAKE_CELLS`\n\nin terms of nameing convention\n\nNUMBER_FAKE_NOVA_COMPUTE and NOVA_FAKE_CONF\n\nthere does nto seam to be a hard rule but i general prefer having the service at the start of the option","commit_id":"0e3004636c2d5526365deea2dbc6d043514cc844"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"27dcc0ad15be6676994587a4fab998f7e33e69a5","unresolved":true,"context_lines":[{"line_number":1100,"context_line":"            iniset $fake_conf DEFAULT state_path \"$state_path\""},{"line_number":1101,"context_line":"            # use the generated UUID as the stable compute node UUID"},{"line_number":1102,"context_line":"            echo \"$COMPUTE_ID\" | sudo tee \"$state_path/compute_id\""},{"line_number":1103,"context_line":"            if [[ \"$FAKE_NOVA_COMPUTE_DISTRIBUTE_CELLS\" ]]; then"},{"line_number":1104,"context_line":"                # distribute the fake computes on this host across each"},{"line_number":1105,"context_line":"                # available cells equally"},{"line_number":1106,"context_line":"                local cell_index"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ded4e48d_a6cc42d3","line":1103,"updated":"2025-12-17 17:33:05.000000000","message":"then do\n\n```suggestion\n            if [[ \"$FAKE_NOVA_COMPUTE_DISTRIBUTE_CELLS\" \u003d\u003d \"True\" ]]; then\n```","commit_id":"0e3004636c2d5526365deea2dbc6d043514cc844"}]}
