)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"486bcc66f8f3a2f5e6515a4f9fb190b0b5c36bb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e6f14c03_99b62f51","updated":"2025-10-07 20:11:22.000000000","message":"We also need to configure the BGP peering bridges for the agent","commit_id":"dd6e901f3999e12730ddacb740f1d7b5217ceb06"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"94012a8c12dcd9c63ce5375440bf72015d15e090","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6fa34ce0_a139fcc6","updated":"2026-02-03 17:04:36.000000000","message":"... so is this ready? Was it tested somewhere (maybe https://review.opendev.org/c/openstack/neutron/+/962188 ) ? Should it be marked as work in progress while the job is tested?","commit_id":"37000afa60debc7c21bf8c8623e66cb13e0660c1"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8f8edec4e22608581d210b5df9ec1fbd0de83aa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5e078ea4_d9d84b92","updated":"2026-02-03 17:21:30.000000000","message":"I see some zuul failures but they are probably unrelated to the patch, also because the patch does not change the default behavior of devstack. So +2","commit_id":"37000afa60debc7c21bf8c8623e66cb13e0660c1"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"e25329b352de976d068b7d308d968d2f15aedfb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4a12bf03_c9279743","updated":"2026-02-03 17:16:53.000000000","message":"recheck functional","commit_id":"37000afa60debc7c21bf8c8623e66cb13e0660c1"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"cf1f5b32c6e2ca0812db15e42c919616abb23ff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3703a028_86fe4920","in_reply_to":"6fa34ce0_a139fcc6","updated":"2026-02-03 17:16:01.000000000","message":"Yes. I removed WIP from this patch because it was tested with https://review.opendev.org/c/openstack/neutron/+/962188 and the job passes (that patch needs one more dependency merged to remove WIP from it)","commit_id":"37000afa60debc7c21bf8c8623e66cb13e0660c1"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"5613ef57a2eb806bbc5252c258174326d57616cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"412b1b18_9aaada88","updated":"2026-02-04 11:43:28.000000000","message":"recheck","commit_id":"6f7ac1665c6e06b0cb801406915b83aae9ff301b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"248c2eb73c7c8901388f2550d2496da6de4e5dd1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"47e945c1_9fa179dd","updated":"2026-03-13 11:52:51.000000000","message":"-2 since we are in feature freeze, will unblock after branching.","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"407b060db943896fa18933749ff8c6796719732f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2d1f888a_782a12e6","updated":"2026-03-13 09:38:57.000000000","message":"At a quick glance, it seems all the code added here is not enabled by default, so it does not change the default behavior. It should be safe to be added. As far as what the new code does, I admit I don\u0027t know that part well, but nothing looks out of order and other people with better knowledge of networking then myself have added their votes, so let\u0027s go.","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"25b6de4272477ce846ab34588e0aa61fbb0698b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3a6c0b9e_f265f803","updated":"2026-03-11 17:03:46.000000000","message":"I have removed WIP from https://review.opendev.org/c/openstack/neutron/+/962188 so this devstack patch (which is a dependency for the new neutron bgp job) is ready for code review too.","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"8e5306365343d81f154c3293e2dd798a3d0c2b17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"091f3bb4_6b3922c0","updated":"2026-03-11 15:18:58.000000000","message":"lgtm","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f849266fd6b268bf0f724dfcf340f504fd68b4d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5d9721ed_07eec89e","in_reply_to":"47e945c1_9fa179dd","updated":"2026-03-13 15:29:52.000000000","message":"++, thanks","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"be1191201d3520004f36a553bd2bfe6e9551eeeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ca0a1428_2c5c1887","in_reply_to":"5d9721ed_07eec89e","updated":"2026-04-07 10:58:22.000000000","message":"@frickler@offenerstapel.de\n\nIIUC feature freeze is over. Can you please remove the -2? Thanks.","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"aef3556c83a6eb901b591ac67fd4e7443febb605","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b1513eb4_9dfc260b","updated":"2026-03-16 12:50:39.000000000","message":"recheck tempest-full-py3","commit_id":"95b483aa827baab579ce62812f71fe1368f6a650"}],"lib/neutron":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"248c2eb73c7c8901388f2550d2496da6de4e5dd1","unresolved":true,"context_lines":[{"line_number":427,"context_line":"        configure_placement_neutron"},{"line_number":428,"context_line":"        configure_segments_extension"},{"line_number":429,"context_line":"    fi"},{"line_number":430,"context_line":"    if is_service_enabled ovn-bgp; then"},{"line_number":431,"context_line":"        configure_ovn_bgp_service_plugin"},{"line_number":432,"context_line":"    fi"},{"line_number":433,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"6a716c6f_d981af79","line":430,"range":{"start_line":430,"start_character":26,"end_line":430,"end_character":33},"updated":"2026-03-13 11:52:51.000000000","message":"can this be prefixed with either `neutron-` or `q-`? (or both?) (I\u0027m not sure which direction the neutron team is preferring, iirc there was some talk recently to stick to the `q-` option? but anyway it should be made clear that this is a sub-service for neutron","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2bd8b15ac2ed312ab6689486fd2d3f0de0c787e9","unresolved":true,"context_lines":[{"line_number":427,"context_line":"        configure_placement_neutron"},{"line_number":428,"context_line":"        configure_segments_extension"},{"line_number":429,"context_line":"    fi"},{"line_number":430,"context_line":"    if is_service_enabled ovn-bgp; then"},{"line_number":431,"context_line":"        configure_ovn_bgp_service_plugin"},{"line_number":432,"context_line":"    fi"},{"line_number":433,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"99f61e81_026b699d","line":430,"range":{"start_line":430,"start_character":26,"end_line":430,"end_character":33},"in_reply_to":"5be82d7e_8397d55d","updated":"2026-03-13 21:55:44.000000000","message":"That\u0027s a current issue we had now: we use both due to the partial and then reverted migration to the neutron v2 in devstack. We decided to go back to \"q-\" [1], as long as many CI jobs are still using \"q-\" prefix and we\u0027ll start migrating all services to this new naming convention.\n\n[1]https://meetings.opendev.org/meetings/neutron_drivers/2026/neutron_drivers.2026-01-16-14.01.log.html#l-14","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f5f75795b2954c4c9a06f146cb036ab5bb054da6","unresolved":true,"context_lines":[{"line_number":427,"context_line":"        configure_placement_neutron"},{"line_number":428,"context_line":"        configure_segments_extension"},{"line_number":429,"context_line":"    fi"},{"line_number":430,"context_line":"    if is_service_enabled ovn-bgp; then"},{"line_number":431,"context_line":"        configure_ovn_bgp_service_plugin"},{"line_number":432,"context_line":"    fi"},{"line_number":433,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"5be82d7e_8397d55d","line":430,"range":{"start_line":430,"start_character":26,"end_line":430,"end_character":33},"in_reply_to":"6a716c6f_d981af79","updated":"2026-03-13 12:06:30.000000000","message":"Good point, I\u0027ll ask around - my personal preference would be the `neutron-` prefix but if we want to stick to `q-` then let\u0027s go with that.","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"ffce760b7670390753592696103109eddf7e68b1","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        configure_placement_neutron"},{"line_number":428,"context_line":"        configure_segments_extension"},{"line_number":429,"context_line":"    fi"},{"line_number":430,"context_line":"    if is_service_enabled ovn-bgp; then"},{"line_number":431,"context_line":"        configure_ovn_bgp_service_plugin"},{"line_number":432,"context_line":"    fi"},{"line_number":433,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"f2005e51_57fe289f","line":430,"range":{"start_line":430,"start_character":26,"end_line":430,"end_character":33},"in_reply_to":"99f61e81_026b699d","updated":"2026-03-16 10:44:31.000000000","message":"ovn-bgp -\u003e q-ovn-bgp","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"}],"lib/neutron_plugins/ovn_agent":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6d12fc82e45c5a589c6b5e070ceb80823794902b","unresolved":true,"context_lines":[{"line_number":695,"context_line":"        fi"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        if [[ \"$OVN_AGENT_EXTENSIONS\" \u003d~ \u0027ovn-bgp\u0027 ]]; then"},{"line_number":698,"context_line":"            sudo ovs-vsctl --no-wait -- set Open_vSwitch . external-ids:bgp-peer-bridges\u003d$OVN_BGP_PEER_BRIDGES"},{"line_number":699,"context_line":"        elif is_provider_network || [[ $Q_USE_PROVIDERNET_FOR_PUBLIC \u003d\u003d \"True\" ]]; then"},{"line_number":700,"context_line":"            ovn_base_setup_bridge $OVS_PHYSICAL_BRIDGE"},{"line_number":701,"context_line":"            sudo ovs-vsctl set open . external-ids:ovn-bridge-mappings\u003d${PHYSICAL_NETWORK}:${OVS_PHYSICAL_BRIDGE}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"98208bec_64dd7d1f","line":698,"updated":"2026-01-21 11:19:25.000000000","message":"Who is in charge of creating these bridges?","commit_id":"1293ce382919dc6e619b806886cbcffbb2fc4776"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"3397aa0063ef63754edbb03b99742522f18caf74","unresolved":false,"context_lines":[{"line_number":695,"context_line":"        fi"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        if [[ \"$OVN_AGENT_EXTENSIONS\" \u003d~ \u0027ovn-bgp\u0027 ]]; then"},{"line_number":698,"context_line":"            sudo ovs-vsctl --no-wait -- set Open_vSwitch . external-ids:bgp-peer-bridges\u003d$OVN_BGP_PEER_BRIDGES"},{"line_number":699,"context_line":"        elif is_provider_network || [[ $Q_USE_PROVIDERNET_FOR_PUBLIC \u003d\u003d \"True\" ]]; then"},{"line_number":700,"context_line":"            ovn_base_setup_bridge $OVS_PHYSICAL_BRIDGE"},{"line_number":701,"context_line":"            sudo ovs-vsctl set open . external-ids:ovn-bridge-mappings\u003d${PHYSICAL_NETWORK}:${OVS_PHYSICAL_BRIDGE}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5e5a2fbe_edbb9e45","line":698,"in_reply_to":"1dfa6da5_636a3a04","updated":"2026-02-03 13:45:34.000000000","message":"Done","commit_id":"1293ce382919dc6e619b806886cbcffbb2fc4776"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d915ce81b822fe3619fad1c9a7e817e2dd7be55","unresolved":true,"context_lines":[{"line_number":695,"context_line":"        fi"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        if [[ \"$OVN_AGENT_EXTENSIONS\" \u003d~ \u0027ovn-bgp\u0027 ]]; then"},{"line_number":698,"context_line":"            sudo ovs-vsctl --no-wait -- set Open_vSwitch . external-ids:bgp-peer-bridges\u003d$OVN_BGP_PEER_BRIDGES"},{"line_number":699,"context_line":"        elif is_provider_network || [[ $Q_USE_PROVIDERNET_FOR_PUBLIC \u003d\u003d \"True\" ]]; then"},{"line_number":700,"context_line":"            ovn_base_setup_bridge $OVS_PHYSICAL_BRIDGE"},{"line_number":701,"context_line":"            sudo ovs-vsctl set open . external-ids:ovn-bridge-mappings\u003d${PHYSICAL_NETWORK}:${OVS_PHYSICAL_BRIDGE}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"1dfa6da5_636a3a04","line":698,"in_reply_to":"3be21575_6dcfab89","updated":"2026-02-03 07:50:18.000000000","message":"Ok, so that belongs to the deployment tool. Shouldn\u0027t this have a default value? Or at least fail if there is no value defined?","commit_id":"1293ce382919dc6e619b806886cbcffbb2fc4776"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"b990e29ab14920ed747225631b8ac5261307281e","unresolved":true,"context_lines":[{"line_number":695,"context_line":"        fi"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        if [[ \"$OVN_AGENT_EXTENSIONS\" \u003d~ \u0027ovn-bgp\u0027 ]]; then"},{"line_number":698,"context_line":"            sudo ovs-vsctl --no-wait -- set Open_vSwitch . external-ids:bgp-peer-bridges\u003d$OVN_BGP_PEER_BRIDGES"},{"line_number":699,"context_line":"        elif is_provider_network || [[ $Q_USE_PROVIDERNET_FOR_PUBLIC \u003d\u003d \"True\" ]]; then"},{"line_number":700,"context_line":"            ovn_base_setup_bridge $OVS_PHYSICAL_BRIDGE"},{"line_number":701,"context_line":"            sudo ovs-vsctl set open . external-ids:ovn-bridge-mappings\u003d${PHYSICAL_NETWORK}:${OVS_PHYSICAL_BRIDGE}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3be21575_6dcfab89","line":698,"in_reply_to":"98208bec_64dd7d1f","updated":"2026-01-21 11:54:17.000000000","message":"this playbook:\nhttps://review.opendev.org/c/openstack/neutron/+/962188/45/playbooks/configure_bgp_networking.yaml#58","commit_id":"1293ce382919dc6e619b806886cbcffbb2fc4776"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"248c2eb73c7c8901388f2550d2496da6de4e5dd1","unresolved":true,"context_lines":[{"line_number":699,"context_line":"            sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-cms-options\u003d\"enable-chassis-as-gw\""},{"line_number":700,"context_line":"        fi"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        if [[ \"$OVN_AGENT_EXTENSIONS\" \u003d~ \u0027ovn-bgp\u0027 ]]; then"},{"line_number":703,"context_line":"            if [[ -z \"$NEUTRON_BGP_PEER_BRIDGES\" ]]; then"},{"line_number":704,"context_line":"                echo \"NEUTRON_BGP_PEER_BRIDGES must be set when ovn-bgp extension is enabled\""},{"line_number":705,"context_line":"                return 1"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"06b7db3d_765d09e6","line":702,"updated":"2026-03-13 11:52:51.000000000","message":"why do you check this and not whether the service is enabled? can\u0027t this lead to inconsistent deployments?","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f5f75795b2954c4c9a06f146cb036ab5bb054da6","unresolved":true,"context_lines":[{"line_number":699,"context_line":"            sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-cms-options\u003d\"enable-chassis-as-gw\""},{"line_number":700,"context_line":"        fi"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        if [[ \"$OVN_AGENT_EXTENSIONS\" \u003d~ \u0027ovn-bgp\u0027 ]]; then"},{"line_number":703,"context_line":"            if [[ -z \"$NEUTRON_BGP_PEER_BRIDGES\" ]]; then"},{"line_number":704,"context_line":"                echo \"NEUTRON_BGP_PEER_BRIDGES must be set when ovn-bgp extension is enabled\""},{"line_number":705,"context_line":"                return 1"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"504a6cd7_198ebc32","line":702,"in_reply_to":"06b7db3d_765d09e6","updated":"2026-03-13 12:06:30.000000000","message":"There are two \"drivers\" and both are named ovn-bgp - one is a service plugin for the Neutron Server side (neutron-periodic-workers service)  and one is an extension for the OVN agent (neutron-ovn-agent service). This check is for the extension and I do not think we have a function like is_service_enabled for this.","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"be1191201d3520004f36a553bd2bfe6e9551eeeb","unresolved":false,"context_lines":[{"line_number":699,"context_line":"            sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-cms-options\u003d\"enable-chassis-as-gw\""},{"line_number":700,"context_line":"        fi"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        if [[ \"$OVN_AGENT_EXTENSIONS\" \u003d~ \u0027ovn-bgp\u0027 ]]; then"},{"line_number":703,"context_line":"            if [[ -z \"$NEUTRON_BGP_PEER_BRIDGES\" ]]; then"},{"line_number":704,"context_line":"                echo \"NEUTRON_BGP_PEER_BRIDGES must be set when ovn-bgp extension is enabled\""},{"line_number":705,"context_line":"                return 1"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"e6930935_e8d24bf8","line":702,"in_reply_to":"504a6cd7_198ebc32","updated":"2026-04-07 10:58:22.000000000","message":"Done","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"}],"lib/neutron_plugins/services/l3":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"25bc9861f71f473560808b7263e511931b7c7d01","unresolved":false,"context_lines":[{"line_number":94,"context_line":"PUBLIC_NETWORK_GATEWAY\u003d${PUBLIC_NETWORK_GATEWAY:-}"},{"line_number":95,"context_line":"PRIVATE_SUBNET_NAME\u003d${PRIVATE_SUBNET_NAME:-\"private-subnet\"}"},{"line_number":96,"context_line":"PUBLIC_SUBNET_NAME\u003d${PUBLIC_SUBNET_NAME:-\"public-subnet\"}"},{"line_number":97,"context_line":"PUBLIC_SUBNET_ENABLE_DHCP\u003d${PUBLIC_SUBNET_ENABLE_DHCP:-False}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# Subnetpool defaults"},{"line_number":100,"context_line":"USE_SUBNETPOOL\u003d${USE_SUBNETPOOL:-True}"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"f1be0ac3_551eeff4","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":25},"updated":"2026-03-12 16:19:21.000000000","message":"Ok, now I see you are using it here: https://review.opendev.org/c/openstack/neutron/+/962188/75/zuul.d/tempest-multinode-bgp.yaml","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"afb8a4b2d8b8fb8d7e5f10adcbec9b561c968061","unresolved":false,"context_lines":[{"line_number":94,"context_line":"PUBLIC_NETWORK_GATEWAY\u003d${PUBLIC_NETWORK_GATEWAY:-}"},{"line_number":95,"context_line":"PRIVATE_SUBNET_NAME\u003d${PRIVATE_SUBNET_NAME:-\"private-subnet\"}"},{"line_number":96,"context_line":"PUBLIC_SUBNET_NAME\u003d${PUBLIC_SUBNET_NAME:-\"public-subnet\"}"},{"line_number":97,"context_line":"PUBLIC_SUBNET_ENABLE_DHCP\u003d${PUBLIC_SUBNET_ENABLE_DHCP:-False}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# Subnetpool defaults"},{"line_number":100,"context_line":"USE_SUBNETPOOL\u003d${USE_SUBNETPOOL:-True}"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"bba12df1_c6f062ea","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":25},"in_reply_to":"f1be0ac3_551eeff4","updated":"2026-03-12 21:52:18.000000000","message":"right, I think disabling DHCP for provider networks does not make much sense since DHCP is L2 layer and we assume L3 everywhere. So even if there was a DHCP server on the provider network, it would need DHCP relays configured.","commit_id":"21a925ace5b4a11b2ad95c5e227905adaa928f10"}]}