)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d2fc78e838210bb039f257bf2270b2e6576e2c7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6ecc7d16_792e258a","updated":"2026-01-22 19:06:19.000000000","message":"lgtm","commit_id":"c2a5090c2f6ab70cf8d3026e9af26af84cca3a3a"}],"functions":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dacd782b64a29bb0c861b81970cb3d5191a3b2a5","unresolved":true,"context_lines":[{"line_number":67,"context_line":"    local retry_args\u003d\"--retry-on-host-error --retry-on-http-error\u003d${EXTRA_FILES_RETRY_ERRORS} \""},{"line_number":68,"context_line":"    retry_args+\u003d\"-t ${EXTRA_FILES_DOWNLOAD_TIMEOUT} --waitretry\u003d${EXTRA_FILES_RETRY_TIMEOUT} \""},{"line_number":69,"context_line":"    retry_args+\u003d\"--tries\u003d${EXTRA_FILES_RETRY} --retry-connrefused\""},{"line_number":70,"context_line":"    # Using Bash parameter expansion (##*/) instead of external \u0027basename\u0027"},{"line_number":71,"context_line":"    local file_name\u003d\"${file_url##*/}\""},{"line_number":72,"context_line":"    if [[ $file_url !\u003d file* ]]; then"},{"line_number":73,"context_line":"        # If the file isn\u0027t cache, download it"},{"line_number":74,"context_line":"        if [[ ! -f $FILES/$file_name ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"a458475e_8d9060ae","line":71,"range":{"start_line":70,"start_character":4,"end_line":71,"end_character":36},"updated":"2025-11-24 19:23:35.000000000","message":"this  (adding local and replaceing basename with partmare expansion) and ...","commit_id":"c2a5090c2f6ab70cf8d3026e9af26af84cca3a3a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dacd782b64a29bb0c861b81970cb3d5191a3b2a5","unresolved":true,"context_lines":[{"line_number":81,"context_line":"        return"},{"line_number":82,"context_line":"    else"},{"line_number":83,"context_line":"        # just strip the file:// bit and that\u0027s the path to the file"},{"line_number":84,"context_line":"        echo \"${file_url#file://}\""},{"line_number":85,"context_line":"    fi"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9f44af84_ba614d04","line":84,"updated":"2025-11-24 19:23:35.000000000","message":"... this removing the use of sed were the suggestion form gemini to minimize external deps\n\ni can eitehr drop this change or put it in a seperate commit if we prefer.\n\n\nwe used to use bash parameter expansion like this a lot in networking-ovs-dpdk but ill admin i completely forgto that was a thing until it mentione dit so im fine with using basename and sed to keep it simple as well.\n\ndo we have a gener prefence betwen using common tools like basename and sed that should always be present in a posix env vs using bash inbuilt behaviour?","commit_id":"c2a5090c2f6ab70cf8d3026e9af26af84cca3a3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d2fc78e838210bb039f257bf2270b2e6576e2c7a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        return"},{"line_number":82,"context_line":"    else"},{"line_number":83,"context_line":"        # just strip the file:// bit and that\u0027s the path to the file"},{"line_number":84,"context_line":"        echo \"${file_url#file://}\""},{"line_number":85,"context_line":"    fi"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"c66e7800_3947a9e1","line":84,"in_reply_to":"9f44af84_ba614d04","updated":"2026-01-22 19:06:19.000000000","message":"I think I am on using inbuilt things unless we really need to do soemthing with external tools.","commit_id":"c2a5090c2f6ab70cf8d3026e9af26af84cca3a3a"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"58e5574f42136b1ee6bf18ba523b25df4d2da0cf","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        return"},{"line_number":82,"context_line":"    else"},{"line_number":83,"context_line":"        # just strip the file:// bit and that\u0027s the path to the file"},{"line_number":84,"context_line":"        echo \"${file_url#file://}\""},{"line_number":85,"context_line":"    fi"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"aa2d4e0e_da89f8e3","line":84,"in_reply_to":"c66e7800_3947a9e1","updated":"2026-02-03 16:43:30.000000000","message":"I would argue basename is something that we can always rely on. As far as sed is concerned, the bash-native replacement is fine, I guess.\n\nBut let\u0027s move forward with this","commit_id":"c2a5090c2f6ab70cf8d3026e9af26af84cca3a3a"}]}