)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6f7a4fed4c5c7b7ea965df62fb07defdea6c22d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3db64cb0_e8b5eea9","updated":"2026-01-12 09:50:19.000000000","message":"I need to admit that the neutron service naming is a mess (`q-`, `neutron-`). We (Neutron team) never finished the migration to `neutron-`.\n\nIn any case, I would propose new patches to:\n* Replace the no longer used `q-svc`. This is now `neutron-api` since we moved to WSGI.\n* Replace the `q-ovn-agent` and `q-ovn-metadata-agent` with the names `neutron-ovn-agent` and `neutron-ovn-metadata-agent`.\n* Also replace the other agents (L3, DHCP, SR-IOV and OVS) with the new prefix","commit_id":"dc51f6fbb35fec8adfb40b7f21cd319fc81ab928"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1f5f3181dd4ad759f1d45cb1f0679b480b4fc8fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7c799af_46f343b4","updated":"2026-01-12 07:12:12.000000000","message":"thx, lgtm but one cleanup inline","commit_id":"dc51f6fbb35fec8adfb40b7f21cd319fc81ab928"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"59c155a15bb04e4300c34c87502c94b6a62df0b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"53ce181a_27f48f41","in_reply_to":"3db64cb0_e8b5eea9","updated":"2026-01-12 11:45:31.000000000","message":"i wasnt actully aware ye started it.\n\ni assume it was starteed as part of the eventlet removal?\nrenameing the sevice will break existing local.conf and ci jobs so we coudl do it but it woudl have been better to stick with the q- forever or move all of them in one go doing it peicemeal is not good DX.\n\nwe also shoudl conitnue to make the q- work for some peroid of time by having the new names default to the old.\n\nthe service names are part of the public api of destack and the muscel memory of developers. the second we change them we break all the existing trible knowladge and debuging experince i.e. `systemctl -f -u q-* | lnav -q` to monitor all of neutron.","commit_id":"dc51f6fbb35fec8adfb40b7f21cd319fc81ab928"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"634c38fa19e6bc5e2b1182ea3133efa98b8a400a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a82853d9_5fffebf5","in_reply_to":"53ce181a_27f48f41","updated":"2026-01-12 12:09:10.000000000","message":"We (Neutron) started that 8 years ago (more or less) and closed the unfinished work in [1]. So now we support both prefixes. But for the q-svc (for example), this is no longer used now.\n\nI think we can do this gradually, as long as we support both prefixes. We can change the current CI jobs and documents to use the `neutron-` one.\n\n[1]https://review.opendev.org/c/openstack/devstack/+/865014","commit_id":"dc51f6fbb35fec8adfb40b7f21cd319fc81ab928"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"31f207fa43e875af54181f301fcb38164513ccc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d3380b50_1bcb35e4","updated":"2026-01-22 15:52:14.000000000","message":"just a naming nit I can live with","commit_id":"efb34cacc71d4c80a4a62655f271526981a61a48"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"67ec094ffaa9b3ce81a7218c325377202852bfc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"42acce06_9ef68109","updated":"2026-01-22 18:43:47.000000000","message":"lgtm","commit_id":"efb34cacc71d4c80a4a62655f271526981a61a48"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"52cfd197db470ed71a76ed81131394a4d210e62b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6bd2ec1c_e58bec5d","updated":"2026-01-22 19:47:16.000000000","message":"recheck cephadm failed \n\n2026-01-22 15:15:55.768987 | controller | Non-zero exit code 95 from /usr/bin/podman run --rm --ipc\u003dhost --stop-signal\u003dSIGTERM --net\u003dhost --entrypoint /usr/bin/ceph --init -e CONTAINER_IMAGE\u003dquay.io/ceph/ceph:v20 -e NODE_NAME\u003dnp4cef510a42104 -v /var/log/ceph/fafa640e-4003-4007-b096-e2692470e30f:/var/log/ceph:z -v /tmp/ceph-tmpb4cvrz_v:/etc/ceph/ceph.client.admin.keyring:z -v /tmp/ceph-tmpgiq1hjcr:/etc/ceph/ceph.conf:z quay.io/ceph/ceph:v20 orch set backend cephadm","commit_id":"efb34cacc71d4c80a4a62655f271526981a61a48"}],"lib/neutron":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1f5f3181dd4ad759f1d45cb1f0679b480b4fc8fa","unresolved":true,"context_lines":[{"line_number":633,"context_line":"        enable_service neutron-rpc-server"},{"line_number":634,"context_line":"    fi"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    # Enable OVN maintenance worker if using OVN"},{"line_number":637,"context_line":"    if [[ $Q_AGENT \u003d\u003d \"ovn\" ]]; then"},{"line_number":638,"context_line":"        enable_service neutron-ovn-maintenance-worker"},{"line_number":639,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"192c12c7_82fed0ca","line":636,"updated":"2026-01-12 07:12:12.000000000","message":"can just call _enable_ovn_maintenance which already does the check and enable part","commit_id":"dc51f6fbb35fec8adfb40b7f21cd319fc81ab928"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6f7a4fed4c5c7b7ea965df62fb07defdea6c22d0","unresolved":true,"context_lines":[{"line_number":633,"context_line":"        enable_service neutron-rpc-server"},{"line_number":634,"context_line":"    fi"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    # Enable OVN maintenance worker if using OVN"},{"line_number":637,"context_line":"    if [[ $Q_AGENT \u003d\u003d \"ovn\" ]]; then"},{"line_number":638,"context_line":"        enable_service neutron-ovn-maintenance-worker"},{"line_number":639,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"eac3899f_1056d231","line":636,"in_reply_to":"192c12c7_82fed0ca","updated":"2026-01-12 09:50:19.000000000","message":"+1","commit_id":"dc51f6fbb35fec8adfb40b7f21cd319fc81ab928"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6b09cd8d7b2034263fe5fccb1ffc143498d2b93b","unresolved":true,"context_lines":[{"line_number":633,"context_line":"        enable_service neutron-rpc-server"},{"line_number":634,"context_line":"    fi"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    # Enable OVN maintenance worker if using OVN"},{"line_number":637,"context_line":"    if [[ $Q_AGENT \u003d\u003d \"ovn\" ]]; then"},{"line_number":638,"context_line":"        enable_service neutron-ovn-maintenance-worker"},{"line_number":639,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"cd656a10_23a8782b","line":636,"in_reply_to":"7f443cd5_c3d9dd18","updated":"2026-01-12 15:36:54.000000000","message":"deleting fine too as unused now","commit_id":"dc51f6fbb35fec8adfb40b7f21cd319fc81ab928"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"eac4ad7f07d8fcb7bab4315f4e3965e7aece13a2","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        enable_service neutron-rpc-server"},{"line_number":634,"context_line":"    fi"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    # Enable OVN maintenance worker if using OVN"},{"line_number":637,"context_line":"    if [[ $Q_AGENT \u003d\u003d \"ovn\" ]]; then"},{"line_number":638,"context_line":"        enable_service neutron-ovn-maintenance-worker"},{"line_number":639,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"e368bdfd_cc7c9543","line":636,"in_reply_to":"cd656a10_23a8782b","updated":"2026-01-22 14:41:52.000000000","message":"Done","commit_id":"dc51f6fbb35fec8adfb40b7f21cd319fc81ab928"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"59c155a15bb04e4300c34c87502c94b6a62df0b7","unresolved":true,"context_lines":[{"line_number":633,"context_line":"        enable_service neutron-rpc-server"},{"line_number":634,"context_line":"    fi"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    # Enable OVN maintenance worker if using OVN"},{"line_number":637,"context_line":"    if [[ $Q_AGENT \u003d\u003d \"ovn\" ]]; then"},{"line_number":638,"context_line":"        enable_service neutron-ovn-maintenance-worker"},{"line_number":639,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7f443cd5_c3d9dd18","line":636,"in_reply_to":"eac3899f_1056d231","updated":"2026-01-12 11:45:31.000000000","message":"i guess i can but its only used in this function so it probaly better to just delete _enable_ovn_maintenance\n\nas an aside calling enable_service in devstack is actully kind of an anti pattern in general.  we are kind of workign around the fact that in general we shoudl not eb dynmiclly enabling serivces like this at all.","commit_id":"dc51f6fbb35fec8adfb40b7f21cd319fc81ab928"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"31f207fa43e875af54181f301fcb38164513ccc9","unresolved":true,"context_lines":[{"line_number":605,"context_line":"# and adds them to ENABLED_SERVICES. It reads the neutron configuration"},{"line_number":606,"context_line":"# to determine if RPC workers should be enabled."},{"line_number":607,"context_line":"# This must be called after configure_neutron has created the config files."},{"line_number":608,"context_line":"function enable_neutron_server_services {"},{"line_number":609,"context_line":"    local rpc_workers"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"    # The default value of \"rpc_workers\" is None (not defined). If"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f97902d_0aa94213","line":608,"range":{"start_line":608,"start_character":9,"end_line":608,"end_character":39},"updated":"2026-01-22 15:52:14.000000000","message":"do we need the \"server\" word here?","commit_id":"efb34cacc71d4c80a4a62655f271526981a61a48"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"41a0766e274ba8b5241af58a79e14f2d461343e4","unresolved":true,"context_lines":[{"line_number":605,"context_line":"# and adds them to ENABLED_SERVICES. It reads the neutron configuration"},{"line_number":606,"context_line":"# to determine if RPC workers should be enabled."},{"line_number":607,"context_line":"# This must be called after configure_neutron has created the config files."},{"line_number":608,"context_line":"function enable_neutron_server_services {"},{"line_number":609,"context_line":"    local rpc_workers"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"    # The default value of \"rpc_workers\" is None (not defined). If"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"f988f743_34440985","line":608,"range":{"start_line":608,"start_character":9,"end_line":608,"end_character":39},"in_reply_to":"3f97902d_0aa94213","updated":"2026-01-22 19:45:02.000000000","message":"server is in this name jsut because the neutron-api and neutron-periodic-workesrs and neutron-rpc-server were part fo neutron-server binary in the past.\n\n\nthis is not all posible neutron services as it does not include the ovn agent or ml2 agents that run on the compute nodes jsut a collection of the neutron services that run on the contoler.\n\nif folks prefer a diffent name im fine with that but i avoid enable_neutron_services because i woudl expect that to enabel all relevnet neutron serices including the compute node ones and things liek the l3 or dhcp agenst when those are configured.","commit_id":"efb34cacc71d4c80a4a62655f271526981a61a48"}]}