)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"81d4ec87eb34f74930f1a64d2e77a5af1f6c11d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b9df2739_d9a8b56c","updated":"2026-01-29 01:32:34.000000000","message":"-1 for the wrong endpoint_service_type for Nova","commit_id":"e633d49a4bfe0b88362d76ce723e63fe3b877c5e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cc5648471e16d26ebff08e9641fc2b9c143c4833","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7bc65a82_761465e1","updated":"2026-01-29 17:40:44.000000000","message":"check experimental","commit_id":"aa31c0c739ffd1a3a944b488aaae6409b823e020"}],"lib/nova":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"81d4ec87eb34f74930f1a64d2e77a5af1f6c11d1","unresolved":true,"context_lines":[{"line_number":830,"context_line":"    iniset $NOVA_CONF oslo_limit auth_type password"},{"line_number":831,"context_line":"    iniset $NOVA_CONF oslo_limit auth_url $KEYSTONE_SERVICE_URI"},{"line_number":832,"context_line":"    iniset $NOVA_CONF oslo_limit system_scope all"},{"line_number":833,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_service_type image"},{"line_number":834,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_interface public"},{"line_number":835,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_region_name $REGION_NAME"},{"line_number":836,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"8bf584d3_4f5513dc","line":833,"range":{"start_line":833,"start_character":55,"end_line":833,"end_character":60},"updated":"2026-01-29 01:32:34.000000000","message":"compute","commit_id":"e633d49a4bfe0b88362d76ce723e63fe3b877c5e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"43db96134aea5736adedaa8767c75c5accf2e8bf","unresolved":false,"context_lines":[{"line_number":830,"context_line":"    iniset $NOVA_CONF oslo_limit auth_type password"},{"line_number":831,"context_line":"    iniset $NOVA_CONF oslo_limit auth_url $KEYSTONE_SERVICE_URI"},{"line_number":832,"context_line":"    iniset $NOVA_CONF oslo_limit system_scope all"},{"line_number":833,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_service_type image"},{"line_number":834,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_interface public"},{"line_number":835,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_region_name $REGION_NAME"},{"line_number":836,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"4a5d42ea_9375626d","line":833,"range":{"start_line":833,"start_character":55,"end_line":833,"end_character":60},"in_reply_to":"8bf584d3_4f5513dc","updated":"2026-01-29 14:16:05.000000000","message":"Oh yes. Fixed it.","commit_id":"e633d49a4bfe0b88362d76ce723e63fe3b877c5e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"81d4ec87eb34f74930f1a64d2e77a5af1f6c11d1","unresolved":true,"context_lines":[{"line_number":831,"context_line":"    iniset $NOVA_CONF oslo_limit auth_url $KEYSTONE_SERVICE_URI"},{"line_number":832,"context_line":"    iniset $NOVA_CONF oslo_limit system_scope all"},{"line_number":833,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_service_type image"},{"line_number":834,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_interface public"},{"line_number":835,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_region_name $REGION_NAME"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    # Allow the nova service user to read quotas"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9f814d4f_7f8cef3d","line":834,"range":{"start_line":834,"start_character":52,"end_line":834,"end_character":58},"updated":"2026-01-29 01:32:34.000000000","message":"internal","commit_id":"e633d49a4bfe0b88362d76ce723e63fe3b877c5e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"43db96134aea5736adedaa8767c75c5accf2e8bf","unresolved":false,"context_lines":[{"line_number":831,"context_line":"    iniset $NOVA_CONF oslo_limit auth_url $KEYSTONE_SERVICE_URI"},{"line_number":832,"context_line":"    iniset $NOVA_CONF oslo_limit system_scope all"},{"line_number":833,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_service_type image"},{"line_number":834,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_interface public"},{"line_number":835,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_region_name $REGION_NAME"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    # Allow the nova service user to read quotas"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"0d398143_8ed342c8","line":834,"range":{"start_line":834,"start_character":52,"end_line":834,"end_character":58},"in_reply_to":"4e691ae5_67f318c1","updated":"2026-01-29 14:16:05.000000000","message":"Yeah it\u0027s confusing but the public endpoint is the only one created in devstack atm.","commit_id":"e633d49a4bfe0b88362d76ce723e63fe3b877c5e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7cf6376396a071dadf5b34e78ebe15735517610b","unresolved":true,"context_lines":[{"line_number":831,"context_line":"    iniset $NOVA_CONF oslo_limit auth_url $KEYSTONE_SERVICE_URI"},{"line_number":832,"context_line":"    iniset $NOVA_CONF oslo_limit system_scope all"},{"line_number":833,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_service_type image"},{"line_number":834,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_interface public"},{"line_number":835,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_region_name $REGION_NAME"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    # Allow the nova service user to read quotas"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"4e691ae5_67f318c1","line":834,"range":{"start_line":834,"start_character":52,"end_line":834,"end_character":58},"in_reply_to":"9f814d4f_7f8cef3d","updated":"2026-01-29 02:13:17.000000000","message":"Sorry you are right, this should be `public` for devstack so please ignore the previous comment.","commit_id":"e633d49a4bfe0b88362d76ce723e63fe3b877c5e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"81d4ec87eb34f74930f1a64d2e77a5af1f6c11d1","unresolved":true,"context_lines":[{"line_number":833,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_service_type image"},{"line_number":834,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_interface public"},{"line_number":835,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_region_name $REGION_NAME"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    # Allow the nova service user to read quotas"},{"line_number":838,"context_line":"    openstack --os-cloud devstack-system-admin role add --user nova \\"},{"line_number":839,"context_line":"        --user-domain $SERVICE_DOMAIN_NAME --system all reader"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"21247fba_307f6286","line":836,"updated":"2026-01-29 01:32:34.000000000","message":"Sorry I didn\u0027t see your patch before I uploaded another that is very similar:\n\nhttps://review.opendev.org/c/openstack/devstack/+/974791\n\nUnfortunately we have a bug in Nova like the one you fixed in oslo.limit about the openstacksdk generators, so we will have to fix that before we can change Devstack:\n\nhttps://review.opendev.org/c/openstack/nova/+/975106","commit_id":"e633d49a4bfe0b88362d76ce723e63fe3b877c5e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ba8f547915f5ec50ae5ed546cb8e3b8b8371470b","unresolved":true,"context_lines":[{"line_number":833,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_service_type image"},{"line_number":834,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_interface public"},{"line_number":835,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_region_name $REGION_NAME"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    # Allow the nova service user to read quotas"},{"line_number":838,"context_line":"    openstack --os-cloud devstack-system-admin role add --user nova \\"},{"line_number":839,"context_line":"        --user-domain $SERVICE_DOMAIN_NAME --system all reader"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"8e99a164_4b7979ee","line":836,"in_reply_to":"0306c2f3_3547e772","updated":"2026-01-29 19:46:37.000000000","message":"Update: I think I see why `nova-next` is not failing and I think it\u0027s because we have a gap in our integration test coverage. The bug is in a part of the code that only runs if we encounter an _unset_ unified limit for a resource being requested. And currently all of the test coverage is setting all of the unified limits, so the branch for unset limits is not being reached.\n\nI will work on a Tempest patch to cover that gap and I will Depends-On this to verify the behavior.","commit_id":"e633d49a4bfe0b88362d76ce723e63fe3b877c5e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"43db96134aea5736adedaa8767c75c5accf2e8bf","unresolved":true,"context_lines":[{"line_number":833,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_service_type image"},{"line_number":834,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_interface public"},{"line_number":835,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_region_name $REGION_NAME"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    # Allow the nova service user to read quotas"},{"line_number":838,"context_line":"    openstack --os-cloud devstack-system-admin role add --user nova \\"},{"line_number":839,"context_line":"        --user-domain $SERVICE_DOMAIN_NAME --system all reader"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"70d2d86b_0045461b","line":836,"in_reply_to":"21247fba_307f6286","updated":"2026-01-29 14:16:05.000000000","message":"Ah, ok. I can probably exclude the nova change part from this change and defer it to yours.","commit_id":"e633d49a4bfe0b88362d76ce723e63fe3b877c5e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7f77c21df1488f590c0c3e448ab793496a64b501","unresolved":true,"context_lines":[{"line_number":833,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_service_type image"},{"line_number":834,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_interface public"},{"line_number":835,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_region_name $REGION_NAME"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    # Allow the nova service user to read quotas"},{"line_number":838,"context_line":"    openstack --os-cloud devstack-system-admin role add --user nova \\"},{"line_number":839,"context_line":"        --user-domain $SERVICE_DOMAIN_NAME --system all reader"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"0306c2f3_3547e772","line":836,"in_reply_to":"2541e803_0afe0769","updated":"2026-01-29 19:26:55.000000000","message":"So ... `nova-next` _passed_ and I don\u0027t understand how, given that Nova is doing len(generator) in its code when endpoint_id is not configured for oslo_limit ... I will go through the job logs to see if I can figure out what\u0027s going on.","commit_id":"e633d49a4bfe0b88362d76ce723e63fe3b877c5e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cc5648471e16d26ebff08e9641fc2b9c143c4833","unresolved":true,"context_lines":[{"line_number":833,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_service_type image"},{"line_number":834,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_interface public"},{"line_number":835,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_region_name $REGION_NAME"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    # Allow the nova service user to read quotas"},{"line_number":838,"context_line":"    openstack --os-cloud devstack-system-admin role add --user nova \\"},{"line_number":839,"context_line":"        --user-domain $SERVICE_DOMAIN_NAME --system all reader"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"2541e803_0afe0769","line":836,"in_reply_to":"70d2d86b_0045461b","updated":"2026-01-29 17:40:44.000000000","message":"I don\u0027t think we need to defer, but we do need to hold off on removing endpoint_id until Nova is fixed for endpoint discovery. FYI the only CI job where Nova runs with unified limits enabled is `nova-next` so I think it would fail with this change.\n\nI will run the experimental pipeline to make sure.","commit_id":"e633d49a4bfe0b88362d76ce723e63fe3b877c5e"}]}