)]}'
{"lib/databases/mysql":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"1b6d3178f1086b2f9912f44ec33e61e5342916b5","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    # set default db type to InnoDB"},{"line_number":89,"context_line":"    sudo bash -c \"source $TOP_DIR/functions \u0026\u0026 \\"},{"line_number":90,"context_line":"        iniset $MY_CONF mysqld bind-address 0.0.0.0 \u0026\u0026 \\"},{"line_number":91,"context_line":"        iniset $MY_CONF mysqld sql_mode STRICT_ALL_TABLES \u0026\u0026 \\"},{"line_number":92,"context_line":"        iniset $MY_CONF mysqld default-storage-engine InnoDB\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ae5cdf2_194668c0","line":91,"updated":"2014-06-12 15:51:17.000000000","message":"I\u0027d rather see TRADITIONAL here.  \n\n\"Setting the sql_mode system variable to TRADITIONAL causes MySQL to act like more traditional database servers in its input data handling.\"\n\nFrom http://www.mysqlfaqs.net/mysql-faqs/Client-Server-Commands/What-is-sql-mode-in-MySQL-and-how-can-we-set-it\n\nBasically it\u0027s a superset of strict mode and probably closer to how postgres does things.  Also, it\u0027s what we\u0027ll eventually be enabling by default once everyone switches to oslo.db/updates their incubator code.","commit_id":"e56c137edb504cb86c4bb2cc5749603829438378"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ebfac37eaf6cdc8f487b1a099f81e3d05af8b289","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    # set default db type to InnoDB"},{"line_number":89,"context_line":"    sudo bash -c \"source $TOP_DIR/functions \u0026\u0026 \\"},{"line_number":90,"context_line":"        iniset $MY_CONF mysqld bind-address 0.0.0.0 \u0026\u0026 \\"},{"line_number":91,"context_line":"        iniset $MY_CONF mysqld sql_mode STRICT_ALL_TABLES \u0026\u0026 \\"},{"line_number":92,"context_line":"        iniset $MY_CONF mysqld default-storage-engine InnoDB\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ae5cdf2_ef6e37ff","line":91,"in_reply_to":"1ae5cdf2_0fcc4369","updated":"2014-06-13 08:24:17.000000000","message":"The official doc about the tradional mode is here : http://dev.mysql.com/doc/refman/5.5/en/sql-mode.html#sqlmode_traditional","commit_id":"e56c137edb504cb86c4bb2cc5749603829438378"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"81bf957fbd7edae38654f6e2d98d873b779a5929","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    # set default db type to InnoDB"},{"line_number":89,"context_line":"    sudo bash -c \"source $TOP_DIR/functions \u0026\u0026 \\"},{"line_number":90,"context_line":"        iniset $MY_CONF mysqld bind-address 0.0.0.0 \u0026\u0026 \\"},{"line_number":91,"context_line":"        iniset $MY_CONF mysqld sql_mode STRICT_ALL_TABLES \u0026\u0026 \\"},{"line_number":92,"context_line":"        iniset $MY_CONF mysqld default-storage-engine InnoDB\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ae5cdf2_0fcc4369","line":91,"in_reply_to":"1ae5cdf2_194668c0","updated":"2014-06-13 08:11:02.000000000","message":"There\u0027s a discussion about this here : http://lists.openstack.org/pipermail/openstack-dev/2014-January/025259.html","commit_id":"e56c137edb504cb86c4bb2cc5749603829438378"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"c13a769c02fa10c489dce243c244d31df1da9aa9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    # set default db type to InnoDB"},{"line_number":89,"context_line":"    sudo bash -c \"source $TOP_DIR/functions \u0026\u0026 \\"},{"line_number":90,"context_line":"        iniset $MY_CONF mysqld bind-address 0.0.0.0 \u0026\u0026 \\"},{"line_number":91,"context_line":"        iniset $MY_CONF mysqld sql_mode STRICT_ALL_TABLES \u0026\u0026 \\"},{"line_number":92,"context_line":"        iniset $MY_CONF mysqld default-storage-engine InnoDB\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ae5cdf2_1325005c","line":91,"in_reply_to":"1ae5cdf2_44bd24d7","updated":"2014-06-16 17:14:05.000000000","message":"Well, all of those mysql experts had ample opportunity to weigh in on the multiple discussions on the mailing list about this very topic.  None of them did, so we went with the strictest option.","commit_id":"e56c137edb504cb86c4bb2cc5749603829438378"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a2e3e28ceb323b83a59a86bd4d8067380f3dffcf","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    # set default db type to InnoDB"},{"line_number":89,"context_line":"    sudo bash -c \"source $TOP_DIR/functions \u0026\u0026 \\"},{"line_number":90,"context_line":"        iniset $MY_CONF mysqld bind-address 0.0.0.0 \u0026\u0026 \\"},{"line_number":91,"context_line":"        iniset $MY_CONF mysqld sql_mode STRICT_ALL_TABLES \u0026\u0026 \\"},{"line_number":92,"context_line":"        iniset $MY_CONF mysqld default-storage-engine InnoDB\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ae5cdf2_44bd24d7","line":91,"in_reply_to":"1ae5cdf2_cde899b5","updated":"2014-06-16 01:01:27.000000000","message":"Honestly, oslo.db opinions aren\u0027t holding much sway with me given the number of things that were broken in it recently that degraded nova functionality (like not being able to run tests in parallel).\n\nIt seems the mysql experts are mostly on the STRICT side, and I\u0027m not really sure that TRADITIONAL buys us really all that much given the SQLA layer.","commit_id":"e56c137edb504cb86c4bb2cc5749603829438378"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9b7d9bb0a9e61f460d35e2187a141d7b2c1de0f5","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    # set default db type to InnoDB"},{"line_number":89,"context_line":"    sudo bash -c \"source $TOP_DIR/functions \u0026\u0026 \\"},{"line_number":90,"context_line":"        iniset $MY_CONF mysqld bind-address 0.0.0.0 \u0026\u0026 \\"},{"line_number":91,"context_line":"        iniset $MY_CONF mysqld sql_mode STRICT_ALL_TABLES \u0026\u0026 \\"},{"line_number":92,"context_line":"        iniset $MY_CONF mysqld default-storage-engine InnoDB\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ae5cdf2_f40a8777","line":91,"in_reply_to":"1ae5cdf2_ef6e37ff","updated":"2014-06-13 10:52:04.000000000","message":"So reading the mysql docs it\u0027s not clear to me that TRADITIONAL is actually closer to PG than Strict. \n\nThe additional options seems to have no overlap with the PG compat options.","commit_id":"e56c137edb504cb86c4bb2cc5749603829438378"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"4b7bdba44b7d778f8689610ef6cb100534797534","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    # set default db type to InnoDB"},{"line_number":89,"context_line":"    sudo bash -c \"source $TOP_DIR/functions \u0026\u0026 \\"},{"line_number":90,"context_line":"        iniset $MY_CONF mysqld bind-address 0.0.0.0 \u0026\u0026 \\"},{"line_number":91,"context_line":"        iniset $MY_CONF mysqld sql_mode STRICT_ALL_TABLES \u0026\u0026 \\"},{"line_number":92,"context_line":"        iniset $MY_CONF mysqld default-storage-engine InnoDB\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ae5cdf2_cde899b5","line":91,"in_reply_to":"1ae5cdf2_f40a8777","updated":"2014-06-13 15:12:47.000000000","message":"Okay, maybe it doesn\u0027t help with postgres compatibility, but why would we _not_ want the extra validation?\n\nBesides which, the current plan is to make TRADITIONAL the default for everything (as discussed in the links Jordan posted), so if we\u0027re going to make devstack\u0027s default more stringent we might as well go all the way.","commit_id":"e56c137edb504cb86c4bb2cc5749603829438378"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"467839d3c860b3dc6aaac75cd4c3060f0da3dde9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    # set default db type to InnoDB"},{"line_number":89,"context_line":"    sudo bash -c \"source $TOP_DIR/functions \u0026\u0026 \\"},{"line_number":90,"context_line":"        iniset $MY_CONF mysqld bind-address 0.0.0.0 \u0026\u0026 \\"},{"line_number":91,"context_line":"        iniset $MY_CONF mysqld sql_mode STRICT_ALL_TABLES \u0026\u0026 \\"},{"line_number":92,"context_line":"        iniset $MY_CONF mysqld default-storage-engine InnoDB\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ae5cdf2_4d656edf","line":91,"in_reply_to":"1ae5cdf2_f40a8777","updated":"2014-06-13 12:24:03.000000000","message":"Yep. It depends on what we want with this patch. If we want to mimic PG, maybe we should try the \u0027POSTGRESQL\" mode, but that seems weird. If we just want to be strict, then let\u0027s try the TRADITIONAL mode.\n\nThere seems to be several discution on this here : https://bugs.launchpad.net/oslo/+bug/1271706 and http://lists.openstack.org/pipermail/openstack-dev/2014-January/025259.html \n\nSo in the end, I have no opinion...","commit_id":"e56c137edb504cb86c4bb2cc5749603829438378"}]}