)]}'
{"functions-common":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6ab26182ec5acb5bfec8ed5c23ce09e5a66adbed","unresolved":false,"context_lines":[{"line_number":887,"context_line":"    if is_ubuntu; then"},{"line_number":888,"context_line":"        # if there are transient errors pulling the updates try again, and"},{"line_number":889,"context_line":"        # if that fails. continue since it may be a secondary repository"},{"line_number":890,"context_line":"        # that we don\u0027t really care about."},{"line_number":891,"context_line":"        if ! ([[ \"$NO_UPDATE_REPOS\" \u003d \"True\" ]] || apt_get update ) ; then"},{"line_number":892,"context_line":"          sleep 10"},{"line_number":893,"context_line":"          [[ \"$NO_UPDATE_REPOS\" \u003d \"True\" ]] || apt_get update || /bin/true"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ae5cdf2_8f5ce04c","line":890,"updated":"2014-06-05 06:13:38.000000000","message":"I\u0027m really surprised to see this change ... doesn\u0027t it mean that if there are invalid/missing packages you\u0027ll never notice?\n\nTwo suggestions\n\n1) if you really don\u0027t care about the apt-get failures, perhaps you should wrap it in the timeout/until loop like git does?\n\n2) i feel it might be better to make this more robust.  since apt-get doesn\u0027t seem to have a lot of return codes, maybe similar to how we check for yum failures [2] and match some output on \"real\" transient failures, and catch things that really should stop the build...\n\n[1] http://git.openstack.org/cgit/openstack-dev/devstack/tree/functions-common#n595\n[2] https://review.openstack.org/#/c/77067/","commit_id":"dad23f374120d074717abb46f4db5a80278e752f"}]}