)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"783caaafccad6dccac96bf54c4d970eac578f532","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9695845a_2bcfae2b","updated":"2026-04-01 11:57:50.000000000","message":"the -1 is really for the completely unrelated chnages to functions-common with no explaition why","commit_id":"3fa9211fbb36036b504ce472357a920eeff1ef1a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6372d893cd97f1ec738d6a43e1ce1e446a46e67f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9482df51_774e5adf","in_reply_to":"9695845a_2bcfae2b","updated":"2026-04-01 16:08:24.000000000","message":"This is an unintentional leftover of my earlier attempt to use var for this openstackclient config file. I updated the change to use a variable for it too.","commit_id":"3fa9211fbb36036b504ce472357a920eeff1ef1a"},{"author":{"_account_id":32704,"name":"Alfredo Garcia","email":"alfrgarc@redhat.com","username":"alfrgarc"},"change_message_id":"77f10726c257bc140a4e75e2cd1e56b55063ce77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7f93dd43_d7871cfd","updated":"2026-04-02 15:14:52.000000000","message":"The only failing gate is due to a timeout, so it doesn\u0027t affect my review. The change is concise and makes sense. LGTM","commit_id":"b3873485b00d0f6d3f0c95dec73dd43a9f3bce03"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e8f3650f0c7a5815247bd7311206d51b941c6060","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d639c9c5_24a5f2e2","updated":"2026-04-02 14:34:26.000000000","message":"recheck","commit_id":"b3873485b00d0f6d3f0c95dec73dd43a9f3bce03"}],"clean.sh":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fdfd7e4bd479554ef75a60e35b3d0952b9757051","unresolved":true,"context_lines":[{"line_number":102,"context_line":"fi"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"# Clean out /etc"},{"line_number":105,"context_line":"sudo rm -rf $KEYSTONE_CONF_DIR $GLANCE_CONF_DIR $NOVA_CONF_DIR $PLACEMENT_CONF_DIR $CINDER_CONF_DIR $SWIFT_CONF_DIR $NEUTRON_CONF_DIR /etc/openstack/"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Clean out tgt"},{"line_number":108,"context_line":"sudo rm -f /etc/tgt/conf.d/*"}],"source_content_type":"text/x-sh","patch_set":1,"id":"d9c39fbf_f9dc9818","line":105,"range":{"start_line":105,"start_character":12,"end_line":105,"end_character":132},"updated":"2026-04-01 11:55:45.000000000","message":"if we are doing this we shoudl proably check that non of these are ever /, /etc/, ~ or .","commit_id":"3fa9211fbb36036b504ce472357a920eeff1ef1a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6372d893cd97f1ec738d6a43e1ce1e446a46e67f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"fi"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"# Clean out /etc"},{"line_number":105,"context_line":"sudo rm -rf $KEYSTONE_CONF_DIR $GLANCE_CONF_DIR $NOVA_CONF_DIR $PLACEMENT_CONF_DIR $CINDER_CONF_DIR $SWIFT_CONF_DIR $NEUTRON_CONF_DIR /etc/openstack/"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Clean out tgt"},{"line_number":108,"context_line":"sudo rm -f /etc/tgt/conf.d/*"}],"source_content_type":"text/x-sh","patch_set":1,"id":"a6210cf4_59d3dd80","line":105,"range":{"start_line":105,"start_character":12,"end_line":105,"end_character":132},"in_reply_to":"4773f772_1ee75573","updated":"2026-04-01 16:08:24.000000000","message":"Done","commit_id":"3fa9211fbb36036b504ce472357a920eeff1ef1a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"783caaafccad6dccac96bf54c4d970eac578f532","unresolved":true,"context_lines":[{"line_number":102,"context_line":"fi"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"# Clean out /etc"},{"line_number":105,"context_line":"sudo rm -rf $KEYSTONE_CONF_DIR $GLANCE_CONF_DIR $NOVA_CONF_DIR $PLACEMENT_CONF_DIR $CINDER_CONF_DIR $SWIFT_CONF_DIR $NEUTRON_CONF_DIR /etc/openstack/"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Clean out tgt"},{"line_number":108,"context_line":"sudo rm -f /etc/tgt/conf.d/*"}],"source_content_type":"text/x-sh","patch_set":1,"id":"4773f772_1ee75573","line":105,"range":{"start_line":105,"start_character":12,"end_line":105,"end_character":132},"in_reply_to":"d9c39fbf_f9dc9818","updated":"2026-04-01 11:57:50.000000000","message":"we could argue that theses are alwasy set by devstack internally so it should be safe but it feels like /etc/openstack shoudl also get defiend in stackrc or a lib file to keep it consitnet","commit_id":"3fa9211fbb36036b504ce472357a920eeff1ef1a"}],"functions-common":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fdfd7e4bd479554ef75a60e35b3d0952b9757051","unresolved":true,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    CLOUDS_YAML\u003d/etc/openstack/clouds.yaml"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    sudo mkdir -p /etc/openstack"},{"line_number":85,"context_line":"    sudo chown -R $STACK_USER /etc/openstack"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    CA_CERT_ARG\u003d\u0027\u0027"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"cf95eae6_a6b8fb8d","line":84,"range":{"start_line":84,"start_character":2,"end_line":84,"end_character":32},"updated":"2026-04-01 11:55:45.000000000","message":"i woudl prefer if you did \n```\nOPENSTACK_CONF_DIR\u003d/etc/openstack\nCLOUDS_YAML\u003d${OPENSTACK_CONF_DIR}/clouds.yaml\nsudo mkdir -p ${OPENSTACK_CONF_DIR}\nsudo chown -R ${STACK_USER} ${OPENSTACK_CONF_DIR}\n```\n\nif we are makign this change there is no reason to keep having to keep all 3 of these in sync manually.\n\nbut this also feels unrelated to the clanup change\nand its not refenced in the commit why this is needed","commit_id":"3fa9211fbb36036b504ce472357a920eeff1ef1a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6372d893cd97f1ec738d6a43e1ce1e446a46e67f","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    CLOUDS_YAML\u003d/etc/openstack/clouds.yaml"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    sudo mkdir -p /etc/openstack"},{"line_number":85,"context_line":"    sudo chown -R $STACK_USER /etc/openstack"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    CA_CERT_ARG\u003d\u0027\u0027"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"435c9639_e7609bc3","line":84,"range":{"start_line":84,"start_character":2,"end_line":84,"end_character":32},"in_reply_to":"cf95eae6_a6b8fb8d","updated":"2026-04-01 16:08:24.000000000","message":"Done","commit_id":"3fa9211fbb36036b504ce472357a920eeff1ef1a"}]}