)]}'
{"files/apts/ironic":[{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"96b98dcf1785a02fd49b9824a56fc2be71845aac","unresolved":false,"context_lines":[{"line_number":3,"context_line":"libvirt-bin"},{"line_number":4,"context_line":"openssh-client"},{"line_number":5,"context_line":"openvswitch-switch"},{"line_number":6,"context_line":"openvswitch-datapath-dkms"},{"line_number":7,"context_line":"python-libguestfs"},{"line_number":8,"context_line":"python-libvirt"},{"line_number":9,"context_line":"syslinux"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_9bd94bf7","side":"PARENT","line":6,"updated":"2014-06-06 15:19:58.000000000","message":"Doesn\u0027t that break openvswitch behaviour?","commit_id":"7b63c5ec9e9aea54024105a6521a754efc9f9983"},{"author":{"_account_id":7881,"name":"Anthony Woods","email":"awoods@internap.com","username":"awoods"},"change_message_id":"095045e96072370b691f3376a6efae307003377e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"libvirt-bin"},{"line_number":4,"context_line":"openssh-client"},{"line_number":5,"context_line":"openvswitch-switch"},{"line_number":6,"context_line":"openvswitch-datapath-dkms"},{"line_number":7,"context_line":"python-libguestfs"},{"line_number":8,"context_line":"python-libvirt"},{"line_number":9,"context_line":"syslinux"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_08094f2c","side":"PARENT","line":6,"in_reply_to":"1ae5cdf2_9bd94bf7","updated":"2014-06-09 04:04:42.000000000","message":"No.  Openvswitch is a dependency of the Neutron openvswitch-agent, it is not a dependency of Ironic.","commit_id":"7b63c5ec9e9aea54024105a6521a754efc9f9983"}],"lib/ironic":[{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"eb7e4eb3504cab56d346840fe042a56a8f0b4d6c","unresolved":false,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    # intentional sleep to make sure the tag has been set to port"},{"line_number":391,"context_line":"    sleep 10"},{"line_number":392,"context_line":"    if [ $Q_AGENT \u003d\u003d \u0027linuxbridge\u0027 ] ; then"},{"line_number":393,"context_line":"        IRONIC_NET_BRIDGE\u003dbrq${IRONIC_NET_ID:0:11}"},{"line_number":394,"context_line":"    elif [ $Q_AGENT \u003d\u003d \u0027openvswitch\u0027 ] ; then"},{"line_number":395,"context_line":"        TAPDEV\u003d$(sudo ip netns exec qdhcp-${IRONIC_NET_ID} ip link list | grep tap | cut -d\u0027:\u0027 -f2 | cut -b2-)"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1ae5cdf2_af7b8527","line":392,"updated":"2014-06-19 07:20:57.000000000","message":"This new line seems unnecessary.","commit_id":"9b6f4fa560e701acb5880aed2f9106b68d352408"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"2e7739ff5b450ed633439fac63eeaf8c2e647f91","unresolved":false,"context_lines":[{"line_number":405,"context_line":"    # create veth pair for future interconnection between br-int and brbm"},{"line_number":406,"context_line":"    sudo ip link add brbm-tap1 type veth peer name ovs-tap1"},{"line_number":407,"context_line":"    sudo ip link set dev brbm-tap1 up"},{"line_number":408,"context_line":"    sudo ip link set dev ovs-tap1 up"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    if [ $Q_AGENT \u003d\u003d \u0027linuxbridge\u0027 ] ; then"},{"line_number":411,"context_line":"        sudo brctl addif $IRONIC_VM_NETWORK_BRIDGE brbm-tap1"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1ae5cdf2_ee2ca695","line":408,"updated":"2014-06-19 07:30:40.000000000","message":"Also, if we\u0027re supporting other implementations maybe we can use a more generic name instead of ovs-tap1?","commit_id":"9b6f4fa560e701acb5880aed2f9106b68d352408"}],"tools/ironic/scripts/configure-vm":[{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"96b98dcf1785a02fd49b9824a56fc2be71845aac","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        params[\u0027console_log\u0027] \u003d CONSOLE_LOG % {\u0027console_log\u0027: args.console_log}"},{"line_number":100,"context_line":"    else:"},{"line_number":101,"context_line":"        params[\u0027console_log\u0027] \u003d \u0027\u0027"},{"line_number":102,"context_line":"    "},{"line_number":103,"context_line":"    if args.network_type \u003d\u003d \"linuxbridge\":"},{"line_number":104,"context_line":"        params[\u0027network_type\u0027] \u003d LB_NETWORK % params"},{"line_number":105,"context_line":"    else:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_2f81d14d","line":102,"updated":"2014-06-06 15:19:58.000000000","message":"Does that passes pep8?","commit_id":"2962973dbd976f3d7d00f13e65aad85d310055e9"},{"author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"change_message_id":"eb7e4eb3504cab56d346840fe042a56a8f0b4d6c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    elif args.network_type \u003d\u003d \"openvswitch\":"},{"line_number":106,"context_line":"        params[\u0027network_type\u0027] \u003d OVS_NETWORK % params"},{"line_number":107,"context_line":"    else:"},{"line_number":108,"context_line":"        sys.stderr.write(\"Network_type %s is not supported.\" % "},{"line_number":109,"context_line":"                                                params[\u0027network_type\u0027])"},{"line_number":110,"context_line":"        sys.exit(1)"},{"line_number":111,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1ae5cdf2_af946544","line":108,"updated":"2014-06-19 07:20:57.000000000","message":"whitespace","commit_id":"9b6f4fa560e701acb5880aed2f9106b68d352408"}],"tools/ironic/scripts/setup-network":[{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"96b98dcf1785a02fd49b9824a56fc2be71845aac","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# running baremetal poseur nodes for ironic testing purposes"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"set -exu"},{"line_number":9,"context_line":"Q_AGENT\u003d$1"},{"line_number":10,"context_line":"LIBVIRT_CONNECT_URI\u003d${LIBVIRT_CONNECT_URI:-\"qemu:///system\"}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Keep track of the devstack directory"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_2f871114","line":9,"updated":"2014-06-06 15:19:58.000000000","message":"I would prefer if this defaulted to \"openvswitch\"","commit_id":"2962973dbd976f3d7d00f13e65aad85d310055e9"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"96b98dcf1785a02fd49b9824a56fc2be71845aac","unresolved":false,"context_lines":[{"line_number":20,"context_line":"if [ $Q_AGENT \u003d\u003d \u0027linuxbridge\u0027 ] ; then"},{"line_number":21,"context_line":"    (sudo brctl show|awk \u0027{print $1}\u0027 | grep ${BRIDGE_NAME}$) || sudo brctl addbr ${BRIDGE_NAME}"},{"line_number":22,"context_line":"    sudo ip link set ${BRIDGE_NAME} up"},{"line_number":23,"context_line":"else "},{"line_number":24,"context_line":"    (sudo ovs-vsctl list-br | grep ${BRIDGE_NAME}$) || sudo ovs-vsctl add-br ${BRIDGE_NAME}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    # remove bridge before replacing it."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_e11e22bb","line":23,"updated":"2014-06-06 15:19:58.000000000","message":"And here we used elif openvswitch","commit_id":"2962973dbd976f3d7d00f13e65aad85d310055e9"}]}