)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"82201d7955cc49fdb1311c6fad42b36e88c4ee13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ab057fd_6c2af8da","updated":"2026-04-24 08:20:02.000000000","message":"why zuul is not getting added by default anymore","commit_id":"e0b824eb80e3ac72089dcacb178ba2f6d80f8866"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b6092515efa5f26e88c6703393bfeb2a0de9a997","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34bbffe9_2fac8a56","updated":"2026-05-07 12:11:43.000000000","message":"I small request inline and it would be nice to see some review from cinder folks. Then I can upgrade to +2","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a8ae4df492f02c15a5bc7f8aba81c31489c53b67","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"99f40dbc_1b57393b","updated":"2026-05-07 13:25:10.000000000","message":"I\u0027m not sure about this approach because from the Cinder point of view, we don\u0027t really want to support thick-provisioned LVM at all. Should we just refuse to deploy in this situation?","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"}],"lib/cinder":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b6092515efa5f26e88c6703393bfeb2a0de9a997","unresolved":true,"context_lines":[{"line_number":83,"context_line":"CINDER_SERVICE_REPORT_INTERVAL\u003d${CINDER_SERVICE_REPORT_INTERVAL:-120}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# What type of LVM device should Cinder use for LVM backend"},{"line_number":86,"context_line":"# Defaults to auto, which will do thin provisioning if it\u0027s a fresh"},{"line_number":87,"context_line":"# volume group, otherwise it will do thick. The other valid choices are"},{"line_number":88,"context_line":"# default, which is thick, or thin, which as the name implies utilizes lvm"},{"line_number":89,"context_line":"# thin provisioning."},{"line_number":90,"context_line":"CINDER_LVM_TYPE\u003d${CINDER_LVM_TYPE:-auto}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"f23faa26_41330ee1","line":87,"range":{"start_line":86,"start_character":13,"end_line":87,"end_character":16},"updated":"2026-05-07 12:11:43.000000000","message":"I think we could mention the new logic here too","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"edf8fbd34d91d7e30a6e3b897808526efaf7f1ac","unresolved":true,"context_lines":[{"line_number":83,"context_line":"CINDER_SERVICE_REPORT_INTERVAL\u003d${CINDER_SERVICE_REPORT_INTERVAL:-120}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# What type of LVM device should Cinder use for LVM backend"},{"line_number":86,"context_line":"# Defaults to auto, which will do thin provisioning if it\u0027s a fresh"},{"line_number":87,"context_line":"# volume group, otherwise it will do thick. The other valid choices are"},{"line_number":88,"context_line":"# default, which is thick, or thin, which as the name implies utilizes lvm"},{"line_number":89,"context_line":"# thin provisioning."},{"line_number":90,"context_line":"CINDER_LVM_TYPE\u003d${CINDER_LVM_TYPE:-auto}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"4045c16e_cf1cc400","line":87,"range":{"start_line":86,"start_character":13,"end_line":87,"end_character":16},"in_reply_to":"f23faa26_41330ee1","updated":"2026-05-07 12:51:37.000000000","message":"yeah like if auto and thin is not support set the supported one ?","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a8ae4df492f02c15a5bc7f8aba81c31489c53b67","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    # Thin provisioning requires the dm-thin-pool kernel module"},{"line_number":94,"context_line":"    # lvcreate -T command run by cinder require dm-thin-pool kernel module."},{"line_number":95,"context_line":"    # Check kernel support it, before defaulting to \u0027auto\u0027."},{"line_number":96,"context_line":"    if ! sudo modprobe dm-thin-pool 2\u003e/dev/null; then"},{"line_number":97,"context_line":"        echo_summary \"WARNING: Underlining kernel does not support dm-thin-pool, using thick LVM provisioning\""},{"line_number":98,"context_line":"        CINDER_LVM_TYPE\u003d\"default\""},{"line_number":99,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"982a4049_6836a398","line":96,"updated":"2026-05-07 13:25:10.000000000","message":"This won\u0027t work if there\u0027s some other kernel that has the support built in instead of a module.","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a8ae4df492f02c15a5bc7f8aba81c31489c53b67","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    # lvcreate -T command run by cinder require dm-thin-pool kernel module."},{"line_number":95,"context_line":"    # Check kernel support it, before defaulting to \u0027auto\u0027."},{"line_number":96,"context_line":"    if ! sudo modprobe dm-thin-pool 2\u003e/dev/null; then"},{"line_number":97,"context_line":"        echo_summary \"WARNING: Underlining kernel does not support dm-thin-pool, using thick LVM provisioning\""},{"line_number":98,"context_line":"        CINDER_LVM_TYPE\u003d\"default\""},{"line_number":99,"context_line":"    fi"},{"line_number":100,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"e121a104_84a23cda","line":97,"range":{"start_line":97,"start_character":31,"end_line":97,"end_character":42},"updated":"2026-05-07 13:25:10.000000000","message":"s/Underlining/Underlying/\n\nAlso might be good to point out that this will perform significantly worse than thin LVM.","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"}]}