)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"82201d7955cc49fdb1311c6fad42b36e88c4ee13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ab057fd_6c2af8da","updated":"2026-04-24 08:20:02.000000000","message":"why zuul is not getting added by default anymore","commit_id":"e0b824eb80e3ac72089dcacb178ba2f6d80f8866"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b6092515efa5f26e88c6703393bfeb2a0de9a997","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34bbffe9_2fac8a56","updated":"2026-05-07 12:11:43.000000000","message":"I small request inline and it would be nice to see some review from cinder folks. Then I can upgrade to +2","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a8ae4df492f02c15a5bc7f8aba81c31489c53b67","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"99f40dbc_1b57393b","updated":"2026-05-07 13:25:10.000000000","message":"I\u0027m not sure about this approach because from the Cinder point of view, we don\u0027t really want to support thick-provisioned LVM at all. Should we just refuse to deploy in this situation?","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"dc9f2bd4559fe62f7737c9a1e2019f46170e9eae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3df57777_a1bb92a8","updated":"2026-05-11 13:14:03.000000000","message":"recheck\n\nunrelated - nova-ceph-multistore `compute.test_resize_volume_backed_server_confirm` test failed due to kernel panic\n\n\n```\n[    4.167812] virtio_gpu virtio0: [drm] drm_plane_enable_fb_damage_clips() not called\n[    4.210886] random: crng init done\ncurrently loaded modules: 8021q 8139cp 8390 9pnet 9pnet_virtio ahci cec dca drm drm_kms_helper e1000 e1000e failover fb_sys_fops garp hid hid_generic i2c_algo_bit igb igbvf ip6_udp_tunnel ip_tables isofs libahci libcrc32c llc mii mrp ne2k_pci net_failover nls_ascii nls_iso8859_1 nls_utf8 pcnet32 qemu_fw_cfg rc_core sctp stp syscopyarea sysfillrect sysimgblt udp_tunnel usbhid virtio_blk virtio_dma_buf virtio_gpu virtio_input virtio_net virtio_rng virtio_scsi virtiofs x_tables \ninfo: initramfs loading root from /dev/vda1\n/sbin/init: can\u0027t load library \u0027libtirpc.so.3\u0027\n[    5.193948] Kernel panic - not syncing: Attempted to kill init! exitcode\u003d0x00001000\n[    5.194539] CPU: 0 PID: 1 Comm: init Not tainted 5.15.0-117-generic #127-Ubuntu\n[    5.194859] Hardware name: OpenStack Foundation OpenStack Nova, BIOS 1.16.3-debian-1.16.3-2 04/01/2014\n[    5.195406] Call Trace:\n[    5.195945]  \u003cTASK\u003e\n[    5.196156]  show_stack+0x52/0x5c\n[    5.196586]  dump_stack_lvl+0x4a/0x63\n[    5.196740]  dump_stack+0x10/0x16\n[    5.196877]  panic+0x15c/0x33b\n[    5.197001]  do_exit.cold+0x15/0xa0\n```","commit_id":"8b0e1dd48c5445db69e06654c398f46b6d520f4d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"172e3f4621cf4ccedecc839e9429d80884ca32cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3890fe8d_6417d6cc","updated":"2026-05-11 14:15:34.000000000","message":"this is not a devstack bug its a cinder bug","commit_id":"8b0e1dd48c5445db69e06654c398f46b6d520f4d"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"49e96e05e84949705870a4f9e3a4b55902708c4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"31d0c4fe_b269ce76","updated":"2026-05-21 07:04:02.000000000","message":"we should not slow CI, by make it fallback to thick \n\nthough would have help us to find out if image needs upgrade.\nthis is indeed not a devstack bug and closing this","commit_id":"8b0e1dd48c5445db69e06654c398f46b6d520f4d"}],"lib/cinder":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b6092515efa5f26e88c6703393bfeb2a0de9a997","unresolved":true,"context_lines":[{"line_number":83,"context_line":"CINDER_SERVICE_REPORT_INTERVAL\u003d${CINDER_SERVICE_REPORT_INTERVAL:-120}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# What type of LVM device should Cinder use for LVM backend"},{"line_number":86,"context_line":"# Defaults to auto, which will do thin provisioning if it\u0027s a fresh"},{"line_number":87,"context_line":"# volume group, otherwise it will do thick. The other valid choices are"},{"line_number":88,"context_line":"# default, which is thick, or thin, which as the name implies utilizes lvm"},{"line_number":89,"context_line":"# thin provisioning."},{"line_number":90,"context_line":"CINDER_LVM_TYPE\u003d${CINDER_LVM_TYPE:-auto}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"f23faa26_41330ee1","line":87,"range":{"start_line":86,"start_character":13,"end_line":87,"end_character":16},"updated":"2026-05-07 12:11:43.000000000","message":"I think we could mention the new logic here too","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"d1490938d0d6d452c30a5acd3079e1f48ab1c0d5","unresolved":true,"context_lines":[{"line_number":83,"context_line":"CINDER_SERVICE_REPORT_INTERVAL\u003d${CINDER_SERVICE_REPORT_INTERVAL:-120}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# What type of LVM device should Cinder use for LVM backend"},{"line_number":86,"context_line":"# Defaults to auto, which will do thin provisioning if it\u0027s a fresh"},{"line_number":87,"context_line":"# volume group, otherwise it will do thick. The other valid choices are"},{"line_number":88,"context_line":"# default, which is thick, or thin, which as the name implies utilizes lvm"},{"line_number":89,"context_line":"# thin provisioning."},{"line_number":90,"context_line":"CINDER_LVM_TYPE\u003d${CINDER_LVM_TYPE:-auto}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"d479a6cf_a2ed8a17","line":87,"range":{"start_line":86,"start_character":13,"end_line":87,"end_character":16},"in_reply_to":"4045c16e_cf1cc400","updated":"2026-05-11 10:57:19.000000000","message":"missread, added comment now, done.","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"edf8fbd34d91d7e30a6e3b897808526efaf7f1ac","unresolved":true,"context_lines":[{"line_number":83,"context_line":"CINDER_SERVICE_REPORT_INTERVAL\u003d${CINDER_SERVICE_REPORT_INTERVAL:-120}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# What type of LVM device should Cinder use for LVM backend"},{"line_number":86,"context_line":"# Defaults to auto, which will do thin provisioning if it\u0027s a fresh"},{"line_number":87,"context_line":"# volume group, otherwise it will do thick. The other valid choices are"},{"line_number":88,"context_line":"# default, which is thick, or thin, which as the name implies utilizes lvm"},{"line_number":89,"context_line":"# thin provisioning."},{"line_number":90,"context_line":"CINDER_LVM_TYPE\u003d${CINDER_LVM_TYPE:-auto}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"4045c16e_cf1cc400","line":87,"range":{"start_line":86,"start_character":13,"end_line":87,"end_character":16},"in_reply_to":"f23faa26_41330ee1","updated":"2026-05-07 12:51:37.000000000","message":"yeah like if auto and thin is not support set the supported one ?","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a8ae4df492f02c15a5bc7f8aba81c31489c53b67","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    # Thin provisioning requires the dm-thin-pool kernel module"},{"line_number":94,"context_line":"    # lvcreate -T command run by cinder require dm-thin-pool kernel module."},{"line_number":95,"context_line":"    # Check kernel support it, before defaulting to \u0027auto\u0027."},{"line_number":96,"context_line":"    if ! sudo modprobe dm-thin-pool 2\u003e/dev/null; then"},{"line_number":97,"context_line":"        echo_summary \"WARNING: Underlining kernel does not support dm-thin-pool, using thick LVM provisioning\""},{"line_number":98,"context_line":"        CINDER_LVM_TYPE\u003d\"default\""},{"line_number":99,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"982a4049_6836a398","line":96,"updated":"2026-05-07 13:25:10.000000000","message":"This won\u0027t work if there\u0027s some other kernel that has the support built in instead of a module.","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"d1490938d0d6d452c30a5acd3079e1f48ab1c0d5","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    # Thin provisioning requires the dm-thin-pool kernel module"},{"line_number":94,"context_line":"    # lvcreate -T command run by cinder require dm-thin-pool kernel module."},{"line_number":95,"context_line":"    # Check kernel support it, before defaulting to \u0027auto\u0027."},{"line_number":96,"context_line":"    if ! sudo modprobe dm-thin-pool 2\u003e/dev/null; then"},{"line_number":97,"context_line":"        echo_summary \"WARNING: Underlining kernel does not support dm-thin-pool, using thick LVM provisioning\""},{"line_number":98,"context_line":"        CINDER_LVM_TYPE\u003d\"default\""},{"line_number":99,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bae115f4_82f51057","line":96,"in_reply_to":"982a4049_6836a398","updated":"2026-05-11 10:57:19.000000000","message":"ack,\nnow usnig `dmsetup targets` detects both built-in and modules","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a8ae4df492f02c15a5bc7f8aba81c31489c53b67","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    # lvcreate -T command run by cinder require dm-thin-pool kernel module."},{"line_number":95,"context_line":"    # Check kernel support it, before defaulting to \u0027auto\u0027."},{"line_number":96,"context_line":"    if ! sudo modprobe dm-thin-pool 2\u003e/dev/null; then"},{"line_number":97,"context_line":"        echo_summary \"WARNING: Underlining kernel does not support dm-thin-pool, using thick LVM provisioning\""},{"line_number":98,"context_line":"        CINDER_LVM_TYPE\u003d\"default\""},{"line_number":99,"context_line":"    fi"},{"line_number":100,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"e121a104_84a23cda","line":97,"range":{"start_line":97,"start_character":31,"end_line":97,"end_character":42},"updated":"2026-05-07 13:25:10.000000000","message":"s/Underlining/Underlying/\n\nAlso might be good to point out that this will perform significantly worse than thin LVM.","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"d1490938d0d6d452c30a5acd3079e1f48ab1c0d5","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    # lvcreate -T command run by cinder require dm-thin-pool kernel module."},{"line_number":95,"context_line":"    # Check kernel support it, before defaulting to \u0027auto\u0027."},{"line_number":96,"context_line":"    if ! sudo modprobe dm-thin-pool 2\u003e/dev/null; then"},{"line_number":97,"context_line":"        echo_summary \"WARNING: Underlining kernel does not support dm-thin-pool, using thick LVM provisioning\""},{"line_number":98,"context_line":"        CINDER_LVM_TYPE\u003d\"default\""},{"line_number":99,"context_line":"    fi"},{"line_number":100,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"46721a48_a5597fac","line":97,"range":{"start_line":97,"start_character":31,"end_line":97,"end_character":42},"in_reply_to":"e121a104_84a23cda","updated":"2026-05-11 10:57:19.000000000","message":"Done","commit_id":"23d16145ecb70e30311607a829242c5bc3f7205e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"172e3f4621cf4ccedecc839e9429d80884ca32cb","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        echo_summary \"WARNING: No dm-thin-pool kernel support, falling back to thick provisioning (slower)\""},{"line_number":98,"context_line":"        CINDER_LVM_TYPE\u003d\"default\""},{"line_number":99,"context_line":"    fi"},{"line_number":100,"context_line":"fi"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# ``CINDER_USE_SERVICE_TOKEN`` is a mode where service token is passed along with"},{"line_number":103,"context_line":"# user token while communicating to external REST APIs like Glance."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"4f154283_0269a1c9","line":100,"updated":"2026-05-11 14:15:34.000000000","message":"honestly this feels like a cidner bug/feature\n\nwe can work around it but cinder shoudl be doing this detection itself and falling back to thin provisoingin tiself.\n\nwe write this valdue directly to the config\n\nhttps://github.com/openstack/devstack/blob/c2e2cf18e62c46438137b3b31d46177b8c23b28f/lib/cinder_backends/lvm#L57\n\ntis ment to actully handel this internally\n\nhttps://github.com/openstack/cinder/blob/11c1a009150b803b115fb13fd9ab2a684bd9ea15/cinder/volume/drivers/lvm.py#L349-L365\n\nhttps://github.com/openstack/cinder/blob/master/cinder/brick/local_dev/lvm.py#L243-L251\n\nbut its only checkign teh lvm version isntead of actully checkign if the host supprot it which is defnilay incorrect.,","commit_id":"8b0e1dd48c5445db69e06654c398f46b6d520f4d"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"6c8b1090c550093a1719787846d425a392bc4848","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        echo_summary \"WARNING: No dm-thin-pool kernel support, falling back to thick provisioning (slower)\""},{"line_number":98,"context_line":"        CINDER_LVM_TYPE\u003d\"default\""},{"line_number":99,"context_line":"    fi"},{"line_number":100,"context_line":"fi"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# ``CINDER_USE_SERVICE_TOKEN`` is a mode where service token is passed along with"},{"line_number":103,"context_line":"# user token while communicating to external REST APIs like Glance."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"f9ea7ba8_fe5ad6e2","line":100,"in_reply_to":"4f154283_0269a1c9","updated":"2026-05-11 16:06:24.000000000","message":"\u003e but its only checkign teh lvm version isntead of actully checkign if the host supprot it which is defnilay incorrect.,\n\nyes, I am planning to fix this in cinder itself have few ideas, but for that will need more discussion.\nright now I have a bug https://bugs.launchpad.net/cinder/+bug/2150211 to track this in cinder.\n\n\nbut I think its would be best if we fix devstack too, because devstack deploy first cinder service but service are not up as they should be, how cinder take care of it comes later.\n\nso right now issue is cinder is failing at initializing service, but it would nice to fix devstack for operators/devs who do not want to fix cinder and just the deployment quickly.","commit_id":"8b0e1dd48c5445db69e06654c398f46b6d520f4d"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"efc201c0156981b3563342c41fc4e9d4ea216eae","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        echo_summary \"WARNING: No dm-thin-pool kernel support, falling back to thick provisioning (slower)\""},{"line_number":98,"context_line":"        CINDER_LVM_TYPE\u003d\"default\""},{"line_number":99,"context_line":"    fi"},{"line_number":100,"context_line":"fi"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# ``CINDER_USE_SERVICE_TOKEN`` is a mode where service token is passed along with"},{"line_number":103,"context_line":"# user token while communicating to external REST APIs like Glance."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"e42edf42_d73cd51e","line":100,"in_reply_to":"caa8caf0_b9cd6a8f","updated":"2026-05-12 08:12:02.000000000","message":"ok yeah from CI perspective not changing this in devstack makes sense. but 🤔!!","commit_id":"8b0e1dd48c5445db69e06654c398f46b6d520f4d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d73473e4b9e8ade7b1546f35d71e40b8a3a10732","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        echo_summary \"WARNING: No dm-thin-pool kernel support, falling back to thick provisioning (slower)\""},{"line_number":98,"context_line":"        CINDER_LVM_TYPE\u003d\"default\""},{"line_number":99,"context_line":"    fi"},{"line_number":100,"context_line":"fi"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# ``CINDER_USE_SERVICE_TOKEN`` is a mode where service token is passed along with"},{"line_number":103,"context_line":"# user token while communicating to external REST APIs like Glance."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"caa8caf0_b9cd6a8f","line":100,"in_reply_to":"f9ea7ba8_fe5ad6e2","updated":"2026-05-11 16:31:37.000000000","message":"its not a devstack bug\ndevstack should not need to replceacte the detection logic and implement auto itself when the service is ment to supprot that\n\n\nyou can overed this in you jobs explcity but i don think we shoudl modify devstack for this espically sicne it will make testing the behvior in cinder harder.","commit_id":"8b0e1dd48c5445db69e06654c398f46b6d520f4d"}]}