)]}'
{"lib/keystone":[{"author":{"_account_id":12754,"name":"Patrizio Tufarolo","email":"patriziotufarolo@gmail.com","username":"patriziotufarolo"},"change_message_id":"ae657cb82db201a0a2a6bf937eb1c2e1d998b7ee","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        s|%SSLKEYFILE%|$keystone_keyfile|g;"},{"line_number":156,"context_line":"        s|%USER%|$STACK_USER|g"},{"line_number":157,"context_line":"    \" -i $keystone_apache_conf"},{"line_number":158,"context_line":"    enable_apache_site keystone"},{"line_number":159,"context_line":"}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# configure_keystone() - Set config files, create data dirs, etc"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_29f9f6c4","line":158,"updated":"2014-08-04 19:16:03.000000000","message":"Take a look at this: I think we should make sure that mod_ssl is already installed and enabled before writing the \"SSLEngine On\" directive in Apache configuration. Otherwise Apache crashes and the deploy fails.\nTo accomplish this, for example, in Ubuntu and other Debian based distros you can use \"a2enmod\".\nIn Fedora, CentOS and other Red Hat family distros you have to edit httpd.conf un-commenting the appropriate LoadModule line.","commit_id":"dbe060f1185063b94d1aa875aad14dde08e2cea7"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"579559341954be2f022536ebf30908a1cb2242e3","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        s|%SSLKEYFILE%|$keystone_keyfile|g;"},{"line_number":156,"context_line":"        s|%USER%|$STACK_USER|g"},{"line_number":157,"context_line":"    \" -i $keystone_apache_conf"},{"line_number":158,"context_line":"    enable_apache_site keystone"},{"line_number":159,"context_line":"}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# configure_keystone() - Set config files, create data dirs, etc"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_3f266823","line":158,"in_reply_to":"baada198_13ba90b9","updated":"2014-08-05 13:06:48.000000000","message":"It is possible to install conditional dependencies in devstack.  Keystone currently does this for openldap-servers.  Take a look at how install_ldap() is used in lib/keystone.","commit_id":"dbe060f1185063b94d1aa875aad14dde08e2cea7"},{"author":{"_account_id":12754,"name":"Patrizio Tufarolo","email":"patriziotufarolo@gmail.com","username":"patriziotufarolo"},"change_message_id":"4a9abdfc5cff834b2dc64e8d7a12616cb707499d","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        s|%SSLKEYFILE%|$keystone_keyfile|g;"},{"line_number":156,"context_line":"        s|%USER%|$STACK_USER|g"},{"line_number":157,"context_line":"    \" -i $keystone_apache_conf"},{"line_number":158,"context_line":"    enable_apache_site keystone"},{"line_number":159,"context_line":"}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# configure_keystone() - Set config files, create data dirs, etc"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_8252bb10","line":158,"in_reply_to":"baada198_13ba90b9","updated":"2014-08-05 13:20:42.000000000","message":"You are right, most people use tls proxy for development scopes.\n\nBy the way I tried to deploy devstack with this patchset just five minutes ago on a fresh Ubuntu, and it fails because of mod_ssl disabled.\nSo I\u0027ve launched \"clean.sh\", \"sudo a2enmod ssl\", \"stack.sh\" and now it is fine.\nIn Ubuntu mod_ssl is disabled by default even if it is installed.\nTo solve this problem we can add \"sudo a2enmod ssl\" somewhere verifying \"is_ubuntu\" USE_SSL to be \"True\".","commit_id":"dbe060f1185063b94d1aa875aad14dde08e2cea7"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"fe3c8e363a76bbf5b5ef8902dcdc379c9007b742","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        s|%SSLKEYFILE%|$keystone_keyfile|g;"},{"line_number":156,"context_line":"        s|%USER%|$STACK_USER|g"},{"line_number":157,"context_line":"    \" -i $keystone_apache_conf"},{"line_number":158,"context_line":"    enable_apache_site keystone"},{"line_number":159,"context_line":"}"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# configure_keystone() - Set config files, create data dirs, etc"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baada198_13ba90b9","line":158,"in_reply_to":"baada198_29f9f6c4","updated":"2014-08-05 03:28:04.000000000","message":"I considered that and at one point used conditionals in Apache to not enable SSL if mod_ssl is not loaded but that too would lead to fail (Keystone wouldn\u0027t be started in SSL mode in that case) so I skipped it.\n\nThe issue is that pure SSL is probably an edge case as most users are probably going to use an SSL terminator (aka TLS Proxy).\n\nAt least in Fedora/CentOS/RHEL if the mod_ssl package is installed, it is enabled by default, so requiring the package is probably good enough for a dev system. I don\u0027t know what the Ubuntu default is.\n\nIs there a way to have devstack-specific requirements? Otherwise we\u0027d have add mod_ssl to the requirements of something, perhaps keystone or horizon, so that we can assume it is already there for devstack, but then that requirement won\u0027t be used in a high percentage of production installations and I\u0027d imagine that those component owners would protest.","commit_id":"dbe060f1185063b94d1aa875aad14dde08e2cea7"}],"lib/nova":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"72e4fd9bac4a0bdef53ab3ddb695332a066754ea","unresolved":false,"context_lines":[{"line_number":724,"context_line":"function start_nova_api {"},{"line_number":725,"context_line":"    # Get right service port for testing"},{"line_number":726,"context_line":"    local service_port\u003d$NOVA_SERVICE_PORT"},{"line_number":727,"context_line":"    local service_protocol\u003d${NOVA_SERVICE_PROTOCOL:-http}"},{"line_number":728,"context_line":"    if is_service_enabled tls-proxy; then"},{"line_number":729,"context_line":"        service_port\u003d$NOVA_SERVICE_PORT_INT"},{"line_number":730,"context_line":"        service_protocol\u003d\"http\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1ae5cdf2_4dcc3c62","line":727,"updated":"2014-06-16 22:23:51.000000000","message":"we shouldn\u0027t do defaults this buried.","commit_id":"8f61acc364beb23ac8423b79bc80026b9217bcbd"},{"author":{"_account_id":12754,"name":"Patrizio Tufarolo","email":"patriziotufarolo@gmail.com","username":"patriziotufarolo"},"change_message_id":"a10b74b350de31f0a1011fd7a5b81562fddc5477","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1abeadc6_8e31c60d","updated":"2014-08-26 17:38:42.000000000","message":"I\u0027m not able to deploy VMs because Nova fails to communicate with Glance reporting that the certificate is not verified.\nUsing the glance CLI I can do everything, so I think the problem is something related to lib/nova.","commit_id":"d894d8d3eabd16a106f6657e2bcaa92ba1239f26"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"7dace3887f829d06ec3ab31b1a0492a393bc5943","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1abeadc6_c16c6ca0","in_reply_to":"1abeadc6_167ce8b4","updated":"2014-08-26 20:06:36.000000000","message":"Rather than passing around CA certs everywhere I\u0027m relying on the global CA cert store so this shouldn\u0027t be an issue. The glance client recently made some changes regarding SSL validation so it may be related to that. I\u0027m seeing cinder failures as well, which I\u0027m investigating now.","commit_id":"d894d8d3eabd16a106f6657e2bcaa92ba1239f26"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bd92d30f074353f55b068825992bc4d4ffd54d94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1abeadc6_167ce8b4","in_reply_to":"1abeadc6_8e31c60d","updated":"2014-08-26 19:53:58.000000000","message":"Patrizio - I think this might be a known problem. See this bug: https://bugs.launchpad.net/nova/+bug/1299841","commit_id":"d894d8d3eabd16a106f6657e2bcaa92ba1239f26"}],"lib/tls":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"35b376909f6824f65404cd1ea439d67838b0a6c8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    TLS_IP\u003d${TLS_IP:-$SERVICE_IP}"},{"line_number":38,"context_line":"fi"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"DEVSTACK_HOSTNAME\u003d$(hostname -f)"},{"line_number":41,"context_line":"DEVSTACK_CERT_NAME\u003ddevstack-cert"},{"line_number":42,"context_line":"DEVSTACK_CERT\u003d$DATA_DIR/$DEVSTACK_CERT_NAME.pem"},{"line_number":43,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_9d79fcfd","line":40,"updated":"2014-07-30 16:47:08.000000000","message":"Many VMs don\u0027t have a FQDN here, I\u0027d prefer to have a fallback, especially where $(hostname -f) \u003d\u003d \u0027localhost\u0027.","commit_id":"d7319ca9e07d9fc91a070f29e7a6743dfd6c00bb"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"01e1180ad2010fe1f8612d573965066de2a31823","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    TLS_IP\u003d${TLS_IP:-$SERVICE_IP}"},{"line_number":38,"context_line":"fi"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"DEVSTACK_HOSTNAME\u003d$(hostname -f)"},{"line_number":41,"context_line":"DEVSTACK_CERT_NAME\u003ddevstack-cert"},{"line_number":42,"context_line":"DEVSTACK_CERT\u003d$DATA_DIR/$DEVSTACK_CERT_NAME.pem"},{"line_number":43,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_b1d34736","line":40,"in_reply_to":"baada198_9d79fcfd","updated":"2014-07-30 18:44:29.000000000","message":"Fallback to what though? Things I choose might work as long as all the work is done locally but once we get into other systems contacting the install things get sticky real fast.","commit_id":"d7319ca9e07d9fc91a070f29e7a6743dfd6c00bb"},{"author":{"_account_id":12754,"name":"Patrizio Tufarolo","email":"patriziotufarolo@gmail.com","username":"patriziotufarolo"},"change_message_id":"b197e385dfd1972b58c61601667c102f663113ea","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    if is_fedora; then"},{"line_number":210,"context_line":"        sudo cp $INT_CA_DIR/ca-chain.pem /usr/share/pki/ca-trust-source/anchors/devstack-chain.pem"},{"line_number":211,"context_line":"        sudo update-ca-trust"},{"line_number":212,"context_line":"    elif is_ubuntu; then"},{"line_number":213,"context_line":"        sudo cp $INT_CA_DIR/ca-chain.pem /etc/ssl/certs/devstack-int.pem"},{"line_number":214,"context_line":"        sudo cp $ROOT_CA_DIR/cacert.pem /etc/ssl/certs/devstack-root.pem"},{"line_number":215,"context_line":"        sudo ln -s /etc/ssl/certs/devstack-int.pem /etc/ssl/certs/`openssl x509 -hash -noout -in devstack-int.pem`.0"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_96f88b7f","line":212,"updated":"2014-08-02 19:33:02.000000000","message":"#we should replace the entire elif block with:\nelif is_ubuntu; then\n        sudo cp $INT_CA_DIR/ca-chain.pem /usr/local/share/ca-certificates/devstack-int.crt\n        sudo cp $ROOT_CA_DIR/cacert.pem /usr/local/share/ca-certificates/devstack-root.crt\n        sudo update-ca-certificates\n    fi\n\n#I couldn\u0027t get it working the previous way because python didn\u0027t want to recognize the generated ca as trusted, so the deploy fails.","commit_id":"d7319ca9e07d9fc91a070f29e7a6743dfd6c00bb"},{"author":{"_account_id":12754,"name":"Patrizio Tufarolo","email":"patriziotufarolo@gmail.com","username":"patriziotufarolo"},"change_message_id":"b197e385dfd1972b58c61601667c102f663113ea","unresolved":false,"context_lines":[{"line_number":222,"context_line":"function cleanup_CA {"},{"line_number":223,"context_line":"    if is_fedora; then"},{"line_number":224,"context_line":"        sudo rm -f /usr/share/pki/ca-trust-source/anchors/devstack-chain.pem"},{"line_number":225,"context_line":"    elif is_ubuntu; then"},{"line_number":226,"context_line":"        sudo rm -f /etc/ssl/certs/`openssl x509 -hash -noout -in devstack-int.pem`.0"},{"line_number":227,"context_line":"        sudo rm -f /etc/ssl/certs/devstack-int.pem"},{"line_number":228,"context_line":"        sudo rm -f /etc/ssl/certs/`openssl x509 -hash -noout -in devstack-root.pem`.0"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_762e97fb","line":225,"updated":"2014-08-02 19:33:02.000000000","message":"#For the same reason as above we should replace the entire elif block with:\nelif is_ubuntu; then\n        sudo rm /usr/local/share/ca-certificates/devstack-int.crt\n        sudo rm /usr/local/share/ca-certificates/devstack-root.crt\n        sudo update-ca-certificates\nfi\n#In this way we can remove easily the CA from the trust store, using the tool provided by the os itself.","commit_id":"d7319ca9e07d9fc91a070f29e7a6743dfd6c00bb"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"35b376909f6824f65404cd1ea439d67838b0a6c8","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        local ca\u003d\"$INT_CA_DIR/ca-chain.pem\""},{"line_number":386,"context_line":"        eval ${service}_SSL_CERT\u003d\\$cert"},{"line_number":387,"context_line":"        eval ${service}_SSL_KEY\u003d\\$key"},{"line_number":388,"context_line":"        eval ${service}_SSL_CA\u003d\\$ca"},{"line_number":389,"context_line":"        return # the CA certificate is already in the bundle"},{"line_number":390,"context_line":"    elif [[ -z \"$cert\" || -z \"$key\" || -z \"$ca\" ]]; then"},{"line_number":391,"context_line":"        die $LINENO \"Missing either the ${cert_var} ${key_var} or ${ca_var}\" \\"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_60bc7fb6","line":388,"updated":"2014-07-30 16:47:08.000000000","message":"I\u0027d like to see this done without the eval...declare works too:\n\n declare ${cert_var}\u003d$cert","commit_id":"d7319ca9e07d9fc91a070f29e7a6743dfd6c00bb"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"01e1180ad2010fe1f8612d573965066de2a31823","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        local ca\u003d\"$INT_CA_DIR/ca-chain.pem\""},{"line_number":386,"context_line":"        eval ${service}_SSL_CERT\u003d\\$cert"},{"line_number":387,"context_line":"        eval ${service}_SSL_KEY\u003d\\$key"},{"line_number":388,"context_line":"        eval ${service}_SSL_CA\u003d\\$ca"},{"line_number":389,"context_line":"        return # the CA certificate is already in the bundle"},{"line_number":390,"context_line":"    elif [[ -z \"$cert\" || -z \"$key\" || -z \"$ca\" ]]; then"},{"line_number":391,"context_line":"        die $LINENO \"Missing either the ${cert_var} ${key_var} or ${ca_var}\" \\"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_9212c25f","line":388,"in_reply_to":"baada198_60bc7fb6","updated":"2014-07-30 18:44:29.000000000","message":"I think it\u0027s a scope thing but this doesn\u0027t set it such that the variable is available outside ensure_certificates.","commit_id":"d7319ca9e07d9fc91a070f29e7a6743dfd6c00bb"},{"author":{"_account_id":12754,"name":"Patrizio Tufarolo","email":"patriziotufarolo@gmail.com","username":"patriziotufarolo"},"change_message_id":"7b1722b2557077713cbc1342df3bbaaa2d2839b9","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        :"},{"line_number":407,"context_line":"    fi"},{"line_number":408,"context_line":"}"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"# Proxy Functions"},{"line_number":412,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1abeadc6_397fb9ac","line":409,"updated":"2014-08-21 14:45:35.000000000","message":"I think we could make this more clever by preventing the deploy failure on dirty setups (e.g. httpd/apache serves already other contents, without ssl), by checking if mod_ssl is actually enabled, without assuming default configuration.\nTo obtain this we could write enable_mod_ssl in this way:\n\nfunction enable_mod_ssl {\n    echo \"Enabling mod_ssl\"\n    if `which httpd || which apache2` -M | grep -w -q ssl_module; then\n        echo \"mod_ssl already enabled, nothing to do\"\n    else\n        if is_fedora; then\n            echo \"LoadModule ssl_module modules/mod_ssl.so\" | sudo tee /etc/httpd/conf.modules.d/00-ssl.conf\n        elif is_ubuntu; then\n            sudo a2enmod ssl\n        fi\n        echo \"mod_ssl successfully enabled\"\n    fi\n}\n\nBecause a2enmod checks on its own the module to be already enabled, we could\nwrite the same function also in this way:\n\nfunction enable_mod_ssl {\n    echo \"Enabling mod_ssl\"\n    if is_ubuntu; then\n        sudo a2enmod ssl\n    elif is_fedora; then\n        if `which httpd` -M | grep -w -q ssl_module; then\n            echo \"mod_ssl already enabled, nothing to do\"\n        else\n            echo \"LoadModule ssl_module modules/mod_ssl.so\" | sudo tee /etc/httpd/conf.modules.d/00-ssl.conf\n            echo \"mod_ssl successfully enabled\"\n\tfi\n    fi\n}\n\nWhat do you think about that?","commit_id":"b3f456503491c2104436dffada9491f8099aaba2"},{"author":{"_account_id":12754,"name":"Patrizio Tufarolo","email":"patriziotufarolo@gmail.com","username":"patriziotufarolo"},"change_message_id":"7185b7aa554ec68390a0eb1aa9f5c81031421b78","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        :"},{"line_number":407,"context_line":"    fi"},{"line_number":408,"context_line":"}"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"# Proxy Functions"},{"line_number":412,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1abeadc6_ab8b421d","line":409,"in_reply_to":"1abeadc6_1a5ac229","updated":"2014-08-22 16:44:41.000000000","message":"I think we have a problem. This is executed before the installation of apache2 package (that is a dependancy of both keystone and horizon)\nOn a fresh Ubuntu setup, without the apache2 package, the deploy fails.","commit_id":"b3f456503491c2104436dffada9491f8099aaba2"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"440a7229d65b0eb351b83c3ca2cac3bb67034f48","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        :"},{"line_number":407,"context_line":"    fi"},{"line_number":408,"context_line":"}"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"# Proxy Functions"},{"line_number":412,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1abeadc6_8be4e5ac","line":409,"in_reply_to":"1abeadc6_397fb9ac","updated":"2014-08-21 22:17:52.000000000","message":"I\u0027d almost be more inclined to error out in this case. If the package is installed but not enabled, which is the Fedora/RHEL default, then who knows what else has changed. It is probably safer to detect this and error out and let the user decide how to fix it.","commit_id":"b3f456503491c2104436dffada9491f8099aaba2"},{"author":{"_account_id":12754,"name":"Patrizio Tufarolo","email":"patriziotufarolo@gmail.com","username":"patriziotufarolo"},"change_message_id":"1e65b14c624cdc26a6097ebc9d9acf0761f1afab","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        :"},{"line_number":407,"context_line":"    fi"},{"line_number":408,"context_line":"}"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"# Proxy Functions"},{"line_number":412,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1abeadc6_1a5ac229","line":409,"in_reply_to":"1abeadc6_8be4e5ac","updated":"2014-08-22 15:10:48.000000000","message":"You are right, so something like that should be fine:\n\nfunction enable_mod_ssl {\n    echo \"Enabling mod_ssl\"\n    if is_ubuntu; then\n        sudo a2enmod ssl\n    elif is_fedora; then\n        # Fedora enables mod_ssl by default\n        :\n    fi\n    if ! `which httpd` -M | grep -w -q ssl_module; then\n        die $LINENO \"mod_ssl is not enabled in apache2/httpd, please check for it manually and run stack.sh again\"\n    fi\n}","commit_id":"b3f456503491c2104436dffada9491f8099aaba2"},{"author":{"_account_id":12754,"name":"Patrizio Tufarolo","email":"patriziotufarolo@gmail.com","username":"patriziotufarolo"},"change_message_id":"20a1cd1364c7ae15cab5c06586285e2a25b8a2b7","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        # Fedora enables mod_ssl by default"},{"line_number":406,"context_line":"        :"},{"line_number":407,"context_line":"    fi"},{"line_number":408,"context_line":"    if ! `which httpd` -M | grep -w -q ssl_module; then"},{"line_number":409,"context_line":"        die $LINENO \"mod_ssl is not enabled in apache2/httpd, please check for it manually and run stack.sh again\""},{"line_number":410,"context_line":"    fi"},{"line_number":411,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1abeadc6_c4cd6cb9","line":408,"updated":"2014-08-26 13:36:52.000000000","message":"My mistake I am sorry, It should be\n    if sudo `which httpd || which apache2ctl` -M | grep -w -q ssl_module; then","commit_id":"328ffc5a6fad6edb643a34d982877663f00946ec"},{"author":{"_account_id":12754,"name":"Patrizio Tufarolo","email":"patriziotufarolo@gmail.com","username":"patriziotufarolo"},"change_message_id":"5a2152e813110207699020a73c64c421f49de410","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        # Fedora enables mod_ssl by default"},{"line_number":406,"context_line":"        :"},{"line_number":407,"context_line":"    fi"},{"line_number":408,"context_line":"    if ! `which httpd` -M | grep -w -q ssl_module; then"},{"line_number":409,"context_line":"        die $LINENO \"mod_ssl is not enabled in apache2/httpd, please check for it manually and run stack.sh again\""},{"line_number":410,"context_line":"    fi"},{"line_number":411,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1abeadc6_a43a2b96","line":408,"in_reply_to":"1abeadc6_2a77c703","updated":"2014-08-26 15:00:58.000000000","message":"In Ubuntu you do not have httpd. The same executable is called apache2.\nThe right way to call it is through apache2ctl (different from Fedora\u0027s apachectl) that parses the /etc/apache2/envvars file","commit_id":"328ffc5a6fad6edb643a34d982877663f00946ec"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"284d1ec7940434df2116f40161d10740590d15fd","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        # Fedora enables mod_ssl by default"},{"line_number":406,"context_line":"        :"},{"line_number":407,"context_line":"    fi"},{"line_number":408,"context_line":"    if ! `which httpd` -M | grep -w -q ssl_module; then"},{"line_number":409,"context_line":"        die $LINENO \"mod_ssl is not enabled in apache2/httpd, please check for it manually and run stack.sh again\""},{"line_number":410,"context_line":"    fi"},{"line_number":411,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1abeadc6_2a77c703","line":408,"in_reply_to":"1abeadc6_c4cd6cb9","updated":"2014-08-26 14:07:35.000000000","message":"I\u0027m not opposed to this I just don\u0027t understand the need. Isn\u0027t apachectl just a pass-through to httpd? Or is the httpd binary not necessarily in the path?","commit_id":"328ffc5a6fad6edb643a34d982877663f00946ec"}],"stack.sh":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"35b376909f6824f65404cd1ea439d67838b0a6c8","unresolved":false,"context_lines":[{"line_number":330,"context_line":"USE_SSL\u003d$(trueorfalse False $USE_SSL)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"# Service to enable with SSL if USE_SSL is True"},{"line_number":333,"context_line":"SSL_ENABLED_SERVICES\u003d\"key,nova,cinder,glance,s-proxy,neutron\""},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"# Configure Projects"},{"line_number":336,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":4,"id":"baada198_201d2778","line":333,"updated":"2014-07-30 16:47:08.000000000","message":"This list should not be hard-coded","commit_id":"d7319ca9e07d9fc91a070f29e7a6743dfd6c00bb"}]}