)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7d5b3ef2ab1f833ae257e5fde8204fc36d2efcce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"17ddea1a_f707f9b1","updated":"2026-05-21 08:20:00.000000000","message":"ok im not really familry with the ovn bgp work but this seams reasonable based on the commit message","commit_id":"9663242d683c88739109b55c9a861ed364f1edfc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"beebaa3b0ada5efeaa7a750d123591acac746aa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fcfe8b3c_94d1dbfd","updated":"2026-05-19 07:56:24.000000000","message":"recheck ironic-tempest-bios-ipmi-autodetect","commit_id":"9663242d683c88739109b55c9a861ed364f1edfc"}],"lib/neutron_plugins/ovn_agent":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c3042e4d0b46bcd1f2ec11fb77f028fc0b9ec955","unresolved":true,"context_lines":[{"line_number":701,"context_line":"                echo \"NEUTRON_BGP_PEER_BRIDGES must be set when ovn-bgp extension is enabled\""},{"line_number":702,"context_line":"                return 1"},{"line_number":703,"context_line":"            fi"},{"line_number":704,"context_line":"            sudo ovs-vsctl --no-wait -- set Open_vSwitch . external-ids:neutron-bgp-peer-bridges\u003d$NEUTRON_BGP_PEER_BRIDGES"},{"line_number":705,"context_line":"            sudo ovs-vsctl --no-wait -- set Open_vSwitch . external-ids:neutron-bgp-interconnect-bridge\u003d$OVS_PHYSICAL_BRIDGE"},{"line_number":706,"context_line":"        elif is_provider_network || [[ $Q_USE_PROVIDERNET_FOR_PUBLIC \u003d\u003d \"True\" ]]; then"},{"line_number":707,"context_line":"            ovn_base_setup_bridge $OVS_PHYSICAL_BRIDGE"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ca7d8f0e_d4558e29","line":704,"updated":"2026-05-18 14:27:21.000000000","message":"nit: you could have bundled it together with `-- set Open_vSwitch` and do it all as one transaction","commit_id":"81bb33ccd1c4b728e391e935353256eede260706"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"2787ba3bb9626ef671fbe4eaa77d8b8d7d9710de","unresolved":false,"context_lines":[{"line_number":701,"context_line":"                echo \"NEUTRON_BGP_PEER_BRIDGES must be set when ovn-bgp extension is enabled\""},{"line_number":702,"context_line":"                return 1"},{"line_number":703,"context_line":"            fi"},{"line_number":704,"context_line":"            sudo ovs-vsctl --no-wait -- set Open_vSwitch . external-ids:neutron-bgp-peer-bridges\u003d$NEUTRON_BGP_PEER_BRIDGES"},{"line_number":705,"context_line":"            sudo ovs-vsctl --no-wait -- set Open_vSwitch . external-ids:neutron-bgp-interconnect-bridge\u003d$OVS_PHYSICAL_BRIDGE"},{"line_number":706,"context_line":"        elif is_provider_network || [[ $Q_USE_PROVIDERNET_FOR_PUBLIC \u003d\u003d \"True\" ]]; then"},{"line_number":707,"context_line":"            ovn_base_setup_bridge $OVS_PHYSICAL_BRIDGE"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3b085943_4c41d191","line":704,"in_reply_to":"ca7d8f0e_d4558e29","updated":"2026-05-19 13:00:38.000000000","message":"Done","commit_id":"81bb33ccd1c4b728e391e935353256eede260706"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"67957b3406672b9b58724e8bc2ddd852ee9adb5d","unresolved":true,"context_lines":[{"line_number":701,"context_line":"                echo \"NEUTRON_BGP_PEER_BRIDGES must be set when ovn-bgp extension is enabled\""},{"line_number":702,"context_line":"                return 1"},{"line_number":703,"context_line":"            fi"},{"line_number":704,"context_line":"            sudo ovs-vsctl --no-wait -- set Open_vSwitch . external-ids:neutron-bgp-peer-bridges\u003d$NEUTRON_BGP_PEER_BRIDGES external-ids:neutron-bgp-interconnect-bridge\u003d$OVS_PHYSICAL_BRIDGE"},{"line_number":705,"context_line":"        elif is_provider_network || [[ $Q_USE_PROVIDERNET_FOR_PUBLIC \u003d\u003d \"True\" ]]; then"},{"line_number":706,"context_line":"            ovn_base_setup_bridge $OVS_PHYSICAL_BRIDGE"},{"line_number":707,"context_line":"            sudo ovs-vsctl set open . external-ids:ovn-bridge-mappings\u003d${PHYSICAL_NETWORK}:${OVS_PHYSICAL_BRIDGE}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"43d5ee3e_1d94fb3c","line":704,"updated":"2026-05-21 10:27:42.000000000","message":"can this be split into two commands to avoid the overlong line?\n\nis there a special significance for the `Open_vSwitch` or can this be normalized to lower case like in the above commands?\n\nfinally, not necessarily specific only to this change: is this setup documented somewhere? asking for a deployment project that may want to implement this","commit_id":"9663242d683c88739109b55c9a861ed364f1edfc"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"5c6aaa8fbf414fd29044b30e5c4ddbcef9e78236","unresolved":true,"context_lines":[{"line_number":701,"context_line":"                echo \"NEUTRON_BGP_PEER_BRIDGES must be set when ovn-bgp extension is enabled\""},{"line_number":702,"context_line":"                return 1"},{"line_number":703,"context_line":"            fi"},{"line_number":704,"context_line":"            sudo ovs-vsctl --no-wait -- set Open_vSwitch . external-ids:neutron-bgp-peer-bridges\u003d$NEUTRON_BGP_PEER_BRIDGES external-ids:neutron-bgp-interconnect-bridge\u003d$OVS_PHYSICAL_BRIDGE"},{"line_number":705,"context_line":"        elif is_provider_network || [[ $Q_USE_PROVIDERNET_FOR_PUBLIC \u003d\u003d \"True\" ]]; then"},{"line_number":706,"context_line":"            ovn_base_setup_bridge $OVS_PHYSICAL_BRIDGE"},{"line_number":707,"context_line":"            sudo ovs-vsctl set open . external-ids:ovn-bridge-mappings\u003d${PHYSICAL_NETWORK}:${OVS_PHYSICAL_BRIDGE}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"754efc5c_32f343f6","line":704,"in_reply_to":"43d5ee3e_1d94fb3c","updated":"2026-05-21 10:44:40.000000000","message":"\u003e can this be split into two commands to avoid the overlong line?\n\nI received the opposite suggestion in a previous comment:\nhttps://review.opendev.org/c/openstack/devstack/+/988977/comment/ca7d8f0e_d4558e29/\n\n\n\n\u003e is there a special significance for the Open_vSwitch or can this be normalized to lower case like in the above commands?\n\nhttps://manpages.ubuntu.com/manpages/stonking/man8/ovs-vsctl.8.html\n_Names of tables and columns are not case-sensitive_\n\n\u003e finally, not necessarily specific only to this change: is this setup documented somewhere? asking for a deployment project that may want to implement this\n\nWe documented it in neutron\nhttps://opendev.org/openstack/neutron/src/branch/master/doc/source/ovn/bgp_tempest_job.rst","commit_id":"9663242d683c88739109b55c9a861ed364f1edfc"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"970d6b9a5b1e547d4b1fcff7eb32fec554bfdca1","unresolved":false,"context_lines":[{"line_number":701,"context_line":"                echo \"NEUTRON_BGP_PEER_BRIDGES must be set when ovn-bgp extension is enabled\""},{"line_number":702,"context_line":"                return 1"},{"line_number":703,"context_line":"            fi"},{"line_number":704,"context_line":"            sudo ovs-vsctl --no-wait -- set Open_vSwitch . external-ids:neutron-bgp-peer-bridges\u003d$NEUTRON_BGP_PEER_BRIDGES external-ids:neutron-bgp-interconnect-bridge\u003d$OVS_PHYSICAL_BRIDGE"},{"line_number":705,"context_line":"        elif is_provider_network || [[ $Q_USE_PROVIDERNET_FOR_PUBLIC \u003d\u003d \"True\" ]]; then"},{"line_number":706,"context_line":"            ovn_base_setup_bridge $OVS_PHYSICAL_BRIDGE"},{"line_number":707,"context_line":"            sudo ovs-vsctl set open . external-ids:ovn-bridge-mappings\u003d${PHYSICAL_NETWORK}:${OVS_PHYSICAL_BRIDGE}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"a9cca053_d0983e1c","line":704,"in_reply_to":"754efc5c_32f343f6","updated":"2026-05-21 11:24:12.000000000","message":"sorry for the conflicting suggestion, guess I\u0027ll add a follow-up then\n\nthe doc is more about the testing environment and not about how a real deployment would look like, but nothing to block this for, thx","commit_id":"9663242d683c88739109b55c9a861ed364f1edfc"}]}
