)]}'
{"files/apache-ironic.template":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c842ff26713bbb851bcdae8acce3803ece5fc18c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Listen %PUBLICPORT%"},{"line_number":2,"context_line":"DocumentRoot \"%HTTPROOT%\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"\u003cVirtualHost *:%PUBLICPORT%\u003e"},{"line_number":5,"context_line":"    \u003cDirectory \"%HTTPROOT%\"\u003e"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1ae5cdf2_41fb0947","line":2,"updated":"2014-06-17 15:23:31.000000000","message":"I think DocumentRoot should be inside the VirtualHost","commit_id":"6a1ef3ca79cf7b6a73aaedcdb8ccc8190f90f46d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"972bb48375010d30b5a38a5d18281d71f70fac51","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Listen %PUBLICPORT%"},{"line_number":2,"context_line":"DocumentRoot \"%HTTPROOT%\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"\u003cVirtualHost *:%PUBLICPORT%\u003e"},{"line_number":5,"context_line":"    \u003cDirectory \"%HTTPROOT%\"\u003e"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_f9911e9b","line":2,"in_reply_to":"1ae5cdf2_41fb0947","updated":"2014-07-02 13:23:35.000000000","message":"ah, that\u0027s correct. Thanks!","commit_id":"6a1ef3ca79cf7b6a73aaedcdb8ccc8190f90f46d"}],"lib/ironic":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"891ad217c5da5fb8aaca0c11e92af129b4bdc239","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        iniset $IRONIC_CONF_FILE pxe ipxe_enabled True"},{"line_number":243,"context_line":"        iniset $IRONIC_CONF_FILE pxe http_server $HOST_IP:$IRONIC_HTTP_PORT"},{"line_number":244,"context_line":"        iniset $IRONIC_CONF_FILE pxe http_root $IRONIC_HTTP_DIR"},{"line_number":245,"context_line":"        iniset $IRONIC_CONF_FILE pxe pxe_bootfile_name gpxelinux.0"},{"line_number":246,"context_line":"    fi"},{"line_number":247,"context_line":"}"},{"line_number":248,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_851e2aba","line":245,"updated":"2014-06-16 16:32:08.000000000","message":"and the option value here should be $PXE_BOOT_FILE","commit_id":"5ae0c6cadf6c295f38211c896f72aa4f98e81618"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"891ad217c5da5fb8aaca0c11e92af129b4bdc239","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"function configure_ironic_dirs {"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    PXE_BOOT_FILE\u003dpxelinux.0"},{"line_number":367,"context_line":"    if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"},{"line_number":368,"context_line":"        PXE_BOOT_FILE\u003dgpxelinux.0"},{"line_number":369,"context_line":"        sudo mkdir -p $IRONIC_HTTP_DIR"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_85470abc","line":366,"updated":"2014-06-16 16:32:08.000000000","message":"the PXE_BOOT_FILE variable is being set both here and in configure_tftpd, so it seems like it should be refactored to a common location.","commit_id":"5ae0c6cadf6c295f38211c896f72aa4f98e81618"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c842ff26713bbb851bcdae8acce3803ece5fc18c","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    fi"},{"line_number":152,"context_line":"}"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"# _config_keystone_apache_wsgi() - Set WSGI config files of Keystone"},{"line_number":155,"context_line":"function _config_ironic_apache_wsgi {"},{"line_number":156,"context_line":"    sudo cp $FILES/apache-ironic.template $IRONIC_APACHE_CONF_FILE"},{"line_number":157,"context_line":"    sudo sed -e \""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1ae5cdf2_614f2535","line":154,"updated":"2014-06-17 15:23:31.000000000","message":"c-n-p fix: s/keystone/ironic/","commit_id":"6a1ef3ca79cf7b6a73aaedcdb8ccc8190f90f46d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"972bb48375010d30b5a38a5d18281d71f70fac51","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    fi"},{"line_number":152,"context_line":"}"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"# _config_keystone_apache_wsgi() - Set WSGI config files of Keystone"},{"line_number":155,"context_line":"function _config_ironic_apache_wsgi {"},{"line_number":156,"context_line":"    sudo cp $FILES/apache-ironic.template $IRONIC_APACHE_CONF_FILE"},{"line_number":157,"context_line":"    sudo sed -e \""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_99f4a2f3","line":154,"in_reply_to":"1ae5cdf2_614f2535","updated":"2014-07-02 13:23:35.000000000","message":"oops, done","commit_id":"6a1ef3ca79cf7b6a73aaedcdb8ccc8190f90f46d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f809f4033ae345370997be69d08f443c709654d4","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":103,"context_line":"function get_pxe_boot_file {"},{"line_number":104,"context_line":"    PXE_BOOT_FILE\u003dsyslinux/pxelinux.0"},{"line_number":105,"context_line":"    if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"},{"line_number":106,"context_line":"        PXE_BOOT_FILE\u003dipxe/undionly.kpxe"},{"line_number":107,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"baada198_a1750436","line":104,"updated":"2014-08-12 19:22:10.000000000","message":"shouldn\u0027t this be a \"local\" variable?\n\nwould it be handy to be able to override this?  i know that i\u0027ve had times that various versions of pxelinux didn\u0027t work with various hardware, and i\u0027ve used different versions than the packaged ones","commit_id":"afe06114d5b983dfb1c94d68e0576d3b65a5e9d0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ca48b94ec63e169299bb171e2e4f2cb5ea43aa2e","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":103,"context_line":"function get_pxe_boot_file {"},{"line_number":104,"context_line":"    PXE_BOOT_FILE\u003dsyslinux/pxelinux.0"},{"line_number":105,"context_line":"    if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"},{"line_number":106,"context_line":"        PXE_BOOT_FILE\u003dipxe/undionly.kpxe"},{"line_number":107,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"baada198_bd8fc7d2","line":104,"in_reply_to":"baada198_a1750436","updated":"2014-08-13 10:04:37.000000000","message":"+1\n\nYeah, that\u0027s a valid assumption, people may want to use different pxe boot images/custom ones. I will make it overridable","commit_id":"afe06114d5b983dfb1c94d68e0576d3b65a5e9d0"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f809f4033ae345370997be69d08f443c709654d4","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    fi"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"},{"line_number":252,"context_line":"        PXEBIN\u003d$(get_pxe_boot_file)"},{"line_number":253,"context_line":"        PXEBIN\u003d`basename $PXEBIN`"},{"line_number":254,"context_line":"        iniset $IRONIC_CONF_FILE pxe ipxe_enabled True"},{"line_number":255,"context_line":"        iniset $IRONIC_CONF_FILE pxe pxe_config_template \u0027\\$pybasedir/drivers/modules/ipxe_config.template\u0027"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"baada198_e16ffc5f","line":252,"updated":"2014-08-12 19:22:10.000000000","message":"same, local variables","commit_id":"afe06114d5b983dfb1c94d68e0576d3b65a5e9d0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ca48b94ec63e169299bb171e2e4f2cb5ea43aa2e","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    fi"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"},{"line_number":252,"context_line":"        PXEBIN\u003d$(get_pxe_boot_file)"},{"line_number":253,"context_line":"        PXEBIN\u003d`basename $PXEBIN`"},{"line_number":254,"context_line":"        iniset $IRONIC_CONF_FILE pxe ipxe_enabled True"},{"line_number":255,"context_line":"        iniset $IRONIC_CONF_FILE pxe pxe_config_template \u0027\\$pybasedir/drivers/modules/ipxe_config.template\u0027"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"baada198_1d127361","line":252,"in_reply_to":"baada198_e16ffc5f","updated":"2014-08-13 10:04:37.000000000","message":"Done","commit_id":"afe06114d5b983dfb1c94d68e0576d3b65a5e9d0"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f809f4033ae345370997be69d08f443c709654d4","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    sudo chown -R $STACK_USER $IRONIC_DATA_DIR $IRONIC_STATE_PATH"},{"line_number":381,"context_line":"    sudo chown -R $STACK_USER:$LIBVIRT_GROUP $IRONIC_TFTPBOOT_DIR"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    PXEBIN\u003d$(get_pxe_boot_file)"},{"line_number":384,"context_line":"    cp $PXEBIN $IRONIC_TFTPBOOT_DIR"},{"line_number":385,"context_line":"    mkdir -p $IRONIC_TFTPBOOT_DIR/pxelinux.cfg"},{"line_number":386,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"baada198_418ee827","line":383,"updated":"2014-08-12 19:22:10.000000000","message":"ditto on local","commit_id":"afe06114d5b983dfb1c94d68e0576d3b65a5e9d0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ca48b94ec63e169299bb171e2e4f2cb5ea43aa2e","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    sudo chown -R $STACK_USER $IRONIC_DATA_DIR $IRONIC_STATE_PATH"},{"line_number":381,"context_line":"    sudo chown -R $STACK_USER:$LIBVIRT_GROUP $IRONIC_TFTPBOOT_DIR"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    PXEBIN\u003d$(get_pxe_boot_file)"},{"line_number":384,"context_line":"    cp $PXEBIN $IRONIC_TFTPBOOT_DIR"},{"line_number":385,"context_line":"    mkdir -p $IRONIC_TFTPBOOT_DIR/pxelinux.cfg"},{"line_number":386,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"baada198_5d030b11","line":383,"in_reply_to":"baada198_418ee827","updated":"2014-08-13 10:04:37.000000000","message":"Done","commit_id":"afe06114d5b983dfb1c94d68e0576d3b65a5e9d0"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"be3899c135d00a8a6061dddca8431611c9cdf762","unresolved":false,"context_lines":[{"line_number":99,"context_line":"IRONIC_IPXE_ENABLED\u003d$(trueorfalse False $IRONIC_IPXE_ENABLED)"},{"line_number":100,"context_line":"IRONIC_HTTP_DIR\u003d${IRONIC_HTTP_DIR:-$IRONIC_DATA_DIR/httpboot}"},{"line_number":101,"context_line":"IRONIC_HTTP_SERVER\u003d${IRONIC_HTTP_SERVER:-$HOST_IP}"},{"line_number":102,"context_line":"IRONIC_HTTP_PORT\u003d${IRONIC_HTTP_PORT:-8080}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":105,"context_line":"function get_pxe_boot_file {"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"1abeadc6_7d530739","line":102,"updated":"2014-08-20 15:47:19.000000000","message":"This conflicts with the Swift/S3 default port on 8080.  Heh, Midonet, Ryu and OpenDaylight also default to it in Neutron.  Fun!  IMO S3 would win that clash due to AWS compat if it were ever put to a vote.","commit_id":"dd17fba4aeb70fce6993ac9219f8548543b3e68d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"adf5e44460f137342e7062a7ffa1b03e49c32cd9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"IRONIC_IPXE_ENABLED\u003d$(trueorfalse False $IRONIC_IPXE_ENABLED)"},{"line_number":100,"context_line":"IRONIC_HTTP_DIR\u003d${IRONIC_HTTP_DIR:-$IRONIC_DATA_DIR/httpboot}"},{"line_number":101,"context_line":"IRONIC_HTTP_SERVER\u003d${IRONIC_HTTP_SERVER:-$HOST_IP}"},{"line_number":102,"context_line":"IRONIC_HTTP_PORT\u003d${IRONIC_HTTP_PORT:-8080}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":105,"context_line":"function get_pxe_boot_file {"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"1abeadc6_d8e509dd","line":102,"in_reply_to":"1abeadc6_7d530739","updated":"2014-08-20 16:15:19.000000000","message":"hah, ouch... I alright I will check for an non used port number. Thanks","commit_id":"dd17fba4aeb70fce6993ac9219f8548543b3e68d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"be3899c135d00a8a6061dddca8431611c9cdf762","unresolved":false,"context_lines":[{"line_number":105,"context_line":"function get_pxe_boot_file {"},{"line_number":106,"context_line":"    local pxe_boot_file\u003dsyslinux/pxelinux.0"},{"line_number":107,"context_line":"    if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"},{"line_number":108,"context_line":"        pxe_boot_file\u003dipxe/undionly.kpxe"},{"line_number":109,"context_line":"    fi"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    if is_ubuntu; then"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"1abeadc6_9d062385","line":108,"updated":"2014-08-20 15:47:19.000000000","message":"How is this value ever returned?  either is_ubuntu() or is_fedora() below are going to be true...\n\nAlso, the relative path is fragile, is the ipxe dir directly below devstack?","commit_id":"dd17fba4aeb70fce6993ac9219f8548543b3e68d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"adf5e44460f137342e7062a7ffa1b03e49c32cd9","unresolved":false,"context_lines":[{"line_number":105,"context_line":"function get_pxe_boot_file {"},{"line_number":106,"context_line":"    local pxe_boot_file\u003dsyslinux/pxelinux.0"},{"line_number":107,"context_line":"    if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"},{"line_number":108,"context_line":"        pxe_boot_file\u003dipxe/undionly.kpxe"},{"line_number":109,"context_line":"    fi"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    if is_ubuntu; then"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"1abeadc6_584c99c8","line":108,"in_reply_to":"1abeadc6_9d062385","updated":"2014-08-20 16:15:19.000000000","message":"Oh I see what you mean...\n\nIt\u0027s was not suppose to be a relative path, I will concat it later based on distro...\n\ne.g in fedora the path will be:\n\n /usr/share/ipxe/undionly.kpxe (for iPXE)\n /usr/share/syslinux/pxelinux.0 (for standard PXE)\n\nThe difference is that those files live under \u0027/usr/share/\u0027 in fedora and \u0027/usr/lib\u0027 on ubuntu.\n\nShould I die in case the distro is neither fedora/ubuntu/[suse] ? (it would die later on because the file wouldn\u0027t be found)","commit_id":"dd17fba4aeb70fce6993ac9219f8548543b3e68d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"be3899c135d00a8a6061dddca8431611c9cdf762","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    if is_ubuntu; then"},{"line_number":112,"context_line":"        pxe_boot_file\u003d/usr/lib/$pxe_boot_file"},{"line_number":113,"context_line":"    elif is_fedora; then"},{"line_number":114,"context_line":"        pxe_boot_file\u003d/usr/share/$pxe_boot_file"},{"line_number":115,"context_line":"    fi"},{"line_number":116,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":18,"id":"1abeadc6_fda8f7dc","line":113,"updated":"2014-08-20 15:47:19.000000000","message":"https://review.openstack.org/#/c/114268/ adds \u0027|| is_suse\u0027 to this test...one of you will need to rebase","commit_id":"dd17fba4aeb70fce6993ac9219f8548543b3e68d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"bba081230594168dc7b4bb7bc8815da374f80fc2","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    if is_ubuntu; then"},{"line_number":112,"context_line":"        pxe_boot_file\u003d/usr/lib/$pxe_boot_file"},{"line_number":113,"context_line":"    elif is_fedora; then"},{"line_number":114,"context_line":"        pxe_boot_file\u003d/usr/share/$pxe_boot_file"},{"line_number":115,"context_line":"    fi"},{"line_number":116,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":18,"id":"1abeadc6_2fc6b49a","line":113,"in_reply_to":"1abeadc6_58e3b9a3","updated":"2014-08-20 16:50:42.000000000","message":"I added a comment about it on his review (and reviewed his patch)","commit_id":"dd17fba4aeb70fce6993ac9219f8548543b3e68d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"adf5e44460f137342e7062a7ffa1b03e49c32cd9","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    if is_ubuntu; then"},{"line_number":112,"context_line":"        pxe_boot_file\u003d/usr/lib/$pxe_boot_file"},{"line_number":113,"context_line":"    elif is_fedora; then"},{"line_number":114,"context_line":"        pxe_boot_file\u003d/usr/share/$pxe_boot_file"},{"line_number":115,"context_line":"    fi"},{"line_number":116,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":18,"id":"1abeadc6_58e3b9a3","line":113,"in_reply_to":"1abeadc6_fda8f7dc","updated":"2014-08-20 16:15:19.000000000","message":"Well I would rebase on top of that but I need the author to rebase #114268 on top of master first (otherwise my patch will conflict with an old version of lib/ironic [1])\n\nSo I will just add \u0027|| is_suse\u0027 here myself for now then\n\n[1] https://review.openstack.org/#/c/108457/","commit_id":"dd17fba4aeb70fce6993ac9219f8548543b3e68d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"be3899c135d00a8a6061dddca8431611c9cdf762","unresolved":false,"context_lines":[{"line_number":118,"context_line":"}"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# PXE boot image"},{"line_number":121,"context_line":"IRONIC_PXE_BOOT_IMAGE\u003d${IRONIC_PXE_BOOT_IMAGE:-$(get_pxe_boot_file)}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Functions"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"1abeadc6_1d74d366","line":121,"updated":"2014-08-20 15:47:19.000000000","message":"I don\u0027t like calling get_pxe_boot_file() here, it requires more than just setting default variables during the source phase.  Generally it is not good for Grenade, but that might be a non-issue for this code?","commit_id":"dd17fba4aeb70fce6993ac9219f8548543b3e68d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"adf5e44460f137342e7062a7ffa1b03e49c32cd9","unresolved":false,"context_lines":[{"line_number":118,"context_line":"}"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# PXE boot image"},{"line_number":121,"context_line":"IRONIC_PXE_BOOT_IMAGE\u003d${IRONIC_PXE_BOOT_IMAGE:-$(get_pxe_boot_file)}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Functions"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"1abeadc6_4ce69e16","line":121,"in_reply_to":"1abeadc6_1d74d366","updated":"2014-08-20 16:15:19.000000000","message":"So this came from a comment from Ian Wienand at patch-set #14[1]\n\nIndeed it creates a small overhead on the source phase, but this also makes the code more flexible because it makes the PXE boot image overridable (before it was not), and, I believe people may want to use their own custom PXE boot images[2] so I think it\u0027s good to allow them use their images instead of forcing using the pre-packaged ones.\n\nI don\u0027t think it\u0027s a problem to have it here, but if you think we should be strict about calling a function to determine the default value and instead we should just set a static default, I can change it back.\n\n[1] https://review.openstack.org/#/c/99677/14/lib/ironic (L104)\n\n[2] http://ipxe.org/download#choosing_what_to_build","commit_id":"dd17fba4aeb70fce6993ac9219f8548543b3e68d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"bba081230594168dc7b4bb7bc8815da374f80fc2","unresolved":false,"context_lines":[{"line_number":118,"context_line":"}"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# PXE boot image"},{"line_number":121,"context_line":"IRONIC_PXE_BOOT_IMAGE\u003d${IRONIC_PXE_BOOT_IMAGE:-$(get_pxe_boot_file)}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Functions"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"1abeadc6_ef3f5c85","line":121,"in_reply_to":"1abeadc6_4ce69e16","updated":"2014-08-20 16:50:42.000000000","message":"So I\u0027m pushin another patch-set fixing the other things, I will leave this function as-is because I don\u0027t think it\u0027s a problem. But feel free to ask me to remove it on the new patch set if you think it is a problem.","commit_id":"dd17fba4aeb70fce6993ac9219f8548543b3e68d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"a27047c97a44c0ea3568b62b7e878ac64dfca462","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    local pxe_boot_file"},{"line_number":112,"context_line":"    if is_ubuntu; then"},{"line_number":113,"context_line":"        pxe_boot_file\u003d/usr/lib/$relpath"},{"line_number":114,"context_line":"    elif is_fedora || is_suse; then"},{"line_number":115,"context_line":"        pxe_boot_file\u003d/usr/share/$relpath"},{"line_number":116,"context_line":"    fi"},{"line_number":117,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":19,"id":"1abeadc6_711b2b73","line":114,"updated":"2014-08-20 19:03:49.000000000","message":"This works for me, thanks for commenting on Felipe\u0027s review.  Actually, does this one moot his completely?  Since this is in a function now I think it does...","commit_id":"5851e5f6984afe1f3a71d3a0420b442c55770f3e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"351094cdfac0833a032154e71dbf172b5f727de0","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    local pxe_boot_file"},{"line_number":112,"context_line":"    if is_ubuntu; then"},{"line_number":113,"context_line":"        pxe_boot_file\u003d/usr/lib/$relpath"},{"line_number":114,"context_line":"    elif is_fedora || is_suse; then"},{"line_number":115,"context_line":"        pxe_boot_file\u003d/usr/share/$relpath"},{"line_number":116,"context_line":"    fi"},{"line_number":117,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":19,"id":"1abeadc6_70a9528f","line":114,"in_reply_to":"1abeadc6_711b2b73","updated":"2014-08-21 08:34:53.000000000","message":"Yeah it does :/","commit_id":"5851e5f6984afe1f3a71d3a0420b442c55770f3e"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"a27047c97a44c0ea3568b62b7e878ac64dfca462","unresolved":false,"context_lines":[{"line_number":119,"context_line":"}"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# PXE boot image"},{"line_number":122,"context_line":"IRONIC_PXE_BOOT_IMAGE\u003d${IRONIC_PXE_BOOT_IMAGE:-$(get_pxe_boot_file)}"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# Functions"}],"source_content_type":"application/octet-stream","patch_set":19,"id":"1abeadc6_5140ef33","line":122,"updated":"2014-08-20 19:03:49.000000000","message":"This still isn\u0027t my first preference but I think you\u0027re right, it\u0027ll work fine.  If it is ever a problem in Grenade, however... ;)","commit_id":"5851e5f6984afe1f3a71d3a0420b442c55770f3e"}]}