)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8647f8fa5a914d45771476cdd198734838d31822","unresolved":true,"context_lines":[{"line_number":14,"context_line":"subtree."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The trade-off with bind mounts is that they cannot be cleanly unmounted"},{"line_number":17,"context_line":"by the build process, since the container runtime owns these mounts."},{"line_number":18,"context_line":"The unmount_dir function is therefore skipped entirely when"},{"line_number":19,"context_line":"DIB_BIND_MOUNTS is set — attempting individual unmounts would fail and"},{"line_number":20,"context_line":"trigger error exits that abort the build."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e4fb0260_725b0ae1","line":17,"updated":"2026-09-28 23:18:34.000000000","message":"Are there also tradeoffs with exposing the \"system\" /proc, /sys/, and /dev/pts filesystems? For example if someone were to set this flag when not inside of a container?","commit_id":"a9a4f0756881a38a561f13c2f9dc9ebf28303907"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9d4845d63914acaee657627035716f879d12ce74","unresolved":true,"context_lines":[{"line_number":14,"context_line":"subtree."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The trade-off with bind mounts is that they cannot be cleanly unmounted"},{"line_number":17,"context_line":"by the build process, since the container runtime owns these mounts."},{"line_number":18,"context_line":"The unmount_dir function is therefore skipped entirely when"},{"line_number":19,"context_line":"DIB_BIND_MOUNTS is set — attempting individual unmounts would fail and"},{"line_number":20,"context_line":"trigger error exits that abort the build."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e6203436_c8df710d","line":17,"in_reply_to":"e4fb0260_725b0ae1","updated":"2026-09-29 22:07:31.000000000","message":"I wouldn\u0027t recommend running DIB_BIND_MOUNTS on a full host and I don\u0027t want to sacrifice my workstation to find out :P \n\nBut yes, I\u0027ll add some docs to developing_elements.rst to provide more context around setting this.","commit_id":"a9a4f0756881a38a561f13c2f9dc9ebf28303907"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8647f8fa5a914d45771476cdd198734838d31822","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ddf4702a_d305ed61","updated":"2026-09-28 23:18:34.000000000","message":"This should be documented to make it clear when it is useful and what the potential pitfalls are (for example one of my inline comments touches on whether or not this is a good idea when running outside of a container).","commit_id":"a9a4f0756881a38a561f13c2f9dc9ebf28303907"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"7531fb2e48c0e6a193ec1529a7ec11b8d84ada37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9a1f9485_7b772170","updated":"2026-09-30 21:28:20.000000000","message":"recheck cloud.centos.org 502","commit_id":"fe490556611d73127c1f8880ecfb7cc9c201813d"}],"releasenotes/notes/dib_bind_mounts-cf2a95ad7c0ff4be.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8647f8fa5a914d45771476cdd198734838d31822","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When environment variable `DIB_BIND_MOUNTS` is set to `1`, the host system"},{"line_number":5,"context_line":"    mounts /proc, /sys etc will be bind mounted. This is to accomodate"},{"line_number":6,"context_line":"    diskimage-builder running inside a container. Bind mounts cannot be"},{"line_number":7,"context_line":"    unmounted from inside the container, so less cleanup occurs. Full cleanup"},{"line_number":8,"context_line":"    is not a requirement in ephemeral container builds."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b315cd93_9ca248bc","line":6,"range":{"start_line":5,"start_character":49,"end_line":6,"end_character":49},"updated":"2026-09-28 23:18:34.000000000","message":"I feel like this is lacking necessary detail. OpenDev ran dib inside of containers just fine for many years and didn\u0027t need this change. There are additional restrictions being placed on the build environment that necessitate this and that should probably be captured to avoid confusion.","commit_id":"a9a4f0756881a38a561f13c2f9dc9ebf28303907"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9d4845d63914acaee657627035716f879d12ce74","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When environment variable `DIB_BIND_MOUNTS` is set to `1`, the host system"},{"line_number":5,"context_line":"    mounts /proc, /sys etc will be bind mounted. This is to accomodate"},{"line_number":6,"context_line":"    diskimage-builder running inside a container. Bind mounts cannot be"},{"line_number":7,"context_line":"    unmounted from inside the container, so less cleanup occurs. Full cleanup"},{"line_number":8,"context_line":"    is not a requirement in ephemeral container builds."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fbfb6f55_a3ffee44","line":6,"range":{"start_line":5,"start_character":49,"end_line":6,"end_character":49},"in_reply_to":"b315cd93_9ca248bc","updated":"2026-09-29 22:07:31.000000000","message":"This may be required due to the specifics of the podman implementation plus the host being SELinux enforcing, neither of which would have been an issue in OpenDev. I\u0027ll provide more details.","commit_id":"a9a4f0756881a38a561f13c2f9dc9ebf28303907"}]}
