)]}'
{"elements/vm/finalise.d/51-bootloader":[{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"8c1fc775fe9e1d4dce7cb95c1bbe2b5ab096dd72","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # Find any pre-created extlinux install directory"},{"line_number":34,"context_line":"    for EXTDIR in /boot/extlinux /boot/syslinux ; do"},{"line_number":35,"context_line":"\tif [ -d $EXTDIR ] ; then"},{"line_number":36,"context_line":"\t    break"},{"line_number":37,"context_line":"\tfi"},{"line_number":38,"context_line":"    done"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"baada198_982ae32a","line":35,"updated":"2014-07-02 11:31:16.000000000","message":"Tab Chars should be replaced with 4 space chars.","commit_id":"20a15e68c6284323fbd91b1648feaaa02fd1011f"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"85f7a61b24c5fb379bd2a443326ecb770ef9167c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    echo \"Installing Extlinux...\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # Find and install mbr.bin"},{"line_number":20,"context_line":"    for MBR in /usr/share/syslinux/mbr.bin /usr/lib/syslinux/mbr.bin \\"},{"line_number":21,"context_line":"        /usr/lib/extlinux/mbr.bin ; do"},{"line_number":22,"context_line":"        if [ -f $MBR ]; then"},{"line_number":23,"context_line":"            break"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"baada198_e62fc09f","line":20,"updated":"2014-07-02 12:12:56.000000000","message":"It could be simplified using following logic:\nMBR\u003d`ls /usr/share/syslinux/mbr.bin /usr/lib/syslinux/mbr.bin /usr/lib/extlinux/mbr.bin || echo \"\"`\nMBR\u003d${MBR%%[[:space:]]*}\nif [ -n $MBR ] ; then \n    echo \"mbr.bin (from EXT/SYSLINUX) not found.\"\n    exit 1\nfi","commit_id":"c74acfc3010227ae73944dc4fcecc70164db0d82"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"ab70ccbbd86aa251fbf4d11bedaba40a9862ab03","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    echo \"Installing Extlinux...\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # Find and install mbr.bin"},{"line_number":20,"context_line":"    for MBR in /usr/share/syslinux/mbr.bin /usr/lib/syslinux/mbr.bin \\"},{"line_number":21,"context_line":"        /usr/lib/extlinux/mbr.bin ; do"},{"line_number":22,"context_line":"        if [ -f $MBR ]; then"},{"line_number":23,"context_line":"            break"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"baada198_ff8a8cba","line":20,"in_reply_to":"baada198_2190c242","updated":"2014-07-25 18:26:32.000000000","message":"agreed with Juerg, i think it\u0027s easier to read the way it is.","commit_id":"c74acfc3010227ae73944dc4fcecc70164db0d82"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"244071e029f8c24cbf592656e375ef3135661364","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    echo \"Installing Extlinux...\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # Find and install mbr.bin"},{"line_number":20,"context_line":"    for MBR in /usr/share/syslinux/mbr.bin /usr/lib/syslinux/mbr.bin \\"},{"line_number":21,"context_line":"        /usr/lib/extlinux/mbr.bin ; do"},{"line_number":22,"context_line":"        if [ -f $MBR ]; then"},{"line_number":23,"context_line":"            break"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"baada198_c11b861a","line":20,"in_reply_to":"baada198_e62fc09f","updated":"2014-07-02 12:16:49.000000000","message":"Actually above should change to \nMBR\u003d`ls /usr/share/syslinux/mbr.bin /usr/lib/syslinux/mbr.bin /usr/lib/extlinux/mbr.bin 2\u003e/dev/null || echo \"\"`","commit_id":"c74acfc3010227ae73944dc4fcecc70164db0d82"},{"author":{"_account_id":2036,"name":"Juerg Haefliger","email":"juerg.haefliger@hpe.com","username":"juergh"},"change_message_id":"c41bad96cfad24a162d4f7e548ae9a28011312db","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    echo \"Installing Extlinux...\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    # Find and install mbr.bin"},{"line_number":20,"context_line":"    for MBR in /usr/share/syslinux/mbr.bin /usr/lib/syslinux/mbr.bin \\"},{"line_number":21,"context_line":"        /usr/lib/extlinux/mbr.bin ; do"},{"line_number":22,"context_line":"        if [ -f $MBR ]; then"},{"line_number":23,"context_line":"            break"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"baada198_2190c242","line":20,"in_reply_to":"baada198_e62fc09f","updated":"2014-07-02 12:23:25.000000000","message":"I don\u0027t consider this simplification but rather make the code hard to read.","commit_id":"c74acfc3010227ae73944dc4fcecc70164db0d82"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"85f7a61b24c5fb379bd2a443326ecb770ef9167c","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    dd if\u003d$MBR of\u003d$BOOT_DEV"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # Find any pre-created extlinux install directory"},{"line_number":34,"context_line":"    for EXTDIR in /boot/extlinux /boot/syslinux ; do"},{"line_number":35,"context_line":"        if [ -d $EXTDIR ] ; then"},{"line_number":36,"context_line":"            break"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"baada198_c191c69b","line":33,"updated":"2014-07-02 12:12:56.000000000","message":"Like above this could also be simplified as follows:\n\nEXTDIR\u003d`ls /boot/extlinux /boot/syslinux || echo \"\"`\nEXTDIR\u003d${EXTDIR%%[[:space:]]*}\nEXTDIR\u003d${EXTDIR:-\"/boot/syslinux\"}\nmkdir -p $EXTDIR","commit_id":"c74acfc3010227ae73944dc4fcecc70164db0d82"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"244071e029f8c24cbf592656e375ef3135661364","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    dd if\u003d$MBR of\u003d$BOOT_DEV"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # Find any pre-created extlinux install directory"},{"line_number":34,"context_line":"    for EXTDIR in /boot/extlinux /boot/syslinux ; do"},{"line_number":35,"context_line":"        if [ -d $EXTDIR ] ; then"},{"line_number":36,"context_line":"            break"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"baada198_41d77623","line":33,"in_reply_to":"baada198_c191c69b","updated":"2014-07-02 12:16:49.000000000","message":"Actually above should change to \nEXTDIR\u003d`ls /boot/extlinux /boot/syslinux 2\u003e/dev/null || echo \"\"`","commit_id":"c74acfc3010227ae73944dc4fcecc70164db0d82"},{"author":{"_account_id":2036,"name":"Juerg Haefliger","email":"juerg.haefliger@hpe.com","username":"juergh"},"change_message_id":"c41bad96cfad24a162d4f7e548ae9a28011312db","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    dd if\u003d$MBR of\u003d$BOOT_DEV"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # Find any pre-created extlinux install directory"},{"line_number":34,"context_line":"    for EXTDIR in /boot/extlinux /boot/syslinux ; do"},{"line_number":35,"context_line":"        if [ -d $EXTDIR ] ; then"},{"line_number":36,"context_line":"            break"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"baada198_619aba64","line":33,"in_reply_to":"baada198_c191c69b","updated":"2014-07-02 12:23:25.000000000","message":"See above.","commit_id":"c74acfc3010227ae73944dc4fcecc70164db0d82"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"175c8d4c531714374a7172719bc749c792ef916a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"            break"},{"line_number":24,"context_line":"        fi"},{"line_number":25,"context_line":"    done"},{"line_number":26,"context_line":"    if [ ! -f $MBR ]; then"},{"line_number":27,"context_line":"        echo \"mbr.bin (from EXT/SYSLINUX) not found.\""},{"line_number":28,"context_line":"        exit 1"},{"line_number":29,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa98f980_14211f4d","line":26,"updated":"2014-09-02 20:29:47.000000000","message":"Apparently bash doesn\u0027t believe in variable scoping. :-)","commit_id":"340f38d014ee10c9e31832526460704c3e360cbb"}]}