)]}'
{"elements/centos7/element-deps":[{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"b71b574af07d646a83614e60dfc8ff331830e505","unresolved":false,"context_lines":[{"line_number":3,"context_line":"redhat-common"},{"line_number":4,"context_line":"rpm-distro"},{"line_number":5,"context_line":"source-repositories"},{"line_number":6,"context_line":"vm"},{"line_number":7,"context_line":"yum"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_f6c0b97d","line":6,"updated":"2014-07-15 07:17:12.000000000","message":"Why vm element as dependency? is centos not supposed to work as a partition image and so vm element is must..?","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"febdabbd13d1b9237cd956a25d2260e3c1020e88","unresolved":false,"context_lines":[{"line_number":3,"context_line":"redhat-common"},{"line_number":4,"context_line":"rpm-distro"},{"line_number":5,"context_line":"source-repositories"},{"line_number":6,"context_line":"vm"},{"line_number":7,"context_line":"yum"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_0df337a0","line":6,"in_reply_to":"baada198_f6c0b97d","updated":"2014-07-16 01:36:05.000000000","message":"Done","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ca53e593614a1bf345259988bffd678e729502ab","unresolved":false,"context_lines":[{"line_number":3,"context_line":"redhat-common"},{"line_number":4,"context_line":"rpm-distro"},{"line_number":5,"context_line":"source-repositories"},{"line_number":6,"context_line":"vm"},{"line_number":7,"context_line":"yum"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_87a90292","line":6,"in_reply_to":"baada198_f6c0b97d","updated":"2014-07-15 11:54:48.000000000","message":"I see what\u0027s going on here; I didn\u0027t realise extra elements were being specified on the command line to do various things.  The nodepool changes want a vm to upload to glance, so it adds \"vm\" to the creation cmdline for disk-image-builder.\n\ni.e., you\u0027re right, this shouldn\u0027t be here\n\n[1] https://review.openstack.org/#/c/88479/","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"}],"elements/centos7/install.d/00-install-cloud-init":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"286eca0212f95c13af2808691104bc9c1731fa37","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -eu"},{"line_number":4,"context_line":"set -o pipefail"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"install-packages cloud-init"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baada198_d0c7c062","line":6,"updated":"2014-07-17 15:57:23.000000000","message":"Is there not a centos cloud image that includes this already?!","commit_id":"5abb4a4f12d62f072e0902055e591ff9d0610174"}],"elements/centos7/pre-install.d/06-yum-repos":[{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"f89f3c61364ee2e1cf54a65c56aa517eca6e1313","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -o pipefail"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"cat \u003c\u003c EOF \u003e /etc/yum.repos.d/centos7-latest.repo"},{"line_number":7,"context_line":"[rhel7]"},{"line_number":8,"context_line":"name\u003dcentos7"},{"line_number":9,"context_line":"baseurl\u003dhttp://buildlogs.centos.org/centos/7/os/x86_64-latest/"},{"line_number":10,"context_line":"enabled\u003d1"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baada198_ed04f81a","line":7,"updated":"2014-07-23 17:51:40.000000000","message":"This should reference centos, not rhel","commit_id":"5abb4a4f12d62f072e0902055e591ff9d0610174"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"286eca0212f95c13af2808691104bc9c1731fa37","unresolved":false,"context_lines":[{"line_number":12,"context_line":"gpgcheck\u003d0"},{"line_number":13,"context_line":"EOF"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"cat \u003c\u003c EOF \u003e /etc/yum.repos.d/epel.repo"},{"line_number":16,"context_line":"[epel]"},{"line_number":17,"context_line":"name\u003dExtra Packages for Enterprise Linux 7 - \\$basearch"},{"line_number":18,"context_line":"mirrorlist\u003dhttps://mirrors.fedoraproject.org/metalink?repo\u003depel-7\u0026arch\u003d\\$basearch"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baada198_b076cc3d","line":15,"updated":"2014-07-17 15:57:23.000000000","message":"This is not related to your change, but we should probably move this to a separate \"epel\" element at some point.  People building images won\u0027t necessarily always want epel, although for tripleo we do need it.","commit_id":"5abb4a4f12d62f072e0902055e591ff9d0610174"}],"elements/centos7/pre-install.d/10-install-cloud-init":[{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"b71b574af07d646a83614e60dfc8ff331830e505","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -eu"},{"line_number":4,"context_line":"set -o pipefail"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"yum install -y cloud-init"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_36a6b1ab","line":6,"updated":"2014-07-15 07:17:12.000000000","message":"This is an install action that I think should be done in install.d hooks. And I guess we should use install-packages to install any packages so that it can get abstracted using map-packages..","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"febdabbd13d1b9237cd956a25d2260e3c1020e88","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -eu"},{"line_number":4,"context_line":"set -o pipefail"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"yum install -y cloud-init"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_6d611311","line":6,"in_reply_to":"baada198_36a6b1ab","updated":"2014-07-16 01:36:05.000000000","message":"Done","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"0e17d5c9dbf9f2c78f7cb50a11cf1b6741e4c606","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -eu"},{"line_number":4,"context_line":"set -o pipefail"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"yum install -y cloud-init"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_ec08ec2e","line":6,"in_reply_to":"baada198_36a6b1ab","updated":"2014-07-15 08:40:40.000000000","message":"I agree with Om, we should be using install-packages here.","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"}],"elements/centos7/root.d/10-centos7-cloud-image":[{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"0e17d5c9dbf9f2c78f7cb50a11cf1b6741e4c606","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ARCH\u003d\"x86_64\""},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DIB_LOCAL_IMAGE\u003d${DIB_LOCAL_IMAGE:-\"\"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if [ -n \"$DIB_LOCAL_IMAGE\" ]; then"},{"line_number":16,"context_line":"    IMAGE_LOCATION\u003d$DIB_LOCAL_IMAGE"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_c70a211f","line":13,"updated":"2014-07-15 08:40:40.000000000","message":"Nit: The \"\" is unneeded.","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"febdabbd13d1b9237cd956a25d2260e3c1020e88","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ARCH\u003d\"x86_64\""},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DIB_LOCAL_IMAGE\u003d${DIB_LOCAL_IMAGE:-\"\"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if [ -n \"$DIB_LOCAL_IMAGE\" ]; then"},{"line_number":16,"context_line":"    IMAGE_LOCATION\u003d$DIB_LOCAL_IMAGE"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_4ded2fb7","line":13,"in_reply_to":"baada198_c70a211f","updated":"2014-07-16 01:36:05.000000000","message":"Done","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"0e17d5c9dbf9f2c78f7cb50a11cf1b6741e4c606","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    # No need to copy a local image into the cache directory, so just specify"},{"line_number":18,"context_line":"    # the cached path as the original path."},{"line_number":19,"context_line":"    CACHED_IMAGE\u003d$IMAGE_LOCATION"},{"line_number":20,"context_line":"    BASE_IMAGE_FILE\u003d`basename $DIB_LOCAL_IMAGE`"},{"line_number":21,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    DIB_RELEASE\u003d${DIB_RELEASE:-latest}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_8704a915","line":20,"updated":"2014-07-15 08:40:40.000000000","message":"This is new code, please use $()","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"febdabbd13d1b9237cd956a25d2260e3c1020e88","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    # No need to copy a local image into the cache directory, so just specify"},{"line_number":18,"context_line":"    # the cached path as the original path."},{"line_number":19,"context_line":"    CACHED_IMAGE\u003d$IMAGE_LOCATION"},{"line_number":20,"context_line":"    BASE_IMAGE_FILE\u003d`basename $DIB_LOCAL_IMAGE`"},{"line_number":21,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    DIB_RELEASE\u003d${DIB_RELEASE:-latest}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_4d728f12","line":20,"in_reply_to":"baada198_8704a915","updated":"2014-07-16 01:36:05.000000000","message":"Done","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"8342602fab2feb9380a6b58c3edeec81116417c1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    BASE_IMAGE_FILE\u003d`basename $DIB_LOCAL_IMAGE`"},{"line_number":21,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    DIB_RELEASE\u003d${DIB_RELEASE:-latest}"},{"line_number":24,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://buildlogs.centos.org/centos/7/cloud}"},{"line_number":25,"context_line":"    BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-CentOS-7-Broken-20140620-Nightly.qcow2}"},{"line_number":26,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_b3272411","line":23,"updated":"2014-07-15 13:30:18.000000000","message":"Looks like DIB_RELEASE is not being used anywhere. Or was it meant to be used on L25.","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"febdabbd13d1b9237cd956a25d2260e3c1020e88","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    BASE_IMAGE_FILE\u003d`basename $DIB_LOCAL_IMAGE`"},{"line_number":21,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    DIB_RELEASE\u003d${DIB_RELEASE:-latest}"},{"line_number":24,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://buildlogs.centos.org/centos/7/cloud}"},{"line_number":25,"context_line":"    BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-CentOS-7-Broken-20140620-Nightly.qcow2}"},{"line_number":26,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_2d471bbe","line":23,"in_reply_to":"baada198_b3272411","updated":"2014-07-16 01:36:05.000000000","message":"Done; 25 modified to use this","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"286eca0212f95c13af2808691104bc9c1731fa37","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    BASE_IMAGE_FILE\u003d$(basename $DIB_LOCAL_IMAGE)"},{"line_number":21,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    DIB_RELEASE\u003d${DIB_RELEASE:-Broken-20140620-Nightly}"},{"line_number":24,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://buildlogs.centos.org/centos/7/cloud}"},{"line_number":25,"context_line":"    BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-CentOS-7-$DIB_RELEASE.qcow2}"},{"line_number":26,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baada198_d0da6016","line":23,"updated":"2014-07-17 15:57:23.000000000","message":"Broken?","commit_id":"5abb4a4f12d62f072e0902055e591ff9d0610174"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"4d3cab3491050193945f23a2c23b8da9c0195c16","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    BASE_IMAGE_FILE\u003d$(basename $DIB_LOCAL_IMAGE)"},{"line_number":21,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    DIB_RELEASE\u003d${DIB_RELEASE:-Broken-20140620-Nightly}"},{"line_number":24,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://buildlogs.centos.org/centos/7/cloud}"},{"line_number":25,"context_line":"    BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-CentOS-7-$DIB_RELEASE.qcow2}"},{"line_number":26,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baada198_722c4302","line":23,"in_reply_to":"baada198_d0da6016","updated":"2014-07-23 17:17:08.000000000","message":"Can this be \u0027automatically\u0027 generated, or is there any expectations once is not broken, to have a non \u0027date formated\u0027 name, like current in the ubuntu images?","commit_id":"5abb4a4f12d62f072e0902055e591ff9d0610174"}],"elements/redhat-common/bin/extract-image":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"5e41f5e216e58ebd3bdf915d5c917190dc4c0b65","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -x"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Intended to be called from the root.d cloud-image script as follows:"},{"line_number":4,"context_line":"# $TMP_HOOKS_PATH/bin/extract-image $BASE_IMAGE_FILE $BASE_IMAGE_TAR $IMAGE_LOCATION $CACHED_IMAGE"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_42427fab","line":1,"updated":"2014-07-15 09:22:39.000000000","message":"Randomly noticed this - a mistake?","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"febdabbd13d1b9237cd956a25d2260e3c1020e88","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -x"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Intended to be called from the root.d cloud-image script as follows:"},{"line_number":4,"context_line":"# $TMP_HOOKS_PATH/bin/extract-image $BASE_IMAGE_FILE $BASE_IMAGE_TAR $IMAGE_LOCATION $CACHED_IMAGE"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_ed51a364","line":1,"in_reply_to":"baada198_42427fab","updated":"2014-07-16 01:36:05.000000000","message":"Done","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"4f21c3ea172826727df6dbb0649ce5ed7277e0a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -x"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Intended to be called from the root.d cloud-image script as follows:"},{"line_number":4,"context_line":"# $TMP_HOOKS_PATH/bin/extract-image $BASE_IMAGE_FILE $BASE_IMAGE_TAR $IMAGE_LOCATION $CACHED_IMAGE"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_02232705","line":1,"in_reply_to":"baada198_42427fab","updated":"2014-07-15 09:23:45.000000000","message":"left-over debugging, will fix :)","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"0e17d5c9dbf9f2c78f7cb50a11cf1b6741e4c606","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # need to copy the contents of /boot into the image too, so"},{"line_number":78,"context_line":"        # mount it"},{"line_number":79,"context_line":"        if [[ $DISTRO_NAME \u003d\u003d \"centos7\" ]]; then"},{"line_number":80,"context_line":"            BOOT_LOOPDEV\u003d${ROOT_LOOPDEV/p3/p1}"},{"line_number":81,"context_line":"            sudo mount /dev/mapper/$BOOT_LOOPDEV $WORKING/mnt/boot"},{"line_number":82,"context_line":"            EACTION\u003d\"sudo umount -f $WORKING/mnt/boot;$EACTION\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_c7586133","line":79,"updated":"2014-07-15 08:40:40.000000000","message":"\u003d\u003d means substring search\n\nif [ $DISTRO_NAME \u003d \"centos7\" ]; then\n\nplease","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"febdabbd13d1b9237cd956a25d2260e3c1020e88","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # need to copy the contents of /boot into the image too, so"},{"line_number":78,"context_line":"        # mount it"},{"line_number":79,"context_line":"        if [[ $DISTRO_NAME \u003d\u003d \"centos7\" ]]; then"},{"line_number":80,"context_line":"            BOOT_LOOPDEV\u003d${ROOT_LOOPDEV/p3/p1}"},{"line_number":81,"context_line":"            sudo mount /dev/mapper/$BOOT_LOOPDEV $WORKING/mnt/boot"},{"line_number":82,"context_line":"            EACTION\u003d\"sudo umount -f $WORKING/mnt/boot;$EACTION\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_4d49afb6","line":79,"in_reply_to":"baada198_c7586133","updated":"2014-07-16 01:36:05.000000000","message":"Done","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"0e17d5c9dbf9f2c78f7cb50a11cf1b6741e4c606","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        if [[ $DISTRO_NAME \u003d\u003d \"centos7\" ]]; then"},{"line_number":80,"context_line":"            BOOT_LOOPDEV\u003d${ROOT_LOOPDEV/p3/p1}"},{"line_number":81,"context_line":"            sudo mount /dev/mapper/$BOOT_LOOPDEV $WORKING/mnt/boot"},{"line_number":82,"context_line":"            EACTION\u003d\"sudo umount -f $WORKING/mnt/boot;$EACTION\""},{"line_number":83,"context_line":"            trap \"$EACTION\" EXIT"},{"line_number":84,"context_line":"        fi"},{"line_number":85,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_e769e5be","line":82,"updated":"2014-07-15 08:40:40.000000000","message":"Nit: I\u0027d prefer white space around the ;","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"febdabbd13d1b9237cd956a25d2260e3c1020e88","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        if [[ $DISTRO_NAME \u003d\u003d \"centos7\" ]]; then"},{"line_number":80,"context_line":"            BOOT_LOOPDEV\u003d${ROOT_LOOPDEV/p3/p1}"},{"line_number":81,"context_line":"            sudo mount /dev/mapper/$BOOT_LOOPDEV $WORKING/mnt/boot"},{"line_number":82,"context_line":"            EACTION\u003d\"sudo umount -f $WORKING/mnt/boot;$EACTION\""},{"line_number":83,"context_line":"            trap \"$EACTION\" EXIT"},{"line_number":84,"context_line":"        fi"},{"line_number":85,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baada198_4de0cf96","line":82,"in_reply_to":"baada198_e769e5be","updated":"2014-07-16 01:36:05.000000000","message":"Done","commit_id":"053bc7cd97cd3e0e06987090a2b37d28ab1d9668"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"286eca0212f95c13af2808691104bc9c1731fa37","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # need to copy the contents of /boot into the image too, so"},{"line_number":78,"context_line":"        # mount it"},{"line_number":79,"context_line":"        if [[ $DISTRO_NAME \u003d \"centos7\" ]]; then"},{"line_number":80,"context_line":"            BOOT_LOOPDEV\u003d${ROOT_LOOPDEV/p3/p1}"},{"line_number":81,"context_line":"            sudo mount /dev/mapper/$BOOT_LOOPDEV $WORKING/mnt/boot"},{"line_number":82,"context_line":"            EACTION\u003d\"sudo umount -f $WORKING/mnt/boot ; $EACTION\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baada198_30f1dc6a","line":79,"updated":"2014-07-17 15:57:23.000000000","message":"[[ is generally frowned upon.  Single [ should be fine here.","commit_id":"5abb4a4f12d62f072e0902055e591ff9d0610174"}]}
