)]}'
{"bin/disk-image-create":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1cc74d770973583d0bfd49508b304be75279b301","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"arg_to_elements \"$@\""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"export IMAGE_NAME\u003d${IMAGE_NAME%%\\.${IMAGE_TYPE}}"},{"line_number":141,"context_line":"# FS_TYPE isn\u0027t available until after we source img-defaults"},{"line_number":142,"context_line":"if [ -z \"$DIB_ROOT_LABEL\" ]; then"},{"line_number":143,"context_line":"    # NOTE(bnemec): XFS has a limit of 12 characters for filesystem labels"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"baa201ad_437dd6e6","side":"PARENT","line":140,"updated":"2014-10-01 19:47:57.000000000","message":"See comment about backward compat.","commit_id":"de60893ccd78b35731828081e0aaa053676cbfed"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1cc74d770973583d0bfd49508b304be75279b301","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    echo \"Options:\""},{"line_number":46,"context_line":"    echo \"    -a i386|amd64|armhf -- set the architecture of the image(default amd64)\""},{"line_number":47,"context_line":"    echo \"    -o imagename -- set the imagename of the output image file(default image)\""},{"line_number":48,"context_line":"    echo \"       This name should not include the file extension suffix\""},{"line_number":49,"context_line":"    echo \"    -t qcow2,tar -- set the image types of the output image files (default qcow2)\""},{"line_number":50,"context_line":"    echo \"       File types should be comma separated\""},{"line_number":51,"context_line":"    echo \"    -x -- turn on tracing\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"baa201ad_c321c6fd","line":48,"updated":"2014-10-01 19:47:57.000000000","message":"This is not quite backward compatible.","commit_id":"86fc314af8750d7bb7104bd0f14297a35361701c"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"463fd8a8a32385f06c27c7aec118a7c16768b064","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    echo \"Options:\""},{"line_number":46,"context_line":"    echo \"    -a i386|amd64|armhf -- set the architecture of the image(default amd64)\""},{"line_number":47,"context_line":"    echo \"    -o imagename -- set the imagename of the output image file(default image)\""},{"line_number":48,"context_line":"    echo \"       This name should not include the file extension suffix\""},{"line_number":49,"context_line":"    echo \"    -t qcow2,tar -- set the image types of the output image files (default qcow2)\""},{"line_number":50,"context_line":"    echo \"       File types should be comma separated\""},{"line_number":51,"context_line":"    echo \"    -x -- turn on tracing\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"baa201ad_0f05af79","line":48,"in_reply_to":"baa201ad_c321c6fd","updated":"2014-10-01 22:51:04.000000000","message":"Why not leave that in for single type builds?","commit_id":"86fc314af8750d7bb7104bd0f14297a35361701c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ebe479f5c76c6099f4753123230431cb54dcf3c5","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    case \"$1\" in"},{"line_number":100,"context_line":"        -a) export ARCH\u003d$2; shift 2 ;;"},{"line_number":101,"context_line":"        -o) export IMAGE_NAME\u003d$2; shift 2 ;;"},{"line_number":102,"context_line":"        -t) IFS\u003d\",\" read -a IMAGE_TYPES \u003c\u003c\u003c \"$2\"; export IMAGE_TYPES ; shift 2 ;;"},{"line_number":103,"context_line":"        -h|--help) show_options; exit 0;;"},{"line_number":104,"context_line":"        -x) shift; set -x;;"},{"line_number":105,"context_line":"        -u) shift; export COMPRESS_IMAGE\u003d\"\";;"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"baa201ad_c441c93a","line":102,"updated":"2014-10-02 00:50:18.000000000","message":"Gotta love arrays in Bash...","commit_id":"86fc314af8750d7bb7104bd0f14297a35361701c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1cc74d770973583d0bfd49508b304be75279b301","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"if [ \"$IS_RAMDISK\" \u003d\u003d \"0\" ]; then"},{"line_number":223,"context_line":"  for IMAGE_TYPE in ${IMAGE_TYPES[@]} ; do"},{"line_number":224,"context_line":"    compress_and_save_image $IMAGE_NAME.$IMAGE_TYPE"},{"line_number":225,"context_line":"  done"},{"line_number":226,"context_line":"else"},{"line_number":227,"context_line":"  # This is a ramdisk build, we have already extracted the kernel and ramdisk"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"baa201ad_c368e623","line":224,"updated":"2014-10-01 19:47:57.000000000","message":"Compress_and_save_image needs to be updated so that it doens\u0027t nuke the raw image. Then that nuking will have to happen after this for loop.","commit_id":"86fc314af8750d7bb7104bd0f14297a35361701c"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"bb083d7ac2cd569dbd991e408fd290d97a9d076e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    case \"$1\" in"},{"line_number":100,"context_line":"        -a) export ARCH\u003d$2; shift 2 ;;"},{"line_number":101,"context_line":"        -o) export IMAGE_NAME\u003d$2; shift 2 ;;"},{"line_number":102,"context_line":"        -t) IFS\u003d\",\" read -a IMAGE_TYPES \u003c\u003c\u003c \"$2\"; export IMAGE_TYPES ; shift 2 ;;"},{"line_number":103,"context_line":"        -h|--help) show_options; exit 0;;"},{"line_number":104,"context_line":"        -x) shift; set -x;;"},{"line_number":105,"context_line":"        -u) shift; export COMPRESS_IMAGE\u003d\"\";;"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baa201ad_c016f5a6","line":102,"updated":"2014-10-03 07:00:16.000000000","message":"Shouldn\u0027t we restore IFS after this?","commit_id":"0a2f1c45e7ec66d150e16bec834e36c45c9912f7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bdf06dcd4489da1339b9f75fa3550ea51b01134f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    case \"$1\" in"},{"line_number":100,"context_line":"        -a) export ARCH\u003d$2; shift 2 ;;"},{"line_number":101,"context_line":"        -o) export IMAGE_NAME\u003d$2; shift 2 ;;"},{"line_number":102,"context_line":"        -t) IFS\u003d\",\" read -a IMAGE_TYPES \u003c\u003c\u003c \"$2\"; export IMAGE_TYPES ; shift 2 ;;"},{"line_number":103,"context_line":"        -h|--help) show_options; exit 0;;"},{"line_number":104,"context_line":"        -x) shift; set -x;;"},{"line_number":105,"context_line":"        -u) shift; export COMPRESS_IMAGE\u003d\"\";;"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baa201ad_87b79539","line":102,"in_reply_to":"baa201ad_7ad96921","updated":"2014-10-03 16:55:37.000000000","message":"Same process is used for -p below too.","commit_id":"0a2f1c45e7ec66d150e16bec834e36c45c9912f7"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"5fe0a501172b54b6d95d74f9508980e5ade89dd3","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    case \"$1\" in"},{"line_number":100,"context_line":"        -a) export ARCH\u003d$2; shift 2 ;;"},{"line_number":101,"context_line":"        -o) export IMAGE_NAME\u003d$2; shift 2 ;;"},{"line_number":102,"context_line":"        -t) IFS\u003d\",\" read -a IMAGE_TYPES \u003c\u003c\u003c \"$2\"; export IMAGE_TYPES ; shift 2 ;;"},{"line_number":103,"context_line":"        -h|--help) show_options; exit 0;;"},{"line_number":104,"context_line":"        -x) shift; set -x;;"},{"line_number":105,"context_line":"        -u) shift; export COMPRESS_IMAGE\u003d\"\";;"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baa201ad_efb4a836","line":102,"in_reply_to":"baa201ad_87b79539","updated":"2014-10-05 23:21:31.000000000","message":"Ah, derp. Sorry :)","commit_id":"0a2f1c45e7ec66d150e16bec834e36c45c9912f7"},{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"4dbe1d12fa32b779358d3d78b230b12645505214","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    case \"$1\" in"},{"line_number":100,"context_line":"        -a) export ARCH\u003d$2; shift 2 ;;"},{"line_number":101,"context_line":"        -o) export IMAGE_NAME\u003d$2; shift 2 ;;"},{"line_number":102,"context_line":"        -t) IFS\u003d\",\" read -a IMAGE_TYPES \u003c\u003c\u003c \"$2\"; export IMAGE_TYPES ; shift 2 ;;"},{"line_number":103,"context_line":"        -h|--help) show_options; exit 0;;"},{"line_number":104,"context_line":"        -x) shift; set -x;;"},{"line_number":105,"context_line":"        -u) shift; export COMPRESS_IMAGE\u003d\"\";;"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baa201ad_7ad96921","line":102,"in_reply_to":"baa201ad_c016f5a6","updated":"2014-10-03 16:01:41.000000000","message":"The IFS value isn\u0027t being exported, it\u0027s only being used by the read command.","commit_id":"0a2f1c45e7ec66d150e16bec834e36c45c9912f7"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"bb083d7ac2cd569dbd991e408fd290d97a9d076e","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"arg_to_elements \"$@\""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [ \"${#IMAGE_TYPES[@]}\" \u003d \"1\" ]; then"},{"line_number":143,"context_line":"  export IMAGE_NAME\u003d${IMAGE_NAME%%\\.${IMAGE_TYPES[0]}}"},{"line_number":144,"context_line":"fi"},{"line_number":145,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baa201ad_e03cd9e4","line":142,"updated":"2014-10-03 07:00:16.000000000","message":"This is technically a backwards incompat change (sorry to be *that* reviewer). If we\u0027re ok with that, then I think the behavior of only exporting this var when one type is specified seems less than useful. How about making this just be IMAGE_BASENAME?","commit_id":"0a2f1c45e7ec66d150e16bec834e36c45c9912f7"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"5fe0a501172b54b6d95d74f9508980e5ade89dd3","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"arg_to_elements \"$@\""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [ \"${#IMAGE_TYPES[@]}\" \u003d \"1\" ]; then"},{"line_number":143,"context_line":"  export IMAGE_NAME\u003d${IMAGE_NAME%%\\.${IMAGE_TYPES[0]}}"},{"line_number":144,"context_line":"fi"},{"line_number":145,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baa201ad_6f80b846","line":142,"in_reply_to":"baa201ad_2780a945","updated":"2014-10-05 23:21:31.000000000","message":"We chatted in IRC about this but codifying it here:\nThe backwards incompat detail here is that the var isnt exported any more when multiple image types are specified. Tthis basically makes this variable useless (an element which wanted to use it would have to detect whether its set, and if not compute it manually). Seems like the sensible thing to do here is just export the basename for the image. IMO if were changing the data format we should change the variable name as well so when users are expecting the old format errors are manifested as variable undefined rather than data corruption bugs.","commit_id":"0a2f1c45e7ec66d150e16bec834e36c45c9912f7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e675be82af75c0983743e696dca72092429163d2","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"arg_to_elements \"$@\""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [ \"${#IMAGE_TYPES[@]}\" \u003d \"1\" ]; then"},{"line_number":143,"context_line":"  export IMAGE_NAME\u003d${IMAGE_NAME%%\\.${IMAGE_TYPES[0]}}"},{"line_number":144,"context_line":"fi"},{"line_number":145,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baa201ad_f2d3805d","line":142,"in_reply_to":"baa201ad_6f80b846","updated":"2014-10-07 15:27:35.000000000","message":"It is exported though on line 101. (I honestly have no idea why this code even existed in the first place [here let me take that name you gave me and modify it because you the user must not know what you are doing]).\n\nSo the backward incompat is more subtle that you ahve stated. The only difference is that when using new behavior you will not get the file extension removed. I don\u0027t consider that backward incompatibility because it only happens with new functionality. All existing dib builds with a single image output should continue to work as before.","commit_id":"0a2f1c45e7ec66d150e16bec834e36c45c9912f7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bdf06dcd4489da1339b9f75fa3550ea51b01134f","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"arg_to_elements \"$@\""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [ \"${#IMAGE_TYPES[@]}\" \u003d \"1\" ]; then"},{"line_number":143,"context_line":"  export IMAGE_NAME\u003d${IMAGE_NAME%%\\.${IMAGE_TYPES[0]}}"},{"line_number":144,"context_line":"fi"},{"line_number":145,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baa201ad_2780a945","line":142,"in_reply_to":"baa201ad_e03cd9e4","updated":"2014-10-03 16:55:37.000000000","message":"In a previous patchset SpampS proposed this method of maintaining backward compat for the single image case.","commit_id":"0a2f1c45e7ec66d150e16bec834e36c45c9912f7"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"08a567398d7d7c38386c4740412c5315ef2998bf","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"arg_to_elements \"$@\""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [ \"${#IMAGE_TYPES[@]}\" \u003d \"1\" ]; then"},{"line_number":143,"context_line":"  export IMAGE_NAME\u003d${IMAGE_NAME%%\\.${IMAGE_TYPES[0]}}"},{"line_number":144,"context_line":"fi"},{"line_number":145,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"baa201ad_44572302","line":142,"in_reply_to":"baa201ad_f2d3805d","updated":"2014-10-07 20:25:17.000000000","message":"aha! didnt see the line 101 bit. This code should totally get removed / consolidated but not a problem for this patch. Sorry for the derpage.","commit_id":"0a2f1c45e7ec66d150e16bec834e36c45c9912f7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6fe05c09d64e5e097a873a1fd8edd2a2916c5f3e","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    sudo tar -C ${TMP_BUILD_DIR}/mnt -cf $IMAGE_NAME.tar --exclude ./sys \\"},{"line_number":218,"context_line":"             --exclude ./proc --xattrs --xattrs-include\u003d\\* ."},{"line_number":219,"context_line":"    sudo chown $USER: $IMAGE_NAME.tar"},{"line_number":220,"context_line":"    unset IMAGE_TYPES[$X]"},{"line_number":221,"context_line":"  fi"},{"line_number":222,"context_line":"done"},{"line_number":223,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"baa201ad_7005ec0f","line":220,"updated":"2014-10-15 19:28:11.000000000","message":"This line here is what prevents what greghaynes describes below. We remove tar from the array of types as we have already completed the work necessary to make the tar happen.","commit_id":"ae928057bd2fc2205c91bf052d5503de64f9ea69"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"a6d2371caed2ab86371daaee2df39287c3474c5e","unresolved":false,"context_lines":[{"line_number":224,"context_line":"unmount_image"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"if [ \"$IS_RAMDISK\" \u003d\u003d \"0\" ]; then"},{"line_number":227,"context_line":"  for IMAGE_TYPE in ${IMAGE_TYPES[@]} ; do"},{"line_number":228,"context_line":"    compress_and_save_image $IMAGE_NAME.$IMAGE_TYPE"},{"line_number":229,"context_line":"  done"},{"line_number":230,"context_line":"  rm $TMP_IMAGE_PATH"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"baa201ad_e37bdfbb","line":227,"updated":"2014-10-15 16:24:14.000000000","message":"If we specified to build a tar image this looks like it will now call compress_and_save_image with IMAGE_TYPE\u003dtar? If so, the qemu-img convert should fail in that function.","commit_id":"ae928057bd2fc2205c91bf052d5503de64f9ea69"}],"lib/common-functions":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"e3e815fbba8623e4debedde2be1c3b89e5368700","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    mv $OUT_IMAGE_PATH $1"},{"line_number":54,"context_line":"    # All done!"},{"line_number":55,"context_line":"    trap EXIT"},{"line_number":56,"context_line":"    echo \"Image file $1 created...\""},{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"baa201ad_89046ac7","line":55,"updated":"2014-10-10 17:23:55.000000000","message":"I\u0027m thinking we don\u0027t want to do this here anymore either.  If a subsequent image failed we might end up with the build directories not getting unmounted.","commit_id":"0a2f1c45e7ec66d150e16bec834e36c45c9912f7"}]}
