)]}'
{"elements/deploy-ironic/init.d/80-deploy-ironic":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"29922b3e39041b77a213ccd2f1a4ac78c6fb2cca","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    # We need to run partprobe to ensure all partitions are visible"},{"line_number":69,"context_line":"    partprobe $target_disk"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    # root partition is always the last partition of the disk"},{"line_number":72,"context_line":"    readonly root_part\u003d$(ls $target_disk* | tr \" \" \"\\n\" | tail -n1)"},{"line_number":73,"context_line":"    readonly root_part_mount\u003d$(mktemp -d)"},{"line_number":74,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3a961159_1229ac3a","line":71,"updated":"2015-01-09 15:04:06.000000000","message":"how does it play with your root hint work?","commit_id":"5c5bdb0eca4943bbc2239e6e4dfcec7ef29e63e3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f022fbe20ac23ac66eecaff78a66115de88934cd","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    # We need to run partprobe to ensure all partitions are visible"},{"line_number":69,"context_line":"    partprobe $target_disk"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    # root partition is always the last partition of the disk"},{"line_number":72,"context_line":"    readonly root_part\u003d$(ls $target_disk* | tr \" \" \"\\n\" | tail -n1)"},{"line_number":73,"context_line":"    readonly root_part_mount\u003d$(mktemp -d)"},{"line_number":74,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3a961159_4097deeb","line":71,"in_reply_to":"3a961159_1229ac3a","updated":"2015-01-09 16:17:47.000000000","message":"It\u0027s fine because the root device hints will populate the $target_disk [1]. And when partioning the disk Ironic always put the root partition as the last partition of the disk so it can be extended until the end of the disk by cloud-init (growpart)\n\n[1] https://review.openstack.org/#/c/142178/2/elements/deploy-ironic/init.d/80-deploy-ironic","commit_id":"5c5bdb0eca4943bbc2239e6e4dfcec7ef29e63e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"29922b3e39041b77a213ccd2f1a4ac78c6fb2cca","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    mount -o bind /sys $root_part_mount/sys"},{"line_number":80,"context_line":"    mount -o bind /proc $root_part_mount/proc"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # TODO(lucasagomes): Add extlinux as a fallback"},{"line_number":83,"context_line":"    # Find grub version"},{"line_number":84,"context_line":"    V\u003d"},{"line_number":85,"context_line":"    if [ -x $root_part_mount/usr/sbin/grub2-install ]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3a961159_b2753835","line":82,"updated":"2015-01-09 15:04:06.000000000","message":"I guess this can actually wait","commit_id":"5c5bdb0eca4943bbc2239e6e4dfcec7ef29e63e3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f022fbe20ac23ac66eecaff78a66115de88934cd","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    mount -o bind /sys $root_part_mount/sys"},{"line_number":80,"context_line":"    mount -o bind /proc $root_part_mount/proc"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # TODO(lucasagomes): Add extlinux as a fallback"},{"line_number":83,"context_line":"    # Find grub version"},{"line_number":84,"context_line":"    V\u003d"},{"line_number":85,"context_line":"    if [ -x $root_part_mount/usr/sbin/grub2-install ]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3a961159_007b16bf","line":82,"in_reply_to":"3a961159_b2753835","updated":"2015-01-09 16:17:47.000000000","message":"Yeah, just added the TODO so we don\u0027t forget :)","commit_id":"5c5bdb0eca4943bbc2239e6e4dfcec7ef29e63e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cdf78dfb553a66e600b2e15fd387b38c0a09c715","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    # Install grub"},{"line_number":90,"context_line":"    ret\u003d1"},{"line_number":91,"context_line":"    if chroot $root_part_mount /bin/bash -c \"/usr/sbin/grub$V-install ${target_disk}\"; then"},{"line_number":92,"context_line":"        echo \"Generating the grub configuration file\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        # tell GRUB2 to preload its \"lvm\" module to gain LVM booting on direct-attached disks"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"da86d52c_0f43e014","line":91,"updated":"2015-02-03 14:48:21.000000000","message":"not sure you need /bin/bash here, why not just:\n\n chroot $root_part_mount grub$V-install ${target_disk}","commit_id":"9880d16d47aad92b625e543ede2590c058bcea14"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"6d4430494c69f0c7dd36e68238d71adbb1de1be8","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        # tell GRUB2 to preload its \"lvm\" module to gain LVM booting on direct-attached disks"},{"line_number":95,"context_line":"        if [ \"$V\" \u003d \"2\" ]; then"},{"line_number":96,"context_line":"            echo \"GRUB_PRELOAD_MODULES\u003dlvm\" \u003e\u003e $root_part_mount/etc/default/grub"},{"line_number":97,"context_line":"        fi"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        chroot $root_part_mount /bin/bash -c \"/usr/sbin/grub$V-mkconfig -o /boot/grub$V/grub.cfg\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"da86d52c_cb0e7c32","line":96,"updated":"2015-02-06 22:20:46.000000000","message":"This could break if another element wants to set GRUB_PRELOAD_MODULES.  I would guess grub is not going to be smart enough to append multiple entries.\n\nThat said, I don\u0027t see anything setting this today so we can cross that bridge when we burn it.","commit_id":"9880d16d47aad92b625e543ede2590c058bcea14"}]}