)]}'
{"elements/dracut-ramdisk/README.rst":[{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"76f85a7e94e91829b5ab0326866e9d8260174328","unresolved":false,"context_lines":[{"line_number":12,"context_line":"fashion to the binary-deps.d feature.  The element needing to"},{"line_number":13,"context_line":"add drivers should create a dracut-drivers.d directory and"},{"line_number":14,"context_line":"populate it with a single file listing all of the kernel modules"},{"line_number":15,"context_line":"it needs added to the ramdisk.  Comments are not supported in this"},{"line_number":16,"context_line":"file.  Note that these modules must be installed in the chroot first."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"By default, the virtio, virtio_net, and virtio_blk modules are"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da86d52c_4287a6d7","line":15,"updated":"2015-02-15 19:06:26.000000000","message":"Is this an intended double space ? Just a suggestion, it might look good if these points are brought under a notes head in this document.","commit_id":"f689c6051d2d0d3a1fa885cc262a6b997b9f11ee"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"a4944b9e00122221970a989bf15bdcddded9c951","unresolved":false,"context_lines":[{"line_number":12,"context_line":"fashion to the binary-deps.d feature.  The element needing to"},{"line_number":13,"context_line":"add drivers should create a dracut-drivers.d directory and"},{"line_number":14,"context_line":"populate it with a single file listing all of the kernel modules"},{"line_number":15,"context_line":"it needs added to the ramdisk.  Comments are not supported in this"},{"line_number":16,"context_line":"file.  Note that these modules must be installed in the chroot first."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"By default, the virtio, virtio_net, and virtio_blk modules are"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da86d52c_3c0472c5","line":15,"in_reply_to":"da86d52c_4287a6d7","updated":"2015-02-16 21:03:31.000000000","message":"Habit.  I learned to type back when they were still recommending two spaces between sentences. :-)","commit_id":"f689c6051d2d0d3a1fa885cc262a6b997b9f11ee"}],"elements/dracut-ramdisk/post-install.d/01-ensure-drivers":[{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"d2b45a5178e54f4bddf2298e3ecb53518da88d5e","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"EXTRA_DRIVERS\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"for _FILE in $(ls ${TARGET_DIR}/binary-deps.d/) ; do"},{"line_number":11,"context_line":"    _FILE\u003d\"${TARGET_DIR}/dracut-drivers.d/${_FILE}\""},{"line_number":12,"context_line":"    if [ -a $_FILE ]; then"},{"line_number":13,"context_line":"        for _LINE in $(cat $_FILE) ; do"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da86d52c_195d3722","line":10,"updated":"2015-02-02 08:11:28.000000000","message":"I suspect you mean dracut-drivers.d here, rather than binary-deps.d","commit_id":"b038e67db0ad3c0a6fd25e003372714abd047060"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"1e7f5cd7190b0faea999bdb5175a5b2d8d32169e","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"EXTRA_DRIVERS\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"for _FILE in $(ls ${TARGET_DIR}/binary-deps.d/) ; do"},{"line_number":11,"context_line":"    _FILE\u003d\"${TARGET_DIR}/dracut-drivers.d/${_FILE}\""},{"line_number":12,"context_line":"    if [ -a $_FILE ]; then"},{"line_number":13,"context_line":"        for _LINE in $(cat $_FILE) ; do"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da86d52c_5f53b3e1","line":10,"in_reply_to":"da86d52c_195d3722","updated":"2015-02-03 22:18:17.000000000","message":"Huh, I have no idea how that made it in here.  I had to have fixed it locally before this would work, and it was working before I pushed this change. :-/\n\nAnyway, will be fixed in the next patch set.","commit_id":"b038e67db0ad3c0a6fd25e003372714abd047060"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"c6fed5edaf2844ef4beb17c0a3e726d369cc40ef","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"EXTRA_DRIVERS\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"for _FILE in $(ls ${TARGET_DIR}/binary-deps.d/) ; do"},{"line_number":11,"context_line":"    _FILE\u003d\"${TARGET_DIR}/dracut-drivers.d/${_FILE}\""},{"line_number":12,"context_line":"    if [ -a $_FILE ]; then"},{"line_number":13,"context_line":"        for _LINE in $(cat $_FILE) ; do"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da86d52c_bfe4afe1","line":10,"in_reply_to":"da86d52c_5f53b3e1","updated":"2015-02-03 22:25:34.000000000","message":"Oh, I accidentally committed the fix as part of the next commit: https://review.openstack.org/#/c/151779/2/elements/dracut-ramdisk/post-install.d/01-ensure-drivers\n\nAt least I\u0027m not losing my mind. :-)","commit_id":"b038e67db0ad3c0a6fd25e003372714abd047060"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"d2b45a5178e54f4bddf2298e3ecb53518da88d5e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"done"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"if [ \"$EXTRA_DRIVERS\" \u003d\u003d \"\" ]; then"},{"line_number":28,"context_line":"    echo \"No extra drivers found\""},{"line_number":29,"context_line":"else"},{"line_number":30,"context_line":"    DRIVERS_OUTPUT\u003d\"/etc/dib_dracut_drivers\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da86d52c_39411b3a","line":27,"updated":"2015-02-02 08:11:28.000000000","message":"Nit: I\u0027d prefer a single \u003d here.","commit_id":"b038e67db0ad3c0a6fd25e003372714abd047060"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"1e7f5cd7190b0faea999bdb5175a5b2d8d32169e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"done"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"if [ \"$EXTRA_DRIVERS\" \u003d\u003d \"\" ]; then"},{"line_number":28,"context_line":"    echo \"No extra drivers found\""},{"line_number":29,"context_line":"else"},{"line_number":30,"context_line":"    DRIVERS_OUTPUT\u003d\"/etc/dib_dracut_drivers\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da86d52c_df56c3cd","line":27,"in_reply_to":"da86d52c_39411b3a","updated":"2015-02-03 22:18:17.000000000","message":"I blame the person I copy-pasted this from. ;-)","commit_id":"b038e67db0ad3c0a6fd25e003372714abd047060"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"fb5c0d437abe2547a6f018aead313218934eb37b","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"for _FILE in $(ls ${TARGET_DIR}/dracut-drivers.d/) ; do"},{"line_number":11,"context_line":"    _FILE\u003d\"${TARGET_DIR}/dracut-drivers.d/${_FILE}\""},{"line_number":12,"context_line":"    if [ -a $_FILE ]; then"},{"line_number":13,"context_line":"        for _LINE in $(cat $_FILE) ; do"},{"line_number":14,"context_line":"            EXTRA_DRIVERS\u003d\"${EXTRA_DRIVERS} $_LINE\""},{"line_number":15,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da86d52c_45df5d69","line":12,"updated":"2015-02-04 02:52:47.000000000","message":"I don\u0027t think you mean -a here, perhaps -f or -s?","commit_id":"5daba6b8abd9802b321b3724c11544e86994df07"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"f983f171fa95332cc65fd38b2241e17e9753a666","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"for _FILE in $(ls ${TARGET_DIR}/dracut-drivers.d/) ; do"},{"line_number":11,"context_line":"    _FILE\u003d\"${TARGET_DIR}/dracut-drivers.d/${_FILE}\""},{"line_number":12,"context_line":"    if [ -a $_FILE ]; then"},{"line_number":13,"context_line":"        for _LINE in $(cat $_FILE) ; do"},{"line_number":14,"context_line":"            EXTRA_DRIVERS\u003d\"${EXTRA_DRIVERS} $_LINE\""},{"line_number":15,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da86d52c_3b60b3a4","line":12,"in_reply_to":"da86d52c_45df5d69","updated":"2015-02-04 16:08:23.000000000","message":"Done","commit_id":"5daba6b8abd9802b321b3724c11544e86994df07"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"e43065c5739c7b7e4ecd75b1de2b9a489675c0d2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    if [ -s $_FILE ]; then"},{"line_number":13,"context_line":"        for _LINE in $(cat $_FILE) ; do"},{"line_number":14,"context_line":"            EXTRA_DRIVERS\u003d\"${EXTRA_DRIVERS} $_LINE\""},{"line_number":15,"context_line":"        done"},{"line_number":16,"context_line":"    fi"},{"line_number":17,"context_line":"done"},{"line_number":18,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ba7be1f8_32622d17","line":15,"updated":"2015-02-26 23:19:07.000000000","message":"This is some crazy logic for what can be done with:\n\n    EXTRA_DRIVERS\u003d$(cat ${TARGET_DIR}/dracut-drivers.d/* | xargs echo)\n\nDid I miss something?","commit_id":"f689c6051d2d0d3a1fa885cc262a6b997b9f11ee"}]}