)]}'
{"bin/disk-image-create":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"00ef5cf16942ffcccbdca2c6bf525fac5dd3cc31","unresolved":false,"context_lines":[{"line_number":244,"context_line":"      sudo tar -C ${TMP_BUILD_DIR}/mnt -cf $IMAGE_NAME.tar --exclude ./sys \\"},{"line_number":245,"context_line":"               --exclude ./proc --xattrs --xattrs-include\u003d\\* \\"},{"line_number":246,"context_line":"               --transform \u0027s,^.,rootfs,S\u0027 ."},{"line_number":247,"context_line":"      cp $ACI_MANIFEST ${TMP_BUILD_DIR}/manifest"},{"line_number":248,"context_line":"      sudo tar -C ${TMP_BUILD_DIR} --append -f $IMAGE_NAME.aci manifest"},{"line_number":249,"context_line":"    else"},{"line_number":250,"context_line":"      sudo tar -C ${TMP_BUILD_DIR}/mnt -cf $IMAGE_NAME.tar --exclude ./sys \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da9b358b_f0852059","line":247,"updated":"2015-03-31 12:11:09.000000000","message":"it might be worth adding a check that $ACI_MANIFEST is not null since it\u0027s expected to be","commit_id":"7cfffa8c3d595000f70f95049f339b47268e230c"},{"author":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"change_message_id":"9ef84a0bee6ba68eda24487703650a1531f7c057","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1aca2d91_504a88c6","side":"PARENT","updated":"2015-05-07 16:19:03.000000000","message":"bariable -\u003e variable","commit_id":"362cb398c82448cccd04a937d72bb89c2f24554d"},{"author":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"change_message_id":"9ef84a0bee6ba68eda24487703650a1531f7c057","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1aca2d91_703b4439","side":"PARENT","updated":"2015-05-07 16:19:03.000000000","message":"bariable -\u003e variable","commit_id":"362cb398c82448cccd04a937d72bb89c2f24554d"},{"author":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"change_message_id":"9ef84a0bee6ba68eda24487703650a1531f7c057","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    echo \"    -o imagename -- set the imagename of the output image file(default image)\""},{"line_number":48,"context_line":"    echo \"    -t qcow2,tar,vhd,raw -- set the image types of the output image files (default qcow2)\""},{"line_number":49,"context_line":"    echo \"       File types should be comma separated. VHD outputting requires the vhd-util\""},{"line_number":50,"context_line":"    echo \"       executable be in your PATH.\""},{"line_number":51,"context_line":"    echo \"    -x -- turn on tracing\""},{"line_number":52,"context_line":"    echo \"    -u -- uncompressed; do not compress the image - larger but faster\""},{"line_number":53,"context_line":"    echo \"    -c -- clear environment before starting work\""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"1aca2d91_3045ccb2","side":"PARENT","line":50,"updated":"2015-05-07 16:19:03.000000000","message":"do we need to mention that vhd-util needs to be patched to support the \"convert\" command? (or has that landed upstream since I last looked?","commit_id":"362cb398c82448cccd04a937d72bb89c2f24554d"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"e21783640a4fc4df8c6a2aeddfffe532440a96af","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    echo \"    -o imagename -- set the imagename of the output image file(default image)\""},{"line_number":48,"context_line":"    echo \"    -t qcow2,tar,vhd,raw -- set the image types of the output image files (default qcow2)\""},{"line_number":49,"context_line":"    echo \"       File types should be comma separated. VHD outputting requires the vhd-util\""},{"line_number":50,"context_line":"    echo \"       executable be in your PATH.\""},{"line_number":51,"context_line":"    echo \"    -x -- turn on tracing\""},{"line_number":52,"context_line":"    echo \"    -u -- uncompressed; do not compress the image - larger but faster\""},{"line_number":53,"context_line":"    echo \"    -c -- clear environment before starting work\""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"1aca2d91_50596859","side":"PARENT","line":50,"in_reply_to":"1aca2d91_3045ccb2","updated":"2015-05-07 16:23:26.000000000","message":"Different patch, this one is for adding ACI support. We have a note below about needing the patched vhd-util, though.","commit_id":"362cb398c82448cccd04a937d72bb89c2f24554d"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"503909702566e5a0b4dec1b1a4294278e1abc77d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"COMPRESS_IMAGE\u003d\"true\""},{"line_number":102,"context_line":"export DIB_ROOT_LABEL\u003d\"\""},{"line_number":103,"context_line":"DIB_DEFAULT_INSTALLTYPE\u003d${DIB_DEFAULT_INSTALLTYPE:-\"source\"}"},{"line_number":104,"context_line":"MKFS_OPTS\u003d\"\""},{"line_number":105,"context_line":"TEMP\u003d`getopt -o a:ho:t:xucnp: -l no-tmpfs,offline,help,min-tmpfs:,image-size:,image-cache:,max-online-resize:,mkfs-options:,qemu-img-options:,ramdisk-element:,root-label:,install-type: -n $SCRIPTNAME -- \"$@\"`"},{"line_number":106,"context_line":"if [ $? -ne 0 ] ; then echo \"Terminating...\" \u003e\u00262 ; exit 1 ; fi"},{"line_number":107,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"9a0c5dc1_5b79ccfb","side":"PARENT","line":104,"updated":"2015-05-12 14:42:30.000000000","message":"You are dropping this line...","commit_id":"362cb398c82448cccd04a937d72bb89c2f24554d"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"503909702566e5a0b4dec1b1a4294278e1abc77d","unresolved":false,"context_lines":[{"line_number":268,"context_line":"finalise_base"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"for X in ${!IMAGE_TYPES[@]} ; do"},{"line_number":271,"context_line":"  if [[ \" tar aci \" \u003d~ \"${IMAGE_TYPES[$X]}\" ]]; then"},{"line_number":272,"context_line":"    if [ \"${IMAGE_TYPES[$X]}\" \u003d \"aci\" ]; then"},{"line_number":273,"context_line":"      sudo tar -C ${TMP_BUILD_DIR}/mnt -cf $IMAGE_NAME.aci --exclude ./sys \\"},{"line_number":274,"context_line":"               --exclude ./proc --xattrs --xattrs-include\u003d\\* \\"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"9a0c5dc1_9bfce43f","line":271,"updated":"2015-05-12 14:42:30.000000000","message":"Sounds like you should save ${IMAGE_TYPES[$X]} in an own variable, otherwise it\u0027s copy\u0026paste of array lookup every time.","commit_id":"42a571dd7cefe07773ac24b79f976ba4ffa58c89"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"e76ef0a0863c693c2a133e52ed2b10894975931e","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"for X in ${!IMAGE_TYPES[@]} ; do"},{"line_number":284,"context_line":"  if [[ \" tar aci \" \u003d~ \"${IMAGE_TYPES[$X]}\" ]]; then"},{"line_number":285,"context_line":"    if [ \"${IMAGE_TYPES[$X]}\" \u003d \"aci\" ]; then"},{"line_number":286,"context_line":"      sudo tar -C ${TMP_BUILD_DIR}/mnt -cf $IMAGE_NAME.aci --exclude ./sys \\"},{"line_number":287,"context_line":"               --exclude ./proc --xattrs --xattrs-include\u003d\\* \\"},{"line_number":288,"context_line":"               --transform \u0027s,^.,rootfs,S\u0027 ."}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"da20952f_dbf61ef9","line":285,"updated":"2015-09-01 16:48:40.000000000","message":"Weird bash/non-bash mix here. [[ above, but [ below, and then the \u003d\u003d was changed to \u003d. Just strikes me as confusing, not as a bug.","commit_id":"eb6a260a5a81cd1135acb42d4b4769ac9935347c"}]}
