)]}'
{"elements/cloud-instance-simple-config/README.rst":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"59e5d252e7512d774d88157c5b588537c7a93ab8","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Several basic tasks that equalize us across different environments."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Autodetect network interfaces during boot and configure them"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The rationale for this is that we are likely to require multiple"},{"line_number":11,"context_line":"network interfaces for use cases such as baremetal and there is no way"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a6ced46_ee4ca5a0","line":8,"updated":"2015-03-25 18:39:58.000000000","message":"The three things above are all quite vague to be left alone as paragraphs, but would work as a bulleted list or a brief summary paragraph, perhaps with complete sentences. Anyway, I think it is a net-zero to clarity right now, and could be better, so I\u0027m o-k if it doesn\u0027t get any improvement before merge.","commit_id":"1f46aba076ceee591d8309062012b468942c5242"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"59e5d252e7512d774d88157c5b588537c7a93ab8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"DHCP client on all interfaces with real MAC addresses (except lo) that"},{"line_number":14,"context_line":"are visible on the first boot."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The script /usr/local/sbin/dhcp-all-interfaces.sh will be called"},{"line_number":17,"context_line":"early in each boot and will scan available network interfaces and"},{"line_number":18,"context_line":"ensure they are configured properly before networking services are started."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a6ced46_19c949ac","line":16,"updated":"2015-03-25 18:39:58.000000000","message":"Graves for the script path will help highlight it. so `/usr/local/sbin/dhcp-all-interfaces.sh`","commit_id":"1f46aba076ceee591d8309062012b468942c5242"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"59e5d252e7512d774d88157c5b588537c7a93ab8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"early in each boot and will scan available network interfaces and"},{"line_number":18,"context_line":"ensure they are configured properly before networking services are started."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Processing startup information from config-drive"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"On most systems, that\u0027s fine. But in Rackspace cloud, there is no DHCP there."},{"line_number":23,"context_line":"Instead, there is static network config via config-drive. dhcp-all-interfaces"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a6ced46_196dc9cc","line":20,"updated":"2015-03-25 18:39:58.000000000","message":"I think this might need an underline as a sub-section?","commit_id":"1f46aba076ceee591d8309062012b468942c5242"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"59e5d252e7512d774d88157c5b588537c7a93ab8","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Processing startup information from config-drive"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"On most systems, that\u0027s fine. But in Rackspace cloud, there is no DHCP there."},{"line_number":23,"context_line":"Instead, there is static network config via config-drive. dhcp-all-interfaces"},{"line_number":24,"context_line":"will happily call process-config-drive which will do nothing if static"},{"line_number":25,"context_line":"network information is not there."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a6ced46_39a9a5df","line":22,"updated":"2015-03-25 18:39:58.000000000","message":"that\u0027s could be the sentence above or dhcp-all-interfaces. I suggest ditching the pronoun and saying \"The DHCP approacha above is fine.\" Also, drop the dangling preposition. \"... there is no DHCP.\"","commit_id":"1f46aba076ceee591d8309062012b468942c5242"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"59e5d252e7512d774d88157c5b588537c7a93ab8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"On most systems, that\u0027s fine. But in Rackspace cloud, there is no DHCP there."},{"line_number":23,"context_line":"Instead, there is static network config via config-drive. dhcp-all-interfaces"},{"line_number":24,"context_line":"will happily call process-config-drive which will do nothing if static"},{"line_number":25,"context_line":"network information is not there."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Finally, process-config-drive will handle ssh-keypair-injection from config"},{"line_number":28,"context_line":"drive if cloud-init is not installed."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a6ced46_599821c0","line":25,"updated":"2015-03-25 18:39:58.000000000","message":"I sugest adding graves to config-drive, dhcp-all-interfaces, and process-config-drive. RST will make these stand out a bit which helps with speed reading.","commit_id":"1f46aba076ceee591d8309062012b468942c5242"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"59e5d252e7512d774d88157c5b588537c7a93ab8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"will happily call process-config-drive which will do nothing if static"},{"line_number":25,"context_line":"network information is not there."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Finally, process-config-drive will handle ssh-keypair-injection from config"},{"line_number":28,"context_line":"drive if cloud-init is not installed."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a6ced46_39f7e5f6","line":27,"updated":"2015-03-25 18:39:58.000000000","message":"Same for process-config-drive here. Also I suggest \u0027ssh-keypair injection\u0027","commit_id":"1f46aba076ceee591d8309062012b468942c5242"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"59e5d252e7512d774d88157c5b588537c7a93ab8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"network information is not there."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Finally, process-config-drive will handle ssh-keypair-injection from config"},{"line_number":28,"context_line":"drive if cloud-init is not installed."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a6ced46_59df4169","line":28,"updated":"2015-03-25 18:39:58.000000000","message":"And for good measure, `cloud-init`","commit_id":"1f46aba076ceee591d8309062012b468942c5242"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"e111a447d80d8e4242a0e834d7609e3e3f952fea","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Processing startup information from config-drive"},{"line_number":26,"context_line":"------------------------------------------------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"On most systems, the DHCP approach desribed above is fine. But in some clouds,"},{"line_number":29,"context_line":"such as Rackspace Public cloud, there is no DHCP.  Instead, there is static"},{"line_number":30,"context_line":"network config via `config-drive`. `dhcp-all-interfaces` will happily call"},{"line_number":31,"context_line":"`process-config-drive` which will do nothing if static network information is"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a6ced46_a4ae49e4","line":28,"updated":"2015-03-25 20:24:55.000000000","message":"s/desribed/described/","commit_id":"3694d679056a3c330e4a2868fc5da6746ac9272b"}],"elements/cloud-instance-simple-config/install.d/dhcp-all-interfaces.sh":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"59e5d252e7512d774d88157c5b588537c7a93ab8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# dib-lint makes us put this header here even though this script is not an"},{"line_number":4,"context_line":"# element script"},{"line_number":5,"context_line":"if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then"},{"line_number":6,"context_line":"    set -x"},{"line_number":7,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1a6ced46_146d90cc","line":4,"updated":"2015-03-25 18:39:58.000000000","message":"If you iterate on this again, can you reference this bug?\n\nhttps://bugs.launchpad.net/diskimage-builder/+bug/1436485","commit_id":"1f46aba076ceee591d8309062012b468942c5242"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"59e5d252e7512d774d88157c5b588537c7a93ab8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"# either up or it\u0027s not coming up"},{"line_number":119,"context_line":"if type initctl \u003e/dev/null ; then"},{"line_number":120,"context_line":"    initctl emit --no-wait static-network-up"},{"line_number":121,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1a6ced46_149e7007","line":121,"updated":"2015-03-25 18:39:58.000000000","message":"I think this will jump the gun on systems with more than one interface, but so does the current system, just jumps a little later. The reason is that we don\u0027t check _all_ interfaces for link and configure _all_ of them before ifupping, so the first one ends up emitting the signal above anyway because /etc/network/interfaces shows only the first one. That said, I\u0027m curious why you feel it is needed here, when it will be run _after_ ifup later.","commit_id":"1f46aba076ceee591d8309062012b468942c5242"}],"elements/dhcp-all-interfaces/README.rst":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"59e5d252e7512d774d88157c5b588537c7a93ab8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1a6ced46_4ed5b9b7","side":"PARENT","updated":"2015-03-25 18:39:58.000000000","message":"I think I\u0027d like to see this file changed to something like \"This element has been deprecated, please see: cloud-instance-simple-config\"","commit_id":"12165f7b25652bc44c75cda137ecb3788625d1dc"}],"elements/simple-init/README.rst":[{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"728fa22ab14c68c011ed7d01c3102b08b2070372","unresolved":false,"context_lines":[{"line_number":15,"context_line":"The rationale for this is that we are likely to require multiple"},{"line_number":16,"context_line":"network interfaces for use cases such as baremetal and there is no way"},{"line_number":17,"context_line":"to know ahead of time which one is which, so we will simply run a"},{"line_number":18,"context_line":"DHCP client on all interfaces with real MAC addresses (except lo) that"},{"line_number":19,"context_line":"are visible on the first boot."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The script `/usr/local/sbin/simple-init.sh` will be called"}],"source_content_type":"text/x-rst","patch_set":20,"id":"da9b358b_788ff223","line":18,"updated":"2015-03-30 04:16:13.000000000","message":"I don\u0027t know if I can claim with a straight face that lo has a real MAC address. That said, I don\u0027t dislike this wording.","commit_id":"c49d994acc2f89cca788ff2f0194a8e3d78ec6e3"}],"elements/simple-init/install.d/50-simple-init":[{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"006779076a214d6cd7676230a1bf63097a684390","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"install -D -g root -o root -m 0755 ${SCRIPTDIR}/simple-init.sh /usr/local/sbin/simple-init.sh"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DIB_INIT_SYSTEM\u003d$(dib-init-system)"},{"line_number":27,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":28,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/simple-init.conf /etc/init/simple-init.conf"},{"line_number":29,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":26,"id":"da9b358b_e0d9a584","line":26,"updated":"2015-04-01 08:55:43.000000000","message":"Isn\u0027t $DIB_INIT_SYSTEM already set by 10-dib-init-system.bash?","commit_id":"ba963c53e6f5cfef7ab2c0e50525c968dfff5e6c"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"006779076a214d6cd7676230a1bf63097a684390","unresolved":false,"context_lines":[{"line_number":24,"context_line":"install -D -g root -o root -m 0755 ${SCRIPTDIR}/simple-init.sh /usr/local/sbin/simple-init.sh"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DIB_INIT_SYSTEM\u003d$(dib-init-system)"},{"line_number":27,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":28,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/simple-init.conf /etc/init/simple-init.conf"},{"line_number":29,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"},{"line_number":30,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/simple-init@.service /usr/lib/systemd/system/simple-init@.service"}],"source_content_type":"application/x-shellscript","patch_set":26,"id":"da9b358b_45e9837f","line":27,"updated":"2015-04-01 08:55:43.000000000","message":"Please use a switch case here:\n\n case \"$DIB_INIT_SYSTEM\" in\n     upstart)\n  ...","commit_id":"ba963c53e6f5cfef7ab2c0e50525c968dfff5e6c"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"9cf5b028eb12c0a44e2ca5e40563cb07edab47bd","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"install -D -g root -o root -m 0755 ${SCRIPTDIR}/simple-init.sh /usr/local/sbin/simple-init.sh"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DIB_INIT_SYSTEM\u003d$(dib-init-system)"},{"line_number":27,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":28,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/simple-init.conf /etc/init/simple-init.conf"},{"line_number":29,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"baa041b7_3d3168ed","line":26,"updated":"2015-04-01 17:07:42.000000000","message":"Isn\u0027t $DIB_INIT_SYSTEM already set by 10-dib-init-system.bash?","commit_id":"0df22c62c5e92b874b674b6b126bf8b56345f9b9"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"9cf5b028eb12c0a44e2ca5e40563cb07edab47bd","unresolved":false,"context_lines":[{"line_number":24,"context_line":"install -D -g root -o root -m 0755 ${SCRIPTDIR}/simple-init.sh /usr/local/sbin/simple-init.sh"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DIB_INIT_SYSTEM\u003d$(dib-init-system)"},{"line_number":27,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":28,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/simple-init.conf /etc/init/simple-init.conf"},{"line_number":29,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"},{"line_number":30,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/simple-init@.service /usr/lib/systemd/system/simple-init@.service"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"baa041b7_5d4b0c5a","line":27,"updated":"2015-04-01 17:07:42.000000000","message":"Please use a switch case here:\n\n case \"$DIB_INIT_SYSTEM\" in\n     upstart)\n  ...","commit_id":"0df22c62c5e92b874b674b6b126bf8b56345f9b9"}],"elements/simple-init/install.d/simple-init.sh":[{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"728fa22ab14c68c011ed7d01c3102b08b2070372","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function config_exists() {"},{"line_number":30,"context_line":"    local interface\u003d$1"},{"line_number":31,"context_line":"    if [ \"$CONF_TYPE\" \u003d\u003d \"netscripts\" ]; then"},{"line_number":32,"context_line":"        if [ -f \"/etc/sysconfig/network-scripts/ifcfg-$interface\" ]; then"},{"line_number":33,"context_line":"            return 0"},{"line_number":34,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":20,"id":"da9b358b_b8db3a1b","line":31,"updated":"2015-03-30 04:16:13.000000000","message":"Nit: I\u0027d prefer single equals here.","commit_id":"c49d994acc2f89cca788ff2f0194a8e3d78ec6e3"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"728fa22ab14c68c011ed7d01c3102b08b2070372","unresolved":false,"context_lines":[{"line_number":52,"context_line":"if [ -n \"$INTERFACE\" ]; then"},{"line_number":53,"context_line":"    /usr/local/bin/process-config-drive --interface $INTERFACE"},{"line_number":54,"context_line":"else"},{"line_number":55,"context_line":"    /usr/local/bin/process-config-drive $INTERFACE"},{"line_number":56,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":20,"id":"da9b358b_f8d1c2fc","line":55,"updated":"2015-03-30 04:16:13.000000000","message":"I don\u0027t understand this line -- it\u0027s in the else block of a -n, which means for this branch to be called, $INTERFACE has to be ! -n, or to put another way -z -- which means you\u0027re calling process-config-drive with no arguments?","commit_id":"c49d994acc2f89cca788ff2f0194a8e3d78ec6e3"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"f3c21d7a676fb6e3ff36dba6a9a3603ea3523a90","unresolved":false,"context_lines":[{"line_number":44,"context_line":"if blkid -t LABEL\u003d\"config-2\" ; then"},{"line_number":45,"context_line":"    # Mount config drive"},{"line_number":46,"context_line":"    mkdir -p /mnt/config"},{"line_number":47,"context_line":"    mount -o mode\u003d0700 /dev/disk/by-label/config-2 /mnt/config || true"},{"line_number":48,"context_line":"    /usr/local/bin/get-keys-from-config-drive"},{"line_number":49,"context_line":"fi"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-sh","patch_set":22,"id":"da9b358b_3724b90b","line":47,"updated":"2015-03-30 20:21:54.000000000","message":"the \"|| true\" is to handle the case where it\u0027s already mounted? what about when you are using cloud-init, is that going to leave the config-drive mounted?\n\nwhat if it fails to mount? i think it would be a good idea to bail out in that case","commit_id":"13b6f7f8866a69afdde96dd7145ba34a62b3620a"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"096b747eef0817f26c1e90a088a49a0b542195f1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"if blkid -t LABEL\u003d\"config-2\" ; then"},{"line_number":45,"context_line":"    # Mount config drive"},{"line_number":46,"context_line":"    mkdir -p /mnt/config"},{"line_number":47,"context_line":"    mount -o mode\u003d0700 /dev/disk/by-label/config-2 /mnt/config || true"},{"line_number":48,"context_line":"    /usr/local/bin/get-keys-from-config-drive"},{"line_number":49,"context_line":"fi"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-sh","patch_set":22,"id":"da9b358b_4d0d6a3d","line":47,"in_reply_to":"da9b358b_3724b90b","updated":"2015-03-30 21:24:29.000000000","message":"This does not support being used hand-in-hand with cloud-init - it\u0027s a siple-init vs. cloud-init thing.\n\nFailing to mount is an interesting case ... if it exists I wonder what would cause it to fail to mount?","commit_id":"13b6f7f8866a69afdde96dd7145ba34a62b3620a"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"006779076a214d6cd7676230a1bf63097a684390","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# dib-lint makes us put this header here even though this script is not an"},{"line_number":17,"context_line":"# element script"},{"line_number":18,"context_line":"if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then"},{"line_number":19,"context_line":"    set -x"}],"source_content_type":"text/x-sh","patch_set":26,"id":"da9b358b_e521b7b5","line":16,"updated":"2015-04-01 08:55:43.000000000","message":"You can use dib-lint exceptions here:\n\n # dib-lint: disable\u003dsete setu setpipefail dibdebugtrace","commit_id":"ba963c53e6f5cfef7ab2c0e50525c968dfff5e6c"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"9cf5b028eb12c0a44e2ca5e40563cb07edab47bd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# dib-lint makes us put this header here even though this script is not an"},{"line_number":17,"context_line":"# element script"},{"line_number":18,"context_line":"if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then"},{"line_number":19,"context_line":"    set -x"}],"source_content_type":"text/x-sh","patch_set":27,"id":"baa041b7_1d74649a","line":16,"updated":"2015-04-01 17:07:42.000000000","message":"You can use dib-lint exceptions here:\n\n # dib-lint: disable\u003dsete setu setpipefail dibdebugtrace","commit_id":"0df22c62c5e92b874b674b6b126bf8b56345f9b9"}],"elements/simple-init/process-config-drive.py":[{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"728fa22ab14c68c011ed7d01c3102b08b2070372","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"post_up \u003d \"    post-up route add -net {net} netmask {mask} gw {gw} || true\\n\""},{"line_number":25,"context_line":"pre_down \u003d \"    pre-down route del -net {net} netmask {mask} gw {gw} || true\\n\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _write_rh_interface(name, interface):"}],"source_content_type":"text/x-python","patch_set":20,"id":"da9b358b_b820daf8","line":25,"updated":"2015-03-30 04:16:13.000000000","message":"These two make me sad -- I understand you\u0027re porting code from dhcp-all-interfaces, but ip route add is a thing, and we should use it. :-(","commit_id":"c49d994acc2f89cca788ff2f0194a8e3d78ec6e3"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"728fa22ab14c68c011ed7d01c3102b08b2070372","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        hwaddr\u003dinterface[\u0027mac_address\u0027],"},{"line_number":41,"context_line":"        ip_address\u003dinterface[\u0027ip_address\u0027],"},{"line_number":42,"context_line":"        netmask\u003dinterface[\u0027netmask\u0027],"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    )"},{"line_number":45,"context_line":"    routes \u003d []"},{"line_number":46,"context_line":"    for route in interface[\u0027routes\u0027]:"}],"source_content_type":"text/x-python","patch_set":20,"id":"da9b358b_782b72ec","line":43,"updated":"2015-03-30 04:16:13.000000000","message":"Blank line?","commit_id":"c49d994acc2f89cca788ff2f0194a8e3d78ec6e3"}],"elements/simple-init/sample/README.rst":[{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"728fa22ab14c68c011ed7d01c3102b08b2070372","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"These are sample config-drives taken from Rackspace and HP for the purposes of"},{"line_number":5,"context_line":"testing. There is also a theoretical new example for what it should look like"},{"line_number":6,"context_line":"in liberty once https://review.openstack.org/#/c/153097/ has landed."}],"source_content_type":"text/x-rst","patch_set":20,"id":"da9b358b_787932fc","line":6,"updated":"2015-03-30 04:16:13.000000000","message":"Half a nit, but: Liberty, since it references the name of the release.","commit_id":"c49d994acc2f89cca788ff2f0194a8e3d78ec6e3"}]}