)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"355e5608a2d90958deb3c47cef44696e3d7bc58d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix image size to fit filesystem journal"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Our logic to determine needed image size doesnt fully account for the"},{"line_number":10,"context_line":"in-filsystem journal. This only shows up when creating images that are"},{"line_number":11,"context_line":"very small relative to the FS journal size."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic3c2bcd31ec4fee6bcd9f67767842eb3fbe20d3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da9b358b_04eef4eb","line":10,"updated":"2015-03-31 18:19:13.000000000","message":"s/filsystem/filesystem/","commit_id":"93d5a4a1df0c5ecf6a5660c708366a629d1d9e81"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"f04078eb0e5b32789d02938ea8bbf7039862d3f4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix image size to fit filesystem journal"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Our logic to determine needed image size doesnt fully account for the"},{"line_number":10,"context_line":"in-filsystem journal. This only shows up when creating images that are"},{"line_number":11,"context_line":"very small relative to the FS journal size."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic3c2bcd31ec4fee6bcd9f67767842eb3fbe20d3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da9b358b_49452715","line":10,"updated":"2015-04-01 00:35:44.000000000","message":"still says \"filsystem\" ... did you run out of e\u0027s? ;)","commit_id":"468498e5259c5b72da5a60362023a4a935ba422d"}],"bin/disk-image-create":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"355e5608a2d90958deb3c47cef44696e3d7bc58d","unresolved":false,"context_lines":[{"line_number":178,"context_line":"mk_build_dir"},{"line_number":179,"context_line":"create_base"},{"line_number":180,"context_line":"# This variable needs to be propagated into the chroot"},{"line_number":181,"context_line":"mkdir -p $TMP_HOOKS_PATH/environment.d"},{"line_number":182,"context_line":"echo \"export DIB_DEFAULT_INSTALLTYPE\u003d\\\"${DIB_DEFAULT_INSTALLTYPE}\\\"\" \u003e $TMP_HOOKS_PATH/environment.d/11-dib-install-type.bash"},{"line_number":183,"context_line":"run_d extra-data"},{"line_number":184,"context_line":"# Run pre-install scripts. These do things that prepare the chroot for package installs"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da9b358b_e4bb10e4","line":181,"updated":"2015-03-31 18:19:13.000000000","message":"This change doesn\u0027t really relate to the commit message. ?","commit_id":"93d5a4a1df0c5ecf6a5660c708366a629d1d9e81"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"70383e026e437161d48eec86df36f14461f93c2b","unresolved":false,"context_lines":[{"line_number":178,"context_line":"mk_build_dir"},{"line_number":179,"context_line":"create_base"},{"line_number":180,"context_line":"# This variable needs to be propagated into the chroot"},{"line_number":181,"context_line":"mkdir -p $TMP_HOOKS_PATH/environment.d"},{"line_number":182,"context_line":"echo \"export DIB_DEFAULT_INSTALLTYPE\u003d\\\"${DIB_DEFAULT_INSTALLTYPE}\\\"\" \u003e $TMP_HOOKS_PATH/environment.d/11-dib-install-type.bash"},{"line_number":183,"context_line":"run_d extra-data"},{"line_number":184,"context_line":"# Run pre-install scripts. These do things that prepare the chroot for package installs"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da9b358b_6f4d993d","line":181,"in_reply_to":"da9b358b_e4bb10e4","updated":"2015-03-31 18:42:30.000000000","message":"woops, this should be in the following patch","commit_id":"93d5a4a1df0c5ecf6a5660c708366a629d1d9e81"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"355e5608a2d90958deb3c47cef44696e3d7bc58d","unresolved":false,"context_lines":[{"line_number":235,"context_line":"fi"},{"line_number":236,"context_line":"mkdir $TMP_BUILD_DIR/mnt"},{"line_number":237,"context_line":"sudo mount ${IMAGE_BLOCK_DEVICE} $TMP_BUILD_DIR/mnt"},{"line_number":238,"context_line":"sudo mv -t $TMP_BUILD_DIR/mnt ${TMP_BUILD_DIR}/built/* || true"},{"line_number":239,"context_line":"mount_proc_dev_sys"},{"line_number":240,"context_line":"run_d_in_target finalise"},{"line_number":241,"context_line":"finalise_base"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da9b358b_c4beccd3","line":238,"updated":"2015-03-31 18:19:13.000000000","message":"Nor is this change explained.","commit_id":"93d5a4a1df0c5ecf6a5660c708366a629d1d9e81"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"70383e026e437161d48eec86df36f14461f93c2b","unresolved":false,"context_lines":[{"line_number":235,"context_line":"fi"},{"line_number":236,"context_line":"mkdir $TMP_BUILD_DIR/mnt"},{"line_number":237,"context_line":"sudo mount ${IMAGE_BLOCK_DEVICE} $TMP_BUILD_DIR/mnt"},{"line_number":238,"context_line":"sudo mv -t $TMP_BUILD_DIR/mnt ${TMP_BUILD_DIR}/built/* || true"},{"line_number":239,"context_line":"mount_proc_dev_sys"},{"line_number":240,"context_line":"run_d_in_target finalise"},{"line_number":241,"context_line":"finalise_base"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da9b358b_4f48952d","line":238,"in_reply_to":"da9b358b_c4beccd3","updated":"2015-03-31 18:42:30.000000000","message":"same","commit_id":"93d5a4a1df0c5ecf6a5660c708366a629d1d9e81"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"476017adbe08b3c8c6f3c2fa83965687985fbc4b","unresolved":false,"context_lines":[{"line_number":205,"context_line":"  # Rounding down size so that is is a multiple of 64, works around a bug in"},{"line_number":206,"context_line":"  # qemu-img that may occur when compressing raw images that aren\u0027t a multiple"},{"line_number":207,"context_line":"  # of 64k. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1180021"},{"line_number":208,"context_line":"  du_size\u003d$(sudo du --block-size\u003d600 -x -s ${TMP_BUILD_DIR}/built |\\"},{"line_number":209,"context_line":"            awk \u0027 { print $1 }\u0027)"},{"line_number":210,"context_line":"  if [ \"$FS_TYPE\" \u003d \"ext4\" ] ; then"},{"line_number":211,"context_line":"    # Very conservative to handle images being resized a lot"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9aa53dc9_27212cfc","line":208,"updated":"2015-04-07 15:11:18.000000000","message":"to be honest, I don\u0027t know how long this has been around but I would prefer not to trick the actual du_size and define instead a fixed increment (not relative) to be added in _NEEDED_SIZE, where we do the 64 rounding as well","commit_id":"a927b665a358ed3e48a446d28633af32e7175d80"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"33552eec00735b296c84870fc02350689d8e99c4","unresolved":false,"context_lines":[{"line_number":205,"context_line":"  # Rounding down size so that is is a multiple of 64, works around a bug in"},{"line_number":206,"context_line":"  # qemu-img that may occur when compressing raw images that aren\u0027t a multiple"},{"line_number":207,"context_line":"  # of 64k. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1180021"},{"line_number":208,"context_line":"  du_size\u003d$(sudo du --block-size\u003d600 -x -s ${TMP_BUILD_DIR}/built |\\"},{"line_number":209,"context_line":"            awk \u0027 { print $1 }\u0027)"},{"line_number":210,"context_line":"  if [ \"$FS_TYPE\" \u003d \"ext4\" ] ; then"},{"line_number":211,"context_line":"    # Very conservative to handle images being resized a lot"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9aa53dc9_780785ca","line":208,"in_reply_to":"9aa53dc9_27212cfc","updated":"2015-04-09 04:29:33.000000000","message":"Sorry, I don\u0027t understand what you\u0027re suggesting. Could you maybe provide an example?","commit_id":"a927b665a358ed3e48a446d28633af32e7175d80"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"476017adbe08b3c8c6f3c2fa83965687985fbc4b","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            awk \u0027 { print $1 }\u0027)"},{"line_number":210,"context_line":"  if [ \"$FS_TYPE\" \u003d \"ext4\" ] ; then"},{"line_number":211,"context_line":"    # Very conservative to handle images being resized a lot"},{"line_number":212,"context_line":"    # Without -J option specified, default journal size will be set to 64M"},{"line_number":213,"context_line":"    # and online resize will be failed with error of needs too many credits."},{"line_number":214,"context_line":"    MKFS_OPTS\u003d\"-i 4096 -J size\u003d64\""},{"line_number":215,"context_line":"    du_size\u003d$(( $du_size + 65536 ))"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9aa53dc9_42009e34","line":212,"updated":"2015-04-07 15:11:18.000000000","message":"from the sources at [1], it seems journal size doesn\u0027t really have a default but depends on fs size\n\ncan we update the comment just saying we default to 64M to allow for appropriate resizing?\n\n1. http://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/tree/misc/util.c#n222","commit_id":"a927b665a358ed3e48a446d28633af32e7175d80"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"fc99705380e3d61f86f054bf8ccaad775dbbb351","unresolved":false,"context_lines":[{"line_number":205,"context_line":"  # Rounding down size so that is is a multiple of 64, works around a bug in"},{"line_number":206,"context_line":"  # qemu-img that may occur when compressing raw images that aren\u0027t a multiple"},{"line_number":207,"context_line":"  # of 64k. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1180021"},{"line_number":208,"context_line":"  du_size\u003d$(sudo du --block-size\u003d600 -x -s ${TMP_BUILD_DIR}/built |\\"},{"line_number":209,"context_line":"            awk \u0027 { print $1 }\u0027)"},{"line_number":210,"context_line":"  if [ \"$FS_TYPE\" \u003d \"ext4\" ] ; then"},{"line_number":211,"context_line":"    # Very conservative to handle images being resized a lot"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9aa53dc9_4433bc62","line":208,"updated":"2015-04-09 07:52:08.000000000","message":"I was thinking to remove --block-size\u003d600 from this line and add to it whatever amount we want (to make it big enough) in _NEEDED_SIZE instead of hacking the value returned du_size\n\ndefinitely not something worth a -1, maybe keep it on a note in case more changes are demanded","commit_id":"b701d60d3447ce8a542a6b45b96f9c7339321a3b"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"2565ee7113135bff317fc6a95fcb8fd27b5437ed","unresolved":false,"context_lines":[{"line_number":205,"context_line":"  # Rounding down size so that is is a multiple of 64, works around a bug in"},{"line_number":206,"context_line":"  # qemu-img that may occur when compressing raw images that aren\u0027t a multiple"},{"line_number":207,"context_line":"  # of 64k. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1180021"},{"line_number":208,"context_line":"  du_size\u003d$(sudo du --block-size\u003d600 -x -s ${TMP_BUILD_DIR}/built |\\"},{"line_number":209,"context_line":"            awk \u0027 { print $1 }\u0027)"},{"line_number":210,"context_line":"  if [ \"$FS_TYPE\" \u003d \"ext4\" ] ; then"},{"line_number":211,"context_line":"    # Very conservative to handle images being resized a lot"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9aa53dc9_e3019306","line":208,"in_reply_to":"9aa53dc9_4433bc62","updated":"2015-04-09 15:28:02.000000000","message":"Yeah, this feels sort of inelegant, but at the same time I\u0027m not sure I would want to mess with it just for this.  That seems like the sort of thing that could have a lot of unintended consequences.","commit_id":"b701d60d3447ce8a542a6b45b96f9c7339321a3b"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"2565ee7113135bff317fc6a95fcb8fd27b5437ed","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            awk \u0027 { print $1 }\u0027)"},{"line_number":210,"context_line":"  if [ \"$FS_TYPE\" \u003d \"ext4\" ] ; then"},{"line_number":211,"context_line":"    # Very conservative to handle images being resized a lot"},{"line_number":212,"context_line":"    # We set journal size to 64M so we can size the fs appropriately."},{"line_number":213,"context_line":"    MKFS_OPTS\u003d\"-i 4096 -J size\u003d64\""},{"line_number":214,"context_line":"    du_size\u003d$(( $du_size + 65536 ))"},{"line_number":215,"context_line":"  fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9aa53dc9_e32e3342","line":212,"updated":"2015-04-09 15:28:02.000000000","message":"It\u0027s actually REsizing that\u0027s an issue.  We create a small filesystem, but later want to be able to resize it to fit on, say, a 1 TB drive, and we need a journal large enough to support that.  At least as I understand it.\n\nI\u0027m not sure I want to -1 over a comment change, but I feel like the new version loses some of the context of the original.","commit_id":"b701d60d3447ce8a542a6b45b96f9c7339321a3b"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"33ca6a2684130f8c92b325e8606ce33f60466828","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            awk \u0027 { print $1 }\u0027)"},{"line_number":210,"context_line":"  if [ \"$FS_TYPE\" \u003d \"ext4\" ] ; then"},{"line_number":211,"context_line":"    # Very conservative to handle images being resized a lot"},{"line_number":212,"context_line":"    # We set journal size to 64M so we can size the fs appropriately."},{"line_number":213,"context_line":"    MKFS_OPTS\u003d\"-i 4096 -J size\u003d64\""},{"line_number":214,"context_line":"    du_size\u003d$(( $du_size + 65536 ))"},{"line_number":215,"context_line":"  fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9aa53dc9_23d649f1","line":212,"in_reply_to":"9aa53dc9_e32e3342","updated":"2015-04-10 01:12:41.000000000","message":"Ah! This makes a ton more sense now. Ill add that since it would have helped me a bunch.","commit_id":"b701d60d3447ce8a542a6b45b96f9c7339321a3b"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"29b419a16d60aef03b99d45125c5428c0b0352ef","unresolved":false,"context_lines":[{"line_number":205,"context_line":"  # Rounding down size so that is is a multiple of 64, works around a bug in"},{"line_number":206,"context_line":"  # qemu-img that may occur when compressing raw images that aren\u0027t a multiple"},{"line_number":207,"context_line":"  # of 64k. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1180021"},{"line_number":208,"context_line":"  du_size\u003d$(sudo du --block-size\u003d600 -x -s ${TMP_BUILD_DIR}/built |\\"},{"line_number":209,"context_line":"            awk \u0027 { print $1 }\u0027)"},{"line_number":210,"context_line":"  if [ \"$FS_TYPE\" \u003d \"ext4\" ] ; then"},{"line_number":211,"context_line":"    # Very conservative to handle images being resized a lot"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7aaa499b_f6b99d7a","line":208,"updated":"2015-04-14 08:38:30.000000000","message":"so again, given the script used to rely on _NEEDED_SIZE and not du_size I\u0027d rather account for the extra space when calculating _NEEDED_SIZE instead of hacking the output from du with --block-size\n\nthis said, I don\u0027t think it is worth a -1 but if you plan to update this more, please take it into account","commit_id":"82e1acf04ed8f60c8e9371df38c9b521980f8d19"}]}