)]}'
{"elements/redhat-common/pre-install.d/15-remove-grub":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"ed293a7ac7589c5188f572b83879c63753c0f949","unresolved":false,"context_lines":[{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":"if [ -z \"$GRUBNAME\" ] || [ $($GRUBNAME --version | grep -c \"0.97\") -ne 0 ]; then"},{"line_number":13,"context_line":"    echo \"No GRUB2 found. No need to remove\""},{"line_number":14,"context_line":"    exit 0"},{"line_number":15,"context_line":"else"},{"line_number":16,"context_line":"# Must manually remove grub2 here, otherwise the download below does not work."},{"line_number":17,"context_line":"    yum remove -y grub2"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3afb71cf_949025ee","side":"PARENT","line":14,"updated":"2015-06-05 21:00:15.000000000","message":"It seems this case has gone away entirely, and I think its a fallback for centos 5. Shouldnt we still perform this check and exit early the same way?","commit_id":"f5c8f853c9353c9f64f8c0625738c867dc8de149"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"9a0751e74a3a5779b59435938fe77faea3bc499e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":"if [ -z \"$GRUBNAME\" ] || [ $($GRUBNAME --version | grep -c \"0.97\") -ne 0 ]; then"},{"line_number":13,"context_line":"    echo \"No GRUB2 found. No need to remove\""},{"line_number":14,"context_line":"    exit 0"},{"line_number":15,"context_line":"else"},{"line_number":16,"context_line":"# Must manually remove grub2 here, otherwise the download below does not work."},{"line_number":17,"context_line":"    yum remove -y grub2"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa32b979_7206a81e","side":"PARENT","line":14,"in_reply_to":"1af86dd1_c4104aab","updated":"2015-06-16 21:19:05.000000000","message":"oh? this looks to me like centos5 uses grub 0.x, and so with this change we will be changing the behavior to install grub2 with grub0.x already installed.","commit_id":"f5c8f853c9353c9f64f8c0625738c867dc8de149"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a9ac5d808b2af4a529b5bac07daae93bd3a654d4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":"if [ -z \"$GRUBNAME\" ] || [ $($GRUBNAME --version | grep -c \"0.97\") -ne 0 ]; then"},{"line_number":13,"context_line":"    echo \"No GRUB2 found. No need to remove\""},{"line_number":14,"context_line":"    exit 0"},{"line_number":15,"context_line":"else"},{"line_number":16,"context_line":"# Must manually remove grub2 here, otherwise the download below does not work."},{"line_number":17,"context_line":"    yum remove -y grub2"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1af86dd1_c4104aab","side":"PARENT","line":14,"in_reply_to":"3afb71cf_949025ee","updated":"2015-06-16 19:00:14.000000000","message":"I don\u0027t think so ... the issue seems to be that the way it was trying to download with \"yum -d\" did not download it if it is installed.  when we use yumdownloader, this should not occur","commit_id":"f5c8f853c9353c9f64f8c0625738c867dc8de149"}],"elements/yum/bin/install-packages":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"9c4bc8671c13d9895ac801aaeb47ad046ced0077","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    echo \"Running install-packages ${ACTION}. Package list: $PKGS\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    if [[ \"$ACTION\" \u003d\u003d \"download\" ]]; then"},{"line_number":109,"context_line":"        mkdir -p $DOWNLOAD_PATH"},{"line_number":110,"context_line":"        if [[ ${YUM} \u003d\u003d \"dnf\" ]]; then"},{"line_number":111,"context_line":"            dnf download --destdir\u003d$DOWNLOAD_PATH $PKGS"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa32b979_2c8c26d9","line":108,"updated":"2015-06-17 13:19:47.000000000","message":"Nit - our convention is to not use bash tests unless were using a bash-specific feature (s/[[/[/)","commit_id":"dea70851a6ac7b3d2d8bf962d9b1f51461f2cc65"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a52628541a651c8fd6c8388df2e2cd8c8cb6bb33","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    echo \"Running install-packages ${ACTION}. Package list: $PKGS\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    if [[ \"$ACTION\" \u003d\u003d \"download\" ]]; then"},{"line_number":109,"context_line":"        mkdir -p $DOWNLOAD_PATH"},{"line_number":110,"context_line":"        if [[ ${YUM} \u003d\u003d \"dnf\" ]]; then"},{"line_number":111,"context_line":"            dnf download --destdir\u003d$DOWNLOAD_PATH $PKGS"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa32b979_3656b75c","line":108,"in_reply_to":"fa32b979_2c8c26d9","updated":"2015-06-23 23:19:58.000000000","message":"ok","commit_id":"dea70851a6ac7b3d2d8bf962d9b1f51461f2cc65"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"9c4bc8671c13d9895ac801aaeb47ad046ced0077","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            if [ ! -f /usr/bin/yumdownloader ]; then"},{"line_number":118,"context_line":"                yum install -y yum-utils"},{"line_number":119,"context_line":"            fi"},{"line_number":120,"context_line":"            yumdownloader --destdir\u003d$DOWNLOAD_PATH $PKGS"},{"line_number":121,"context_line":"        fi"},{"line_number":122,"context_line":"        exit 0"},{"line_number":123,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa32b979_ce0b2f23","line":120,"updated":"2015-06-17 13:19:47.000000000","message":"We should add yum-utils to the package-installs for this element - I think its in the fedora image by default but the  yum-minimal element may not install it.","commit_id":"dea70851a6ac7b3d2d8bf962d9b1f51461f2cc65"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a52628541a651c8fd6c8388df2e2cd8c8cb6bb33","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            if [ ! -f /usr/bin/yumdownloader ]; then"},{"line_number":118,"context_line":"                yum install -y yum-utils"},{"line_number":119,"context_line":"            fi"},{"line_number":120,"context_line":"            yumdownloader --destdir\u003d$DOWNLOAD_PATH $PKGS"},{"line_number":121,"context_line":"        fi"},{"line_number":122,"context_line":"        exit 0"},{"line_number":123,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa32b979_965c637e","line":120,"in_reply_to":"fa32b979_ce0b2f23","updated":"2015-06-23 23:19:58.000000000","message":"i think we don\u0027t want it in package-installs because it\u0027s on the border of this yum/dnf change -- we only want it installed for \u003c\u003d f21","commit_id":"dea70851a6ac7b3d2d8bf962d9b1f51461f2cc65"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"b659366aecd991c4693195947177202305d9f1f8","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    echo \"Running install-packages ${ACTION}. Package list: $PKGS\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    if [ \"$ACTION\" \u003d\u003d \"download\" ]; then"},{"line_number":109,"context_line":"        mkdir -p $DOWNLOAD_PATH"},{"line_number":110,"context_line":"        if [ ${YUM} \u003d\u003d \"dnf\" ]; then"},{"line_number":111,"context_line":"            dnf download --destdir\u003d$DOWNLOAD_PATH $PKGS"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"fa32b979_ca641e23","line":108,"updated":"2015-06-25 17:11:02.000000000","message":"I don\u0027t understand why you\u0027d switch from [[ to [ ... [[ is always better unless you can\u0027t use bash.","commit_id":"a5b917416cecaf0946896e98d35d34ade0a25a36"}]}