)]}'
{"bin/disk-image-create":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"161e5ff0fcc3410042f710eae40ff6754862f289","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    echo \"       Defaults to \u0027ramdisk\u0027.  Should be set to \u0027dracut-ramdisk\u0027 for platforms such\""},{"line_number":72,"context_line":"    echo \"       as RHEL and CentOS that do not package busybox.\""},{"line_number":73,"context_line":"    echo \"    --install-type -- specify the default installation type. Defaults to \u0027source\u0027. Set to \u0027package\u0027 to use package based installations by default.\""},{"line_number":74,"context_line":"    echo \"    --docker-target -- specify the repo and tag to use if the output type is docker. Defaults to the value of output imagename\""},{"line_number":75,"context_line":"    if [ \"$IS_RAMDISK\" \u003d\u003d \"0\" ]; then"},{"line_number":76,"context_line":"        echo \"    -n skip the default inclusion of the \u0027base\u0027 element\""},{"line_number":77,"context_line":"        echo \"    -p package[,package,package] -- list of packages to install in the image\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3afb71cf_43ddeb6d","line":74,"updated":"2015-06-09 16:12:17.000000000","message":"I\u0027d like a little more information here - can we get an explanation that \"Using the docker output format will attempt an import of the image to docker. By default this will use ___ for the repo and tag.\"","commit_id":"e1b2b877d6bf567bcac3b305975903047d192ba2"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"aeca1e65f654c7d855a0e05f9d3822d07da1746c","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"if [ -z \"$DOCKER_TARGET\" ]; then"},{"line_number":151,"context_line":"  export DOCKER_TARGET\u003d$IMAGE_NAME"},{"line_number":152,"context_line":"fi"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"source $_LIB/img-defaults"},{"line_number":155,"context_line":"source $_LIB/common-functions"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"ba3cc151_1c7a8dbd","line":152,"updated":"2015-07-09 01:44:55.000000000","message":"Setting DOCKER_TARGET to $IMAGE_NAME can cause weird errors on \u0027docker import\u0027 below. Rather than trying to marshal in a default here I think it might be best to simply move this check into the IMAGE_TYPES loop below and check it within the docker case statement to make sure --docker-target is set when exporting a docker image.","commit_id":"c9434978702259927c144bb7571ec440f7e312db"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"aeca1e65f654c7d855a0e05f9d3822d07da1746c","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        docker)"},{"line_number":190,"context_line":"            if [ -z \"$(which docker)\" ]; then"},{"line_number":191,"context_line":"                echo \"docker output format specified but no docker executable found.\""},{"line_number":192,"context_line":"                exit 1"},{"line_number":193,"context_line":"            fi"},{"line_number":194,"context_line":"            ;;"},{"line_number":195,"context_line":"    esac"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"ba3cc151_9c4c5d9f","line":192,"updated":"2015-07-09 01:44:55.000000000","message":"So yeah. Add a DOCKER_TARGET validation here?","commit_id":"c9434978702259927c144bb7571ec440f7e312db"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"aeca1e65f654c7d855a0e05f9d3822d07da1746c","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    sudo chown $USER: $IMAGE_NAME.tar"},{"line_number":286,"context_line":"    unset IMAGE_TYPES[$X]"},{"line_number":287,"context_line":"  elif [ \"${IMAGE_TYPES[$X]}\" \u003d\u003d \"docker\" ]; then"},{"line_number":288,"context_line":"    sudo tar -C ${TMP_BUILD_DIR}/mnt -cf - --exclude ./sys \\"},{"line_number":289,"context_line":"             --exclude ./proc --xattrs --xattrs-include\u003d\\* . \\"},{"line_number":290,"context_line":"        | docker import - $DOCKER_TARGET"},{"line_number":291,"context_line":"    unset IMAGE_TYPES[$X]"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"ba3cc151_fc51e930","line":288,"updated":"2015-07-09 01:44:55.000000000","message":"Minor nit. I think we could drop the \u0027f -\u0027 part of this.\n\nEssentially just make it \u0027sudo tar -C ${TMP_BUILD_DIR}/mnt -c --exclude ./sys \\\u0027 and so on...","commit_id":"c9434978702259927c144bb7571ec440f7e312db"}],"tests/image_output_formats.bash":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"161e5ff0fcc3410042f710eae40ff6754862f289","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"test_formats\u003d\"tar raw qcow2 docker\""},{"line_number":9,"context_line":"for binary in qemu-img docker ; do"},{"line_number":10,"context_line":"    if [ -z \"$(which $binary)\" ]; then"},{"line_number":11,"context_line":"        echo \"Warning: No $binary binary found, cowardly refusing to run tests.\""},{"line_number":12,"context_line":"        exit 0"},{"line_number":13,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3afb71cf_c1543300","line":10,"updated":"2015-06-09 16:12:17.000000000","message":"Id actually like to see this go away and to fail. How about we dont make this change - add docker to CI (https://review.openstack.org/#/c/189796/) and then make another patch to remove this silently fail behavior (https://review.openstack.org/#/c/189800/)","commit_id":"e1b2b877d6bf567bcac3b305975903047d192ba2"}],"tests/test_functions.bash":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"ae8495842539813c1d11fa549676c5a64cac22d3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                exit 1"},{"line_number":38,"context_line":"            else"},{"line_number":39,"context_line":"                echo \"Found docker image $base_dest/image\""},{"line_number":40,"context_line":"            fi "},{"line_number":41,"context_line":"        fi"},{"line_number":42,"context_line":"    done"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"3a50d1a3_d1860e13","line":40,"updated":"2015-07-19 10:21:44.000000000","message":"whitespace derp","commit_id":"d82ace301c0189bd92535f2ecd2625d708fb26c0"}]}