)]}'
{"elements/ironic-agent/README.rst":[{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"7332217952075f4d33834d18eb5b7a4c83806b18","unresolved":false,"context_lines":[{"line_number":2,"context_line":"ironic-agent"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Builds a ramdisk with ironic-python-agent.  More information can be found at:"},{"line_number":5,"context_line":"    https://github.com/openstack/ironic-python-agent/"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Beyond installing the ironic-python-agent, this element does the following:"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a50d1a3_d6ea01d8","line":5,"updated":"2015-08-03 01:22:25.000000000","message":"I\u0027d prefer this to link to git.openstack.org, but won\u0027t block on it.","commit_id":"9f46c3ba0c12a986c00cd315adfc1028f60ffb83"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e6f1430ced38f46f64f87f6dc6b30e180d45842e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"ironic-agent"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Builds a ramdisk with ironic-python-agent.  More information can be found at:"},{"line_number":5,"context_line":"    https://github.com/openstack/ironic-python-agent/"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Beyond installing the ironic-python-agent, this element does the following:"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a50d1a3_3bde9e6d","line":5,"in_reply_to":"3a50d1a3_d6ea01d8","updated":"2015-08-03 11:19:57.000000000","message":"I\u0027ll post a revision dependent upon this revision to change it.","commit_id":"9f46c3ba0c12a986c00cd315adfc1028f60ffb83"}],"elements/ironic-agent/install.d/60-ironic-agent-install":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e2a95528c9d73dc491b284f94a77b89cb8d3e1e1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"pip install -r /tmp/ironic-python-agent/requirements.txt"},{"line_number":21,"context_line":"pip install /tmp/ironic-python-agent"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"dib-init-system"},{"line_number":24,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":25,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent.conf /etc/init/ironic-python-agent.conf"},{"line_number":26,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba3cc151_a0d38b37","line":23,"updated":"2015-07-07 17:32:07.000000000","message":"Seems like your already calling it on line 10.","commit_id":"f53ce078b46846cd3e1256aee5c69d4415f67122"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"2bd3b0aa9af9320bb4b2adff0c989761849aac2e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"pip install -r /tmp/ironic-python-agent/requirements.txt"},{"line_number":21,"context_line":"pip install /tmp/ironic-python-agent"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"dib-init-system"},{"line_number":24,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":25,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent.conf /etc/init/ironic-python-agent.conf"},{"line_number":26,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba3cc151_f9385bd5","line":23,"in_reply_to":"ba3cc151_a0d38b37","updated":"2015-07-08 01:20:04.000000000","message":"yup.. will remove it in next patch.","commit_id":"f53ce078b46846cd3e1256aee5c69d4415f67122"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"88169e9af5e8b720bf41a5ffc6284a056e6cca92","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SCRIPTDIR\u003d$(dirname $0)"},{"line_number":10,"context_line":"DIB_INIT_SYSTEM\u003d$(dib-init-system)"},{"line_number":11,"context_line":"install-packages python-dev qemu-utils parted hdparm util-linux genisoimage gcc"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Install the latest version of pip and setuptools which has some"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba3cc151_75bdc3af","line":10,"updated":"2015-07-09 16:45:00.000000000","message":"DIB_INIT_SYSTEM is already set by the dib-init-system element.","commit_id":"a231293fdee42b95bf7dbf3cbf1ac7d9e8aeedb1"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"a6e66e277004d3ef99e4a91b6baeafc91bd26588","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SCRIPTDIR\u003d$(dirname $0)"},{"line_number":10,"context_line":"DIB_INIT_SYSTEM\u003d$(dib-init-system)"},{"line_number":11,"context_line":"install-packages python-dev qemu-utils parted hdparm util-linux genisoimage gcc"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Install the latest version of pip and setuptools which has some"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba3cc151_2cc59109","line":10,"in_reply_to":"ba3cc151_75bdc3af","updated":"2015-07-10 11:46:29.000000000","message":"Thanks for the catch. will remove in the next patch.","commit_id":"a231293fdee42b95bf7dbf3cbf1ac7d9e8aeedb1"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"88169e9af5e8b720bf41a5ffc6284a056e6cca92","unresolved":false,"context_lines":[{"line_number":20,"context_line":"pip install -r /tmp/ironic-python-agent/requirements.txt"},{"line_number":21,"context_line":"pip install /tmp/ironic-python-agent"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":24,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent.conf /etc/init/ironic-python-agent.conf"},{"line_number":25,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"},{"line_number":26,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent.service /usr/lib/systemd/system/ironic-python-agent@.service"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba3cc151_75d4e3e7","line":23,"updated":"2015-07-09 16:45:00.000000000","message":"What about using a switch case to make these conditions easier to read?","commit_id":"a231293fdee42b95bf7dbf3cbf1ac7d9e8aeedb1"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"a6e66e277004d3ef99e4a91b6baeafc91bd26588","unresolved":false,"context_lines":[{"line_number":20,"context_line":"pip install -r /tmp/ironic-python-agent/requirements.txt"},{"line_number":21,"context_line":"pip install /tmp/ironic-python-agent"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":24,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent.conf /etc/init/ironic-python-agent.conf"},{"line_number":25,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"},{"line_number":26,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent.service /usr/lib/systemd/system/ironic-python-agent@.service"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba3cc151_e7da624b","line":23,"in_reply_to":"ba3cc151_75d4e3e7","updated":"2015-07-10 11:46:29.000000000","message":"Done","commit_id":"a231293fdee42b95bf7dbf3cbf1ac7d9e8aeedb1"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"6be340ffe188bd69f96e52a6e06a50ed70392328","unresolved":false,"context_lines":[{"line_number":23,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":24,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent.conf /etc/init/ironic-python-agent.conf"},{"line_number":25,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"},{"line_number":26,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent.service /usr/lib/systemd/system/ironic-python-agent@.service"},{"line_number":27,"context_line":"    sudo systemctl enable ironic-python-agent@.service"},{"line_number":28,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"sysv\" ]; then"},{"line_number":29,"context_line":"    install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent.init /etc/init.d/ironic-python-agent.init"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba3cc151_93474aa2","line":26,"updated":"2015-07-09 14:38:24.000000000","message":"\"@\" breaks fedora. So will be pushing another patch with the fix.","commit_id":"a231293fdee42b95bf7dbf3cbf1ac7d9e8aeedb1"}],"elements/ironic-agent/install.d/ironic-python-agent.service":[{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"106c3d7f6cebac40869b4ddd8b3e70169f8a5b49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dIronic Python Agent"},{"line_number":3,"context_line":"After\u003dnetwork.target"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3a50d1a3_a09f56b3","line":1,"updated":"2015-07-24 11:32:49.000000000","message":"I think splitting out the service files like this is a great improvement over what is currently in this element, but shouldn\u0027t service files be owned by packaging. Would it be possible to extend this element to install from packages as well as from source?","commit_id":"9feb937583704ce7e80f0a4cda5953daf5b9d0c3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b85793a157e0193fa4b35d2d213e6a2adf4ed24f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Unit]"},{"line_number":2,"context_line":"Description\u003dIronic Python Agent"},{"line_number":3,"context_line":"After\u003dnetwork.target"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3a50d1a3_fa7d05b2","line":1,"in_reply_to":"3a50d1a3_a09f56b3","updated":"2015-07-24 13:39:48.000000000","message":"Dib elements are meant to be agnostic as possible, so there can be source installs and package installs, in this case, the element is geared to do a source install.  We can split the element in a future rev to support package installs.","commit_id":"9feb937583704ce7e80f0a4cda5953daf5b9d0c3"}],"elements/ironic-agent/package-installs.yaml":[{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"106c3d7f6cebac40869b4ddd8b3e70169f8a5b49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tgt:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a50d1a3_80feda03","line":1,"updated":"2015-07-24 11:32:49.000000000","message":"This breaks Fedora/CentOS, since the package containing tgtd is named scsi-target-utils there.","commit_id":"9feb937583704ce7e80f0a4cda5953daf5b9d0c3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b85793a157e0193fa4b35d2d213e6a2adf4ed24f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tgt:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a50d1a3_4911dd5c","line":1,"in_reply_to":"3a50d1a3_80feda03","updated":"2015-07-24 13:39:48.000000000","message":"Added pkg-map file in next revision.","commit_id":"9feb937583704ce7e80f0a4cda5953daf5b9d0c3"}],"elements/ironic-agent/post-install.d/80-ironic-agent":[{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"88169e9af5e8b720bf41a5ffc6284a056e6cca92","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DIB_INIT_SYSTEM\u003d$(dib-init-system)"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"install-packages -e python-dev git cloud-init"},{"line_number":12,"context_line":"rm -rf /tmp/ironic-python-agent"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba3cc151_f50c7394","line":9,"updated":"2015-07-09 16:45:00.000000000","message":"DIB_INIT_SYSTEM is already set by the dib-init-system element.","commit_id":"a231293fdee42b95bf7dbf3cbf1ac7d9e8aeedb1"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"a6e66e277004d3ef99e4a91b6baeafc91bd26588","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DIB_INIT_SYSTEM\u003d$(dib-init-system)"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"install-packages -e python-dev git cloud-init"},{"line_number":12,"context_line":"rm -rf /tmp/ironic-python-agent"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba3cc151_ece569a4","line":9,"in_reply_to":"ba3cc151_f50c7394","updated":"2015-07-10 11:46:29.000000000","message":"Thanks for the catch. will remove in the next patch.","commit_id":"a231293fdee42b95bf7dbf3cbf1ac7d9e8aeedb1"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"88169e9af5e8b720bf41a5ffc6284a056e6cca92","unresolved":false,"context_lines":[{"line_number":11,"context_line":"install-packages -e python-dev git cloud-init"},{"line_number":12,"context_line":"rm -rf /tmp/ironic-python-agent"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":15,"context_line":"    sudo mv /etc/init/ufw.conf /etc/init/ufw.conf.disabled"},{"line_number":16,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"},{"line_number":17,"context_line":"    sudo systemctl disable iptables.service"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba3cc151_952887e3","line":14,"updated":"2015-07-09 16:45:00.000000000","message":"What about using a switch case to make these conditions easier to read?","commit_id":"a231293fdee42b95bf7dbf3cbf1ac7d9e8aeedb1"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"a6e66e277004d3ef99e4a91b6baeafc91bd26588","unresolved":false,"context_lines":[{"line_number":11,"context_line":"install-packages -e python-dev git cloud-init"},{"line_number":12,"context_line":"rm -rf /tmp/ironic-python-agent"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":15,"context_line":"    sudo mv /etc/init/ufw.conf /etc/init/ufw.conf.disabled"},{"line_number":16,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"},{"line_number":17,"context_line":"    sudo systemctl disable iptables.service"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba3cc151_27b84ae8","line":14,"in_reply_to":"ba3cc151_952887e3","updated":"2015-07-10 11:46:29.000000000","message":"Done","commit_id":"a231293fdee42b95bf7dbf3cbf1ac7d9e8aeedb1"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"88169e9af5e8b720bf41a5ffc6284a056e6cca92","unresolved":false,"context_lines":[{"line_number":12,"context_line":"rm -rf /tmp/ironic-python-agent"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":15,"context_line":"    sudo mv /etc/init/ufw.conf /etc/init/ufw.conf.disabled"},{"line_number":16,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"},{"line_number":17,"context_line":"    sudo systemctl disable iptables.service"},{"line_number":18,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"sysv\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba3cc151_956f272a","line":15,"updated":"2015-07-09 16:45:00.000000000","message":"You don\u0027t need to use sudo in post-install.d scripts, as they are run within the chroot.","commit_id":"a231293fdee42b95bf7dbf3cbf1ac7d9e8aeedb1"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"a6e66e277004d3ef99e4a91b6baeafc91bd26588","unresolved":false,"context_lines":[{"line_number":12,"context_line":"rm -rf /tmp/ironic-python-agent"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":15,"context_line":"    sudo mv /etc/init/ufw.conf /etc/init/ufw.conf.disabled"},{"line_number":16,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"},{"line_number":17,"context_line":"    sudo systemctl disable iptables.service"},{"line_number":18,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"sysv\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba3cc151_ac00c136","line":15,"in_reply_to":"ba3cc151_956f272a","updated":"2015-07-10 11:46:29.000000000","message":"Thanks for the catch. will remove in the next patch.","commit_id":"a231293fdee42b95bf7dbf3cbf1ac7d9e8aeedb1"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"88169e9af5e8b720bf41a5ffc6284a056e6cca92","unresolved":false,"context_lines":[{"line_number":14,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":15,"context_line":"    sudo mv /etc/init/ufw.conf /etc/init/ufw.conf.disabled"},{"line_number":16,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"},{"line_number":17,"context_line":"    sudo systemctl disable iptables.service"},{"line_number":18,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"sysv\" ]; then"},{"line_number":19,"context_line":"    update-rc.d iptables disable"},{"line_number":20,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba3cc151_55751ff7","line":17,"updated":"2015-07-09 16:45:00.000000000","message":"Ditto (useless sudo usage).","commit_id":"a231293fdee42b95bf7dbf3cbf1ac7d9e8aeedb1"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"a6e66e277004d3ef99e4a91b6baeafc91bd26588","unresolved":false,"context_lines":[{"line_number":14,"context_line":"if [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"upstart\" ]; then"},{"line_number":15,"context_line":"    sudo mv /etc/init/ufw.conf /etc/init/ufw.conf.disabled"},{"line_number":16,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"systemd\" ]; then"},{"line_number":17,"context_line":"    sudo systemctl disable iptables.service"},{"line_number":18,"context_line":"elif [ \"$DIB_INIT_SYSTEM\" \u003d\u003d \"sysv\" ]; then"},{"line_number":19,"context_line":"    update-rc.d iptables disable"},{"line_number":20,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba3cc151_2c935102","line":17,"in_reply_to":"ba3cc151_55751ff7","updated":"2015-07-10 11:46:29.000000000","message":"Thanks for the catch. will remove in the next patch.","commit_id":"a231293fdee42b95bf7dbf3cbf1ac7d9e8aeedb1"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"d6fde64ec1ad39bda0b961c5c56295907a86d14b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    upstart)"},{"line_number":14,"context_line":"        if [ -f /etc/init/ufw.conf ]; then"},{"line_number":15,"context_line":"            mv /etc/init/ufw.conf /etc/init/ufw.conf.disabled"},{"line_number":16,"context_line":"        fi"},{"line_number":17,"context_line":"        ;;"},{"line_number":18,"context_line":"    systemd)"},{"line_number":19,"context_line":"        systemctl disable iptables.service"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3a50d1a3_ec12db56","line":16,"updated":"2015-07-21 21:22:38.000000000","message":"Corner case that maybe we can just comment on: Debian + upstart _does_ exist, and still runs the iptables init script. In particular I believe hLinux uses Debian + upstart, so that may be important for them.","commit_id":"9feb937583704ce7e80f0a4cda5953daf5b9d0c3"}]}