)]}'
{"bin/disk-image-create":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"abc1469f654bc8992353a1c111d23cef27c4c72a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -eE"},{"line_number":18,"context_line":"set -x"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Prevent perl from complaining a lot, but also remove any unexpected side-effects"},{"line_number":21,"context_line":"# of $LANG varying between build hosts"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"1a4dcd0f_c576323e","line":18,"updated":"2015-08-04 04:40:58.000000000","message":"WIP me please ;)","commit_id":"2920561e890567016f547067c0bcd3870ff694ba"}],"elements/debian/test-elements/build-succeeds/README.rst":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"d516ea1ff633c3f145a9547b934f7457dd91e238","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Test that we can successfully build a debian image.         "}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a50d1a3_f4e9d17f","line":1,"updated":"2015-07-23 14:55:17.000000000","message":"typo?","commit_id":"56d52610ad3403680afb12145cc0d05064f9573b"}],"tests/boot_tests.bash":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"d516ea1ff633c3f145a9547b934f7457dd91e238","unresolved":false,"context_lines":[{"line_number":14,"context_line":"$brctl_cmd stp $bridge_if off"},{"line_number":15,"context_line":"sudo ip addr add 192.0.2.1/24 dev $bridge_if"},{"line_number":16,"context_line":"sudo ip link set dev $bridge_if up"},{"line_number":17,"context_line":"echo \"allow $bridge_if\" | sudo tee /etc/qemu/bridge.conf"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"trap \"rm -rf $dest_dir; sudo ip link set dev $bridge_if down; $brctl_cmd delbr $bridge_if\" EXIT"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_399bb419","line":17,"range":{"start_line":17,"start_character":35,"end_line":17,"end_character":56},"updated":"2015-07-23 14:55:17.000000000","message":"Zaps the old content in \"/etc/qemu/bridge.conf\" (I might run this locally)","commit_id":"56d52610ad3403680afb12145cc0d05064f9573b"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"d516ea1ff633c3f145a9547b934f7457dd91e238","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    ELEMENTS_PATH\u003d$DIB_ELEMENTS:$TEST_ELEMENTS $DIB_CMD -t raw \\"},{"line_number":24,"context_line":"        -o $dest_dir/test_image.raw $distro vm static-network"},{"line_number":25,"context_line":"    sudo qemu-system-x86_64 -nographic $dest_dir/test_image.raw \\"},{"line_number":26,"context_line":"        -net nic -net bridge,br\u003d$bridge_if \u0026"},{"line_number":27,"context_line":"    sleep 1"},{"line_number":28,"context_line":"    qemu_pid\u003d$(ps aux | grep qemu-system-x86_64 | grep -v sudo | grep -v grep | awk \u0027{print $2}\u0027 || true)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_dacb9fa2","line":26,"updated":"2015-07-23 14:55:17.000000000","message":"I\u0027d like to see the output redirected to the logs directory so its available but not stomping all over the script output.","commit_id":"56d52610ad3403680afb12145cc0d05064f9573b"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"d516ea1ff633c3f145a9547b934f7457dd91e238","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    sudo qemu-system-x86_64 -nographic $dest_dir/test_image.raw \\"},{"line_number":26,"context_line":"        -net nic -net bridge,br\u003d$bridge_if \u0026"},{"line_number":27,"context_line":"    sleep 1"},{"line_number":28,"context_line":"    qemu_pid\u003d$(ps aux | grep qemu-system-x86_64 | grep -v sudo | grep -v grep | awk \u0027{print $2}\u0027 || true)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    while true; do"},{"line_number":31,"context_line":"        if ping -c 1 192.0.2.2; then"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_340bb9d7","line":28,"updated":"2015-07-23 14:55:17.000000000","message":"probably no need for the \"grep -v sudo\"\n\nactually how about \"$!\" before the sleep?","commit_id":"56d52610ad3403680afb12145cc0d05064f9573b"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"2638c5ee2bd3e6f39483b0128ad3a5e03fa7b65f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    sudo qemu-system-x86_64 -nographic $dest_dir/test_image.raw \\"},{"line_number":26,"context_line":"        -net nic -net bridge,br\u003d$bridge_if \u0026"},{"line_number":27,"context_line":"    sleep 1"},{"line_number":28,"context_line":"    qemu_pid\u003d$(ps aux | grep qemu-system-x86_64 | grep -v sudo | grep -v grep | awk \u0027{print $2}\u0027 || true)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    while true; do"},{"line_number":31,"context_line":"        if ping -c 1 192.0.2.2; then"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_565bad2e","line":28,"in_reply_to":"3a50d1a3_340bb9d7","updated":"2015-07-24 16:06:30.000000000","message":"I was doing that in a previous patch but the qemu process was sometimes not being killed, there must be some cases where it daemonizes (that will find the sudo process rather then the qemu proess, but in theory that shouldnt be an issue unless it does something like daemonize).","commit_id":"56d52610ad3403680afb12145cc0d05064f9573b"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"d516ea1ff633c3f145a9547b934f7457dd91e238","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    sleep 1"},{"line_number":28,"context_line":"    qemu_pid\u003d$(ps aux | grep qemu-system-x86_64 | grep -v sudo | grep -v grep | awk \u0027{print $2}\u0027 || true)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    while true; do"},{"line_number":31,"context_line":"        if ping -c 1 192.0.2.2; then"},{"line_number":32,"context_line":"            echo \"Boot test of distro element $distro is a success!\""},{"line_number":33,"context_line":"            sudo kill $qemu_pid"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_34a739be","line":30,"updated":"2015-07-23 14:55:17.000000000","message":"This is fine for CI, do we expect people to run it locally? if so maybe it should have a limit.","commit_id":"56d52610ad3403680afb12145cc0d05064f9573b"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"d516ea1ff633c3f145a9547b934f7457dd91e238","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    while true; do"},{"line_number":31,"context_line":"        if ping -c 1 192.0.2.2; then"},{"line_number":32,"context_line":"            echo \"Boot test of distro element $distro is a success!\""},{"line_number":33,"context_line":"            sudo kill $qemu_pid"},{"line_number":34,"context_line":"            rm $dest_dir/test_image.raw"},{"line_number":35,"context_line":"            break"},{"line_number":36,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_5448c5cb","line":33,"updated":"2015-07-23 14:55:17.000000000","message":"It might be better to use the KILL signal incase its caught/ignored.","commit_id":"56d52610ad3403680afb12145cc0d05064f9573b"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"2638c5ee2bd3e6f39483b0128ad3a5e03fa7b65f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    while true; do"},{"line_number":31,"context_line":"        if ping -c 1 192.0.2.2; then"},{"line_number":32,"context_line":"            echo \"Boot test of distro element $distro is a success!\""},{"line_number":33,"context_line":"            sudo kill $qemu_pid"},{"line_number":34,"context_line":"            rm $dest_dir/test_image.raw"},{"line_number":35,"context_line":"            break"},{"line_number":36,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_7681094d","line":33,"in_reply_to":"3a50d1a3_5448c5cb","updated":"2015-07-24 16:06:30.000000000","message":"Qemu seems to respect sigterm in all the tests so far so I think it is better for us to do that if we can get away with it.","commit_id":"56d52610ad3403680afb12145cc0d05064f9573b"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"d516ea1ff633c3f145a9547b934f7457dd91e238","unresolved":false,"context_lines":[{"line_number":41,"context_line":"rm -rf $dest_dir"},{"line_number":42,"context_line":"sudo ip link set dev $bridge_if down"},{"line_number":43,"context_line":"$brctl_cmd delbr $bridge_if"},{"line_number":44,"context_line":"trap EXIT"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_9923e855","line":44,"updated":"2015-07-23 14:55:17.000000000","message":"To avoid duplicating the cleanup code you could just leave the trap in place","commit_id":"56d52610ad3403680afb12145cc0d05064f9573b"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"abc1469f654bc8992353a1c111d23cef27c4c72a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"$brctl_cmd addbr $bridge_if"},{"line_number":13,"context_line":"$brctl_cmd setfd $bridge_if 0"},{"line_number":14,"context_line":"$brctl_cmd stp $bridge_if off"},{"line_number":15,"context_line":"sudo ip addr add 192.0.2.1/24 dev $bridge_if"},{"line_number":16,"context_line":"sudo ip link set dev $bridge_if up"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"if [ -d /etc/qemu-kvm ]; then"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1a4dcd0f_257a7625","line":15,"updated":"2015-08-04 04:40:58.000000000","message":"Can we parameterize this IP? I\u0027m guessing at least one person will have something else running concurrently. Just making it pull from an environment variable, \u0027DIB_BOOTTEST_IP\u0027 or something would be good. #notaminusone","commit_id":"2920561e890567016f547067c0bcd3870ff694ba"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"c67c30035d8f6b8cf418ea6a518181d47dacc4fa","unresolved":false,"context_lines":[{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"if ! grep -q \"allow $bridge_if\" \"$qemu_cfg_dir/bridge.conf\"; then"},{"line_number":25,"context_line":"\techo \"allow $bridge_if\" | sudo tee \"$qemu_cfg_dir/bridge.conf\""},{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"trap \"rm -rf $dest_dir; sudo ip link set dev $bridge_if down; $brctl_cmd delbr $bridge_if\" EXIT"}],"source_content_type":"text/x-sh","patch_set":17,"id":"fa1b9901_8ea644ac","line":25,"updated":"2015-08-21 09:49:45.000000000","message":"tab here.\n\nalso \n\nThis is zaps the previous contents of my bridge.conf can we cp it somewhere and then restore it as part of the trap?","commit_id":"978f533e3c8789f8e4a2df4dbaf547515e3a76ca"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"644f4c67648a6936a55be6b376643a76414ce079","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    echo \"Performing boot test of distro element $distro\""},{"line_number":35,"context_line":"    ELEMENTS_PATH\u003d$DIB_ELEMENTS:$TEST_ELEMENTS $DIB_CMD -t raw \\"},{"line_number":36,"context_line":"        -o $dest_dir/test_image.raw $distro vm static-network"},{"line_number":37,"context_line":"    sudo qemu-system-x86_64 -nographic $dest_dir/test_image.raw \\"},{"line_number":38,"context_line":"        -net nic -net bridge,br\u003d$bridge_if \u0026"},{"line_number":39,"context_line":"    sleep 1"},{"line_number":40,"context_line":"    qemu_pid\u003d$(ps aux | grep qemu-system-x86_64 | grep -v sudo | grep -v grep | awk \u0027{print $2}\u0027 || true)"}],"source_content_type":"text/x-sh","patch_set":19,"id":"9a8ffd7b_dd7d4fe8","line":37,"updated":"2015-11-25 21:07:27.000000000","message":"so this is going to default to 128MiB images, which is probably too small (see the oom in the centos boot)","commit_id":"29219d71cec28053a1242d927b4d92a285bc57c3"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"6ca555719defca4ef7608e5776ce160b4674d49e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"if ! [ -f \"$qemu_cfg_dir/bridge.conf\" ]; then"},{"line_number":25,"context_line":"    echo \"allow $bridge_if\" | sudo tee \"$qemu_cfg_dir/bridge.conf\""},{"line_number":26,"context_line":"elif ! grep -q \"allow $bridge_if\" \"$qemu_cfg_dir/bridge.conf\"; then"},{"line_number":27,"context_line":"    cp \"$qemu_cfg_dir/bridge.conf\" \"$qemu_cfg_dir/bridge.conf.bak\""},{"line_number":28,"context_line":"    echo \"allow $bridge_if\" | sudo tee \"$qemu_cfg_dir/bridge.conf\""},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-sh","patch_set":20,"id":"3a7e1126_a1a788a5","line":27,"updated":"2015-12-21 22:00:52.000000000","message":"This needs a sudo","commit_id":"3d83a661b38444750bd657f34690eddbfa1e48d6"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"6b8b180a459ce319d2b6ac57991536b08b726cc9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -eux"},{"line_number":4,"context_line":"set -o pipefail"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"source $(dirname $0)/test_functions.bash"},{"line_number":7,"context_line":"PATH\u003d$PATH:/sbin:/usr/sbin"},{"line_number":8,"context_line":"dest_dir\u003d$(mktemp -d)"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-sh","patch_set":27,"id":"3aaa91ec_dd3f45b2","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":40},"updated":"2016-06-29 17:38:41.000000000","message":"Looks like this is causing issues in a post- I86d208bd34ff09a29fdb916a4e7ef740c7f65af8 world...","commit_id":"685d585f80e15c601cb515358fd9779ef20d0658"}]}