)]}'
{"elements/ironic-agent/cleanup.d/99-ramdisk-create":[{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"a7053381350d5fab7af29da630a14e9cd3239086","unresolved":false,"context_lines":[{"line_number":18,"context_line":"sudo mv ./tmp/fstab.new ./etc/fstab"},{"line_number":19,"context_line":"sudo ln -s ./sbin/init ./"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"sudo find . -path ./sys -prune -o -path ./proc -prune -o -path \u0027./tmp/*\u0027 -prune -o -path \u0027./boot/*\u0027 -prune -o -path \u0027./root/*\u0027 -prune -o -path \u0027./usr/lib/locale/*\u0027 -prune -o -path \u0027./usr/share/doc/*\u0027 -prune -o -path \u0027./usr/share/man/*\u0027 -prune -o -path \u0027./usr/share/info/*\u0027 -prune -o -path \u0027./usr/share/licenses/*\u0027 -prune -o -path \u0027./usr/share/misc/*\u0027 -prune -o -print | sudo cpio -o -H newc | gzip \u003e ${IMAGE_PATH}.initramfs"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"select_boot_kernel_initrd $TARGET_ROOT"},{"line_number":24,"context_line":"sudo cp $BOOTDIR/$KERNEL ${IMAGE_PATH}.vmlinuz"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa1b9901_960bcbd5","line":21,"updated":"2015-08-21 04:18:57.000000000","message":"There is a similar patch to remove ./sys/* and ./proc/* at https://review.openstack.org/#/c/215060/1/elements/ironic-agent/cleanup.d/99-ramdisk-create\n\nCan we address that here as well..","commit_id":"1181fb8543fcb100d608443e5d2078eef7da2724"},{"author":{"_account_id":10511,"name":"Ligong Duan","email":"duanlg@live.cn","username":"duanlg"},"change_message_id":"f76a5955e717054be3fd4194addef9cc691ea16f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"sudo mv ./tmp/fstab.new ./etc/fstab"},{"line_number":19,"context_line":"sudo ln -s ./sbin/init ./"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"sudo find . -path ./sys -prune -o -path ./proc -prune -o -path \u0027./tmp/*\u0027 -prune -o -path \u0027./boot/*\u0027 -prune -o -path \u0027./root/*\u0027 -prune -o -path \u0027./usr/lib/locale/*\u0027 -prune -o -path \u0027./usr/share/doc/*\u0027 -prune -o -path \u0027./usr/share/man/*\u0027 -prune -o -path \u0027./usr/share/info/*\u0027 -prune -o -path \u0027./usr/share/licenses/*\u0027 -prune -o -path \u0027./usr/share/misc/*\u0027 -prune -o -print | sudo cpio -o -H newc | gzip \u003e ${IMAGE_PATH}.initramfs"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"select_boot_kernel_initrd $TARGET_ROOT"},{"line_number":24,"context_line":"sudo cp $BOOTDIR/$KERNEL ${IMAGE_PATH}.vmlinuz"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa1b9901_1fc45290","line":21,"in_reply_to":"fa1b9901_21549b52","updated":"2015-08-24 10:29:20.000000000","message":"https://review.openstack.org/#/c/215060\nThis patch is submitted by me.\n\nI\u0027ll submit my modification based on your changes.","commit_id":"1181fb8543fcb100d608443e5d2078eef7da2724"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"14e59711926579bcfb578289c7308032371a30a2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"sudo mv ./tmp/fstab.new ./etc/fstab"},{"line_number":19,"context_line":"sudo ln -s ./sbin/init ./"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"sudo find . -path ./sys -prune -o -path ./proc -prune -o -path \u0027./tmp/*\u0027 -prune -o -path \u0027./boot/*\u0027 -prune -o -path \u0027./root/*\u0027 -prune -o -path \u0027./usr/lib/locale/*\u0027 -prune -o -path \u0027./usr/share/doc/*\u0027 -prune -o -path \u0027./usr/share/man/*\u0027 -prune -o -path \u0027./usr/share/info/*\u0027 -prune -o -path \u0027./usr/share/licenses/*\u0027 -prune -o -path \u0027./usr/share/misc/*\u0027 -prune -o -print | sudo cpio -o -H newc | gzip \u003e ${IMAGE_PATH}.initramfs"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"select_boot_kernel_initrd $TARGET_ROOT"},{"line_number":24,"context_line":"sudo cp $BOOTDIR/$KERNEL ${IMAGE_PATH}.vmlinuz"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa1b9901_21549b52","line":21,"in_reply_to":"fa1b9901_960bcbd5","updated":"2015-08-24 09:56:20.000000000","message":"I don\u0027t think it\u0027s a good idea. The patches are solving different problems. This one is about reducing the size of the ramdisk and that patch is fixing something about booting with ubuntu/debian. I understand they touch the same part of the code but they are different problems and therefore should be solved on different patches.","commit_id":"1181fb8543fcb100d608443e5d2078eef7da2724"}],"elements/ironic-agent/finalise.d/99-remove-extra-packages":[{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"b23644efbb887c59fbe718f7161a4fd5fa78e688","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [ $DISTRO_NAME \u003d \u0027fedora\u0027 ] ; then"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  dnf remove kernel-debug-devel gcc mesa* fedora-logos yum python3* rsync sudo pykickstart grubby avahi* make genisoimage tcpdump man-db policycoreutils kbd-misc plymouth cronie -y"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  # Remove package manager cache"},{"line_number":14,"context_line":"  dnf clean all"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_7b9de964","line":11,"updated":"2015-08-06 12:08:14.000000000","message":"Using dnf directly will not work on Fedora \u003c 22, and on any other distribution. Please use `install-packages -e`.\nAlso be careful of the * in shell, escape it to make sure it is not accidentally handled as local file.","commit_id":"950ea55f564bba8424f0f120014b12f793fbcb58"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3e5b46d2ab0f8c3224bc831afdafcc74308fa41e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [ $DISTRO_NAME \u003d \u0027fedora\u0027 ] ; then"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  dnf remove kernel-debug-devel gcc mesa* fedora-logos yum python3* rsync sudo pykickstart grubby avahi* make genisoimage tcpdump man-db policycoreutils kbd-misc plymouth cronie -y"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  # Remove package manager cache"},{"line_number":14,"context_line":"  dnf clean all"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_5b6a6def","line":11,"in_reply_to":"1a4dcd0f_7b9de964","updated":"2015-08-06 12:13:23.000000000","message":"Yeah, I was thinking about even doing a conditional here about F22... Cause it\u0027s tuned for it.","commit_id":"950ea55f564bba8424f0f120014b12f793fbcb58"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"b23644efbb887c59fbe718f7161a4fd5fa78e688","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  dnf remove kernel-debug-devel gcc mesa* fedora-logos yum python3* rsync sudo pykickstart grubby avahi* make genisoimage tcpdump man-db policycoreutils kbd-misc plymouth cronie -y"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  # Remove package manager cache"},{"line_number":14,"context_line":"  dnf clean all"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  # Rebuild the rpm database"},{"line_number":17,"context_line":"  rpm --rebuilddb"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_5b0b4d8e","line":14,"updated":"2015-08-06 12:08:14.000000000","message":"I\u0027d not do that, the default setup is to cache the downloaded packages locally on the build host, and https://review.openstack.org/208321 would allow to keep downloaded packages on the guest.","commit_id":"950ea55f564bba8424f0f120014b12f793fbcb58"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f9ff37e9fbab30390e627c5b4371223a7d461c5c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  dnf remove kernel-debug-devel gcc mesa* fedora-logos yum python3* rsync sudo pykickstart grubby avahi* make genisoimage tcpdump man-db policycoreutils kbd-misc plymouth cronie -y"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  # Remove package manager cache"},{"line_number":14,"context_line":"  dnf clean all"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  # Rebuild the rpm database"},{"line_number":17,"context_line":"  rpm --rebuilddb"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_bb0e1139","line":14,"in_reply_to":"1a4dcd0f_1bb94579","updated":"2015-08-06 12:15:58.000000000","message":"Also it doesn\u0027t removed the cached patches on the host (finalise.d runs inside the chroot right ?)","commit_id":"950ea55f564bba8424f0f120014b12f793fbcb58"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3e5b46d2ab0f8c3224bc831afdafcc74308fa41e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  dnf remove kernel-debug-devel gcc mesa* fedora-logos yum python3* rsync sudo pykickstart grubby avahi* make genisoimage tcpdump man-db policycoreutils kbd-misc plymouth cronie -y"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  # Remove package manager cache"},{"line_number":14,"context_line":"  dnf clean all"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  # Rebuild the rpm database"},{"line_number":17,"context_line":"  rpm --rebuilddb"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_1bb94579","line":14,"in_reply_to":"1a4dcd0f_5b0b4d8e","updated":"2015-08-06 12:13:23.000000000","message":"This element generates a ramdisk which is used to deploy the guest image. It also runs entirely in the RAM so we should clean up all caches we possible can","commit_id":"950ea55f564bba8424f0f120014b12f793fbcb58"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"b23644efbb887c59fbe718f7161a4fd5fa78e688","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  dnf clean all"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  # Rebuild the rpm database"},{"line_number":17,"context_line":"  rpm --rebuilddb"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_dbf75d89","line":17,"updated":"2015-08-06 12:08:14.000000000","message":"Why is it needed?","commit_id":"950ea55f564bba8424f0f120014b12f793fbcb58"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3e5b46d2ab0f8c3224bc831afdafcc74308fa41e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  dnf clean all"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  # Rebuild the rpm database"},{"line_number":17,"context_line":"  rpm --rebuilddb"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_dbaf5d28","line":17,"in_reply_to":"1a4dcd0f_dbf75d89","updated":"2015-08-06 12:13:23.000000000","message":"After removing packages if you recreated the rpm database it will reduce the size of it","commit_id":"950ea55f564bba8424f0f120014b12f793fbcb58"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"d48ac5c43fffe7cadc7c87ae1acde5a76fe8298c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [ \"${DIB_DEBUG_TRACE:-0}\" -gt 0 ]; then"},{"line_number":4,"context_line":"    set -x"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa1b9901_4448efcc","line":1,"updated":"2015-08-21 19:09:12.000000000","message":"This file looks very very similar to the element/apt/finalise.d/99-clean-up-apt-cache file. I wonder if we should put this file in there and wrap it with a flag where it can be turned off using DIB_DISABLE_PKG_CACHE_CLEANUP?","commit_id":"1181fb8543fcb100d608443e5d2078eef7da2724"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"14e59711926579bcfb578289c7308032371a30a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [ \"${DIB_DEBUG_TRACE:-0}\" -gt 0 ]; then"},{"line_number":4,"context_line":"    set -x"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa1b9901_41866fba","line":1,"in_reply_to":"fa1b9901_4448efcc","updated":"2015-08-24 09:56:20.000000000","message":"Well I wouldn\u0027t do that. Because this is specific for the ramdisk (an OS that runs in memory).\n\nThe people using the \"apt\" element (or \"yum\" since the code is specific for fedora), to build custom images that will be written to the disk may still want to have some of the packages I\u0027m removing here installed in their images. (e.g python3)","commit_id":"1181fb8543fcb100d608443e5d2078eef7da2724"}]}