)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"77ba30f9e5589970a93888438e1b8345773d1779","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The ironic-agent element is created using the disk-image-create utility"},{"line_number":10,"context_line":"(even being a ramdisk) and outputs a .vmlinuz file for the kernel"},{"line_number":11,"context_line":"(different than the ramdisk-image-create which outputs a .kernel file"},{"line_number":12,"context_line":"for the kernel). This is inconsistent and make scripting agains the"},{"line_number":13,"context_line":"diskimage-builder more complicated if one wants to support different"},{"line_number":14,"context_line":"types of ramdisk."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_49e966e5","line":12,"updated":"2015-08-11 20:56:16.000000000","message":"s/agains /against /","commit_id":"dc393d4b9dfef2b8bff7bb38e824b24bb9e7bb56"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ad8f67ff87d6604a573ba02df35af49069b0c728","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The ironic-agent element is created using the disk-image-create utility"},{"line_number":10,"context_line":"(even being a ramdisk) and outputs a .vmlinuz file for the kernel"},{"line_number":11,"context_line":"(different than the ramdisk-image-create which outputs a .kernel file"},{"line_number":12,"context_line":"for the kernel). This is inconsistent and make scripting agains the"},{"line_number":13,"context_line":"diskimage-builder more complicated if one wants to support different"},{"line_number":14,"context_line":"types of ramdisk."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_b8ad8aea","line":12,"in_reply_to":"1a4dcd0f_49e966e5","updated":"2015-09-18 13:29:18.000000000","message":"Done","commit_id":"dc393d4b9dfef2b8bff7bb38e824b24bb9e7bb56"}],"elements/ironic-agent/cleanup.d/99-ramdisk-create":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"77ba30f9e5589970a93888438e1b8345773d1779","unresolved":false,"context_lines":[{"line_number":24,"context_line":"sudo cp $BOOTDIR/$KERNEL ${IMAGE_PATH}.kernel"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# TODO(lucasagomes): Create a hard link for the .vmlinuz file to keep"},{"line_number":27,"context_line":"# it backward compatible. Remove it once the Mitaka release cycle starts"},{"line_number":28,"context_line":"echo \"WARNING: The kernel extension .vmlinuz has been deprecated. Please rely on the file with the extension .kernel instead.\""},{"line_number":29,"context_line":"sudo ln ${IMAGE_PATH}.kernel ${IMAGE_PATH}.vmlinuz"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a4dcd0f_a9dfca38","line":27,"updated":"2015-08-11 20:56:16.000000000","message":"Removing it would really be something I don\u0027t want to do until we firmly document this interface for a long time. The way it works needs to be stated in the README of the ironic-agent element. So I think we should change the condition in the comment to \"After it has been consistent and documented in both places for at least one full OpenStack release cycle\"","commit_id":"dc393d4b9dfef2b8bff7bb38e824b24bb9e7bb56"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ad8f67ff87d6604a573ba02df35af49069b0c728","unresolved":false,"context_lines":[{"line_number":24,"context_line":"sudo cp $BOOTDIR/$KERNEL ${IMAGE_PATH}.kernel"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# TODO(lucasagomes): Create a hard link for the .vmlinuz file to keep"},{"line_number":27,"context_line":"# it backward compatible. Remove it once the Mitaka release cycle starts"},{"line_number":28,"context_line":"echo \"WARNING: The kernel extension .vmlinuz has been deprecated. Please rely on the file with the extension .kernel instead.\""},{"line_number":29,"context_line":"sudo ln ${IMAGE_PATH}.kernel ${IMAGE_PATH}.vmlinuz"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba15a1d1_d8a39efe","line":27,"in_reply_to":"1a4dcd0f_a9dfca38","updated":"2015-09-18 13:29:18.000000000","message":"Done","commit_id":"dc393d4b9dfef2b8bff7bb38e824b24bb9e7bb56"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"3741fdc1e9211f79c8271480577f7cdc057565c4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"sudo find . -path ./sys -prune -o -path ./proc -prune -o -path \u0027./tmp/*\u0027 -prune -o -path \u0027./boot/*\u0027 -prune -o -path \u0027./root/*\u0027 -prune -o -path \u0027./usr/lib/locale/*\u0027 -prune -o -path \u0027./usr/share/doc/*\u0027 -prune -o -path \u0027./usr/share/man/*\u0027 -prune -o -path \u0027./usr/share/info/*\u0027 -prune -o -path \u0027./usr/share/licenses/*\u0027 -prune -o -path \u0027./usr/share/misc/*\u0027 -prune -o -print | sudo cpio -o -H newc | gzip \u003e ${IMAGE_PATH}.initramfs"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"select_boot_kernel_initrd $TARGET_ROOT"},{"line_number":24,"context_line":"sudo cp $BOOTDIR/$KERNEL ${IMAGE_PATH}.kernel"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# TODO(lucasagomes): Create a hard link for the .vmlinuz file to keep"},{"line_number":27,"context_line":"# it backward compatible. Remove it after it has been consistent and"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_d824fe60","line":24,"updated":"2015-09-18 13:32:58.000000000","message":"I havent tried, but I wonder if we really need sudo here. It is another place that is inconsistent because the initramfs is non-root owned and the kernel is root owned.\n\nNot really a big deal though.","commit_id":"89867ef7f83b82624d56817db5160787c9f91b03"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c12c84def945283c9d18aaaf657fadd2137752c0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"sudo find . -path ./sys -prune -o -path ./proc -prune -o -path \u0027./tmp/*\u0027 -prune -o -path \u0027./boot/*\u0027 -prune -o -path \u0027./root/*\u0027 -prune -o -path \u0027./usr/lib/locale/*\u0027 -prune -o -path \u0027./usr/share/doc/*\u0027 -prune -o -path \u0027./usr/share/man/*\u0027 -prune -o -path \u0027./usr/share/info/*\u0027 -prune -o -path \u0027./usr/share/licenses/*\u0027 -prune -o -path \u0027./usr/share/misc/*\u0027 -prune -o -print | sudo cpio -o -H newc | gzip \u003e ${IMAGE_PATH}.initramfs"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"select_boot_kernel_initrd $TARGET_ROOT"},{"line_number":24,"context_line":"sudo cp $BOOTDIR/$KERNEL ${IMAGE_PATH}.kernel"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# TODO(lucasagomes): Create a hard link for the .vmlinuz file to keep"},{"line_number":27,"context_line":"# it backward compatible. Remove it after it has been consistent and"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_98d446ec","line":24,"in_reply_to":"ba15a1d1_d824fe60","updated":"2015-09-18 13:38:33.000000000","message":"Right, yeah it was kept because it was there already. I didn\u0027t try without sudo to see if it works or not but it seems out of the scope of the proposed change to modify this bits.","commit_id":"89867ef7f83b82624d56817db5160787c9f91b03"}]}
