)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"442567f9f9dbdb9810b1d620864e0ea9c9cdbd09","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"centos7 dib images ceised to build last week"},{"line_number":10,"context_line":"saying in vm/finalise.d/51-bootloader:"},{"line_number":11,"context_line":"\"package grub2-1:2.02-0.16.el7.centos.x86_64 is already installed\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem is that former code assumes grub2 is not installed,"},{"line_number":14,"context_line":"which could be wrong."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_3fd33a3a","line":11,"updated":"2015-08-10 15:26:53.000000000","message":"Do you mind adding a reference to a log file?","commit_id":"062612dd6f5a4ecc86c0a8d1b8262c1177c89c33"}],"elements/redhat-common/pre-install.d/15-remove-grub":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9c04aa7052fb1df82285e788d29cf35b8c9c7f1e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"for r in /tmp/grub/*.rpm"},{"line_number":25,"context_line":"do"},{"line_number":26,"context_line":"    p\u003d$(rpm -qp $r)"},{"line_number":27,"context_line":"    rpm -q $p || rpm -i $p"},{"line_number":28,"context_line":"done"},{"line_number":29,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1a4dcd0f_19d2fa00","line":27,"updated":"2015-08-11 07:31:50.000000000","message":"just wondering if would be useful to know that something was previously installed so skipping","commit_id":"a36f4885fd540ca5e2e21a77da5e2ecfe959887e"},{"author":{"_account_id":13431,"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"change_message_id":"5d17c1ef08d3bdee751caddf12339412608e2cd1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"for r in /tmp/grub/*.rpm"},{"line_number":25,"context_line":"do"},{"line_number":26,"context_line":"    p\u003d$(rpm -qp $r)"},{"line_number":27,"context_line":"    rpm -q $p || rpm -i $p"},{"line_number":28,"context_line":"done"},{"line_number":29,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1a4dcd0f_7d4a0185","line":27,"in_reply_to":"1a4dcd0f_19d2fa00","updated":"2015-08-11 11:03:42.000000000","message":"there will be an output from \"rpm -q \u003cpkg\u003e\", like that:\n\n# rpm -q grub2-2.02-0.16.el7.centos.x86_64\ngrub2-2.02-0.16.el7.centos.x86_64\n\nwill that suffice?","commit_id":"a36f4885fd540ca5e2e21a77da5e2ecfe959887e"},{"author":{"_account_id":12092,"name":"Abel Lopez","email":"abelopez@cisco.com","username":"alopgeek"},"change_message_id":"bdb6b2c2d10b2b158a3e58e820990a7a7ea9c6fa","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# So we download the latest grub2 package and setup the install script"},{"line_number":44,"context_line":"# to just install the single-package, which will be called later by"},{"line_number":45,"context_line":"# vm/finalise.d/51-bootloader"},{"line_number":46,"context_line":"install-packages -d /tmp/grub grub2"},{"line_number":47,"context_line":"echo \"rpm -i /tmp/grub/*.rpm\" \u003e /tmp/grub/install"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa1b9901_333eeada","line":46,"updated":"2015-08-19 15:59:23.000000000","message":"This needs to be \"grub-pc\", as this will fail later because grub2-tools is missing. \u0027grub-pc\u0027 will download both packages.","commit_id":"9be9ce7076f643f21012c93ee423ed313165f2a2"},{"author":{"_account_id":12092,"name":"Abel Lopez","email":"abelopez@cisco.com","username":"alopgeek"},"change_message_id":"37894832a5d3aa4a37a024ded5e1b2b6e2e31f3b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# So we download the latest grub2 package and setup the install script"},{"line_number":44,"context_line":"# to just install the single-package, which will be called later by"},{"line_number":45,"context_line":"# vm/finalise.d/51-bootloader"},{"line_number":46,"context_line":"install-packages -d /tmp/grub grub2"},{"line_number":47,"context_line":"echo \"rpm -i /tmp/grub/*.rpm\" \u003e /tmp/grub/install"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa1b9901_6fe66ee9","line":46,"in_reply_to":"fa1b9901_03748d33","updated":"2015-08-20 18:48:07.000000000","message":"We do need it, because we\u0027re using \"rpm -i\" to install it, not yum. Yum would resolve the dependencies itself, but (at least on centos7) rpm isn\u0027t smart enough.","commit_id":"9be9ce7076f643f21012c93ee423ed313165f2a2"},{"author":{"_account_id":13431,"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"change_message_id":"0ef6d2b06db184d75217db3abe6d6782b81960e6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# So we download the latest grub2 package and setup the install script"},{"line_number":44,"context_line":"# to just install the single-package, which will be called later by"},{"line_number":45,"context_line":"# vm/finalise.d/51-bootloader"},{"line_number":46,"context_line":"install-packages -d /tmp/grub grub2"},{"line_number":47,"context_line":"echo \"rpm -i /tmp/grub/*.rpm\" \u003e /tmp/grub/install"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa1b9901_03748d33","line":46,"in_reply_to":"fa1b9901_333eeada","updated":"2015-08-20 09:06:38.000000000","message":"grub2 dependenciesincluding grub2-tools are installed in pre-install.d of this element,\nthe point if to not have them being installed in finalise.d","commit_id":"9be9ce7076f643f21012c93ee423ed313165f2a2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3e87b40984bed2f56b6f2608ad81cfb7eadbf2eb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# So we download the latest grub2 package and setup the install script"},{"line_number":44,"context_line":"# to just install the single-package, which will be called later by"},{"line_number":45,"context_line":"# vm/finalise.d/51-bootloader"},{"line_number":46,"context_line":"install-packages -d /tmp/grub grub2"},{"line_number":47,"context_line":"echo \"rpm -i /tmp/grub/*.rpm\" \u003e /tmp/grub/install"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa1b9901_a87940fe","line":46,"in_reply_to":"fa1b9901_6fe66ee9","updated":"2015-08-25 05:43:49.000000000","message":"@Abel -- the grub2-tools dependency is there thanks to being in package-installs.yaml - but more the base cloud image comes with it so it\u0027s actually already there.\n\nare you seeing this problem?  I can build centos7 images, using the defaults (i.e. default cloud base-image) OK, but if you\u0027re seeing this we must be doing something different","commit_id":"9be9ce7076f643f21012c93ee423ed313165f2a2"},{"author":{"_account_id":12092,"name":"Abel Lopez","email":"abelopez@cisco.com","username":"alopgeek"},"change_message_id":"3d267619e38d49bdcc8be0e749b904cb8ce6bf65","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# So we download the latest grub2 package and setup the install script"},{"line_number":44,"context_line":"# to just install the single-package, which will be called later by"},{"line_number":45,"context_line":"# vm/finalise.d/51-bootloader"},{"line_number":46,"context_line":"install-packages -d /tmp/grub grub2"},{"line_number":47,"context_line":"echo \"rpm -i /tmp/grub/*.rpm\" \u003e /tmp/grub/install"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa1b9901_e0296b9c","line":46,"in_reply_to":"fa1b9901_a87940fe","updated":"2015-08-25 17:34:13.000000000","message":"You\u0027re right, it is working as expected, I must have been doing something wrong previously","commit_id":"9be9ce7076f643f21012c93ee423ed313165f2a2"}]}