)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a1562fa07758ca2d094914378622baaa918fb91b","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"On the other hand, deb builds have a similar mechanism with"},{"line_number":13,"context_line":"DIB_APT_LOCAL_CACHE; which is on by default but actually undocumented"},{"line_number":14,"context_line":"as a flag."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Consolidate these into a single DIB_USE_PACKAGE_CACHE flag that is by"},{"line_number":17,"context_line":"default on (maintaining the status-quo) but able to be turned-off."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_aafe2969","line":14,"updated":"2015-08-18 21:15:34.000000000","message":"this is documented in https://github.com/openstack/diskimage-builder/blob/master/elements/dpkg/README.rst","commit_id":"3e55f38f6c66bccd67f1db8bc39ae0fa3d7ee847"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b42f5d0eace71e97496c7b4b2ea3bcadb909a9dd","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"On the other hand, deb builds have a similar mechanism with"},{"line_number":13,"context_line":"DIB_APT_LOCAL_CACHE; which is on by default but actually undocumented"},{"line_number":14,"context_line":"as a flag."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Consolidate these into a single DIB_USE_PACKAGE_CACHE flag that is by"},{"line_number":17,"context_line":"default on (maintaining the status-quo) but able to be turned-off."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_eca2f84a","line":14,"in_reply_to":"fa1b9901_aafe2969","updated":"2015-08-28 04:42:58.000000000","message":"ok, i\u0027ll drop that bit","commit_id":"3e55f38f6c66bccd67f1db8bc39ae0fa3d7ee847"}],"README.rst":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"4c9beb2c995a7b41817dcff30ea868c2fe2f9862","unresolved":false,"context_lines":[{"line_number":109,"context_line":"These are cached by the standard elements - fedora, redhat, ubuntu,"},{"line_number":110,"context_line":"debian and opensuse."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Package caching"},{"line_number":113,"context_line":"---------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"For most builds, a common package-cache is bind-mounted into the build"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_79899a25","line":112,"updated":"2015-08-21 19:26:55.000000000","message":"Can we also get this added to the docs/*, probably under the developer docs? I know its redundant, but that will get added to our doc website which is useful to users.","commit_id":"3e55f38f6c66bccd67f1db8bc39ae0fa3d7ee847"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b42f5d0eace71e97496c7b4b2ea3bcadb909a9dd","unresolved":false,"context_lines":[{"line_number":109,"context_line":"These are cached by the standard elements - fedora, redhat, ubuntu,"},{"line_number":110,"context_line":"debian and opensuse."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Package caching"},{"line_number":113,"context_line":"---------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"For most builds, a common package-cache is bind-mounted into the build"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_0cc88c21","line":112,"in_reply_to":"1a4dcd0f_79899a25","updated":"2015-08-28 04:42:58.000000000","message":"In the next change i have rebased this on changes that moves everything out of README and into the developer documentation","commit_id":"3e55f38f6c66bccd67f1db8bc39ae0fa3d7ee847"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"4c9beb2c995a7b41817dcff30ea868c2fe2f9862","unresolved":false,"context_lines":[{"line_number":127,"context_line":"However, note that in some cases the build-cache is more effective"},{"line_number":128,"context_line":"than using a HTTP proxy, such as when yum has mirror-lists setup and"},{"line_number":129,"context_line":"might be requesting packages from many different places."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"source-repositories"},{"line_number":132,"context_line":"-------------------"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_b94642be","line":130,"updated":"2015-08-21 19:26:55.000000000","message":"Can we also document the caveat that by using the package cache your images will not contain the package cache contents because the bind mount is removed before the image is created.","commit_id":"3e55f38f6c66bccd67f1db8bc39ae0fa3d7ee847"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b42f5d0eace71e97496c7b4b2ea3bcadb909a9dd","unresolved":false,"context_lines":[{"line_number":127,"context_line":"However, note that in some cases the build-cache is more effective"},{"line_number":128,"context_line":"than using a HTTP proxy, such as when yum has mirror-lists setup and"},{"line_number":129,"context_line":"might be requesting packages from many different places."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"source-repositories"},{"line_number":132,"context_line":"-------------------"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_4cfd2439","line":130,"in_reply_to":"1a4dcd0f_b94642be","updated":"2015-08-28 04:42:58.000000000","message":"I think your point is covered by the follow on change where we have DIB_KEEP_PACKAGE_CACHE.  That will discuss this exact behaviour","commit_id":"3e55f38f6c66bccd67f1db8bc39ae0fa3d7ee847"}],"doc/source/developer/caches.rst":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"97f84d0f25218982b67766f53d7896d6cc0f96cb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\u003chttp://docs.openstack.org/developer/tripleo-incubator/devtest_setup.html#f3\u003e`__"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"However, note that in some cases the build-cache is more effective"},{"line_number":28,"context_line":"than using a HTTP proxy, such as when yum has mirror-lists setup and"},{"line_number":29,"context_line":"might be requesting packages from many different places."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Base images"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_8ad59044","line":28,"updated":"2015-09-14 17:15:01.000000000","message":"s/a HTTP/an HTTP/ (with acronyms we use the prounounciation of the letter, not the word it represents) #notaminusone","commit_id":"c06c1752d054dfc538cd380244df76ec5337271f"}],"elements/dpkg/README.rst":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"97f84d0f25218982b67766f53d7896d6cc0f96cb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    mounted in ``/var/cache/apt/archives`` to cache the .deb files downloaded"},{"line_number":29,"context_line":"    during the image creation. Use this variable if you wish to disable the"},{"line_number":30,"context_line":"    internal cache of the ``/var/cache/apt/archives`` directory"},{"line_number":31,"context_line":"  :Example: ``DIB_APT_LOCAL_CACHE\u003d0`` will disable internal caching."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"DIB_DISABLE_APT_CLEANUP"},{"line_number":34,"context_line":"  :Required: No"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_2aca44a2","side":"PARENT","line":31,"updated":"2015-09-14 17:15:01.000000000","message":"not sure I like just removing it. Maybe we could add a deprecated flag to these little blocks? People will still be using it while it is deprecated so they\u0027ll be confused by it missing from the docs.","commit_id":"bf31259810775c68545a93e46632da88f9edf004"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"08405c2e3a6707ca0d1e777f404dbc1f1462876d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    mounted in ``/var/cache/apt/archives`` to cache the .deb files downloaded"},{"line_number":29,"context_line":"    during the image creation. Use this variable if you wish to disable the"},{"line_number":30,"context_line":"    internal cache of the ``/var/cache/apt/archives`` directory"},{"line_number":31,"context_line":"  :Example: ``DIB_APT_LOCAL_CACHE\u003d0`` will disable internal caching."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"DIB_DISABLE_APT_CLEANUP"},{"line_number":34,"context_line":"  :Required: No"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_da0fbd2c","side":"PARENT","line":31,"in_reply_to":"ba15a1d1_2aca44a2","updated":"2015-09-15 08:21:24.000000000","message":"+1 to this sentiment, especially since you are deprecating it in 99-shared_apt_cache - maybe just a big DEPRECATED here too.","commit_id":"bf31259810775c68545a93e46632da88f9edf004"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"08405c2e3a6707ca0d1e777f404dbc1f1462876d","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"By default the ``$DIB_IMAGE_CACHE/apt/$DISTRO_NAME`` directory is"},{"line_number":36,"context_line":"mounted in ``/var/cache/apt/archives`` to cache the .deb files"},{"line_number":37,"context_line":"downloaded during the image creation.  Use ``DIB_USE_PACKAGE_CACHE``"},{"line_number":38,"context_line":"if you wish to disable the internal cache of the"},{"line_number":39,"context_line":"``/var/cache/apt/archives`` directory."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_cfd701be","line":37,"updated":"2015-09-15 08:21:24.000000000","message":"DIB_USE_PACKAGE_CACHE\u003d0 if you wish to disable","commit_id":"c06c1752d054dfc538cd380244df76ec5337271f"}],"elements/dpkg/root.d/99-shared_apt_cache":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a1562fa07758ca2d094914378622baaa918fb91b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [ $DIB_USE_PACKAGE_CACHE \u003d \"0\" ]; then"},{"line_number":10,"context_line":"    exit 0"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa1b9901_caea7dac","line":9,"updated":"2015-08-18 21:15:34.000000000","message":"$DIB_APT_LOCAL_CACHE is documented in this element\u0027s README, so I think it\u0027d be prudent to check both the new and old variable here. If the old one is set, print a deprecation warning.","commit_id":"3e55f38f6c66bccd67f1db8bc39ae0fa3d7ee847"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"4c9beb2c995a7b41817dcff30ea868c2fe2f9862","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [ $DIB_USE_PACKAGE_CACHE \u003d \"0\" ]; then"},{"line_number":10,"context_line":"    exit 0"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa1b9901_d744b31c","line":9,"in_reply_to":"fa1b9901_caea7dac","updated":"2015-08-21 19:26:55.000000000","message":"Agreed","commit_id":"3e55f38f6c66bccd67f1db8bc39ae0fa3d7ee847"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b42f5d0eace71e97496c7b4b2ea3bcadb909a9dd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [ $DIB_USE_PACKAGE_CACHE \u003d \"0\" ]; then"},{"line_number":10,"context_line":"    exit 0"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da20952f_675e0314","line":9,"in_reply_to":"fa1b9901_caea7dac","updated":"2015-08-28 04:42:58.000000000","message":"Done","commit_id":"3e55f38f6c66bccd67f1db8bc39ae0fa3d7ee847"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b42f5d0eace71e97496c7b4b2ea3bcadb909a9dd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [ $DIB_USE_PACKAGE_CACHE \u003d \"0\" ]; then"},{"line_number":10,"context_line":"    exit 0"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da20952f_a7641be5","line":9,"in_reply_to":"fa1b9901_d744b31c","updated":"2015-08-28 04:42:58.000000000","message":"Done","commit_id":"3e55f38f6c66bccd67f1db8bc39ae0fa3d7ee847"}],"elements/yum/README.rst":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"4c9beb2c995a7b41817dcff30ea868c2fe2f9862","unresolved":false,"context_lines":[{"line_number":6,"context_line":"RHEL/Fedora/CentOS and other yum based distributions need specific yum"},{"line_number":7,"context_line":"customizations."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Customizations include caching of downloaded yum packages outside of the build"},{"line_number":10,"context_line":"chroot so that they can be reused by subsequent image builds.  The cache"},{"line_number":11,"context_line":"increases image building speed when building multiple images, especially on"},{"line_number":12,"context_line":"slow connections.  This is more effective than using an HTTP proxy as a yum"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_79ef5a87","side":"PARENT","line":9,"updated":"2015-08-21 19:26:55.000000000","message":"I do think we should leave some documentation in the README that this element supports DIB_USE_PACKAGE_CACHE (This is what will be posted on our docs site)","commit_id":"caf402fd040f960d00484ee36ac47ffef98b5959"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b42f5d0eace71e97496c7b4b2ea3bcadb909a9dd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"RHEL/Fedora/CentOS and other yum based distributions need specific yum"},{"line_number":7,"context_line":"customizations."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Customizations include caching of downloaded yum packages outside of the build"},{"line_number":10,"context_line":"chroot so that they can be reused by subsequent image builds.  The cache"},{"line_number":11,"context_line":"increases image building speed when building multiple images, especially on"},{"line_number":12,"context_line":"slow connections.  This is more effective than using an HTTP proxy as a yum"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_a7d97b85","side":"PARENT","line":9,"in_reply_to":"1a4dcd0f_79ef5a87","updated":"2015-08-28 04:42:58.000000000","message":"I have added a note on this","commit_id":"caf402fd040f960d00484ee36ac47ffef98b5959"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"08405c2e3a6707ca0d1e777f404dbc1f1462876d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"-------"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"For speed, by default we bind-mount the local package-cache into the"},{"line_number":19,"context_line":"build-image; see ``DIB_USE_PACAKGE_CACHE`` for details"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_6f94b5e1","line":19,"updated":"2015-09-15 08:21:24.000000000","message":"pacakge","commit_id":"c06c1752d054dfc538cd380244df76ec5337271f"}],"elements/yum/post-install.d/99-reset-yum-conf":[{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"b54b6092f59eeaab2f7f80d31edf919be4bbc426","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DIB_USE_PACKAGE_CACHE\u003d${DIB_USE_PACKAGE_CACHE:-1}"},{"line_number":10,"context_line":"if [[ ${DIB_USE_PACKAGE_CACHE} \u003d\u003d 0 ]]; then"},{"line_number":11,"context_line":"    exit 0"},{"line_number":12,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"ba15a1d1_66f634d9","line":9,"updated":"2015-09-21 15:28:33.000000000","message":"If DIB_USE_PACKAGE_CACHE is exported in common-defaults, this should not be needed.","commit_id":"e283cbd93297916c0481ab64eedb99afb7b44498"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"b54b6092f59eeaab2f7f80d31edf919be4bbc426","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DIB_USE_PACKAGE_CACHE\u003d${DIB_USE_PACKAGE_CACHE:-1}"},{"line_number":10,"context_line":"if [[ ${DIB_USE_PACKAGE_CACHE} \u003d\u003d 0 ]]; then"},{"line_number":11,"context_line":"    exit 0"},{"line_number":12,"context_line":"fi"},{"line_number":13,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"ba15a1d1_46e77012","line":10,"updated":"2015-09-21 15:28:33.000000000","message":"This can be a simplier\n\n if [[ ${DIB_USE_PACKAGE_CACHE} \u003d\u003d 0 ]]; then\n\nnot a big deal, but at least it\u0027s more uniform with the rest of the review.","commit_id":"e283cbd93297916c0481ab64eedb99afb7b44498"}],"lib/common-defaults":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a1562fa07758ca2d094914378622baaa918fb91b","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Turn this off to avoid using the local package cache that gets"},{"line_number":59,"context_line":"# bind-mounted into the build chroot."},{"line_number":60,"context_line":"export DIB_USE_PACKAGE_CACHE\u003d${DIB_USE_PACKAGE_CACHE:-1}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa1b9901_4a72ed4a","line":60,"updated":"2015-08-18 21:15:34.000000000","message":"defaulting this here feels odd. I\u0027ve typically thought of common-defaults as defaults for dib code itself, and not the included elements.\n\nyou could also default this where it\u0027s used, which i think would be more consistent with how most elements do it.\n\nthis isn\u0027t the reason for my -1 though","commit_id":"3e55f38f6c66bccd67f1db8bc39ae0fa3d7ee847"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b42f5d0eace71e97496c7b4b2ea3bcadb909a9dd","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Turn this off to avoid using the local package cache that gets"},{"line_number":59,"context_line":"# bind-mounted into the build chroot."},{"line_number":60,"context_line":"export DIB_USE_PACKAGE_CACHE\u003d${DIB_USE_PACKAGE_CACHE:-1}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"da20952f_27d48b45","line":60,"in_reply_to":"fa1b9901_4a72ed4a","updated":"2015-08-28 04:42:58.000000000","message":"so i feel like this is a global variable, and not element specific.  the intent is that the caching behaviour is common enough across all elements to be considered globally","commit_id":"3e55f38f6c66bccd67f1db8bc39ae0fa3d7ee847"}]}
