)]}'
{"elements/iso/pkg-map":[{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"92c0fa1caa158dc50aee973b00d50059ef2003ba","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    }"},{"line_number":8,"context_line":"  },"},{"line_number":9,"context_line":"  \"family\":{"},{"line_number":10,"context_line":"    \"debian\":{"},{"line_number":11,"context_line":"      \"syslinux\": \"syslinux\","},{"line_number":12,"context_line":"      \"syslinux-common\": \"\","},{"line_number":13,"context_line":"      \"isolinux\": \"\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da20952f_84811592","line":10,"updated":"2015-08-27 03:38:22.000000000","message":"Will this not build for debian? I think this is used for building ubuntu but why  the same cant be used for debian distro?","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"5c20a1fd3e10f4eec0b140d1d94007ef55935c16","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    }"},{"line_number":8,"context_line":"  },"},{"line_number":9,"context_line":"  \"family\":{"},{"line_number":10,"context_line":"    \"debian\":{"},{"line_number":11,"context_line":"      \"syslinux\": \"syslinux\","},{"line_number":12,"context_line":"      \"syslinux-common\": \"\","},{"line_number":13,"context_line":"      \"isolinux\": \"\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da20952f_7cff4801","line":10,"in_reply_to":"da20952f_5a651643","updated":"2015-09-11 07:05:54.000000000","message":"ok","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":10999,"name":"Ye-hong Fang","email":"hongyefang@gmail.com","username":"Gloria"},"change_message_id":"0577d3a8d3b2c6df76e8abd2e67053479e016683","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    }"},{"line_number":8,"context_line":"  },"},{"line_number":9,"context_line":"  \"family\":{"},{"line_number":10,"context_line":"    \"debian\":{"},{"line_number":11,"context_line":"      \"syslinux\": \"syslinux\","},{"line_number":12,"context_line":"      \"syslinux-common\": \"\","},{"line_number":13,"context_line":"      \"isolinux\": \"\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da20952f_5a651643","line":10,"in_reply_to":"da20952f_84811592","updated":"2015-08-27 05:06:51.000000000","message":"Hi Nisha, \nAs i have said used for \"distro\" debian building at the beginning, so it will not used the \"family\" debian again, and here is only used for ubuntu now. and our team has verified it in both ubuntu and debian(hlinux) , it goes well","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"}],"elements/iso/post-install.d/01-copy-bootloaders":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"25e35d65d1fe0178f35e206fd00f979ade121231","unresolved":false,"context_lines":[{"line_number":13,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"},{"line_number":14,"context_line":"    GRUB_FILE\u003d\"/boot/efi/EFI/fedora/grubx64.efi\""},{"line_number":15,"context_line":"else"},{"line_number":16,"context_line":"    GRUB_FILE\u003d\"/usr/lib/grub/x86_64-efi-signed/grubx64.efi.signed\""},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da20952f_7afc9a3e","line":16,"updated":"2015-08-27 04:49:48.000000000","message":"Is this same for ubuntu and debian?\n\ngrub and shim files are picked from grub2 element. iso has dependency on grub2 element.","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":10999,"name":"Ye-hong Fang","email":"hongyefang@gmail.com","username":"Gloria"},"change_message_id":"f4354ca61ca92c96d719e975ed202a7e3eef662a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"},{"line_number":14,"context_line":"    GRUB_FILE\u003d\"/boot/efi/EFI/fedora/grubx64.efi\""},{"line_number":15,"context_line":"else"},{"line_number":16,"context_line":"    GRUB_FILE\u003d\"/usr/lib/grub/x86_64-efi-signed/grubx64.efi.signed\""},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da20952f_f408b52f","line":16,"in_reply_to":"da20952f_63c2a487","updated":"2015-09-02 07:16:50.000000000","message":"Hi Shiv,\n\nThanks for your reply. My image built for UEFI and BIOS doesn\u0027t throw any errors now.  so i think we maybe can reserve it now util secure boot work well, we can have another patch. What do u think about this?","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":10999,"name":"Ye-hong Fang","email":"hongyefang@gmail.com","username":"Gloria"},"change_message_id":"0577d3a8d3b2c6df76e8abd2e67053479e016683","unresolved":false,"context_lines":[{"line_number":13,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"},{"line_number":14,"context_line":"    GRUB_FILE\u003d\"/boot/efi/EFI/fedora/grubx64.efi\""},{"line_number":15,"context_line":"else"},{"line_number":16,"context_line":"    GRUB_FILE\u003d\"/usr/lib/grub/x86_64-efi-signed/grubx64.efi.signed\""},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da20952f_d5c1f981","line":16,"in_reply_to":"da20952f_7afc9a3e","updated":"2015-08-27 05:06:51.000000000","message":"Hi Shiv, Thanks for your reply.\nThis iso submit only supports for UEFI and BIOS, not considering secure boot for debian, so i will do next submitted for secure boot, so now it will not be changed here now.","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":10999,"name":"Ye-hong Fang","email":"hongyefang@gmail.com","username":"Gloria"},"change_message_id":"34b51e6d34f826036dcd1e7eb0ffe27af16565bd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"},{"line_number":14,"context_line":"    GRUB_FILE\u003d\"/boot/efi/EFI/fedora/grubx64.efi\""},{"line_number":15,"context_line":"else"},{"line_number":16,"context_line":"    GRUB_FILE\u003d\"/usr/lib/grub/x86_64-efi-signed/grubx64.efi.signed\""},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba15a1d1_0afd126e","line":16,"in_reply_to":"da20952f_a1361901","updated":"2015-09-21 07:38:50.000000000","message":"Hi Shiv/Nisha,\nThanks for your focus on this.\nI have investigate in my hlinux(debian) image building env, the secure boot GRUB FILE and SHIM_FILE is the same with ubuntu and debian, so i think this doesn\u0027t have to change any more.","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e57fe0566b171eb93613f53d8cd6af44e2cd944d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"},{"line_number":14,"context_line":"    GRUB_FILE\u003d\"/boot/efi/EFI/fedora/grubx64.efi\""},{"line_number":15,"context_line":"else"},{"line_number":16,"context_line":"    GRUB_FILE\u003d\"/usr/lib/grub/x86_64-efi-signed/grubx64.efi.signed\""},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da20952f_63c2a487","line":16,"in_reply_to":"da20952f_d5c1f981","updated":"2015-09-01 12:46:37.000000000","message":"But won\u0027t your image build throw errors as these files paths are not appropriate for the distribution. If you do not want to copy these files from Debian right now, may be you can add the Ubuntu distro check here so that they gets copied only for Ubuntu and not for Debian.","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"5c20a1fd3e10f4eec0b140d1d94007ef55935c16","unresolved":false,"context_lines":[{"line_number":13,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"},{"line_number":14,"context_line":"    GRUB_FILE\u003d\"/boot/efi/EFI/fedora/grubx64.efi\""},{"line_number":15,"context_line":"else"},{"line_number":16,"context_line":"    GRUB_FILE\u003d\"/usr/lib/grub/x86_64-efi-signed/grubx64.efi.signed\""},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da20952f_a1361901","line":16,"in_reply_to":"da20952f_f408b52f","updated":"2015-09-11 07:05:54.000000000","message":"I was just looking around and saw that debian path for the grubx64.efi is different than of ubuntu. /boot/efi/efi/debian/grubx64.efi . I think this is serious thing to fix. Even if you dont plan to support secure_boot in this patch, it should be masked with the distros so that no one land up in broken image.","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"92c0fa1caa158dc50aee973b00d50059ef2003ba","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"},{"line_number":20,"context_line":"    SHIM_FILE\u003d\"/boot/efi/EFI/fedora/shim.efi\""},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    SHIM_FILE\u003d\"/usr/lib/shim/shim.efi.signed\""},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#fedora"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da20952f_e45b3153","line":22,"updated":"2015-08-27 03:38:22.000000000","message":"is this location same for debian and ubuntu? This is required for secure boot.","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":10999,"name":"Ye-hong Fang","email":"hongyefang@gmail.com","username":"Gloria"},"change_message_id":"34b51e6d34f826036dcd1e7eb0ffe27af16565bd","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"},{"line_number":20,"context_line":"    SHIM_FILE\u003d\"/boot/efi/EFI/fedora/shim.efi\""},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    SHIM_FILE\u003d\"/usr/lib/shim/shim.efi.signed\""},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#fedora"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba15a1d1_2a025670","line":22,"in_reply_to":"da20952f_210a0927","updated":"2015-09-21 07:38:50.000000000","message":"ditto","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e57fe0566b171eb93613f53d8cd6af44e2cd944d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"},{"line_number":20,"context_line":"    SHIM_FILE\u003d\"/boot/efi/EFI/fedora/shim.efi\""},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    SHIM_FILE\u003d\"/usr/lib/shim/shim.efi.signed\""},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#fedora"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da20952f_c337f0ae","line":22,"in_reply_to":"da20952f_75beed00","updated":"2015-09-01 12:46:37.000000000","message":"ditto.","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"5c20a1fd3e10f4eec0b140d1d94007ef55935c16","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"},{"line_number":20,"context_line":"    SHIM_FILE\u003d\"/boot/efi/EFI/fedora/shim.efi\""},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    SHIM_FILE\u003d\"/usr/lib/shim/shim.efi.signed\""},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#fedora"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da20952f_210a0927","line":22,"in_reply_to":"da20952f_9405b915","updated":"2015-09-11 07:05:54.000000000","message":"I agree with Shivanand. You should atleast mask the piece of code which is not applicable to debian.","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":10999,"name":"Ye-hong Fang","email":"hongyefang@gmail.com","username":"Gloria"},"change_message_id":"f4354ca61ca92c96d719e975ed202a7e3eef662a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"},{"line_number":20,"context_line":"    SHIM_FILE\u003d\"/boot/efi/EFI/fedora/shim.efi\""},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    SHIM_FILE\u003d\"/usr/lib/shim/shim.efi.signed\""},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#fedora"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da20952f_9405b915","line":22,"in_reply_to":"da20952f_c337f0ae","updated":"2015-09-02 07:16:50.000000000","message":"ditto","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"25e35d65d1fe0178f35e206fd00f979ade121231","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"},{"line_number":20,"context_line":"    SHIM_FILE\u003d\"/boot/efi/EFI/fedora/shim.efi\""},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    SHIM_FILE\u003d\"/usr/lib/shim/shim.efi.signed\""},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#fedora"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da20952f_ffb3bc08","line":22,"in_reply_to":"da20952f_e45b3153","updated":"2015-08-27 04:49:48.000000000","message":"+1. Is this same for ubuntu and debian?","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":10999,"name":"Ye-hong Fang","email":"hongyefang@gmail.com","username":"Gloria"},"change_message_id":"3e92231302f5bc0b10fbe24a4146d34fda0eede0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"},{"line_number":20,"context_line":"    SHIM_FILE\u003d\"/boot/efi/EFI/fedora/shim.efi\""},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    SHIM_FILE\u003d\"/usr/lib/shim/shim.efi.signed\""},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#fedora"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da20952f_bad1d2fd","line":22,"in_reply_to":"da20952f_e45b3153","updated":"2015-08-27 04:39:33.000000000","message":"Hi Nisha,\nThanks for your reply, this iso submit only supports for UEFI and BIOS, not considering secure boot for debian, so i will do next submitted for secure boot, so now it will not be changed here now.","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"},{"author":{"_account_id":10999,"name":"Ye-hong Fang","email":"hongyefang@gmail.com","username":"Gloria"},"change_message_id":"0577d3a8d3b2c6df76e8abd2e67053479e016683","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if [ $DISTRO_NAME \u003d \"fedora\" ]; then"},{"line_number":20,"context_line":"    SHIM_FILE\u003d\"/boot/efi/EFI/fedora/shim.efi\""},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    SHIM_FILE\u003d\"/usr/lib/shim/shim.efi.signed\""},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#fedora"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da20952f_75beed00","line":22,"in_reply_to":"da20952f_ffb3bc08","updated":"2015-08-27 05:06:51.000000000","message":"Hi Shiv, Thanks for your reply.\nThis iso submit only supports for UEFI and BIOS, not considering secure boot for debian, so i will do next submitted for secure boot, so now it will not be changed here now.","commit_id":"9f1093218c535f4cddfced6ab62f56658c85d0c0"}]}
