)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3048f5660d96ace4a8da4ed04f02f0f1779c6643","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Trowbridge \u003ctrown@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-31 10:44:13 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move service enable to install"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This moves the systemd service enable inside of the"},{"line_number":10,"context_line":"package install, to allow the source install to use"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_fa61e0d3","line":7,"updated":"2015-08-31 14:53:53.000000000","message":"Subject likely needs to indicate this is with ironic-agent.","commit_id":"f6efde9f9aee7f81dc79ed95b6ad1c37f6120405"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"ab34dfd115015d2c67e4091f2caa22a263594519","unresolved":false,"context_lines":[{"line_number":14,"context_line":"these are left as is."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Idca7ad97355cae785162989774a7e6dea6fdc5b5"},{"line_number":17,"context_line":"Resolves: 1490584"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da20952f_fc6c61d1","line":17,"updated":"2015-09-01 03:13:27.000000000","message":"Resolves: 1490584 -\u003e Closes-Bug: #1490584","commit_id":"717e3e9b30cfe2302799b8f43ff8dec22c7f1ab2"}],"elements/ironic-agent/install.d/ironic-agent-package-install/60-ironic-agent-enable":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d7c000f01a974ef4daa27b157997024c05e12fd8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# Right now, the agent is only packaged for RPM, and only for systemd."},{"line_number":10,"context_line":"# In the future we may need to have some logic here to decide what service"},{"line_number":11,"context_line":"# to enable."},{"line_number":12,"context_line":"systemctl disable iptables.service"},{"line_number":13,"context_line":"systemctl enable openstack-ironic-python-agent.service"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da20952f_a69ef4b6","line":12,"updated":"2015-08-31 14:35:30.000000000","message":"Great your disabling iptables here, but this is singlular to package only, and should be handled across all contexties in the post-install step.","commit_id":"9435c4c4f22c146b947b02ee8f434b1d0d627f2d"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"96063bbe82e4904bdf920b414ed2229ea28d6722","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# In the future we may need to have some logic here to decide what service"},{"line_number":11,"context_line":"# to enable."},{"line_number":12,"context_line":"systemctl disable iptables.service"},{"line_number":13,"context_line":"systemctl enable openstack-ironic-python-agent.service"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da20952f_46dcb872","line":13,"updated":"2015-08-31 14:37:26.000000000","message":"I would like to see it documented that package install works with systems running systemd","commit_id":"9435c4c4f22c146b947b02ee8f434b1d0d627f2d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"07dcf72fe80d5a91576d6872f607f58089a08528","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# In the future we may need to have some logic here to decide what service"},{"line_number":11,"context_line":"# to enable."},{"line_number":12,"context_line":"systemctl disable iptables.service"},{"line_number":13,"context_line":"systemctl enable openstack-ironic-python-agent.service"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da20952f_e602acb3","line":13,"in_reply_to":"da20952f_46dcb872","updated":"2015-08-31 14:39:59.000000000","message":"+1","commit_id":"9435c4c4f22c146b947b02ee8f434b1d0d627f2d"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"ab9fe1435e6f72d93c6f1955ae905cbddbbaeb17","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# In the future we may need to have some logic here to decide what service"},{"line_number":11,"context_line":"# to enable."},{"line_number":12,"context_line":"systemctl disable iptables.service"},{"line_number":13,"context_line":"systemctl enable openstack-ironic-python-agent.service"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da20952f_66fd3c6d","line":13,"in_reply_to":"da20952f_46dcb872","updated":"2015-08-31 14:44:58.000000000","message":"Done","commit_id":"9435c4c4f22c146b947b02ee8f434b1d0d627f2d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3048f5660d96ace4a8da4ed04f02f0f1779c6643","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Right now, the agent is only packaged for RPM, and only for systemd."},{"line_number":10,"context_line":"# In the future we may need to have some logic here to decide what service"},{"line_number":11,"context_line":"# to enable."},{"line_number":12,"context_line":"systemctl enable openstack-ironic-python-agent.service"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da20952f_7a563007","line":9,"updated":"2015-08-31 14:53:53.000000000","message":"Not a -1, totally a nit in my book, but I think the notes should be in the form of \"NOTE(Handle):\" for consistencies sake.","commit_id":"f6efde9f9aee7f81dc79ed95b6ad1c37f6120405"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"f45da681551a79026ff1e246431e879a0f735d43","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# NOTE(trown): Right now, the agent is only packaged for RPM, and only for"},{"line_number":10,"context_line":"# systemd. In the future we may need to have some logic here to decide what"},{"line_number":11,"context_line":"# service to enable."},{"line_number":12,"context_line":"systemctl enable openstack-ironic-python-agent.service"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da20952f_ae3d66de","line":10,"updated":"2015-08-31 15:56:10.000000000","message":"Note that we already have that logic: https://github.com/openstack/diskimage-builder/tree/master/elements/svc-map\n\nJust the mapping file would need to be written, and then svc-map used to get the service name.","commit_id":"d2bb5d54a8218a2cf5982d629e1d43183e2cc816"}],"elements/ironic-agent/post-install.d/80-ironic-agent":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d7c000f01a974ef4daa27b157997024c05e12fd8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        ;;"},{"line_number":18,"context_line":"    systemd)"},{"line_number":19,"context_line":"        systemctl disable iptables.service"},{"line_number":20,"context_line":"        systemctl enable openstack-ironic-python-agent.service"},{"line_number":21,"context_line":"        ;;"},{"line_number":22,"context_line":"    sysv)"},{"line_number":23,"context_line":"        update-rc.d iptables disable"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da20952f_666d3ccb","side":"PARENT","line":20,"updated":"2015-08-31 14:35:30.000000000","message":"Line 20 and 24 was the line in question that needed to be removed.\n\nThe rest of the lines are intended to disable the firewall of the machine so callback can occur.","commit_id":"12d71c64477629a2a67027150c53f0b610e2c39b"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"96063bbe82e4904bdf920b414ed2229ea28d6722","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        ;;"},{"line_number":18,"context_line":"    systemd)"},{"line_number":19,"context_line":"        systemctl disable iptables.service"},{"line_number":20,"context_line":"        systemctl enable openstack-ironic-python-agent.service"},{"line_number":21,"context_line":"        ;;"},{"line_number":22,"context_line":"    sysv)"},{"line_number":23,"context_line":"        update-rc.d iptables disable"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da20952f_e6e62c43","side":"PARENT","line":20,"in_reply_to":"da20952f_666d3ccb","updated":"2015-08-31 14:37:26.000000000","message":"+1","commit_id":"12d71c64477629a2a67027150c53f0b610e2c39b"},{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"ab9fe1435e6f72d93c6f1955ae905cbddbbaeb17","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        ;;"},{"line_number":18,"context_line":"    systemd)"},{"line_number":19,"context_line":"        systemctl disable iptables.service"},{"line_number":20,"context_line":"        systemctl enable openstack-ironic-python-agent.service"},{"line_number":21,"context_line":"        ;;"},{"line_number":22,"context_line":"    sysv)"},{"line_number":23,"context_line":"        update-rc.d iptables disable"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da20952f_46d038f6","side":"PARENT","line":20,"in_reply_to":"da20952f_e6e62c43","updated":"2015-08-31 14:44:58.000000000","message":"Done","commit_id":"12d71c64477629a2a67027150c53f0b610e2c39b"}]}