)]}'
{"elements/grub2/install.d/02-grub-install-spec":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e291c08d24be8f4e1011599038efe3cf6527838e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# grub-efi-amd64-signed in ubuntu post will try to call grub-ef-amd64 to install grub into root"},{"line_number":10,"context_line":"# devide which definitely fail at this stage"},{"line_number":11,"context_line":"# the workaround is to skip error and remove postinst script"},{"line_number":12,"context_line":"if [[ \"ubuntu\" \u003d~ \"$DISTRO_NAME\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da85f559_8a20e4b1","line":9,"updated":"2015-11-16 04:03:13.000000000","message":"s/grub-ef-amd64/grub-efi-amd64","commit_id":"4a98b6915feca826ae294f11ffc18ae601c7ce79"},{"author":{"_account_id":18542,"name":"Jane.zhang","email":"jian.zhang8@hpe.com","username":"Jane.zhang"},"change_message_id":"2e452a51c627294b29eb4597034df8d561986f8e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# grub-efi-amd64-signed in ubuntu post will try to call grub-ef-amd64 to install grub into root"},{"line_number":10,"context_line":"# devide which definitely fail at this stage"},{"line_number":11,"context_line":"# the workaround is to skip error and remove postinst script"},{"line_number":12,"context_line":"if [[ \"ubuntu\" \u003d~ \"$DISTRO_NAME\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba8a016a_b6e1f000","line":9,"in_reply_to":"da85f559_8a20e4b1","updated":"2015-11-16 09:50:22.000000000","message":"updated in patch set 5","commit_id":"4a98b6915feca826ae294f11ffc18ae601c7ce79"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e291c08d24be8f4e1011599038efe3cf6527838e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# grub-efi-amd64-signed in ubuntu post will try to call grub-ef-amd64 to install grub into root"},{"line_number":10,"context_line":"# devide which definitely fail at this stage"},{"line_number":11,"context_line":"# the workaround is to skip error and remove postinst script"},{"line_number":12,"context_line":"if [[ \"ubuntu\" \u003d~ \"$DISTRO_NAME\" ]]; then"},{"line_number":13,"context_line":"    set +e"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da85f559_ea173052","line":10,"updated":"2015-11-16 04:03:13.000000000","message":"s/devide/device","commit_id":"4a98b6915feca826ae294f11ffc18ae601c7ce79"},{"author":{"_account_id":18542,"name":"Jane.zhang","email":"jian.zhang8@hpe.com","username":"Jane.zhang"},"change_message_id":"2e452a51c627294b29eb4597034df8d561986f8e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# grub-efi-amd64-signed in ubuntu post will try to call grub-ef-amd64 to install grub into root"},{"line_number":10,"context_line":"# devide which definitely fail at this stage"},{"line_number":11,"context_line":"# the workaround is to skip error and remove postinst script"},{"line_number":12,"context_line":"if [[ \"ubuntu\" \u003d~ \"$DISTRO_NAME\" ]]; then"},{"line_number":13,"context_line":"    set +e"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba8a016a_96dcec47","line":10,"in_reply_to":"da85f559_ea173052","updated":"2015-11-16 09:50:22.000000000","message":"updated in patch set 5","commit_id":"4a98b6915feca826ae294f11ffc18ae601c7ce79"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e291c08d24be8f4e1011599038efe3cf6527838e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":16,"context_line":"        GRUB_EFI_AMD64_SIGNED_POSTINST\u003d/var/lib/dpkg/info/grub-efi-amd64-signed.postinst"},{"line_number":17,"context_line":"        GRUB_EFI_AMD64_POSTINST\u003d/var/lib/dpkg/info/grub-efi-amd64.postinst"},{"line_number":18,"context_line":"        if [ -e $GRUB_EFI_AMD64_SIGNED_POSTINST -o -e $GRUB_EFI_AMD64_POSTINST ]; then"},{"line_number":19,"context_line":"            rm -f $GRUB_EFI_AMD64_SIGNED_POSTINST $GRUB_EFI_AMD64_POSTINST"},{"line_number":20,"context_line":"        fi"},{"line_number":21,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da85f559_e5fe8304","line":18,"updated":"2015-11-16 04:03:13.000000000","message":"If you want to remove the file for sure, then simply rm -f would suffice as it will not throw an error if it doesn\u0027t exist.","commit_id":"4a98b6915feca826ae294f11ffc18ae601c7ce79"},{"author":{"_account_id":18542,"name":"Jane.zhang","email":"jian.zhang8@hpe.com","username":"Jane.zhang"},"change_message_id":"2e452a51c627294b29eb4597034df8d561986f8e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":16,"context_line":"        GRUB_EFI_AMD64_SIGNED_POSTINST\u003d/var/lib/dpkg/info/grub-efi-amd64-signed.postinst"},{"line_number":17,"context_line":"        GRUB_EFI_AMD64_POSTINST\u003d/var/lib/dpkg/info/grub-efi-amd64.postinst"},{"line_number":18,"context_line":"        if [ -e $GRUB_EFI_AMD64_SIGNED_POSTINST -o -e $GRUB_EFI_AMD64_POSTINST ]; then"},{"line_number":19,"context_line":"            rm -f $GRUB_EFI_AMD64_SIGNED_POSTINST $GRUB_EFI_AMD64_POSTINST"},{"line_number":20,"context_line":"        fi"},{"line_number":21,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba8a016a_d6d27434","line":18,"in_reply_to":"da85f559_e5fe8304","updated":"2015-11-16 09:50:22.000000000","message":"updated in patch set 5","commit_id":"4a98b6915feca826ae294f11ffc18ae601c7ce79"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e291c08d24be8f4e1011599038efe3cf6527838e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            rm -f $GRUB_EFI_AMD64_SIGNED_POSTINST $GRUB_EFI_AMD64_POSTINST"},{"line_number":20,"context_line":"        fi"},{"line_number":21,"context_line":"    fi"},{"line_number":22,"context_line":"    set -e"},{"line_number":23,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da85f559_a57b9b7a","line":22,"updated":"2015-11-16 04:03:13.000000000","message":"We will even skip an actual error that might occur while installing the grub package.  Shouldn\u0027t we do a\n\n  dpkg --configure \u003cpackage\u003e\n\nafter this to confirm if it got installed successfully ?","commit_id":"4a98b6915feca826ae294f11ffc18ae601c7ce79"},{"author":{"_account_id":18542,"name":"Jane.zhang","email":"jian.zhang8@hpe.com","username":"Jane.zhang"},"change_message_id":"2e452a51c627294b29eb4597034df8d561986f8e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            rm -f $GRUB_EFI_AMD64_SIGNED_POSTINST $GRUB_EFI_AMD64_POSTINST"},{"line_number":20,"context_line":"        fi"},{"line_number":21,"context_line":"    fi"},{"line_number":22,"context_line":"    set -e"},{"line_number":23,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba8a016a_161a3c18","line":22,"in_reply_to":"da85f559_a57b9b7a","updated":"2015-11-16 09:50:22.000000000","message":"updated in patch set 5","commit_id":"4a98b6915feca826ae294f11ffc18ae601c7ce79"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"37c4adb4e1f8f38fd2993d2056a82574df263114","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# the workaround is to skip error and remove postinst script"},{"line_number":12,"context_line":"if [[ \"ubuntu\" \u003d~ \"$DISTRO_NAME\" ]]; then"},{"line_number":13,"context_line":"    set +e"},{"line_number":14,"context_line":"    install-packages grub-efi-amd64-signed"},{"line_number":15,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":16,"context_line":"        GRUB_EFI_AMD64_SIGNED_POSTINST\u003d/var/lib/dpkg/info/grub-efi-amd64-signed.postinst"},{"line_number":17,"context_line":"        GRUB_EFI_AMD64_POSTINST\u003d/var/lib/dpkg/info/grub-efi-amd64.postinst"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a8ffd7b_8b2e1c8a","line":14,"updated":"2015-11-30 05:16:25.000000000","message":"You don\u0027t need the set +e/set -e dance, you can combine this and the following line as:\n\nif ! install-packages grub-efi-amd64-signed; then\n    rm \u003cpostinst ....\u003e\nfi","commit_id":"185c6f6df7343a254f7a7b28bbdd926ef6ebceb9"},{"author":{"_account_id":18542,"name":"Jane.zhang","email":"jian.zhang8@hpe.com","username":"Jane.zhang"},"change_message_id":"bdaa87d3dd8d3f9ede173166747df0120014a4dc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# the workaround is to skip error and remove postinst script"},{"line_number":12,"context_line":"if [[ \"ubuntu\" \u003d~ \"$DISTRO_NAME\" ]]; then"},{"line_number":13,"context_line":"    set +e"},{"line_number":14,"context_line":"    install-packages grub-efi-amd64-signed"},{"line_number":15,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":16,"context_line":"        GRUB_EFI_AMD64_SIGNED_POSTINST\u003d/var/lib/dpkg/info/grub-efi-amd64-signed.postinst"},{"line_number":17,"context_line":"        GRUB_EFI_AMD64_POSTINST\u003d/var/lib/dpkg/info/grub-efi-amd64.postinst"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a8ffd7b_c4d6cef0","line":14,"in_reply_to":"9a8ffd7b_8b2e1c8a","updated":"2015-12-02 08:03:20.000000000","message":"Thank you for the comment. I have updated it in change set 7.","commit_id":"185c6f6df7343a254f7a7b28bbdd926ef6ebceb9"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"f4c70650bf298eb5669e6b65a704968cac79eb5f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":16,"context_line":"        GRUB_EFI_AMD64_SIGNED_POSTINST\u003d/var/lib/dpkg/info/grub-efi-amd64-signed.postinst"},{"line_number":17,"context_line":"        GRUB_EFI_AMD64_POSTINST\u003d/var/lib/dpkg/info/grub-efi-amd64.postinst"},{"line_number":18,"context_line":"        rm -f $GRUB_EFI_AMD64_SIGNED_POSTINST $GRUB_EFI_AMD64_POSTINST"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":"    set -e"},{"line_number":21,"context_line":"    dpkg --configure grub-efi-amd64"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a8ffd7b_92481689","line":18,"updated":"2015-11-25 20:39:57.000000000","message":"This is ... odd... you can just rm -f them, we can read, by their filenames, that they\u0027re postinsts. The variables are just adding extra bytes. #notAMinusOne","commit_id":"185c6f6df7343a254f7a7b28bbdd926ef6ebceb9"},{"author":{"_account_id":18542,"name":"Jane.zhang","email":"jian.zhang8@hpe.com","username":"Jane.zhang"},"change_message_id":"bdaa87d3dd8d3f9ede173166747df0120014a4dc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":16,"context_line":"        GRUB_EFI_AMD64_SIGNED_POSTINST\u003d/var/lib/dpkg/info/grub-efi-amd64-signed.postinst"},{"line_number":17,"context_line":"        GRUB_EFI_AMD64_POSTINST\u003d/var/lib/dpkg/info/grub-efi-amd64.postinst"},{"line_number":18,"context_line":"        rm -f $GRUB_EFI_AMD64_SIGNED_POSTINST $GRUB_EFI_AMD64_POSTINST"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":"    set -e"},{"line_number":21,"context_line":"    dpkg --configure grub-efi-amd64"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a8ffd7b_04f4d684","line":18,"in_reply_to":"9a8ffd7b_92481689","updated":"2015-12-02 08:03:20.000000000","message":"Thank you for the comment. I have updated it in change set 7.","commit_id":"185c6f6df7343a254f7a7b28bbdd926ef6ebceb9"}],"elements/package-installs/install.d/01-package-installs":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"48d9cd923fe337c6b348f305d1e8c5c3878307a1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"            set -e \u0026\u0026 false"},{"line_number":24,"context_line":"        fi"},{"line_number":25,"context_line":"    fi"},{"line_number":26,"context_line":"    set -e"},{"line_number":27,"context_line":"else"},{"line_number":28,"context_line":"    package-installs-v2 --phase install.d /tmp/package-installs.json"},{"line_number":29,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_3ff148ce","line":26,"updated":"2015-09-13 00:04:14.000000000","message":"i don\u0027t think this is the right place to handle special exceptions like this. this creates tight coupling between the package-installs element and this specific package.\n\nWhat about updating the package-installs yaml schema such that it accepts some sort of noscripts option, and then update install-packages with a generic implementation of the logic above such that it could be applied to any package?","commit_id":"0636590b97f65986563f5af86faaf68a8f00dd72"},{"author":{"_account_id":10511,"name":"Ligong Duan","email":"duanlg@live.cn","username":"duanlg"},"change_message_id":"e6568f85a648a1a645c63a9188098936f659edc2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"            set -e \u0026\u0026 false"},{"line_number":24,"context_line":"        fi"},{"line_number":25,"context_line":"    fi"},{"line_number":26,"context_line":"    set -e"},{"line_number":27,"context_line":"else"},{"line_number":28,"context_line":"    package-installs-v2 --phase install.d /tmp/package-installs.json"},{"line_number":29,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_62a4514a","line":26,"in_reply_to":"ba15a1d1_3ff148ce","updated":"2015-09-24 09:13:47.000000000","message":"Thank James for your comment.\nWe\u0027ll try to move it to the “grub2\" element and adapt it to the convention of \"grub2\" element.","commit_id":"0636590b97f65986563f5af86faaf68a8f00dd72"}]}
