)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"1db61e2810962b4677eb2b2b577fd86a71b6be7d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"/etc/modprobe.d/blacklist.conf."},{"line_number":14,"context_line":"The current code doesn\u0027t copy any of the user added files under"},{"line_number":15,"context_line":"/etc/modprobe.d to the ramdisk. This commit copies the contents"},{"line_number":16,"context_line":"of /etc/modprobe.d to the /etc/modprobe.d and appends the"},{"line_number":17,"context_line":"contents of blacklist.conf with \"blacklist evbug\"."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes bug: #1492804"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a1a9d01_b89b7517","line":16,"updated":"2015-09-30 07:51:47.000000000","message":"Now blacklist.conf is not touched anymore, so please mention the creation of the new file instead, used to put local dib modprobe configuration.","commit_id":"d63a3d8395f10d1e5353abf968faeb2942fda7aa"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"48b9ccffab1be86a9677e8a42188afcdf52c421f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"/etc/modprobe.d/blacklist.conf."},{"line_number":14,"context_line":"The current code doesn\u0027t copy any of the user added files under"},{"line_number":15,"context_line":"/etc/modprobe.d to the ramdisk. This commit copies the contents"},{"line_number":16,"context_line":"of /etc/modprobe.d to the /etc/modprobe.d and appends the"},{"line_number":17,"context_line":"contents of blacklist.conf with \"blacklist evbug\"."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes bug: #1492804"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a1a9d01_feeb15da","line":16,"in_reply_to":"9a1a9d01_b89b7517","updated":"2015-09-30 08:43:49.000000000","message":"Thanks","commit_id":"d63a3d8395f10d1e5353abf968faeb2942fda7aa"}],"lib/ramdisk-functions":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"6eb7beb5fb0b7e23154cbdb8a02800a3a76ec229","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  fi"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  mkdir -p \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":69,"context_line":"  cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":70,"context_line":"  echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  # cjk adding for hwdiscovery support"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba15a1d1_c4053f7a","line":69,"updated":"2015-09-17 06:33:47.000000000","message":"Do we want to do this? we have a element to add modules to the blacklist \"./elements/modprobe-blacklist\", isn\u0027t this enough along with the append fix on the line below?","commit_id":"e7c8634fd64fa7a13968f872b445f112465ba3fe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bbfe941a261ce7c70cb78e225df5cfb8d56a7dae","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  fi"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  mkdir -p \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":69,"context_line":"  cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":70,"context_line":"  echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  # cjk adding for hwdiscovery support"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba15a1d1_4104d348","line":69,"updated":"2015-09-23 13:28:25.000000000","message":"so you use modprobe-blacklist element, and set DIB_MODPROBE_BLACKLIST\u003dahci, no?","commit_id":"e7c8634fd64fa7a13968f872b445f112465ba3fe"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"e5941cbba50251140402b7ca96a1b3be0dd21eb6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  fi"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  mkdir -p \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":69,"context_line":"  cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":70,"context_line":"  echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  # cjk adding for hwdiscovery support"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a1a9d01_d624b5b0","line":69,"in_reply_to":"9a1a9d01_a0a0db91","updated":"2015-09-24 16:29:14.000000000","message":"\u003e After this part is executed, it is overwritten because you use \"\u003e\" to write to the file and not append \"\u003e\u003e\".\n\nThen just the change from \u003e to \u003e\u003e in the following line is enough. For the rest, what Dmitry said is right.","commit_id":"e7c8634fd64fa7a13968f872b445f112465ba3fe"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"84787329dda882a3811f78287b121b5dcb42dd87","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  fi"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  mkdir -p \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":69,"context_line":"  cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":70,"context_line":"  echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  # cjk adding for hwdiscovery support"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a1a9d01_6d122f0b","line":69,"in_reply_to":"9a1a9d01_d624b5b0","updated":"2015-09-29 09:55:15.000000000","message":"what if there is any other file in /etc/modprobe.d directory in the image? \nIn my dependent element \"hpdsa\" i have added \"blacklist ahci\" under \"/etc/modprobe.d/install-hpdsa.conf\". The current change helps to add all the files under /etc/modprobe.d in the image to the ramdisk when it is being created. So even if user forgets to use modprobe-blacklist element the hpdsa element makes sure ahci is blacklisted.","commit_id":"e7c8634fd64fa7a13968f872b445f112465ba3fe"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"f35ac4bc9afefd1af460158e5397c0a77d9ff79b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  fi"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  mkdir -p \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":69,"context_line":"  cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":70,"context_line":"  echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  # cjk adding for hwdiscovery support"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a1a9d01_a0a0db91","line":69,"in_reply_to":"ba15a1d1_4104d348","updated":"2015-09-24 15:58:57.000000000","message":"I used the modprobe-blacklist element and the env variable. And it shows the entry in blacklist.conf in the image till this part of ramdisk function is executed. After this part is executed, it is overwritten because you use \"\u003e\" to write to the file and not append \"\u003e\u003e\".","commit_id":"e7c8634fd64fa7a13968f872b445f112465ba3fe"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2117434493ff58f038925a2db9f8b6b22cec4190","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  fi"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  mkdir -p \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":69,"context_line":"  cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":70,"context_line":"  echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  # cjk adding for hwdiscovery support"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba15a1d1_f357b555","line":69,"in_reply_to":"ba15a1d1_c4053f7a","updated":"2015-09-18 03:50:01.000000000","message":"We need this change because existing code overwrites the blacklist.conf created by the image with the element \u0027modprobe-blacklist\u0027. If we add any other .conf in modprobe.d with any element, that also is not visible if this step is not done.\n\nFor example: hpdsa driver is dependent on blacklisting of ahci driver. It makes the disk visible only if ahci driver is blacklisted. We can add \"blacklist ahci\" in blacklist.conf or a new conf file under modprobe.d for the hpdsa driver to recognize the disk. In both the cases this change is required.","commit_id":"e7c8634fd64fa7a13968f872b445f112465ba3fe"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"36f7f592329cf151c5e5590d8b28e42ff85d2f87","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  mkdir -p \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":69,"context_line":"  # The directory may or may not exist in the image. If the directory exists in"},{"line_number":70,"context_line":"  # the image, sll the files under it should get copied to the ramdisk."},{"line_number":71,"context_line":"  if [ -e \"/etc/modprobe.d/\" ] ; then"},{"line_number":72,"context_line":"      cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":73,"context_line":"      echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a1a9d01_cefa5143","line":70,"updated":"2015-09-29 11:16:51.000000000","message":"\"sll\" typo","commit_id":"0b495461d4496d887004fcac0bf4f342c3c50aff"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a14b378bffd395d643078cbfa46d88013fab4af9","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  mkdir -p \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":69,"context_line":"  # The directory may or may not exist in the image. If the directory exists in"},{"line_number":70,"context_line":"  # the image, sll the files under it should get copied to the ramdisk."},{"line_number":71,"context_line":"  if [ -e \"/etc/modprobe.d/\" ] ; then"},{"line_number":72,"context_line":"      cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":73,"context_line":"      echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a1a9d01_6f4a1028","line":70,"in_reply_to":"9a1a9d01_cefa5143","updated":"2015-09-29 16:42:32.000000000","message":"Thanks","commit_id":"0b495461d4496d887004fcac0bf4f342c3c50aff"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"36f7f592329cf151c5e5590d8b28e42ff85d2f87","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  mkdir -p \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":69,"context_line":"  # The directory may or may not exist in the image. If the directory exists in"},{"line_number":70,"context_line":"  # the image, sll the files under it should get copied to the ramdisk."},{"line_number":71,"context_line":"  if [ -e \"/etc/modprobe.d/\" ] ; then"},{"line_number":72,"context_line":"      cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":73,"context_line":"      echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":74,"context_line":"  else"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a1a9d01_cee331a3","line":71,"updated":"2015-09-29 11:16:51.000000000","message":"This should be -d.","commit_id":"0b495461d4496d887004fcac0bf4f342c3c50aff"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a14b378bffd395d643078cbfa46d88013fab4af9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  mkdir -p \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":69,"context_line":"  # The directory may or may not exist in the image. If the directory exists in"},{"line_number":70,"context_line":"  # the image, sll the files under it should get copied to the ramdisk."},{"line_number":71,"context_line":"  if [ -e \"/etc/modprobe.d/\" ] ; then"},{"line_number":72,"context_line":"      cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":73,"context_line":"      echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":74,"context_line":"  else"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a1a9d01_0f5354e3","line":71,"in_reply_to":"9a1a9d01_cee331a3","updated":"2015-09-29 16:42:32.000000000","message":"ok","commit_id":"0b495461d4496d887004fcac0bf4f342c3c50aff"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"36f7f592329cf151c5e5590d8b28e42ff85d2f87","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  # the image, sll the files under it should get copied to the ramdisk."},{"line_number":71,"context_line":"  if [ -e \"/etc/modprobe.d/\" ] ; then"},{"line_number":72,"context_line":"      cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":73,"context_line":"      echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":74,"context_line":"  else"},{"line_number":75,"context_line":"      # Retaining existing code so that this gets exscuted if \"/etc/modprobe.d/\""},{"line_number":76,"context_line":"      # doesn\u0027t exist."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a1a9d01_02333df7","line":73,"updated":"2015-09-29 11:16:51.000000000","message":"Instead of doing this twice (one here and one below), simply create (after copying stuff from the \"system\") a new file with all the modprobe configurations added in this function (create_ramdisk_base):\n\n echo \"blacklist evbug\" \u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist-dib-ramdisk.conf\"\n\nThe filename should be generic enough to hopefully not clash with any other configuration files possibly installed by packages or created as part of the image building.","commit_id":"0b495461d4496d887004fcac0bf4f342c3c50aff"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a14b378bffd395d643078cbfa46d88013fab4af9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  # the image, sll the files under it should get copied to the ramdisk."},{"line_number":71,"context_line":"  if [ -e \"/etc/modprobe.d/\" ] ; then"},{"line_number":72,"context_line":"      cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":73,"context_line":"      echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":74,"context_line":"  else"},{"line_number":75,"context_line":"      # Retaining existing code so that this gets exscuted if \"/etc/modprobe.d/\""},{"line_number":76,"context_line":"      # doesn\u0027t exist."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a1a9d01_8f79a484","line":73,"in_reply_to":"9a1a9d01_02333df7","updated":"2015-09-29 16:42:32.000000000","message":"Nothing is repeated here.\n1. cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\" : copies the files like /etc/modprobe.d/install-hpdsa.conf or any other such files created during image creation.\n\n2. echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\" :\nIt just appends the evbug driver to the blacklist.conf.\n\nNothing is done twice in these two steps.\n\n\necho \"blacklist evbug\" \u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist-dib-ramdisk.conf\"\nis same as echo \"blacklist evbug\" \u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\". Just changing the filename doesnt solve the issue.","commit_id":"0b495461d4496d887004fcac0bf4f342c3c50aff"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"36f7f592329cf151c5e5590d8b28e42ff85d2f87","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":73,"context_line":"      echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":74,"context_line":"  else"},{"line_number":75,"context_line":"      # Retaining existing code so that this gets exscuted if \"/etc/modprobe.d/\""},{"line_number":76,"context_line":"      # doesn\u0027t exist."},{"line_number":77,"context_line":"      echo \"blacklist evbug\" \u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":78,"context_line":"  fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a1a9d01_4e9de108","line":75,"updated":"2015-09-29 11:16:51.000000000","message":"\"exscuted\" typo","commit_id":"0b495461d4496d887004fcac0bf4f342c3c50aff"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a14b378bffd395d643078cbfa46d88013fab4af9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":73,"context_line":"      echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":74,"context_line":"  else"},{"line_number":75,"context_line":"      # Retaining existing code so that this gets exscuted if \"/etc/modprobe.d/\""},{"line_number":76,"context_line":"      # doesn\u0027t exist."},{"line_number":77,"context_line":"      echo \"blacklist evbug\" \u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":78,"context_line":"  fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a1a9d01_6fdc5073","line":75,"in_reply_to":"9a1a9d01_4e9de108","updated":"2015-09-29 16:42:32.000000000","message":"Thanks","commit_id":"0b495461d4496d887004fcac0bf4f342c3c50aff"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a14b378bffd395d643078cbfa46d88013fab4af9","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  else"},{"line_number":75,"context_line":"      # Retaining existing code so that this gets exscuted if \"/etc/modprobe.d/\""},{"line_number":76,"context_line":"      # doesn\u0027t exist."},{"line_number":77,"context_line":"      echo \"blacklist evbug\" \u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":78,"context_line":"  fi"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  # cjk adding for hwdiscovery support"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a1a9d01_aff588ed","line":77,"updated":"2015-09-29 16:42:32.000000000","message":"I kept this because for fedora elemnt this directory was not existing and cp -rf  was failing. Since hpdsa is required only for ubuntu, i kept original code working.","commit_id":"0b495461d4496d887004fcac0bf4f342c3c50aff"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ab192315460349d3e140d0ef25313f8220d27073","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  # The directory may or may not exist in the image. If the directory exists in"},{"line_number":70,"context_line":"  # the image, all the files under it should get copied to the ramdisk."},{"line_number":71,"context_line":"  if [ -d \"/etc/modprobe.d/\" ] ; then"},{"line_number":72,"context_line":"      cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":73,"context_line":"      echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":74,"context_line":"  else"},{"line_number":75,"context_line":"      # Retaining existing code so that this gets executed if \"/etc/modprobe.d/\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a1a9d01_d4addf84","line":72,"updated":"2015-09-30 00:26:15.000000000","message":"i might use \"cp -a\" here to preserve everything?","commit_id":"e82a0617e97a60848ad5ef695686c55d3cc36c4a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ab192315460349d3e140d0ef25313f8220d27073","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      cp -rf /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":73,"context_line":"      echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":74,"context_line":"  else"},{"line_number":75,"context_line":"      # Retaining existing code so that this gets executed if \"/etc/modprobe.d/\""},{"line_number":76,"context_line":"      # doesn\u0027t exist."},{"line_number":77,"context_line":"      echo \"blacklist evbug\" \u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":78,"context_line":"  fi"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a1a9d01_f49b4364","line":75,"updated":"2015-09-30 00:26:15.000000000","message":"this comment makes less sense when not viewing it in the context of the change; it\u0027s probably pretty clear what this branch does anyway given the above comments","commit_id":"e82a0617e97a60848ad5ef695686c55d3cc36c4a"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"1a1505694fce3d47908fc9b2d9606a9417a23290","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  # The directory may or may not exist in the image. If the directory exists in"},{"line_number":70,"context_line":"  # the image, all the files under it should get copied to the ramdisk."},{"line_number":71,"context_line":"  if [ -d \"/etc/modprobe.d/\" ] ; then"},{"line_number":72,"context_line":"      cp -ar /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":73,"context_line":"      echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":74,"context_line":"  else"},{"line_number":75,"context_line":"      echo \"blacklist evbug\" \u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9a1a9d01_72f5feea","line":72,"updated":"2015-09-30 06:16:23.000000000","message":"This will error out if /etc/modprobe.d/ is empty (and thus /etc/modprobe.d/* will expand to nothing).","commit_id":"d28b95e949021c11f305bd275e001d7fcb073a79"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"1a1505694fce3d47908fc9b2d9606a9417a23290","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  # the image, all the files under it should get copied to the ramdisk."},{"line_number":71,"context_line":"  if [ -d \"/etc/modprobe.d/\" ] ; then"},{"line_number":72,"context_line":"      cp -ar /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":73,"context_line":"      echo \"blacklist evbug\" \u003e\u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":74,"context_line":"  else"},{"line_number":75,"context_line":"      echo \"blacklist evbug\" \u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist.conf\""},{"line_number":76,"context_line":"  fi"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9a1a9d01_d2e64a43","line":73,"updated":"2015-09-30 06:16:23.000000000","message":"As I explained earlier, this line is done twice, i.e. this one and on the other branch of the if. It would be much better to just do it once, like this:\n\n if [ -d \"/etc/modprobe.d/\" ] ; then\n   cp -ar /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\"\n fi\n echo \"blacklist evbug\" \u003e \"$TMP_MOUNT_PATH/etc/modprobe.d/blacklist-dib-ramdisk.conf\"\n\n- the existance of /etc/modproble.d on the host does not matter at all regarding the addition of the blacklist (which needs to be done regardless)\n- the creation of the own modprobe configuration is done just once -- now only with a blacklist line, but if needed more can be added (and always once)\n- a filename like blacklist-dib-ramdisk.conf will hopefully be specific enough to prevent clashes with other modprobe configuration filenames\n- wrt blacklist.conf in /etc/modprobe.d, you are copying anyway\n\nHope this is more clear now.","commit_id":"d28b95e949021c11f305bd275e001d7fcb073a79"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"1db61e2810962b4677eb2b2b577fd86a71b6be7d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  # The directory may or may not exist in the image. If the directory exists in"},{"line_number":70,"context_line":"  # the image, all the files under it should get copied to the ramdisk."},{"line_number":71,"context_line":"  if [ -d \"/etc/modprobe.d/\" ] ; then"},{"line_number":72,"context_line":"      if [ `ls /etc/modprobe.d/ | wc -l` -ne 0 ]; then"},{"line_number":73,"context_line":"          cp -ar /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":74,"context_line":"      fi"},{"line_number":75,"context_line":"  fi"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9a1a9d01_38da05e9","line":72,"updated":"2015-09-30 07:51:47.000000000","message":"Not the best code for this... a better solution would be using find, e.g.:\n\n find /etc/modprobe.d -name \u0027*.conf\u0027 -type f -exec cp -a {} \"$TMP_MOUNT_PATH/etc/modprobe.d/\" \\;\n\nThis way we just copy .conf files from /etc/modproble.d (the only ones read as configuration, anyway).","commit_id":"d63a3d8395f10d1e5353abf968faeb2942fda7aa"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"48b9ccffab1be86a9677e8a42188afcdf52c421f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  # The directory may or may not exist in the image. If the directory exists in"},{"line_number":70,"context_line":"  # the image, all the files under it should get copied to the ramdisk."},{"line_number":71,"context_line":"  if [ -d \"/etc/modprobe.d/\" ] ; then"},{"line_number":72,"context_line":"      if [ `ls /etc/modprobe.d/ | wc -l` -ne 0 ]; then"},{"line_number":73,"context_line":"          cp -ar /etc/modprobe.d/* \"$TMP_MOUNT_PATH/etc/modprobe.d\""},{"line_number":74,"context_line":"      fi"},{"line_number":75,"context_line":"  fi"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9a1a9d01_1eeb69e0","line":72,"in_reply_to":"9a1a9d01_38da05e9","updated":"2015-09-30 08:43:49.000000000","message":"Ok. I will do with your suggestion.","commit_id":"d63a3d8395f10d1e5353abf968faeb2942fda7aa"}]}
