)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"9b598cee0c64cf4cc0ecce8616ec12a802790a21","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a new element hpdsa"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds a new element hpdsa. This element enables"},{"line_number":10,"context_line":"creation of Ubuntu deploy ramdisk and user images which"},{"line_number":11,"context_line":"could be used to deploy the HP Proliant Servers with"},{"line_number":12,"context_line":"Dynamic Smart Array Controllers. Without this driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a1a9d01_422935e5","line":9,"updated":"2015-09-29 11:32:08.000000000","message":"This repeats the commit summary, so it is not needed.","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91a16493640a5058ff70af85ec9504d428bcd7b9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a new element hpdsa"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds a new element hpdsa. This element enables"},{"line_number":10,"context_line":"creation of Ubuntu deploy ramdisk and user images which"},{"line_number":11,"context_line":"could be used to deploy the HP Proliant Servers with"},{"line_number":12,"context_line":"Dynamic Smart Array Controllers. Without this driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a1a9d01_8fa8c48d","line":9,"in_reply_to":"9a1a9d01_422935e5","updated":"2015-09-30 04:23:33.000000000","message":"ok","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"}],"elements/dkms/post-install.d/97-dkms":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"dfbbeb6c6d94d375e57d5317af85453e32d7137d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"ARCH\u003d$__ARCH"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"dkms status"},{"line_number":33,"context_line":"update-initramfs -u"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a1a9d01_c1ed56b8","line":33,"updated":"2015-09-29 00:35:37.000000000","message":"i feel like this should be split out as a dependent change","commit_id":"6d9766e2a013cdbbe4d01757fbac15421e03a473"}],"elements/hpdsa/README.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"58016c0004b97d66a21a534ea32411b435755c75","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Gen9 with Dynamic Smart Array Controllers."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Note: This element enables only ubuntu image/ramdisk to be"},{"line_number":13,"context_line":"updated with the hpdsa driver."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba15a1d1_41605301","line":13,"updated":"2015-09-23 13:31:15.000000000","message":"1. \"This element supports only Ubuntu\"\n\n2. I suspect that this element downloads non-free software. Please mention it here, link to the license would also be handy.","commit_id":"af8a3ff73128da99624b8f22501521db36e41b4f"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"9b598cee0c64cf4cc0ecce8616ec12a802790a21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9a1a9d01_a25db17a","updated":"2015-09-29 11:32:08.000000000","message":"This needs to mention also the supported versions of Ubuntu, if targetting just some.","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91a16493640a5058ff70af85ec9504d428bcd7b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9a1a9d01_afb6e8f6","in_reply_to":"9a1a9d01_a25db17a","updated":"2015-09-30 04:23:33.000000000","message":"See line 12. I am not sure what else are you expecting here.","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"}],"elements/hpdsa/package-installs.yaml":[{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"9b598cee0c64cf4cc0ecce8616ec12a802790a21","unresolved":false,"context_lines":[{"line_number":1,"context_line":"build-essential:"},{"line_number":2,"context_line":"dkms:"},{"line_number":3,"context_line":"linux-headers-generic:"},{"line_number":4,"context_line":"linux-image-generic:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a1a9d01_22ba010b","line":2,"updated":"2015-09-29 11:32:08.000000000","message":"This is installed by the base element already.","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91a16493640a5058ff70af85ec9504d428bcd7b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"build-essential:"},{"line_number":2,"context_line":"dkms:"},{"line_number":3,"context_line":"linux-headers-generic:"},{"line_number":4,"context_line":"linux-image-generic:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a1a9d01_3b62113f","line":2,"in_reply_to":"9a1a9d01_22ba010b","updated":"2015-09-30 04:23:33.000000000","message":"removed","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"9b598cee0c64cf4cc0ecce8616ec12a802790a21","unresolved":false,"context_lines":[{"line_number":1,"context_line":"build-essential:"},{"line_number":2,"context_line":"dkms:"},{"line_number":3,"context_line":"linux-headers-generic:"},{"line_number":4,"context_line":"linux-image-generic:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a1a9d01_e23e498b","line":4,"updated":"2015-09-29 11:32:08.000000000","message":"This is installed by the ubuntu element already.","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91a16493640a5058ff70af85ec9504d428bcd7b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"build-essential:"},{"line_number":2,"context_line":"dkms:"},{"line_number":3,"context_line":"linux-headers-generic:"},{"line_number":4,"context_line":"linux-image-generic:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a1a9d01_fb57b957","line":4,"in_reply_to":"9a1a9d01_e23e498b","updated":"2015-09-30 04:23:33.000000000","message":"Removed","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"c4e2109b0c9d1a451b8b013699d346d71af6dc9b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"build-essential:"},{"line_number":2,"context_line":"curl:"},{"line_number":3,"context_line":"linux-headers-generic:"},{"line_number":4,"context_line":"hpdsa-dkms:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a1a9d01_45a492b8","line":2,"updated":"2015-09-30 20:02:24.000000000","message":"This needs to be marked as phase pre-install.d (otherwise it default to installing at the start of install.d phase).","commit_id":"dfad142ac79460d461a7d109c8a78c28a39214bd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"47c0380e208edc9a41297ade83537bd9f87d79a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"build-essential:"},{"line_number":2,"context_line":"curl:"},{"line_number":3,"context_line":"linux-headers-generic:"},{"line_number":4,"context_line":"hpdsa-dkms:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a1a9d01_97709b0c","line":2,"in_reply_to":"9a1a9d01_45a492b8","updated":"2015-09-30 21:24:09.000000000","message":"done","commit_id":"dfad142ac79460d461a7d109c8a78c28a39214bd"}],"elements/hpdsa/post-install.d/95-hpdsa":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"d4d9e25cb91b0d85f32704b763fd8c7f8fede2cb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"apt-get install --yes dkms"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Add the key"},{"line_number":28,"context_line":"curl http://downloads.linux.hp.com/SDR/hpPublicKey2048_key1.pub | apt-key add -"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#Install hpdsa-dkms"},{"line_number":31,"context_line":"apt-get update"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba15a1d1_20dd8342","line":28,"updated":"2015-09-14 18:06:32.000000000","message":"Please make this https. It is available via a verified cert, and without that, build hosts will be vulnerable to MITM attacks on this key.","commit_id":"0d5f0f163877016d5e41a36110cc5256a5d735ac"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3393591bc59241a6d497a314fa4f8de62ee4b502","unresolved":false,"context_lines":[{"line_number":25,"context_line":"apt-get install --yes dkms"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Add the key"},{"line_number":28,"context_line":"curl http://downloads.linux.hp.com/SDR/hpPublicKey2048_key1.pub | apt-key add -"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#Install hpdsa-dkms"},{"line_number":31,"context_line":"apt-get update"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba15a1d1_17d2f500","line":28,"in_reply_to":"ba15a1d1_20dd8342","updated":"2015-09-15 03:35:57.000000000","message":"Thanks. Will do repost the patch.","commit_id":"0d5f0f163877016d5e41a36110cc5256a5d735ac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"58016c0004b97d66a21a534ea32411b435755c75","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    set -x"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Add hpdsa repository"},{"line_number":10,"context_line":"echo \u0027deb http://downloads.linux.hp.com/SDR/repo/ubuntu-hpdsa trusty main\u0027 \\"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_81418b65","line":7,"updated":"2015-09-23 13:31:15.000000000","message":"please fail early if OS is not Ubuntu","commit_id":"af8a3ff73128da99624b8f22501521db36e41b4f"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"50c3d327f1bcf227cc4f1ee0f18a89cd2ee19dff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Add hpdsa repository"},{"line_number":10,"context_line":"echo \u0027deb http://downloads.linux.hp.com/SDR/repo/ubuntu-hpdsa trusty main\u0027 \\"},{"line_number":11,"context_line":"    \u003e\u003e /etc/apt/sources.list.d/ubuntu-hpdsa.list"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Linux headers, linux-generic and linux-image are required to be of"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_070abd21","line":10,"updated":"2015-09-15 09:04:15.000000000","message":"Setting up repositories and their keys is something to do in pre-install.d scripts, usually.","commit_id":"af8a3ff73128da99624b8f22501521db36e41b4f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ea7ec357fa569a2a540d51f5b89b99617db51bd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Add hpdsa repository"},{"line_number":10,"context_line":"echo \u0027deb http://downloads.linux.hp.com/SDR/repo/ubuntu-hpdsa trusty main\u0027 \\"},{"line_number":11,"context_line":"    \u003e\u003e /etc/apt/sources.list.d/ubuntu-hpdsa.list"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Linux headers, linux-generic and linux-image are required to be of"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_a04ad7aa","line":10,"in_reply_to":"ba15a1d1_070abd21","updated":"2015-09-15 10:14:50.000000000","message":"I can try if that works. As i experimented with this new element pre-install.d didnt work for this driver. I will retry and and if it works will repost the patch.","commit_id":"af8a3ff73128da99624b8f22501521db36e41b4f"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"50c3d327f1bcf227cc4f1ee0f18a89cd2ee19dff","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# Linux headers, linux-generic and linux-image are required to be of"},{"line_number":14,"context_line":"# the version for which dkms is going to create the driver."},{"line_number":15,"context_line":"LINUX_HEADERS\u003dlinux-headers-generic"},{"line_number":16,"context_line":"LINUX_GENERIC\u003dlinux-generic"},{"line_number":17,"context_line":"LINUX_IMAGE\u003dlinux-image-generic"},{"line_number":18,"context_line":"apt-get install --yes $LINUX_HEADERS"},{"line_number":19,"context_line":"apt-get install --yes $LINUX_GENERIC"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_a747514a","line":16,"updated":"2015-09-15 09:04:15.000000000","message":"Why? Isn\u0027t linux-image-generic enough?","commit_id":"af8a3ff73128da99624b8f22501521db36e41b4f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ea7ec357fa569a2a540d51f5b89b99617db51bd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# Linux headers, linux-generic and linux-image are required to be of"},{"line_number":14,"context_line":"# the version for which dkms is going to create the driver."},{"line_number":15,"context_line":"LINUX_HEADERS\u003dlinux-headers-generic"},{"line_number":16,"context_line":"LINUX_GENERIC\u003dlinux-generic"},{"line_number":17,"context_line":"LINUX_IMAGE\u003dlinux-image-generic"},{"line_number":18,"context_line":"apt-get install --yes $LINUX_HEADERS"},{"line_number":19,"context_line":"apt-get install --yes $LINUX_GENERIC"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_a0f8974a","line":16,"in_reply_to":"ba15a1d1_a747514a","updated":"2015-09-15 10:14:50.000000000","message":"i did it as per hp internal document. will see if it works with linux-image-generic alone","commit_id":"af8a3ff73128da99624b8f22501521db36e41b4f"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"50c3d327f1bcf227cc4f1ee0f18a89cd2ee19dff","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# the version for which dkms is going to create the driver."},{"line_number":15,"context_line":"LINUX_HEADERS\u003dlinux-headers-generic"},{"line_number":16,"context_line":"LINUX_GENERIC\u003dlinux-generic"},{"line_number":17,"context_line":"LINUX_IMAGE\u003dlinux-image-generic"},{"line_number":18,"context_line":"apt-get install --yes $LINUX_HEADERS"},{"line_number":19,"context_line":"apt-get install --yes $LINUX_GENERIC"},{"line_number":20,"context_line":"apt-get install --yes $LINUX_IMAGE"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_07587d31","line":17,"updated":"2015-09-15 09:04:15.000000000","message":"The ubuntu element already installs it (see its package-installs.yaml).","commit_id":"af8a3ff73128da99624b8f22501521db36e41b4f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ea7ec357fa569a2a540d51f5b89b99617db51bd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# the version for which dkms is going to create the driver."},{"line_number":15,"context_line":"LINUX_HEADERS\u003dlinux-headers-generic"},{"line_number":16,"context_line":"LINUX_GENERIC\u003dlinux-generic"},{"line_number":17,"context_line":"LINUX_IMAGE\u003dlinux-image-generic"},{"line_number":18,"context_line":"apt-get install --yes $LINUX_HEADERS"},{"line_number":19,"context_line":"apt-get install --yes $LINUX_GENERIC"},{"line_number":20,"context_line":"apt-get install --yes $LINUX_IMAGE"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_c08a6bbf","line":17,"in_reply_to":"ba15a1d1_07587d31","updated":"2015-09-15 10:14:50.000000000","message":"hmmm ok i will remove this and test.","commit_id":"af8a3ff73128da99624b8f22501521db36e41b4f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"58016c0004b97d66a21a534ea32411b435755c75","unresolved":false,"context_lines":[{"line_number":15,"context_line":"LINUX_HEADERS\u003dlinux-headers-generic"},{"line_number":16,"context_line":"LINUX_GENERIC\u003dlinux-generic"},{"line_number":17,"context_line":"LINUX_IMAGE\u003dlinux-image-generic"},{"line_number":18,"context_line":"apt-get install --yes $LINUX_HEADERS"},{"line_number":19,"context_line":"apt-get install --yes $LINUX_GENERIC"},{"line_number":20,"context_line":"apt-get install --yes $LINUX_IMAGE"},{"line_number":21,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_a1460f79","line":18,"updated":"2015-09-23 13:31:15.000000000","message":"++ for package-installs","commit_id":"af8a3ff73128da99624b8f22501521db36e41b4f"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"50c3d327f1bcf227cc4f1ee0f18a89cd2ee19dff","unresolved":false,"context_lines":[{"line_number":15,"context_line":"LINUX_HEADERS\u003dlinux-headers-generic"},{"line_number":16,"context_line":"LINUX_GENERIC\u003dlinux-generic"},{"line_number":17,"context_line":"LINUX_IMAGE\u003dlinux-image-generic"},{"line_number":18,"context_line":"apt-get install --yes $LINUX_HEADERS"},{"line_number":19,"context_line":"apt-get install --yes $LINUX_GENERIC"},{"line_number":20,"context_line":"apt-get install --yes $LINUX_IMAGE"},{"line_number":21,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_07a63d10","line":18,"updated":"2015-09-15 09:04:15.000000000","message":"Even if this is specific for a distribution, please use install-packages to install stuff, as it is used everywhere else in dib. But you can just use the package-installs element, and specify the packages to install in a simplier and declarative format.","commit_id":"af8a3ff73128da99624b8f22501521db36e41b4f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ea7ec357fa569a2a540d51f5b89b99617db51bd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"LINUX_HEADERS\u003dlinux-headers-generic"},{"line_number":16,"context_line":"LINUX_GENERIC\u003dlinux-generic"},{"line_number":17,"context_line":"LINUX_IMAGE\u003dlinux-image-generic"},{"line_number":18,"context_line":"apt-get install --yes $LINUX_HEADERS"},{"line_number":19,"context_line":"apt-get install --yes $LINUX_GENERIC"},{"line_number":20,"context_line":"apt-get install --yes $LINUX_IMAGE"},{"line_number":21,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_809473e2","line":18,"in_reply_to":"ba15a1d1_07a63d10","updated":"2015-09-15 10:14:50.000000000","message":"Thats good advise. will try to follow this.","commit_id":"af8a3ff73128da99624b8f22501521db36e41b4f"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"9b598cee0c64cf4cc0ecce8616ec12a802790a21","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [ $DISTRO_NAME \u003d \u0027ubuntu\u0027 ] ; then"},{"line_number":10,"context_line":"    #Install hpdsa-dkms"},{"line_number":11,"context_line":"    apt-get install hpdsa-dkms"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    # Blacklist the ahci driver for hpdsa to recognize the disks."},{"line_number":14,"context_line":"    # It can also be done with element \"modprobe-blacklist\" which"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a1a9d01_02f01dc8","line":11,"updated":"2015-09-29 11:32:08.000000000","message":"Please use package-installs for this.","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91a16493640a5058ff70af85ec9504d428bcd7b9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [ $DISTRO_NAME \u003d \u0027ubuntu\u0027 ] ; then"},{"line_number":10,"context_line":"    #Install hpdsa-dkms"},{"line_number":11,"context_line":"    apt-get install hpdsa-dkms"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    # Blacklist the ahci driver for hpdsa to recognize the disks."},{"line_number":14,"context_line":"    # It can also be done with element \"modprobe-blacklist\" which"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a1a9d01_a3126f55","line":11,"in_reply_to":"9a1a9d01_02f01dc8","updated":"2015-09-30 04:23:33.000000000","message":"Ok","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91a16493640a5058ff70af85ec9504d428bcd7b9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [ $DISTRO_NAME \u003d \u0027ubuntu\u0027 ] ; then"},{"line_number":10,"context_line":"    #Install hpdsa-dkms"},{"line_number":11,"context_line":"    apt-get install hpdsa-dkms"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    # Blacklist the ahci driver for hpdsa to recognize the disks."},{"line_number":14,"context_line":"    # It can also be done with element \"modprobe-blacklist\" which"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a1a9d01_bb2861e3","line":11,"in_reply_to":"9a1a9d01_02f01dc8","updated":"2015-09-30 04:23:33.000000000","message":"ok done.","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"9b598cee0c64cf4cc0ecce8616ec12a802790a21","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    # To be on safer side, blacklist the driver ahci without the"},{"line_number":17,"context_line":"    # element \"modprobe-blacklist\" also."},{"line_number":18,"context_line":"    echo \"blacklist ahci\" \u003e\u003e /etc/modprobe.d/install-hpdsa.conf"},{"line_number":19,"context_line":"    update-initramfs -u"},{"line_number":20,"context_line":"    echo \"hpdsa\" \u003e\u003e /etc/modules"},{"line_number":21,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a1a9d01_428cd5d9","line":19,"updated":"2015-09-29 11:32:08.000000000","message":"Why is this done twice? Shouldn\u0027t 98-hpdsa-post-dkms be enough?","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91a16493640a5058ff70af85ec9504d428bcd7b9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    # To be on safer side, blacklist the driver ahci without the"},{"line_number":17,"context_line":"    # element \"modprobe-blacklist\" also."},{"line_number":18,"context_line":"    echo \"blacklist ahci\" \u003e\u003e /etc/modprobe.d/install-hpdsa.conf"},{"line_number":19,"context_line":"    update-initramfs -u"},{"line_number":20,"context_line":"    echo \"hpdsa\" \u003e\u003e /etc/modules"},{"line_number":21,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a1a9d01_2fbf38ab","line":19,"in_reply_to":"9a1a9d01_428cd5d9","updated":"2015-09-30 04:23:33.000000000","message":"hmmm yeah good catch","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"}],"elements/hpdsa/post-install.d/98-hpdsa-post-dkms":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"c4e2109b0c9d1a451b8b013699d346d71af6dc9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9a1a9d01_85f14a97","updated":"2015-09-30 20:02:24.000000000","message":"Based on the name of this file - is this intended to run after dkms? dkms runs at 99- in post-install, so it will still run after this script. If we do want this to run after dkms, we should move 99-dkms up (I\u0027d suggest to 85).","commit_id":"dfad142ac79460d461a7d109c8a78c28a39214bd"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"8ff599058a249443dac428b0786d9c09123bc731","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9a1a9d01_45157299","in_reply_to":"9a1a9d01_85f14a97","updated":"2015-09-30 20:03:38.000000000","message":"hah, I missed the parent patch, sorry!","commit_id":"dfad142ac79460d461a7d109c8a78c28a39214bd"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"c4e2109b0c9d1a451b8b013699d346d71af6dc9b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# This is required for HPDSA driver to be included in the"},{"line_number":10,"context_line":"# ramdisk of the image."},{"line_number":11,"context_line":"update-initramfs -u"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9a1a9d01_e5f6068e","line":11,"updated":"2015-09-30 20:02:24.000000000","message":"Could we move this to run after dkms in the dkms element? This really needs to only be run once per image build, and it seems like adding it there would take care of all use cases which would need this.","commit_id":"dfad142ac79460d461a7d109c8a78c28a39214bd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"47c0380e208edc9a41297ade83537bd9f87d79a4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# This is required for HPDSA driver to be included in the"},{"line_number":10,"context_line":"# ramdisk of the image."},{"line_number":11,"context_line":"update-initramfs -u"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9a1a9d01_f46eb5fe","line":11,"in_reply_to":"9a1a9d01_e5f6068e","updated":"2015-09-30 21:24:09.000000000","message":"While i agree to the comment that it sbetter to do in common path and I had done this in patch set 4 or 5. But then it fails for fedora.\nI had two options:\n1. To add it as part of hpdsa so that it doesnt impact anything else.\n2. To add distro check in dkms element and execute update-initramfs for ubuntu and for fedora other suitable command. Fedora doesnt understand \"update-initramfs\" instead understands \"dracut...\" for the same actions.\n\nI have no way to test it for fedora if i add it in common element dkms, hence retaining it under hpdsa element only i.e. going by option 1.","commit_id":"dfad142ac79460d461a7d109c8a78c28a39214bd"}],"elements/hpdsa/pre-install.d/06-hpdsa":[{"author":{"_account_id":17789,"name":"Zhao Lei","email":"zhaolei@cn.fujitsu.com","username":"zhaolei"},"change_message_id":"0778b894980ebf96925a337fd95ec4c231d3d50d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# "},{"line_number":10,"context_line":"# Add hpdsa repository"},{"line_number":11,"context_line":"echo \u0027deb http://downloads.linux.hp.com/SDR/repo/ubuntu-hpdsa trusty main\u0027 \\"},{"line_number":12,"context_line":"    \u003e\u003e /etc/apt/sources.list.d/ubuntu-hpdsa.list"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a1a9d01_7f4f3a6b","line":9,"updated":"2015-09-29 06:02:41.000000000","message":"trailing whitespace","commit_id":"6d9766e2a013cdbbe4d01757fbac15421e03a473"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"dfbbeb6c6d94d375e57d5317af85453e32d7137d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# "},{"line_number":10,"context_line":"# Add hpdsa repository"},{"line_number":11,"context_line":"echo \u0027deb http://downloads.linux.hp.com/SDR/repo/ubuntu-hpdsa trusty main\u0027 \\"},{"line_number":12,"context_line":"    \u003e\u003e /etc/apt/sources.list.d/ubuntu-hpdsa.list"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Add the key"},{"line_number":15,"context_line":"curl https://downloads.linux.hp.com/SDR/hpPublicKey2048_key1.pub | apt-key add -"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a1a9d01_a11e22b9","line":12,"updated":"2015-09-29 00:35:37.000000000","message":"i know you mention it in the doc, but it might be nice to check DISTRO and bail out if not on trusty.","commit_id":"6d9766e2a013cdbbe4d01757fbac15421e03a473"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"9b598cee0c64cf4cc0ecce8616ec12a802790a21","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# Add hpdsa repository"},{"line_number":11,"context_line":"if [ $DISTRO_NAME \u003d \u0027ubuntu\u0027 ] ; then"},{"line_number":12,"context_line":"    echo \u0027deb http://downloads.linux.hp.com/SDR/repo/ubuntu-hpdsa trusty main\u0027 \\"},{"line_number":13,"context_line":"        \u003e\u003e /etc/apt/sources.list.d/ubuntu-hpdsa.list"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    # Add the key"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a1a9d01_42cdb564","line":12,"updated":"2015-09-29 11:32:08.000000000","message":"Either you use $DIB_RELEASE instead of trusty, or bail out if the version is not trusty.","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"91a16493640a5058ff70af85ec9504d428bcd7b9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# Add hpdsa repository"},{"line_number":11,"context_line":"if [ $DISTRO_NAME \u003d \u0027ubuntu\u0027 ] ; then"},{"line_number":12,"context_line":"    echo \u0027deb http://downloads.linux.hp.com/SDR/repo/ubuntu-hpdsa trusty main\u0027 \\"},{"line_number":13,"context_line":"        \u003e\u003e /etc/apt/sources.list.d/ubuntu-hpdsa.list"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    # Add the key"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a1a9d01_fbad7984","line":12,"in_reply_to":"9a1a9d01_42cdb564","updated":"2015-09-30 04:23:33.000000000","message":"Ok used teh variable.","commit_id":"efc4e4b95a4c2486f3d516c63e8cd2a16ccdc5f5"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"5e010d63e0fa1a4ea240ad5cece71ad43d9818aa","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DIB_RELEASE\u003d${DIB_RELEASE:-trusty}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# Add hpdsa repository"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9a1a9d01_12fcc26e","line":9,"updated":"2015-09-30 06:34:52.000000000","message":"$DIB_RELEASE is always set already, so you don\u0027t need to get a default value for it.","commit_id":"cc8716b4bc149de1f63bf717de79df88f33254af"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"d511992c61fdd6b7d6afea050539e89208be08f0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DIB_RELEASE\u003d${DIB_RELEASE:-trusty}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# Add hpdsa repository"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9a1a9d01_dbcdfe31","line":9,"updated":"2015-09-30 10:24:24.000000000","message":"This is redundant, and will do nothing (since $DIB_RELEASE is always set, either by user or with the default distribution value).","commit_id":"aa01ba629e5886ef3e2ce3a34adf8af80e27fa2a"},{"author":{"_account_id":12320,"name":"Pino Toscano","email":"ptoscano@redhat.com","username":"ptoscano"},"change_message_id":"d511992c61fdd6b7d6afea050539e89208be08f0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    \u003e\u003e /etc/apt/sources.list.d/ubuntu-hpdsa.list"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Add the key"},{"line_number":17,"context_line":"curl https://downloads.linux.hp.com/SDR/hpPublicKey2048_key1.pub | apt-key add -"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9a1a9d01_5b01ee36","line":17,"updated":"2015-09-30 10:24:24.000000000","message":"If you are using curl, make sure that curl is available on the image: add\n\n curl:\n   phase: pre-install.d\n\nin package-installs.yaml","commit_id":"aa01ba629e5886ef3e2ce3a34adf8af80e27fa2a"}]}