)]}'
{"elements/rhel7/README.rst":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"43f3449565c2f1f07b17290250524390efcf21fd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Then before running the image build, define DIB_LOCAL_IMAGE (replace the"},{"line_number":14,"context_line":"file name with the one downloaded, if it differs from the example)::"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    export DIB_LOCAL_IMAGE\u003drhel-guest-image-7.1-20150224.0.x86_64.qcow2"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The downloaded file will then be used as the basis for any subsequent"},{"line_number":19,"context_line":"image builds."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_45a44956","line":16,"updated":"2015-09-14 17:52:56.000000000","message":"It\u0027s confusing why this is \"DIB_LOCAL_IMAGE\" but the code below is \"BASE_IMAGE_FILE\". Can you maybe reference that in the commit message? Or is that a legitimate problem?","commit_id":"b39faacc1e5ddc3eca03b299b967b0fffa56b015"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"86e5b4291484be5afdee13931973780bc002420c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Then before running the image build, define DIB_LOCAL_IMAGE (replace the"},{"line_number":14,"context_line":"file name with the one downloaded, if it differs from the example)::"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    export DIB_LOCAL_IMAGE\u003drhel-guest-image-7.1-20150224.0.x86_64.qcow2"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The downloaded file will then be used as the basis for any subsequent"},{"line_number":19,"context_line":"image builds."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_200ca393","line":16,"in_reply_to":"ba15a1d1_45a44956","updated":"2015-09-14 18:13:09.000000000","message":"They\u0027re actually two separate things - DIB_LOCAL_IMAGE is the first branch of the code, BASE_IMAGE_FILE is used in the second branch.  I only changed BASE_IMAGE_FILE to make it more clear what is wrong when a user forgets to set DIB_LOCAL_IMAGE.\n\nI also didn\u0027t just make that path an error because it is still valid to point dib at a local server with the base image, in which case you would override BASE_IMAGE_FILE (among other things).\n\nI can probably just copy-paste ^ into the commit message.","commit_id":"b39faacc1e5ddc3eca03b299b967b0fffa56b015"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6579b2c571a7abd32d2b8aef4d6a12f1547af599","unresolved":false,"context_lines":[{"line_number":9,"context_line":"environment variable."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The cloud image can be found at (login required):"},{"line_number":12,"context_line":"https://access.redhat.com/downloads/content/69/ver\u003d/rhel---7/7.1/x86_64/product-downloads"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Then before running the image build, define DIB_LOCAL_IMAGE (replace the file"},{"line_number":15,"context_line":"name with the one downloaded, if it differs from the example)::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a2fa921_88df4339","line":12,"updated":"2015-10-09 07:52:25.000000000","message":"this looks like a pretty fragile URL, might be best to just say to download it from rhn or something?","commit_id":"77d917441a9c1efa6abf9a4db0681d8dd4d274c0"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0c9090751548a2c2f0d7dff2bde3dadd4bd28afb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"environment variable."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The cloud image can be found at (login required):"},{"line_number":12,"context_line":"https://access.redhat.com/downloads/content/69/ver\u003d/rhel---7/7.1/x86_64/product-downloads"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Then before running the image build, define DIB_LOCAL_IMAGE (replace the file"},{"line_number":15,"context_line":"name with the one downloaded, if it differs from the example)::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a2fa921_a3e1a4d2","line":12,"in_reply_to":"7a2fa921_88df4339","updated":"2015-10-12 18:43:13.000000000","message":"I agree it\u0027s ugly, but this is the same type of URL that we use in our product docs, so it _shouldn\u0027t_ change.  If it does then we need to have a talk with the people who make these images available and our docs team.","commit_id":"77d917441a9c1efa6abf9a4db0681d8dd4d274c0"}],"elements/rhel7/root.d/10-rhel7-cloud-image":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"32127156a87a262543e21830017a0acf257cd631","unresolved":false,"context_lines":[{"line_number":28,"context_line":"else"},{"line_number":29,"context_line":"    DIB_RELEASE\u003d${DIB_RELEASE:-latest}"},{"line_number":30,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-https://access.redhat.com}"},{"line_number":31,"context_line":"    BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-\u0027See element readme for details on how to obtain a base image\u0027}"},{"line_number":32,"context_line":"    BASE_IMAGE_TAR\u003d$DIB_RELEASE-rhel-server-$ARCH-latest.tgz"},{"line_number":33,"context_line":"    IMAGE_LOCATION\u003d$DIB_CLOUD_IMAGES/$BASE_IMAGE_FILE"},{"line_number":34,"context_line":"    CACHED_IMAGE\u003d$DIB_IMAGE_CACHE/$BASE_IMAGE_FILE"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_81fbcb7a","line":31,"updated":"2015-09-23 13:23:46.000000000","message":"I\u0027d prefer a proper error message:\n\n if [ -z \"$BASE_IMAGE_FILE\" ]; then\n   echo \"See rhel7 element readme for details on how to obtain and configure a base image\"\n   exit 1\n fi","commit_id":"2230e62e261c26ee00d793750d4153f1c0060812"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"f878cb6fce5b456d53601d7862ec0809c81b9f29","unresolved":false,"context_lines":[{"line_number":28,"context_line":"else"},{"line_number":29,"context_line":"    DIB_RELEASE\u003d${DIB_RELEASE:-latest}"},{"line_number":30,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-https://access.redhat.com}"},{"line_number":31,"context_line":"    BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-\u0027See element readme for details on how to obtain a base image\u0027}"},{"line_number":32,"context_line":"    BASE_IMAGE_TAR\u003d$DIB_RELEASE-rhel-server-$ARCH-latest.tgz"},{"line_number":33,"context_line":"    IMAGE_LOCATION\u003d$DIB_CLOUD_IMAGES/$BASE_IMAGE_FILE"},{"line_number":34,"context_line":"    CACHED_IMAGE\u003d$DIB_IMAGE_CACHE/$BASE_IMAGE_FILE"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba15a1d1_645d6546","line":31,"in_reply_to":"ba15a1d1_81fbcb7a","updated":"2015-09-23 14:04:25.000000000","message":"This was just a courtesy to people who didn\u0027t RTFM, but I guess I can do that.","commit_id":"2230e62e261c26ee00d793750d4153f1c0060812"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"4903c15e55286f2db97b1ceecfc8d0fb0a673329","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"},{"line_number":28,"context_line":"else"},{"line_number":29,"context_line":"    if [ -z \"${BASE_IMAGE_FILE:-}\" -o -z \"${DIB_CLOUD_IMAGES}\" ]; then"},{"line_number":30,"context_line":"        echo \"See element readme for details on how to obtain a base image.\""},{"line_number":31,"context_line":"        exit 1"},{"line_number":32,"context_line":"    fi"},{"line_number":33,"context_line":"    DIB_RELEASE\u003d${DIB_RELEASE:-latest}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7a2fa921_2e657be0","line":30,"updated":"2015-10-12 18:56:34.000000000","message":"Sorry to nitpick on this, but this error message would be a ton more helpful if it had a bit more context (Missing required env vars. See rhel7 element readme...)","commit_id":"77d917441a9c1efa6abf9a4db0681d8dd4d274c0"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"13e100222b34fc84ffdc206664159473a1b1f275","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"},{"line_number":28,"context_line":"else"},{"line_number":29,"context_line":"    if [ -z \"${BASE_IMAGE_FILE:-}\" -o -z \"${DIB_CLOUD_IMAGES}\" ]; then"},{"line_number":30,"context_line":"        echo \"See element readme for details on how to obtain a base image.\""},{"line_number":31,"context_line":"        exit 1"},{"line_number":32,"context_line":"    fi"},{"line_number":33,"context_line":"    DIB_RELEASE\u003d${DIB_RELEASE:-latest}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7a2fa921_6125c1ac","line":30,"in_reply_to":"7a2fa921_2e657be0","updated":"2015-10-12 20:39:18.000000000","message":"Done","commit_id":"77d917441a9c1efa6abf9a4db0681d8dd4d274c0"}]}