)]}'
{"elements/ironic-agent/element-deps":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"5a62d33346c9357ba2fd6a36a6ed60296879bb40","unresolved":false,"context_lines":[{"line_number":1,"context_line":"dhcp-all-interfaces"},{"line_number":2,"context_line":"dib-init-system"},{"line_number":3,"context_line":"package-installs"},{"line_number":4,"context_line":"pip-and-virtualenv"},{"line_number":5,"context_line":"pkg-map"},{"line_number":6,"context_line":"source-repositories"},{"line_number":7,"context_line":"svc-map"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"9a8ffd7b_5dd87fef","line":4,"updated":"2015-11-25 21:02:31.000000000","message":"This makes diskimage-builder depend on tripleo-image-elements unless Id294f0936c8fef8a3b27a415bfcc93b3f327e104 is merged (adding pip-and-virtualenv to diskimage-builder\u0027s elements)","commit_id":"eb4de3b906aab9c3d1e937737be4b27b311e3e21"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d6da5215aa75ad70fd59a2c3ac7e34756f4f0666","unresolved":false,"context_lines":[{"line_number":1,"context_line":"dhcp-all-interfaces"},{"line_number":2,"context_line":"dib-init-system"},{"line_number":3,"context_line":"package-installs"},{"line_number":4,"context_line":"pip-and-virtualenv"},{"line_number":5,"context_line":"pkg-map"},{"line_number":6,"context_line":"source-repositories"},{"line_number":7,"context_line":"svc-map"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"9a8ffd7b_3874a966","line":4,"in_reply_to":"9a8ffd7b_5dd87fef","updated":"2015-11-25 21:16:33.000000000","message":"Right, yes. Once that patch is sorted out I\u0027m going to update this one","commit_id":"eb4de3b906aab9c3d1e937737be4b27b311e3e21"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e87f15714b0abbdf5db8a0fa7da6e097e0b46936","unresolved":false,"context_lines":[{"line_number":1,"context_line":"dhcp-all-interfaces"},{"line_number":2,"context_line":"dib-init-system"},{"line_number":3,"context_line":"package-installs"},{"line_number":4,"context_line":"pip-and-virtualenv"},{"line_number":5,"context_line":"pkg-map"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9a8ffd7b_bad4debc","line":2,"updated":"2015-11-26 15:51:10.000000000","message":"this should not be here, it\u0027s a basic dependency. everything already depends on it","commit_id":"a453efc9c96f567eb044084574d7f3e036a2e8f6"}],"elements/ironic-agent/install.d/ironic-agent-source-install/60-ironic-agent-install":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6bb076156f8676d6f3825ffbb1a6dcf9b1b7ce92","unresolved":false,"context_lines":[{"line_number":27,"context_line":"pip install -r requirements.txt"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# install IPA"},{"line_number":30,"context_line":"pip install ."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# deactivate the venv"},{"line_number":33,"context_line":"deactivate"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5a2ca52d_c15c517f","line":30,"updated":"2015-10-16 12:07:18.000000000","message":"the current directory is /usr/share/ironic-python-agent/venv. I guess you wanted:\n\n mkdir -p /usr/share/ironic-python-agent\n virtualenv /usr/share/ironic-python-agent/venv\n source  /usr/share/ironic-python-agent/venv/bin/activate\n ...","commit_id":"300705be7d7ba3f63007d28094d8f289aec49728"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d1a19eb7a394fff13742b19c4e0d3a5fb6dd692e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"pip install -r requirements.txt"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# install IPA"},{"line_number":30,"context_line":"pip install ."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# deactivate the venv"},{"line_number":33,"context_line":"deactivate"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5a2ca52d_ebb36398","line":30,"in_reply_to":"5a2ca52d_c15c517f","updated":"2015-10-16 14:23:12.000000000","message":"RIght, that would work too. See L19 I cd into the directory","commit_id":"300705be7d7ba3f63007d28094d8f289aec49728"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"afdb10ac895c2a7569620f5b15d5921618b3cbf8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"pip install -r requirements.txt"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# install IPA"},{"line_number":30,"context_line":"pip install ."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# deactivate the venv"},{"line_number":33,"context_line":"deactivate"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5a2ca52d_31beae65","line":30,"in_reply_to":"5a2ca52d_ebb36398","updated":"2015-10-16 14:56:22.000000000","message":"Ah, I didn\u0027t notice the source-repo change, so I was assuming it\u0027s still in /tmp","commit_id":"300705be7d7ba3f63007d28094d8f289aec49728"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9af49851b1cef073ca429b733d81fbe7d00d6602","unresolved":false,"context_lines":[{"line_number":16,"context_line":"rm -f /tmp/get-pip.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# create the venv"},{"line_number":19,"context_line":"pip install -U virtualenv"},{"line_number":20,"context_line":"virtualenv $IPADIR/venv"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# activate the venv"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a29b11f_1d895375","line":19,"updated":"2015-10-21 15:00:46.000000000","message":"add virtualenv to package-installs and pkg-map?","commit_id":"0387556da3ea92b2a565fda577dbfc7af01523d4"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"a05325d0ae61e6c65251cc6f4a12ea6f3d628812","unresolved":false,"context_lines":[{"line_number":16,"context_line":"rm -f /tmp/get-pip.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# create the venv"},{"line_number":19,"context_line":"pip install -U virtualenv"},{"line_number":20,"context_line":"virtualenv $IPADIR/venv"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# activate the venv"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a29b11f_aff586ed","line":19,"in_reply_to":"3a29b11f_1d895375","updated":"2015-10-21 15:08:38.000000000","message":"sorry, just realised this is source install :/","commit_id":"0387556da3ea92b2a565fda577dbfc7af01523d4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aefbf66e96cbea6ad8fbc014bb586510a3162fb3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# activate the venv"},{"line_number":23,"context_line":"# NOTE(lucasagomes): we have to set +o nounset before the activation"},{"line_number":24,"context_line":"# of an virtualenv or the activation will fail because there are some"},{"line_number":25,"context_line":"# variables that are unbond."},{"line_number":26,"context_line":"set +o nounset"},{"line_number":27,"context_line":"source $IPADIR/venv/bin/activate"},{"line_number":28,"context_line":"set -o nounset"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a29b11f_62e6adb1","line":25,"updated":"2015-10-21 13:08:20.000000000","message":"maybe it\u0027s better to just use the explicit path $IPADIR/venv/bin/something? we can set $IPABINDIR\u003d$IPADIR/venv/bin and then use e.g. $IPABINDIR/pip install ...","commit_id":"0387556da3ea92b2a565fda577dbfc7af01523d4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ead91fccad8d42955f757bba95f9ee4218ea5013","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# activate the venv"},{"line_number":23,"context_line":"# NOTE(lucasagomes): we have to set +o nounset before the activation"},{"line_number":24,"context_line":"# of an virtualenv or the activation will fail because there are some"},{"line_number":25,"context_line":"# variables that are unbond."},{"line_number":26,"context_line":"set +o nounset"},{"line_number":27,"context_line":"source $IPADIR/venv/bin/activate"},{"line_number":28,"context_line":"set -o nounset"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a29b11f_bd0cdfec","line":25,"in_reply_to":"3a29b11f_62e6adb1","updated":"2015-10-21 14:55:49.000000000","message":"We just use the /venv/bin/\u003csomething\u003e to activate the virtual env, is it really necessary?","commit_id":"0387556da3ea92b2a565fda577dbfc7af01523d4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aefbf66e96cbea6ad8fbc014bb586510a3162fb3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"deactivate"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# copy IPA launcher script so services can use it"},{"line_number":41,"context_line":"cp ${SCRIPTDIR}/ironic-python-agent.sh /usr/bin/ironic-python-agent"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"case \"$DIB_INIT_SYSTEM\" in"},{"line_number":44,"context_line":"    upstart)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a29b11f_82ebc977","line":41,"updated":"2015-10-21 13:08:20.000000000","message":"ln -s $IPABINDIR/ironic-python-agent /usr/bin/ironic-python-agent","commit_id":"0387556da3ea92b2a565fda577dbfc7af01523d4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ead91fccad8d42955f757bba95f9ee4218ea5013","unresolved":false,"context_lines":[{"line_number":38,"context_line":"deactivate"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# copy IPA launcher script so services can use it"},{"line_number":41,"context_line":"cp ${SCRIPTDIR}/ironic-python-agent.sh /usr/bin/ironic-python-agent"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"case \"$DIB_INIT_SYSTEM\" in"},{"line_number":44,"context_line":"    upstart)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a29b11f_dd119b05","line":41,"in_reply_to":"3a29b11f_82ebc977","updated":"2015-10-21 14:55:49.000000000","message":"Done","commit_id":"0387556da3ea92b2a565fda577dbfc7af01523d4"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"403e91e7f4ab33cc5f4991b232f818476fda4fd7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"rm -f /tmp/get-pip.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# create the venv"},{"line_number":19,"context_line":"pip install -U virtualenv"},{"line_number":20,"context_line":"virtualenv $IPADIR/venv"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IPABINDIR\u003d$IPADIR/venv/bin"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa80f949_fbaaea84","line":19,"updated":"2015-11-03 19:48:14.000000000","message":"Yes - please base this on the virtuelenv element patch.","commit_id":"5c886ef7015e2a5abb0a6e33358fc2299e291827"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"581ed3a48951021e15868719a2370d19ed7e2993","unresolved":false,"context_lines":[{"line_number":16,"context_line":"rm -f /tmp/get-pip.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# create the venv"},{"line_number":19,"context_line":"pip install -U virtualenv"},{"line_number":20,"context_line":"virtualenv $IPADIR/venv"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IPABINDIR\u003d$IPADIR/venv/bin"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a26ad4f_b10183b1","line":19,"updated":"2015-11-02 02:58:10.000000000","message":"this is a pretty global thing to do ... would it be better to depend on an element that ensures you\u0027ve got this installed?  e.g. Id294f0936c8fef8a3b27a415bfcc93b3f327e104","commit_id":"5c886ef7015e2a5abb0a6e33358fc2299e291827"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f504da318428b536d7dc5fc5598391d62da4aafd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"rm -f /tmp/get-pip.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# create the venv"},{"line_number":19,"context_line":"pip install -U virtualenv"},{"line_number":20,"context_line":"virtualenv $IPADIR/venv"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IPABINDIR\u003d$IPADIR/venv/bin"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ba8a016a_69a8d420","line":19,"in_reply_to":"fa80f949_fbaaea84","updated":"2015-11-19 10:42:19.000000000","message":"Done","commit_id":"5c886ef7015e2a5abb0a6e33358fc2299e291827"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"581ed3a48951021e15868719a2370d19ed7e2993","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# install dependencies"},{"line_number":33,"context_line":"$IPABINDIR/pip install -U setuptools"},{"line_number":34,"context_line":"$IPABINDIR/pip install -r $IPADIR/requirements.txt"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# install IPA"},{"line_number":37,"context_line":"$IPABINDIR/pip install $IPADIR"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a26ad4f_51290f36","line":34,"updated":"2015-11-02 02:58:10.000000000","message":"is this really required?  pip should pick this up when installing directly?","commit_id":"5c886ef7015e2a5abb0a6e33358fc2299e291827"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f504da318428b536d7dc5fc5598391d62da4aafd","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# install dependencies"},{"line_number":33,"context_line":"$IPABINDIR/pip install -U setuptools"},{"line_number":34,"context_line":"$IPABINDIR/pip install -r $IPADIR/requirements.txt"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# install IPA"},{"line_number":37,"context_line":"$IPABINDIR/pip install $IPADIR"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ba8a016a_097028db","line":34,"in_reply_to":"1a26ad4f_51290f36","updated":"2015-11-19 10:42:19.000000000","message":"Not sure, maybe not... I will try without it","commit_id":"5c886ef7015e2a5abb0a6e33358fc2299e291827"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"403e91e7f4ab33cc5f4991b232f818476fda4fd7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"deactivate"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# copy IPA launcher script so services can use it"},{"line_number":43,"context_line":"cp ${SCRIPTDIR}/ironic-python-agent.sh /usr/bin/ironic-python-agent"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"case \"$DIB_INIT_SYSTEM\" in"},{"line_number":46,"context_line":"    upstart)"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa80f949_1bb00ef4","line":43,"updated":"2015-11-03 19:48:14.000000000","message":"This can go away with the fix below","commit_id":"5c886ef7015e2a5abb0a6e33358fc2299e291827"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"5a62d33346c9357ba2fd6a36a6ed60296879bb40","unresolved":false,"context_lines":[{"line_number":21,"context_line":"set -o nounset"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# install IPA"},{"line_number":24,"context_line":"pip install $IPADIR"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# deactivate the venv"},{"line_number":27,"context_line":"deactivate"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9a8ffd7b_9dd587ba","line":24,"updated":"2015-11-25 21:02:31.000000000","message":"I believe you want this:\n\n    pip install --install-options\u003d\"--install-scripts\u003d/usr/local/bin\"","commit_id":"eb4de3b906aab9c3d1e937737be4b27b311e3e21"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d6da5215aa75ad70fd59a2c3ac7e34756f4f0666","unresolved":false,"context_lines":[{"line_number":21,"context_line":"set -o nounset"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# install IPA"},{"line_number":24,"context_line":"pip install $IPADIR"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# deactivate the venv"},{"line_number":27,"context_line":"deactivate"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9a8ffd7b_f8bf01f9","line":24,"in_reply_to":"9a8ffd7b_9dd587ba","updated":"2015-11-25 21:16:33.000000000","message":"Will try it out, thanks","commit_id":"eb4de3b906aab9c3d1e937737be4b27b311e3e21"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"5a62d33346c9357ba2fd6a36a6ed60296879bb40","unresolved":false,"context_lines":[{"line_number":27,"context_line":"deactivate"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# create the launcher link so services can use it"},{"line_number":30,"context_line":"ln -s $IPADIR/venv/bin/ironic-python-agent /usr/local/bin/ironic-python-agent"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9a8ffd7b_3ddd7be0","line":30,"updated":"2015-11-25 21:02:31.000000000","message":"If you do the --install-scripts bit, you don\u0027t need the symlink.","commit_id":"eb4de3b906aab9c3d1e937737be4b27b311e3e21"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d6da5215aa75ad70fd59a2c3ac7e34756f4f0666","unresolved":false,"context_lines":[{"line_number":27,"context_line":"deactivate"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# create the launcher link so services can use it"},{"line_number":30,"context_line":"ln -s $IPADIR/venv/bin/ironic-python-agent /usr/local/bin/ironic-python-agent"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9a8ffd7b_78cb11a6","line":30,"in_reply_to":"9a8ffd7b_3ddd7be0","updated":"2015-11-25 21:16:33.000000000","message":"Ah cool, thanks. I didn\u0027t know it was possible","commit_id":"eb4de3b906aab9c3d1e937737be4b27b311e3e21"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"db4f9eb0c7b1c329f198588e388b0f8b7fb25144","unresolved":false,"context_lines":[{"line_number":21,"context_line":"set -o nounset"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# install IPA"},{"line_number":24,"context_line":"pip install $IPADIR --install-options\u003d\"--install-scripts\u003d/usr/local/bin\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# deactivate the venv"},{"line_number":27,"context_line":"deactivate"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9a8ffd7b_da32075f","line":24,"updated":"2015-11-26 14:54:34.000000000","message":"This is giving me \n\nNew python executable in /usr/share/ironic-python-agent/venv/bin/python\nInstalling setuptools, pip, wheel...done.\n\nUsage:   \n  pip install [options] \u003crequirement specifier\u003e [package-index-options] ...\n  pip install [options] -r \u003crequirements file\u003e [package-index-options] ...\n  pip install [options] [-e] \u003cvcs project url\u003e ...\n  pip install [options] [-e] \u003clocal project path\u003e ...\n  pip install [options] \u003carchive url/path\u003e ...\n\nno such option: --install-options","commit_id":"3c0869ae97a54d30f9ff268713d97d98b2beac98"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"741232945f7eca1fae3c32ea4d0d2f46443758c8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        echo \"Unsupported init system\""},{"line_number":38,"context_line":"        exit 1"},{"line_number":39,"context_line":"        ;;"},{"line_number":40,"context_line":"esac"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"da6ed579_b2528233","side":"PARENT","line":40,"updated":"2016-01-15 12:36:24.000000000","message":"why is all this removed? do we install these files in some other place now?","commit_id":"db3ee03672fdc566d2eddf9efb4ba9071f37a9ee"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9cd2c3bb6f5a276b4b90f2ee32a74cc8e777fed2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        echo \"Unsupported init system\""},{"line_number":38,"context_line":"        exit 1"},{"line_number":39,"context_line":"        ;;"},{"line_number":40,"context_line":"esac"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"da6ed579_b459b65d","side":"PARENT","line":40,"updated":"2016-01-18 12:29:23.000000000","message":"yeah, or fix dib-init-system to only work for source installations... dunno","commit_id":"db3ee03672fdc566d2eddf9efb4ba9071f37a9ee"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"190d17cf59cb4a5911090946cd486ec8dd7d20d7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        echo \"Unsupported init system\""},{"line_number":38,"context_line":"        exit 1"},{"line_number":39,"context_line":"        ;;"},{"line_number":40,"context_line":"esac"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"da6ed579_c9498832","side":"PARENT","line":40,"in_reply_to":"da6ed579_b2528233","updated":"2016-01-15 13:00:28.000000000","message":"Because it\u0027s not needed anymore, we moved the .service files under init-scripts/\u003cinit system\u003e and the dib-init-system element will put them in the right place.","commit_id":"db3ee03672fdc566d2eddf9efb4ba9071f37a9ee"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d2355afbcddcabb4adc105f6308f76d2f5407160","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        echo \"Unsupported init system\""},{"line_number":38,"context_line":"        exit 1"},{"line_number":39,"context_line":"        ;;"},{"line_number":40,"context_line":"esac"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"da6ed579_c993c859","side":"PARENT","line":40,"in_reply_to":"da6ed579_c9498832","updated":"2016-01-15 13:05:51.000000000","message":"how does it work with package-based installs? are you sure we won\u0027t create always-failing services?","commit_id":"db3ee03672fdc566d2eddf9efb4ba9071f37a9ee"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c9ba592c20242cf18b3606ab1931b6ad1d6cbf76","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        echo \"Unsupported init system\""},{"line_number":38,"context_line":"        exit 1"},{"line_number":39,"context_line":"        ;;"},{"line_number":40,"context_line":"esac"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"da6ed579_34c0b44f","side":"PARENT","line":40,"in_reply_to":"da6ed579_c993c859","updated":"2016-01-15 15:50:15.000000000","message":"That\u0027s a good question, I don\u0027t know actually. Indeed it feels like this ironic-python-agent service will be a broken service (cause the packaged version is called openstack-ironic-python-agent).\n\nDo you think we should not use the dib-init-system and copy the service files manually as before?","commit_id":"db3ee03672fdc566d2eddf9efb4ba9071f37a9ee"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f2c62823420476a4fedec579a328c0fd6590eef3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"set -o nounset"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# install IPA"},{"line_number":24,"context_line":"pip install $IPADIR"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# deactivate the venv"},{"line_number":27,"context_line":"deactivate"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3a57f1b5_efe5c337","line":24,"updated":"2016-02-11 23:49:05.000000000","message":"so i think a better way to do this is just to call $IPADIR/venv/bin/pip install ... that will do it inside the virtualenv just fine and avoid this","commit_id":"854f68478b33c94493962cd06c31bb7835607f68"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fe18a971b5fe62dac68b98256b80708658e8432d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"set -o nounset"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# install IPA"},{"line_number":24,"context_line":"pip install $IPADIR"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# deactivate the venv"},{"line_number":27,"context_line":"deactivate"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"dae33548_9526c614","line":24,"in_reply_to":"3a57f1b5_2c8f572b","updated":"2016-02-15 04:04:01.000000000","message":"I understand you want this merged, but this isn\u0027t just a simple spelling mistake -- we\u0027re talking about replacing 12 rather dangerous lines due to their global setting nature (setup virtual env, override -u, deactive) with one very simple line (call the pip from the virtualenv).  let\u0027s get it right the first time...\n\nfwiw, i don\u0027t have any other issues with the code, so presumably i\u0027d have no issues giving it a +2 after that","commit_id":"854f68478b33c94493962cd06c31bb7835607f68"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1eb71638399e01792a95a544aa89416eeb5f7bd7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"set -o nounset"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# install IPA"},{"line_number":24,"context_line":"pip install $IPADIR"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# deactivate the venv"},{"line_number":27,"context_line":"deactivate"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3a57f1b5_2c8f572b","line":24,"in_reply_to":"3a57f1b5_efe5c337","updated":"2016-02-12 09:58:59.000000000","message":"Hi Ian,\n\nThanks for the review, I appreciate it. But this patch have been through a lot of \"better ways of doing some things\" (see the patch-set history).\n\nEvery time I change it I have to go and test it manually, because currently DIB is not tests from source in gate [0][1] (I\u0027ve to update those patches). I have to setup an environment, build the images and deploy a machine with it.\n\nI reckon the way you recommended may be better than what is present here, but they are also cosmetics (AFAIUI). This patch is trying to fix the problem of building a fedora image from source with IPA (the default deploy method for Ironic) since Oct 16 2015.\n\nI think we should merge it as-is to fix the problem, then, if someone wants to put a following patch to fix the cosmetics they are free to do so.\n\nSo, unless the way this patch is coded is really wrong, let\u0027s just go and merge it as-is and fix the problem. The lack of priority in this project is really hurting it. \n\n[0] https://review.openstack.org/#/c/257302/\n[1] https://review.openstack.org/#/c/219351/\n\nCheers,\nLucas","commit_id":"854f68478b33c94493962cd06c31bb7835607f68"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a6316f6fc6dd5e941ade853d564cacf3b94d7037","unresolved":false,"context_lines":[{"line_number":21,"context_line":"set -o nounset"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# install IPA"},{"line_number":24,"context_line":"pip install $IPADIR"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# deactivate the venv"},{"line_number":27,"context_line":"deactivate"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"dae33548_a0abb888","line":24,"in_reply_to":"dae33548_9526c614","updated":"2016-02-15 11:54:57.000000000","message":"Thanks, fair enough. I will give it a try today","commit_id":"854f68478b33c94493962cd06c31bb7835607f68"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"defcd1607e1c28e481a26f1e2ef49200af905354","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SCRIPTDIR\u003d$(dirname $0)"},{"line_number":10,"context_line":"IPADIR\u003d/usr/share/ironic-python-agent"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# create the virtual environment"},{"line_number":13,"context_line":"virtualenv $IPADIR/venv"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"9aed3d3a_d1e82c13","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":6},"updated":"2016-02-26 15:54:25.000000000","message":"Heh, when I first read this I thought it was a typo on IPADDR.\n\n/me has been doing too much networking lately :-)","commit_id":"006b3e6228af5d292ee682ba4b56dd1dd9bf8f6d"}],"elements/ironic-agent/install.d/ironic-agent-source-install/ironic-python-agent.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"afdb10ac895c2a7569620f5b15d5921618b3cbf8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"source venv/bin/activate"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# run IPA"},{"line_number":8,"context_line":"ironic-python-agent"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a2ca52d_d1765ad6","line":8,"updated":"2015-10-16 14:56:22.000000000","message":"it could be just /usr/share/ironic-python-agent/venv/bin/ironic-python-agent. Or maybe create a symlink in install for consistency with package-based installation...","commit_id":"300705be7d7ba3f63007d28094d8f289aec49728"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aefbf66e96cbea6ad8fbc014bb586510a3162fb3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if [ ${DIB_DEBUG_TRACE:-1} -gt 0 ]; then"},{"line_number":17,"context_line":"    set -x"},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":"set -eu"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a29b11f_22051545","line":16,"updated":"2015-10-21 13:08:20.000000000","message":"this will never be set, as this script is not run in DIB context","commit_id":"0387556da3ea92b2a565fda577dbfc7af01523d4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ead91fccad8d42955f757bba95f9ee4218ea5013","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if [ ${DIB_DEBUG_TRACE:-1} -gt 0 ]; then"},{"line_number":17,"context_line":"    set -x"},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":"set -eu"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a29b11f_62e0e696","line":16,"in_reply_to":"3a29b11f_22051545","updated":"2015-10-21 14:55:49.000000000","message":"Yes, but DIB was complaining if it wasn\u0027t set :-( it fails pep8 (maybe it\u0027s because of the .sh extension, I will try without it)","commit_id":"0387556da3ea92b2a565fda577dbfc7af01523d4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aefbf66e96cbea6ad8fbc014bb586510a3162fb3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"set -o pipefail"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# activate the venv \u0026\u0026 run IPA"},{"line_number":23,"context_line":"source /usr/share/ironic-python-agent/venv/bin/activate"},{"line_number":24,"context_line":"ironic-python-agent"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a29b11f_4202913e","line":23,"updated":"2015-10-21 13:08:20.000000000","message":"won\u0027t this activate fail as well? I\u0027d prefer just using an explicit path..","commit_id":"0387556da3ea92b2a565fda577dbfc7af01523d4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ead91fccad8d42955f757bba95f9ee4218ea5013","unresolved":false,"context_lines":[{"line_number":20,"context_line":"set -o pipefail"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# activate the venv \u0026\u0026 run IPA"},{"line_number":23,"context_line":"source /usr/share/ironic-python-agent/venv/bin/activate"},{"line_number":24,"context_line":"ironic-python-agent"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a29b11f_229c2e0e","line":23,"in_reply_to":"3a29b11f_4202913e","updated":"2015-10-21 14:55:49.000000000","message":"No because this is started by the sysvinit/systemd/upstart. The problem is to active the venv while it\u0027s in a chroot enviroment.","commit_id":"0387556da3ea92b2a565fda577dbfc7af01523d4"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"403e91e7f4ab33cc5f4991b232f818476fda4fd7","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# activate the venv \u0026\u0026 run IPA"},{"line_number":18,"context_line":"source /usr/share/ironic-python-agent/venv/bin/activate"},{"line_number":19,"context_line":"ironic-python-agent"}],"source_content_type":"text/x-sh","patch_set":6,"id":"fa80f949_bb954241","line":19,"updated":"2015-11-03 19:48:14.000000000","message":"Agreed - we can remove this script entirely by symlinking /usr/bin/ironic-python-agent to the venv (the service scripts point at /usr/bin/).","commit_id":"5c886ef7015e2a5abb0a6e33358fc2299e291827"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"581ed3a48951021e15868719a2370d19ed7e2993","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# activate the venv \u0026\u0026 run IPA"},{"line_number":18,"context_line":"source /usr/share/ironic-python-agent/venv/bin/activate"},{"line_number":19,"context_line":"ironic-python-agent"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1a26ad4f_f17e1b18","line":19,"updated":"2015-11-02 02:58:10.000000000","message":"I think it would be better to just symlink /usr/local/bin/ironic-python-agent to /usr/share/ironic-python-agent/venv/bin/ironic-python-agent\n\nthat way it is transparent, otherwise you\u0027d easily miss running it with this script","commit_id":"5c886ef7015e2a5abb0a6e33358fc2299e291827"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f504da318428b536d7dc5fc5598391d62da4aafd","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# activate the venv \u0026\u0026 run IPA"},{"line_number":18,"context_line":"source /usr/share/ironic-python-agent/venv/bin/activate"},{"line_number":19,"context_line":"ironic-python-agent"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ba8a016a_c92460c6","line":19,"in_reply_to":"fa80f949_bb954241","updated":"2015-11-19 10:42:19.000000000","message":"Done","commit_id":"5c886ef7015e2a5abb0a6e33358fc2299e291827"}]}