)]}'
{"bin/disk-image-create":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"034b7d2e8ebfba0256ff2a73852f869352b7a1e7","unresolved":false,"context_lines":[{"line_number":252,"context_line":"  # We set journal size to 64M so our journal is large enough when we"},{"line_number":253,"context_line":"  # perform an FS resize."},{"line_number":254,"context_line":"  MKFS_OPTS\u003d\"-i 4096 -J size\u003d64 $MKFS_OPTS\""},{"line_number":255,"context_line":"  du_size\u003d$(( $du_size + 65536 ))"},{"line_number":256,"context_line":"fi"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"_NEEDED_SIZE\u003d$(echo \"$du_size\" | awk \u0027 { print $1 + 64 - ( $1 % 64) } \u0027)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa80f949_2ddaed4c","side":"PARENT","line":255,"updated":"2015-11-06 18:28:29.000000000","message":"I\u0027m not sure we can just remove this.  In the case where we\u0027re automatically determining the size of the image, losing 65 MB of usable space may be a problem.  Imagine building a small ramdisk or something that has \u003c 100 MB of space to begin with.\n\nI\u0027d prefer to just wrap this in an if [ -z \"$DIB_IMAGE_SIZE\" ] or something to prevent it messing with the user configured size.","commit_id":"6f3185f251cc84318571941e255650275b735375"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"09ca31206490a86944223c64bb1a165b9cf4b17d","unresolved":false,"context_lines":[{"line_number":252,"context_line":"  # We set journal size to 64M so our journal is large enough when we"},{"line_number":253,"context_line":"  # perform an FS resize."},{"line_number":254,"context_line":"  MKFS_OPTS\u003d\"-i 4096 -J size\u003d64 $MKFS_OPTS\""},{"line_number":255,"context_line":"  du_size\u003d$(( $du_size + 65536 ))"},{"line_number":256,"context_line":"fi"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"_NEEDED_SIZE\u003d$(echo \"$du_size\" | awk \u0027 { print $1 + 64 - ( $1 % 64) } \u0027)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da85f559_5720c449","side":"PARENT","line":255,"in_reply_to":"fa80f949_2ddaed4c","updated":"2015-11-06 22:03:09.000000000","message":"Yeah, this is the challenge here.  Ok, I think I get your point here and will update.","commit_id":"6f3185f251cc84318571941e255650275b735375"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"034b7d2e8ebfba0256ff2a73852f869352b7a1e7","unresolved":false,"context_lines":[{"line_number":255,"context_line":"  du_size\u003d$(( $du_size + 65536 ))"},{"line_number":256,"context_line":"fi"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"_NEEDED_SIZE\u003d$(echo \"$du_size\" | awk \u0027 { print $1 + 64 - ( $1 % 64) } \u0027)"},{"line_number":259,"context_line":"truncate -s${_NEEDED_SIZE}K $TMP_IMAGE_PATH"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"if [ -n \"$MAX_ONLINE_RESIZE\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa80f949_4de5f135","side":"PARENT","line":258,"updated":"2015-11-06 18:28:29.000000000","message":"I don\u0027t want to drop this completely either.  It\u0027s a workaround for a bug in certain versions of qemu-img where it would sometimes give you a broken image if the size wasn\u0027t a multiple of 64.  In fact, this is what the comment on line 243 is referring to, and it shouldn\u0027t have been separated from the comment (who reviewed the previous change to this code? ;-).\n\nIf this doesn\u0027t cause any issues for your situation, I\u0027d say let\u0027s leave it here and always round to 64, but at the very least I want to keep it for the auto-calculated size case.","commit_id":"6f3185f251cc84318571941e255650275b735375"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"61b43d70a24f6bbd56024e87e7f5dc7e6098c623","unresolved":false,"context_lines":[{"line_number":255,"context_line":"  du_size\u003d$(( $du_size + 65536 ))"},{"line_number":256,"context_line":"fi"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"_NEEDED_SIZE\u003d$(echo \"$du_size\" | awk \u0027 { print $1 + 64 - ( $1 % 64) } \u0027)"},{"line_number":259,"context_line":"truncate -s${_NEEDED_SIZE}K $TMP_IMAGE_PATH"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"if [ -n \"$MAX_ONLINE_RESIZE\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da85f559_3a1ac56f","side":"PARENT","line":258,"in_reply_to":"da85f559_94e62ae7","updated":"2015-11-06 22:26:14.000000000","message":"echo 2097152 | awk \u0027 { print $1 + 64 - ( $1 % 64) } \u0027\n2097216\nThis is broken","commit_id":"6f3185f251cc84318571941e255650275b735375"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"09ca31206490a86944223c64bb1a165b9cf4b17d","unresolved":false,"context_lines":[{"line_number":255,"context_line":"  du_size\u003d$(( $du_size + 65536 ))"},{"line_number":256,"context_line":"fi"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"_NEEDED_SIZE\u003d$(echo \"$du_size\" | awk \u0027 { print $1 + 64 - ( $1 % 64) } \u0027)"},{"line_number":259,"context_line":"truncate -s${_NEEDED_SIZE}K $TMP_IMAGE_PATH"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"if [ -n \"$MAX_ONLINE_RESIZE\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da85f559_94e62ae7","side":"PARENT","line":258,"in_reply_to":"fa80f949_4de5f135","updated":"2015-11-06 22:03:09.000000000","message":"This is also a problem for defined sizes as the way this is coded it will also add onto the size of the image.  In the bug, this causes the image to be larger than a 2GB flavor can boot.","commit_id":"6f3185f251cc84318571941e255650275b735375"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"6dfacbd4695b4624b9023c2ca490a40ee550225c","unresolved":false,"context_lines":[{"line_number":252,"context_line":"  # We set journal size to 64M so our journal is large enough when we"},{"line_number":253,"context_line":"  # perform an FS resize."},{"line_number":254,"context_line":"  MKFS_OPTS\u003d\"-i 4096 -J size\u003d64 $MKFS_OPTS\""},{"line_number":255,"context_line":"  if [ -z \"$DIB_IMAGE_SIZE\" ]; then"},{"line_number":256,"context_line":"    du_size\u003d$(( $du_size + 65536 ))"},{"line_number":257,"context_line":"  fi"},{"line_number":258,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da85f559_6b638ab2","line":255,"updated":"2015-11-08 20:21:22.000000000","message":"It took me a bit to figure out the logic here, but I think this is correct. Can we get a comment here explaining it a bit, something like:\n\n\"Assume our image fits in the specified size - journal space, otherwise our image will be bigger than user specified \nsize.\"\n\nThis bit of code is pretty cryptic so it helps a lot for us to not regress...","commit_id":"f49ba5706ff45427d135c4037b507a705c845a4c"}]}