)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"f4aafd429519107aaac9153bd195c5d925ea74c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-13 12:09:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ironic-agent-troubleshoot element"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Troubleshooting a ramdisk can be quite hard, specially if you can not get"},{"line_number":10,"context_line":"a prompt you can enter commands to find out what went wrong. By default,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da85f559_299ec5b8","line":7,"updated":"2015-11-13 22:08:31.000000000","message":"Sorry this is going to be a bit of refactor work:\nI think we really should be avoiding putting ironic features in DIB. That being said - I think this is useful as a general-purpose element. Can we maybe rename this to something like image-troubleshooting which is more of a general purpose element useful for debugging?","commit_id":"98e1a996fa2a82d9723562ad52547b85f6200b4e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c1edc83c1a6fd7550264d8d93e76c88f09b77a76","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-13 12:09:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ironic-agent-troubleshoot element"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Troubleshooting a ramdisk can be quite hard, specially if you can not get"},{"line_number":10,"context_line":"a prompt you can enter commands to find out what went wrong. By default,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba8a016a_132b1132","line":7,"in_reply_to":"da85f559_29856558","updated":"2015-11-16 18:17:54.000000000","message":"Yes it could be used as a general-purpose element indeed, but since I was only testing it with IPA I thought about limit its scope a little.\n\nBut makes sense I will rename it to login-troubleshooting","commit_id":"98e1a996fa2a82d9723562ad52547b85f6200b4e"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"7ed0c085856fe382d95e185630276cf5a2cc82a3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-13 12:09:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ironic-agent-troubleshoot element"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Troubleshooting a ramdisk can be quite hard, specially if you can not get"},{"line_number":10,"context_line":"a prompt you can enter commands to find out what went wrong. By default,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da85f559_29856558","line":7,"in_reply_to":"da85f559_299ec5b8","updated":"2015-11-13 22:09:23.000000000","message":"I am going to bikeshed on the name even more - maybe login-troubleshooting? Other ideas are welcome too...","commit_id":"98e1a996fa2a82d9723562ad52547b85f6200b4e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d1403acbad651e7526ae5afce161255c954179c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-17 09:39:55 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add login-troubleshooting element"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Troubleshooting a ramdisk can be quite hard, specially if you can not get"},{"line_number":10,"context_line":"a prompt you can enter commands to find out what went wrong. By default,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba8a016a_beb725d7","line":7,"updated":"2015-11-17 21:13:03.000000000","message":"Not sure if troubleshooting is good name. I suspect some people will use it for different purposes. Actually this way we can create a rescue ramdisk (if you apply my comment below). Maybe \"login-credentials\"?","commit_id":"a66e8b84db34011fad97a689e80c83e58455a4c6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"47bfd334950246e94acaeb6f4120d8ae6eb02f97","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-17 09:39:55 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add login-troubleshooting element"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Troubleshooting a ramdisk can be quite hard, specially if you can not get"},{"line_number":10,"context_line":"a prompt you can enter commands to find out what went wrong. By default,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba8a016a_f1e38903","line":7,"in_reply_to":"ba8a016a_4ede8840","updated":"2015-11-18 08:41:01.000000000","message":"Hmm, not sure, I think \"logic-credentials\" would be clearer to people..","commit_id":"a66e8b84db34011fad97a689e80c83e58455a4c6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"838651233977bf38613ada172bfc6423fed8adf0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-17 09:39:55 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add login-troubleshooting element"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Troubleshooting a ramdisk can be quite hard, specially if you can not get"},{"line_number":10,"context_line":"a prompt you can enter commands to find out what went wrong. By default,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba8a016a_4ede8840","line":7,"in_reply_to":"ba8a016a_beb725d7","updated":"2015-11-17 22:20:08.000000000","message":"The name was a suggestion in the previous patch-set. But yeah, naming is hard.\n\nI kinda like the name \"dynamic-login\" since this allow the login credentials to change on boot time. WDYT?","commit_id":"a66e8b84db34011fad97a689e80c83e58455a4c6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d1403acbad651e7526ae5afce161255c954179c","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"rootpwd \u003d If the operator append rootpwd\u003d\"$PASSWORD\" to the kernel"},{"line_number":29,"context_line":"command line on boot, the helper script will set the root password to"},{"line_number":30,"context_line":"the one specified by this option."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: I6b87a1b90163d79745f30dfacd37516051fa0aea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba8a016a_deba29c0","line":30,"updated":"2015-11-17 21:13:03.000000000","message":"it\u0027s a bit harder, but let\u0027s accept already encrypted password, thus we\u0027ll achieve a bit more security","commit_id":"a66e8b84db34011fad97a689e80c83e58455a4c6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"47bfd334950246e94acaeb6f4120d8ae6eb02f97","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"rootpwd \u003d If the operator append rootpwd\u003d\"$PASSWORD\" to the kernel"},{"line_number":29,"context_line":"command line on boot, the helper script will set the root password to"},{"line_number":30,"context_line":"the one specified by this option."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: I6b87a1b90163d79745f30dfacd37516051fa0aea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba8a016a_11b5edec","line":30,"in_reply_to":"ba8a016a_8ebb10e5","updated":"2015-11-18 08:41:01.000000000","message":"The latter. I don\u0027t think that passing root password as clear text is of value.","commit_id":"a66e8b84db34011fad97a689e80c83e58455a4c6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"838651233977bf38613ada172bfc6423fed8adf0","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"rootpwd \u003d If the operator append rootpwd\u003d\"$PASSWORD\" to the kernel"},{"line_number":29,"context_line":"command line on boot, the helper script will set the root password to"},{"line_number":30,"context_line":"the one specified by this option."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: I6b87a1b90163d79745f30dfacd37516051fa0aea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba8a016a_8ebb10e5","line":30,"in_reply_to":"ba8a016a_deba29c0","updated":"2015-11-17 22:20:08.000000000","message":"++\n\nI can add support for that, you think it would be better as a new option? Or just modify the currently rootpwd to do it?","commit_id":"a66e8b84db34011fad97a689e80c83e58455a4c6"}],"elements/dynamic-login/README.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1bce0ef702b805b4b11da600f8dcc15a44cfa47e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  :Description: If the operator append rootpwd\u003d\"$ENCRYPTED_PASSWORD\" to the"},{"line_number":28,"context_line":"                kernel command line on boot, the helper script will set the"},{"line_number":29,"context_line":"                root password to the one specified by this option. Note that"},{"line_number":30,"context_line":"                this password should be an **encrypted** password."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba8a016a_1f9efd06","line":30,"updated":"2015-11-19 16:37:30.000000000","message":"1. please state how to generate a password\n\n2. it requires passing selinux\u003d0 to the command line\n\n3. both key and password must be quoted, it\u0027s not clear from this readme","commit_id":"1a1054e230d1e56737cb2f8b2b18573d3619e781"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"2b23d4022fcebb00b4b1222da6a06e96feddfd20","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                root password to the one specified by this option. Note that"},{"line_number":30,"context_line":"                this password should be **encrypted**. Encrypted passwords"},{"line_number":31,"context_line":"                can be generated using the ``openssl`` command, e.g:"},{"line_number":32,"context_line":"                *openssl passwd -1*."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba8a016a_f6ebe676","line":32,"updated":"2015-11-20 16:34:24.000000000","message":"You\u0027re specifying the MD5-based BSD password algorithm here, but AFAICT you don\u0027t specify an algorithm when you pass it to chpasswd.","commit_id":"4bab4b8ec297615313073813610287ed633c7101"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9b1cfaac873cf6d9cb73094f8d5debcd9bce3a0d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                root password to the one specified by this option. Note that"},{"line_number":30,"context_line":"                this password should be **encrypted**. Encrypted passwords"},{"line_number":31,"context_line":"                can be generated using the ``openssl`` command, e.g:"},{"line_number":32,"context_line":"                *openssl passwd -1*."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba8a016a_dcdb634e","line":32,"in_reply_to":"ba8a016a_f6ebe676","updated":"2015-11-20 16:47:20.000000000","message":"it\u0027s contained in the resulting hash","commit_id":"4bab4b8ec297615313073813610287ed633c7101"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9b1cfaac873cf6d9cb73094f8d5debcd9bce3a0d","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. note::"},{"line_number":36,"context_line":"   That the value of those parameter should be **quoted**, e.g:"},{"line_number":37,"context_line":"   sshkey\u003d\"ssh-rsa BBBA1NBzaC1yc2E ...\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba8a016a_bc78df2c","line":36,"updated":"2015-11-20 16:47:20.000000000","message":"nit: these parameters","commit_id":"4bab4b8ec297615313073813610287ed633c7101"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c9aa37bdb15e9f9e6370cc4cb5c9789d4650b356","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. note::"},{"line_number":36,"context_line":"   That the value of those parameter should be **quoted**, e.g:"},{"line_number":37,"context_line":"   sshkey\u003d\"ssh-rsa BBBA1NBzaC1yc2E ...\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba8a016a_37ede825","line":36,"in_reply_to":"ba8a016a_bc78df2c","updated":"2015-11-20 17:00:06.000000000","message":"s/That//\n\n:-(","commit_id":"4bab4b8ec297615313073813610287ed633c7101"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"d0e03b9bb3eeac93cf0776440f2ee2309249f4e1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  :Description: If the operator append rootpwd\u003d\"$ENCRYPTED_PASSWORD\" to the"},{"line_number":28,"context_line":"                kernel command line on boot, the helper script will set the"},{"line_number":29,"context_line":"                root password to the one specified by this option. Note that"},{"line_number":30,"context_line":"                this password should be **encrypted**. Encrypted passwords"},{"line_number":31,"context_line":"                can be generated using the ``openssl`` command, e.g:"},{"line_number":32,"context_line":"                *openssl passwd -1*."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a8ffd7b_3085c658","line":30,"updated":"2015-12-01 13:38:46.000000000","message":"the password must be encrypted given the usage of chpasswd -e. so i\u0027d s/should/must","commit_id":"25d3ee547176528e86d42eb026c99a134dff9452"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1cea140010b52900f8b805b116fd44d4a836a97f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  :Description: If the operator append rootpwd\u003d\"$ENCRYPTED_PASSWORD\" to the"},{"line_number":28,"context_line":"                kernel command line on boot, the helper script will set the"},{"line_number":29,"context_line":"                root password to the one specified by this option. Note that"},{"line_number":30,"context_line":"                this password should be **encrypted**. Encrypted passwords"},{"line_number":31,"context_line":"                can be generated using the ``openssl`` command, e.g:"},{"line_number":32,"context_line":"                *openssl passwd -1*."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a8ffd7b_d6d0f2cb","line":30,"in_reply_to":"9a8ffd7b_3085c658","updated":"2015-12-01 14:04:49.000000000","message":"Done","commit_id":"25d3ee547176528e86d42eb026c99a134dff9452"}],"elements/dynamic-login/init-scripts/systemd/dynamic-login.service":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"d0e03b9bb3eeac93cf0776440f2ee2309249f4e1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"After\u003dnetwork.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"ExecStart\u003d/usr/local/bin/dynamic-login"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[Install]"},{"line_number":9,"context_line":"WantedBy\u003dmulti-user.target"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9a8ffd7b_3098661b","line":6,"updated":"2015-12-01 13:38:46.000000000","message":"this is probably more accurately Type\u003doneshot instead of the default Type\u003dsimple","commit_id":"25d3ee547176528e86d42eb026c99a134dff9452"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1cea140010b52900f8b805b116fd44d4a836a97f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"After\u003dnetwork.target"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[Service]"},{"line_number":6,"context_line":"ExecStart\u003d/usr/local/bin/dynamic-login"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[Install]"},{"line_number":9,"context_line":"WantedBy\u003dmulti-user.target"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9a8ffd7b_d6e792aa","line":6,"in_reply_to":"9a8ffd7b_3098661b","updated":"2015-12-01 14:04:49.000000000","message":"Done","commit_id":"25d3ee547176528e86d42eb026c99a134dff9452"}],"elements/dynamic-login/init-scripts/upstart/dynamic-login.conf":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"28a81d2631bfc8f2ca741f3024a10ae04cf5cd05","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    echo Executing Dynamic Login"},{"line_number":12,"context_line":"end script"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"exec /usr/local/bin/dynamic-login"}],"source_content_type":"text/plain","patch_set":5,"id":"ba8a016a_8413efb7","line":14,"updated":"2015-11-17 23:11:19.000000000","message":"because this is not a long running service I think upstart will re-run this in a loop forever? If so, I think we want to do this as a pre-start script and no exec.","commit_id":"fcd25eb044d7b2d2fc7f8f2bbec0133aa430987c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fd6487bd38e05cdfe3def5c9acac510d864c7af1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    echo Executing Dynamic Login"},{"line_number":12,"context_line":"end script"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"exec /usr/local/bin/dynamic-login"}],"source_content_type":"text/plain","patch_set":5,"id":"ba8a016a_e7698b26","line":14,"in_reply_to":"ba8a016a_8413efb7","updated":"2015-11-18 09:38:15.000000000","message":"Right, I don\u0027t know much about upstart, but I\u0027ve thought it wouldn\u0027t since I\u0027ve removed the respawn [1] flag.\n\nTho, adding to the pre-start seems fine too. I will do that\n\n[1] http://upstart.ubuntu.com/wiki/Stanzas#respawn","commit_id":"fcd25eb044d7b2d2fc7f8f2bbec0133aa430987c"}],"elements/dynamic-login/package-installs.yaml":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"28a81d2631bfc8f2ca741f3024a10ae04cf5cd05","unresolved":false,"context_lines":[{"line_number":1,"context_line":"openssh-server:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba8a016a_64b4cbd0","line":1,"updated":"2015-11-17 23:11:19.000000000","message":"I am not sure we need to make this a dependency - this is still useful (possibly terminal login) without this package, and it is a lot easier to add dependencies as a user than remove them. Maybe we can just document that openssh-server package is required in order for the public key feature to work?","commit_id":"fcd25eb044d7b2d2fc7f8f2bbec0133aa430987c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fd6487bd38e05cdfe3def5c9acac510d864c7af1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"openssh-server:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba8a016a_07b7ef86","line":1,"in_reply_to":"ba8a016a_64b4cbd0","updated":"2015-11-18 09:38:15.000000000","message":"Right, I kinda disagree on being easier to add than remove features. They both looks pretty simpler, if you don\u0027t want openssh-server you can delete this file, it\u0027s just a rm.\n\nBut also, while terminal login is easier for testing or VMs the main goal of this element is to allow people to troubleshoot ramdisks on production, so this will more likely run on baremetal where SSH\u0027ing is handier and generic (IMHO) than console access (because it depends on the type of hardware and each one is a bit different).\n\nSo can we leave openssh-server installed by default?","commit_id":"fcd25eb044d7b2d2fc7f8f2bbec0133aa430987c"}],"elements/dynamic-login/static/usr/local/bin/dynamic-login":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0656d4485dd54085a9cb5d44cdefb95ee651247b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# root user"},{"line_number":19,"context_line":"if [[ $(\u003c/proc/cmdline) \u003d~ rootpwd\u003d\\\"([^\\\"]+)\\\" ]]; then"},{"line_number":20,"context_line":"    echo \"root:${BASH_REMATCH[1]}\" | chpasswd"},{"line_number":21,"context_line":"fi"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Reads an encrypted root password from the kernel command line and set"},{"line_number":24,"context_line":"# it to the root user"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba8a016a_d196854b","line":21,"updated":"2015-11-18 08:42:29.000000000","message":"I\u0027d prefer to leave only encrypted variant..","commit_id":"fcd25eb044d7b2d2fc7f8f2bbec0133aa430987c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fd6487bd38e05cdfe3def5c9acac510d864c7af1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# root user"},{"line_number":19,"context_line":"if [[ $(\u003c/proc/cmdline) \u003d~ rootpwd\u003d\\\"([^\\\"]+)\\\" ]]; then"},{"line_number":20,"context_line":"    echo \"root:${BASH_REMATCH[1]}\" | chpasswd"},{"line_number":21,"context_line":"fi"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Reads an encrypted root password from the kernel command line and set"},{"line_number":24,"context_line":"# it to the root user"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba8a016a_c7b1e790","line":21,"in_reply_to":"ba8a016a_d196854b","updated":"2015-11-18 09:38:15.000000000","message":"ack, will change it","commit_id":"fcd25eb044d7b2d2fc7f8f2bbec0133aa430987c"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"2b23d4022fcebb00b4b1222da6a06e96feddfd20","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Reads an encrypted root password from the kernel command line and set"},{"line_number":18,"context_line":"# it to the root user"},{"line_number":19,"context_line":"if [[ $(\u003c/proc/cmdline) \u003d~ rootpwd\u003d\\\"([^\\\"]+)\\\" ]]; then"},{"line_number":20,"context_line":"    echo \"root:${BASH_REMATCH[1]}\" | chpasswd -e"},{"line_number":21,"context_line":"fi"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Reads a sshkey from the kernel command line and appends it to the root"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"ba8a016a_d10a6c79","line":20,"updated":"2015-11-20 16:34:24.000000000","message":"I think this should be `chpasswd -e -c MD5`, to ensure consistency with README.rst.","commit_id":"4bab4b8ec297615313073813610287ed633c7101"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e078b1d28af4f186390c4c3afed86995f40d9b51","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Reads an encrypted root password from the kernel command line and set"},{"line_number":18,"context_line":"# it to the root user"},{"line_number":19,"context_line":"if [[ $(\u003c/proc/cmdline) \u003d~ rootpwd\u003d\\\"([^\\\"]+)\\\" ]]; then"},{"line_number":20,"context_line":"    echo \"root:${BASH_REMATCH[1]}\" | chpasswd -e"},{"line_number":21,"context_line":"fi"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Reads a sshkey from the kernel command line and appends it to the root"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"ba8a016a_f771a0a9","line":20,"in_reply_to":"ba8a016a_3ca5cfb4","updated":"2015-11-20 16:59:17.000000000","message":"@Dmitry right\n\n@Miles also -c and -e are exclusive flags","commit_id":"4bab4b8ec297615313073813610287ed633c7101"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9b1cfaac873cf6d9cb73094f8d5debcd9bce3a0d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Reads an encrypted root password from the kernel command line and set"},{"line_number":18,"context_line":"# it to the root user"},{"line_number":19,"context_line":"if [[ $(\u003c/proc/cmdline) \u003d~ rootpwd\u003d\\\"([^\\\"]+)\\\" ]]; then"},{"line_number":20,"context_line":"    echo \"root:${BASH_REMATCH[1]}\" | chpasswd -e"},{"line_number":21,"context_line":"fi"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Reads a sshkey from the kernel command line and appends it to the root"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"ba8a016a_3ca5cfb4","line":20,"in_reply_to":"ba8a016a_d10a6c79","updated":"2015-11-20 16:47:20.000000000","message":"Hashes are not necessary MD5","commit_id":"4bab4b8ec297615313073813610287ed633c7101"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"8323bde3996989a7f41a97bd0818cbd1a677137e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# dib-lint: disable\u003dsetu sete setpipefail dibdebugtrace"},{"line_number":3,"context_line":"# Copyright 2015 Red Hat, Inc."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9a8ffd7b_b82739b5","line":2,"updated":"2015-11-25 21:08:27.000000000","message":"Hrm. Why disable setu, set, and setpipefail? They\u0027re all useful in keeping the script from being frustrating to maintain.","commit_id":"25d3ee547176528e86d42eb026c99a134dff9452"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cc446eaaf4a80dd0a975f044ad428f27ce3eaf1a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# dib-lint: disable\u003dsetu sete setpipefail dibdebugtrace"},{"line_number":3,"context_line":"# Copyright 2015 Red Hat, Inc."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9a8ffd7b_f8f2a1d1","line":2,"in_reply_to":"9a8ffd7b_b82739b5","updated":"2015-11-25 21:19:29.000000000","message":"Agreed. I will enable it if I happen to have to submit a new patch-set","commit_id":"25d3ee547176528e86d42eb026c99a134dff9452"}],"elements/ironic-agent-troubleshoot/install.d/70-ironic-agent-troubleshoot-install":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"f4aafd429519107aaac9153bd195c5d925ea74c7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# Copy IPA troubleshoot script so services can use it"},{"line_number":12,"context_line":"cp ${SCRIPTDIR}/ironic-python-agent-troubleshoot /usr/bin/ironic-python-agent-troubleshoot"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"case \"$DIB_INIT_SYSTEM\" in"},{"line_number":15,"context_line":"    upstart)"},{"line_number":16,"context_line":"        install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent-troubleshoot.conf /etc/init/ironic-python-agent-troubleshoot.conf"},{"line_number":17,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da85f559_c9a4d909","line":14,"updated":"2015-11-13 22:08:31.000000000","message":"Have a look at the dib-init-system element. You probably will still need to enable the services manually, but that at least will remove a lot of the init script copying logic.","commit_id":"98e1a996fa2a82d9723562ad52547b85f6200b4e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c1edc83c1a6fd7550264d8d93e76c88f09b77a76","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# Copy IPA troubleshoot script so services can use it"},{"line_number":12,"context_line":"cp ${SCRIPTDIR}/ironic-python-agent-troubleshoot /usr/bin/ironic-python-agent-troubleshoot"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"case \"$DIB_INIT_SYSTEM\" in"},{"line_number":15,"context_line":"    upstart)"},{"line_number":16,"context_line":"        install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent-troubleshoot.conf /etc/init/ironic-python-agent-troubleshoot.conf"},{"line_number":17,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba8a016a_d31d8910","line":14,"in_reply_to":"da85f559_c9a4d909","updated":"2015-11-16 18:17:54.000000000","message":"Will do, thanks","commit_id":"98e1a996fa2a82d9723562ad52547b85f6200b4e"}],"elements/ironic-agent-troubleshoot/install.d/ironic-python-agent-troubleshoot":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"f4aafd429519107aaac9153bd195c5d925ea74c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"da85f559_e9a75d09","updated":"2015-11-13 22:08:31.000000000","message":"We should avoid puting data files inside of install.d - we have an install-static element which should work fine for copying this file to /usr/local/bin (I would also recommend using /usr/local/bin over /usr/bin).","commit_id":"98e1a996fa2a82d9723562ad52547b85f6200b4e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c1edc83c1a6fd7550264d8d93e76c88f09b77a76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba8a016a_731a9d19","in_reply_to":"da85f559_e9a75d09","updated":"2015-11-16 18:17:54.000000000","message":"Nice, thanks!","commit_id":"98e1a996fa2a82d9723562ad52547b85f6200b4e"}]}