)]}'
{"bin/disk-image-create":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"5276fb7e33e2e9a02e0b21a6c5d473314778f0ae","unresolved":false,"context_lines":[{"line_number":218,"context_line":"fi"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"if [[ -n \"${GENTOO_PROFILE}\" ]]; then"},{"line_number":221,"context_line":"    if [[ \"${GENTOO_PROFILE}\" \u003d\u003d *\"hardened\"* ]]; then"},{"line_number":222,"context_line":"        echo \u0027disabling tmpfs for gentoo hardened build\u0027"},{"line_number":223,"context_line":"        export DIB_NO_TMPFS\u003d1"},{"line_number":224,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"7a5de9d1_50cb9653","line":221,"updated":"2016-01-28 16:45:47.000000000","message":"I am not sure there are any bashate standards around this, but \u003d~ is a bit cleaner than this in my opinion\n\n    if [[ \"${GENTOO_PROFILE}\" \u003d~ \"hardened\" ]]; then","commit_id":"c98df13dd30290b2c9056897eef53c390c531b50"}],"elements/dib-init-system/dib-init-system":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"5276fb7e33e2e9a02e0b21a6c5d473314778f0ae","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [ -f /sbin/initctl ]; then"},{"line_number":10,"context_line":"    echo \"upstart\""},{"line_number":11,"context_line":"elif [ -f /etc/gentoo-release ]; then"},{"line_number":12,"context_line":"    if [[ \"${PROFILE}\" \u003d\u003d *systemd* ]]; then"},{"line_number":13,"context_line":"        echo \"systemd\""},{"line_number":14,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"7a5de9d1_30737a17","line":11,"updated":"2016-01-28 16:45:47.000000000","message":"esh. I would say use [[ ]] but then that breaks the coding style and consistency is important.\n\nReally this whole file needs to be updated to not use `test` but instead use [[ ]]. Thats outside the point of this patchset though","commit_id":"c98df13dd30290b2c9056897eef53c390c531b50"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"5276fb7e33e2e9a02e0b21a6c5d473314778f0ae","unresolved":false,"context_lines":[{"line_number":9,"context_line":"if [ -f /sbin/initctl ]; then"},{"line_number":10,"context_line":"    echo \"upstart\""},{"line_number":11,"context_line":"elif [ -f /etc/gentoo-release ]; then"},{"line_number":12,"context_line":"    if [[ \"${PROFILE}\" \u003d\u003d *systemd* ]]; then"},{"line_number":13,"context_line":"        echo \"systemd\""},{"line_number":14,"context_line":"    else"},{"line_number":15,"context_line":"        echo \"openrc\""}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"7a5de9d1_7050125f","line":12,"updated":"2016-01-28 16:45:47.000000000","message":"same comment about \u003d~ here","commit_id":"c98df13dd30290b2c9056897eef53c390c531b50"}],"elements/dib-init-system/post-install.d/10-enable-init-scripts":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"5276fb7e33e2e9a02e0b21a6c5d473314778f0ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then"},{"line_number":4,"context_line":"    set -x"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"set -eu"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"7a5de9d1_50039642","line":3,"updated":"2016-01-28 16:45:47.000000000","message":"[[ ]] instead of [ ]","commit_id":"c98df13dd30290b2c9056897eef53c390c531b50"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"5276fb7e33e2e9a02e0b21a6c5d473314778f0ae","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SCRIPTS_DIR\u003d\"$(dirname $0)/../init-scripts/${DIB_INIT_SYSTEM}/\""},{"line_number":10,"context_line":"if [ -d \"${SCRIPTS_DIR}\" ]; then"},{"line_number":11,"context_line":"    # figure out init prefix"},{"line_number":12,"context_line":"    DEST\u003d"},{"line_number":13,"context_line":"    case \"${DIB_INIT_SYSTEM}\" in"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"7a5de9d1_10fd1e3a","line":10,"updated":"2016-01-28 16:45:47.000000000","message":"[[ ]] instead of [ ]","commit_id":"c98df13dd30290b2c9056897eef53c390c531b50"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"5276fb7e33e2e9a02e0b21a6c5d473314778f0ae","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        sysv) DEST\u003d\u0027/etc/init.d/\u0027 ;;"},{"line_number":24,"context_line":"    esac"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    if [ -z \"${DEST}\" ]; then"},{"line_number":27,"context_line":"        echo \"ERROR: DIB_INIT_SYSTEM (${DIB_INIT_SYSTEM}) is not an unknown type\""},{"line_number":28,"context_line":"        exit 1"},{"line_number":29,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"7a5de9d1_909fce02","line":26,"updated":"2016-01-28 16:45:47.000000000","message":"[[ ]] instead of [ ]","commit_id":"c98df13dd30290b2c9056897eef53c390c531b50"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"7c511752e42030f64cd665f22f7ef146d4d45d00","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    esac"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    if [[ -z \"${DEST}\" ]]; then"},{"line_number":27,"context_line":"        echo \"ERROR: DIB_INIT_SYSTEM (${DIB_INIT_SYSTEM}) is not an unknown type\""},{"line_number":28,"context_line":"        exit 1"},{"line_number":29,"context_line":"    fi"},{"line_number":30,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"7a5de9d1_dba55bb5","line":27,"updated":"2016-01-28 21:08:52.000000000","message":"s/not an/an/","commit_id":"af2335a2343a2d811054c1f4b6b58171027dcde3"}],"elements/gentoo/bin/install-packages":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"5276fb7e33e2e9a02e0b21a6c5d473314778f0ae","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            rm /dev/shm.orig"},{"line_number":39,"context_line":"        fi"},{"line_number":40,"context_line":"        if [[ -d /dev/shm.orig ]]; then"},{"line_number":41,"context_line":"            rm -Rf /dev/shm.orig"},{"line_number":42,"context_line":"        fi"},{"line_number":43,"context_line":"        mv /dev/shm /dev/shm.orig"},{"line_number":44,"context_line":"        mkdir /dev/shm"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"7a5de9d1_1082fe94","line":41,"updated":"2016-01-28 16:45:47.000000000","message":"wasn\u0027t aware -r \u003d\u003d -R for rm. `rm -rf` is what I typically use. TIL","commit_id":"c98df13dd30290b2c9056897eef53c390c531b50"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"5681422e4d2dc78db81c0ac822d9c0394971d3c2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            rm /dev/shm.orig"},{"line_number":39,"context_line":"        fi"},{"line_number":40,"context_line":"        if [[ -d /dev/shm.orig ]]; then"},{"line_number":41,"context_line":"            rm -Rf /dev/shm.orig"},{"line_number":42,"context_line":"        fi"},{"line_number":43,"context_line":"        mv /dev/shm /dev/shm.orig"},{"line_number":44,"context_line":"        mkdir /dev/shm"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"7a5de9d1_cb04b77f","line":41,"in_reply_to":"7a5de9d1_1082fe94","updated":"2016-01-28 16:54:14.000000000","message":"I use -R as it\u0027s slightly harder to type","commit_id":"c98df13dd30290b2c9056897eef53c390c531b50"}],"elements/gentoo/post-install.d/01-cleanup":[{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"a49fd9736dd95025341ff52b8de469a7e35bef16","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# remove pyc/pyo files, they are regenerated on first run of module as needed"},{"line_number":25,"context_line":"find /usr/lib/python2.7 /usr/lib/python3.* -type f -regex .*.py[o,c] -exec rm {} \\;"},{"line_number":26,"context_line":"find /usr/lib/python2.7/test /usr/lib/python3.*/test -type f -exec rm -Rf {} \\;"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# make it so we don\u0027t have to reinstall grub"},{"line_number":29,"context_line":"mkdir /tmp/grub"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9a68dd71_3de3beda","line":26,"range":{"start_line":26,"start_character":67,"end_line":26,"end_character":76},"updated":"2016-01-25 18:18:56.000000000","message":"Why are you recursively deleting a file?  Directories should not be globbed by your find command.  Also `-delete` is probably faster here and in line 25, I believe this is using GNU find.  I just read about a -exec rm {} + (rather than \\;) which only spawns 1 rm fork for the operation if you\u0027re concerned about not having GNU find.","commit_id":"c85f3a07032e3d67fb77c942b17d2a57d6a03686"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"b87f09a268e89637beac9866674bbb91a675b78f","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# remove pyc/pyo files, they are regenerated on first run of module as needed"},{"line_number":25,"context_line":"find /usr/lib/python2.7 /usr/lib/python3.* -type f -regex .*.py[o,c] -exec rm {} \\;"},{"line_number":26,"context_line":"find /usr/lib/python2.7/test /usr/lib/python3.*/test -type f -exec rm -Rf {} \\;"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# make it so we don\u0027t have to reinstall grub"},{"line_number":29,"context_line":"mkdir /tmp/grub"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9a68dd71_9d28aa9b","line":26,"range":{"start_line":26,"start_character":67,"end_line":26,"end_character":76},"in_reply_to":"9a68dd71_3de3beda","updated":"2016-01-25 18:28:19.000000000","message":"ah, you are correct, will remove the -type f\n\nalso, this runs in a known environment, so gnu find can be trusted to be there","commit_id":"c85f3a07032e3d67fb77c942b17d2a57d6a03686"}],"elements/gentoo/post-install.d/99-cleanup":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"5276fb7e33e2e9a02e0b21a6c5d473314778f0ae","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# make it so we don\u0027t have to reinstall grub"},{"line_number":29,"context_line":"if [[ -a /usr/sbin/grub2-install ]]; then"},{"line_number":30,"context_line":"    mkdir /tmp/grub"},{"line_number":31,"context_line":"    touch /tmp/grub/install"},{"line_number":32,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"7a5de9d1_4b420740","line":30,"updated":"2016-01-28 16:45:47.000000000","message":"This command will fail if /tmp/grub already exists. If you use `mkdir -p /tmp/grub` it will not fail.\n\nAdditionally, can this be made into an autogenerated temp directory? It doesn\u0027t appear this way, but it is worth an ask since that would be the preferred method.","commit_id":"c98df13dd30290b2c9056897eef53c390c531b50"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"5681422e4d2dc78db81c0ac822d9c0394971d3c2","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# make it so we don\u0027t have to reinstall grub"},{"line_number":29,"context_line":"if [[ -a /usr/sbin/grub2-install ]]; then"},{"line_number":30,"context_line":"    mkdir /tmp/grub"},{"line_number":31,"context_line":"    touch /tmp/grub/install"},{"line_number":32,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"7a5de9d1_4b6e8730","line":30,"in_reply_to":"7a5de9d1_4b420740","updated":"2016-01-28 16:54:14.000000000","message":"the reason this is needed is because the bootloader element will reinstall grub, even it\u0027s already installed.  It checks for this file in this location.","commit_id":"c98df13dd30290b2c9056897eef53c390c531b50"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"7c511752e42030f64cd665f22f7ef146d4d45d00","unresolved":false,"context_lines":[{"line_number":22,"context_line":"find /usr/share/man/ -mindepth 1  -maxdepth 1 -path \"/usr/share/man/man*\" -prune -o -exec rm -rf {} \\;"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# remove pyc/pyo files, they are regenerated on first run of module as needed"},{"line_number":25,"context_line":"find /usr/lib/python2.7 /usr/lib/python3.* -type f -regex .*.py[o,c] -delete {} \\;"},{"line_number":26,"context_line":"rm -Rf /usr/lib/python2.7/test /usr/lib/python3.*/test"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# make it so we don\u0027t have to reinstall grub"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"7a5de9d1_7bac67a0","line":25,"updated":"2016-01-28 21:08:52.000000000","message":"Do we do this in other elements? The problem with this logic is that only root will have write access to /usr/lib/python*, so if you run the script as not-root, you end up having to do the heavy lifting that is cached for you in a .pyc/.pyo.","commit_id":"af2335a2343a2d811054c1f4b6b58171027dcde3"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"b6f1a7f2e64fe17a50ee0c295dafe13f3538df87","unresolved":false,"context_lines":[{"line_number":22,"context_line":"find /usr/share/man/ -mindepth 1  -maxdepth 1 -path \"/usr/share/man/man*\" -prune -o -exec rm -rf {} \\;"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# remove pyc/pyo files, they are regenerated on first run of module as needed"},{"line_number":25,"context_line":"find /usr/lib/python2.7 /usr/lib/python3.* -type f -regex .*.py[o,c] -delete {} \\;"},{"line_number":26,"context_line":"rm -Rf /usr/lib/python2.7/test /usr/lib/python3.*/test"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# make it so we don\u0027t have to reinstall grub"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"7a5de9d1_5bd88bef","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":82},"updated":"2016-01-28 21:17:01.000000000","message":"ok, I\u0027ll remove it and possibly make a new element for it specifically.","commit_id":"af2335a2343a2d811054c1f4b6b58171027dcde3"}],"elements/growroot/README.rst":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"5276fb7e33e2e9a02e0b21a6c5d473314778f0ae","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Grow the root partition on first boot."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This only supported on:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* ubuntu trusty or later"},{"line_number":10,"context_line":"* gentoo"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a5de9d1_6bab43d7","line":7,"updated":"2016-01-28 16:45:47.000000000","message":"This is*","commit_id":"c98df13dd30290b2c9056897eef53c390c531b50"}]}