)]}'
{"id":"openstack%2Fdiskimage-builder~273260","triplet_id":"openstack%2Fdiskimage-builder~master~I537510c14103933633eaefb08479bc1b36d914cd","project":"openstack/diskimage-builder","branch":"master","topic":"fix/build-dir-symlink","hashtags":[],"change_id":"I537510c14103933633eaefb08479bc1b36d914cd","subject":"Resolve sylinks when unmounting","status":"ABANDONED","created":"2016-01-27 22:22:46.000000000","updated":"2016-01-28 06:46:33.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9699c57f2a49b0813674a9cf92a1850e5d03e465","_number":273260,"virtual_id_number":273260,"owner":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"actions":{},"labels":{"Verified":{"all":[{"date":"2016-01-28 06:41:47.000000000","_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},{"date":"2016-01-28 06:26:48.000000000","_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-27 23:32:37.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-01-28 05:54:09.000000000","updated_by":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"reviewer":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"state":"REVIEWER"},{"updated":"2016-01-28 06:26:48.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"}],"messages":[{"id":"e319618847c4ee01b4f8aa5dca763e59ab23f8e6","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-01-27 22:22:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"684c120843b493fcf7e53ed622f22e443c9f4853","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-27 22:39:38.000000000","message":"Patch Set 1:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-f22-nonha http://logs.openstack.org/60/273260/1/check-tripleo/gate-tripleo-ci-f22-nonha/358f993/ : FAILURE in 16m 40s","accounts_in_message":[],"_revision_number":1},{"id":"b3d0dde7852fa9eaab327f67248979c313e5eb44","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-01-27 22:41:25.000000000","message":"Patch Set 1: Code-Review-1\n\ni hate to be pedantic, but this is obscure enough and with bad enough side-effects to warrant a comment in the code about being careful with that readlink IMO","accounts_in_message":[],"_revision_number":1},{"id":"9f45f13bedffb59b0e5f79618abbd5bcf46e436f","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-01-27 22:54:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b9e7c08f634d5915273bce99a67733869e8f4567","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-27 23:09:03.000000000","message":"Patch Set 2:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-f22-nonha http://logs.openstack.org/60/273260/2/check-tripleo/gate-tripleo-ci-f22-nonha/cd260c0/ : FAILURE in 14m 43s","accounts_in_message":[],"_revision_number":2},{"id":"1190144ada0aaf0df417dfa11b1026c87d7533a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-27 23:32:37.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-diskimage-builder-pep8 http://logs.openstack.org/60/273260/2/check/gate-diskimage-builder-pep8/d4c7f51/ : SUCCESS in 56s\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/60/273260/2/check/gate-diskimage-builder-docs/4ddcb45//doc/build/html/ : SUCCESS in 1m 06s\n- gate-diskimage-builder-python27 http://logs.openstack.org/60/273260/2/check/gate-diskimage-builder-python27/291299d/ : SUCCESS in 55s\n- gate-diskimage-builder-python34 http://logs.openstack.org/60/273260/2/check/gate-diskimage-builder-python34/af20b31/ : SUCCESS in 45s\n- gate-dib-dsvm-functests-devstack-trusty http://logs.openstack.org/60/273260/2/check/gate-dib-dsvm-functests-devstack-trusty/168151e/ : FAILURE in 2m 17s\n- gate-dib-dsvm-functests-devstack-centos7 http://logs.openstack.org/60/273260/2/check/gate-dib-dsvm-functests-devstack-centos7/89fe3e1/ : FAILURE in 2m 46s\n- gate-tempest-dsvm-ironic-pxe_ssh-dib http://logs.openstack.org/60/273260/2/check/gate-tempest-dsvm-ironic-pxe_ssh-dib/805f526/ : SUCCESS in 35m 38s","accounts_in_message":[],"_revision_number":2},{"id":"06ce9319a0fea54630cdaaddd74f67b750eee981","author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"date":"2016-01-28 05:54:09.000000000","message":"Patch Set 2: Code-Review+2\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"4e8a6402a59ea650b1d7d257f422d0973be768b3","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-01-28 06:08:18.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b7c3ff5cac924982af98198d1b21d245dfd71090","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-01-28 06:26:48.000000000","message":"Patch Set 3:\n\nI feel like fixing this at the underlying function might work better, to avoid the mistake happening again -- see  I335316019ef948758392b03e91f9869102a472b9","accounts_in_message":[],"_revision_number":3},{"id":"5cf71e9ecb6be43db1d909cc82ab059cb854a597","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-01-28 06:41:47.000000000","message":"Patch Set 3:\n\nI agree, but I\u0027d like to merge this ASAP if it passes tests since this bug is extremely bad. It shouldn\u0027t effect merging that patch later.","accounts_in_message":[],"_revision_number":3},{"id":"cbe1c861aa0599ace2b96d33ce8368395eed4b18","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-01-28 06:44:49.000000000","message":"Patch Set 3:\n\nActually, I am just going to merge yours and abandon this.","accounts_in_message":[],"_revision_number":3},{"id":"a7ad8a25cb24479baf8f612d701b609d3a951dd9","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-01-28 06:46:33.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"9d01bc7bd3248c4663361ea653b6ed06a6d231ad","revisions":{"e26eb2d0b733839501935ddf57435713b9ab1186":{"kind":"REWORK","_number":1,"created":"2016-01-27 22:22:46.000000000","uploader":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"ref":"refs/changes/60/273260/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/60/273260/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/60/273260/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/60/273260/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/60/273260/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/60/273260/1"}}},"commit":{"parents":[{"commit":"64e9c6eac33fdfd9e493f2fb842cf159d34bf273","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/64e9c6eac33fdfd9e493f2fb842cf159d34bf273"}]}],"author":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-01-27 22:21:39.000000000","tz":0},"committer":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-01-27 22:21:39.000000000","tz":0},"subject":"Resolve sylinks when unmounting","message":"Resolve sylinks when unmounting\n\nIf the build dir path has a symlink in it we will fail to unmount any of\nthe bind mounted dirs from our chroot. This is because the path we have\nfor the build dir will not match the prefix we check /proc/mounts\nagainst.\n\nChange-Id: I537510c14103933633eaefb08479bc1b36d914cd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/e26eb2d0b733839501935ddf57435713b9ab1186"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/e26eb2d0b733839501935ddf57435713b9ab1186"}]},"branch":"refs/heads/master"},"a6a69e3902bab9d8b4bb94834f38bfdb27c2230c":{"kind":"REWORK","_number":2,"created":"2016-01-27 22:54:09.000000000","uploader":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"ref":"refs/changes/60/273260/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/60/273260/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/60/273260/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/60/273260/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/60/273260/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/60/273260/2"}}},"commit":{"parents":[{"commit":"64e9c6eac33fdfd9e493f2fb842cf159d34bf273","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/64e9c6eac33fdfd9e493f2fb842cf159d34bf273"}]}],"author":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-01-27 22:21:39.000000000","tz":0},"committer":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-01-27 22:54:00.000000000","tz":0},"subject":"Resolve sylinks when unmounting","message":"Resolve sylinks when unmounting\n\nIf the build dir path has a symlink in it we will fail to unmount any of\nthe bind mounted dirs from our chroot. This is because the path we have\nfor the build dir will not match the prefix we check /proc/mounts\nagainst.\n\nChange-Id: I537510c14103933633eaefb08479bc1b36d914cd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/a6a69e3902bab9d8b4bb94834f38bfdb27c2230c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/a6a69e3902bab9d8b4bb94834f38bfdb27c2230c"}]},"branch":"refs/heads/master"},"9d01bc7bd3248c4663361ea653b6ed06a6d231ad":{"kind":"REWORK","_number":3,"created":"2016-01-28 06:08:18.000000000","uploader":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"ref":"refs/changes/60/273260/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/60/273260/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/60/273260/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/60/273260/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/60/273260/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/60/273260/3"}}},"commit":{"parents":[{"commit":"64e9c6eac33fdfd9e493f2fb842cf159d34bf273","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/64e9c6eac33fdfd9e493f2fb842cf159d34bf273"}]}],"author":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-01-27 22:21:39.000000000","tz":0},"committer":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-01-28 06:08:10.000000000","tz":0},"subject":"Resolve sylinks when unmounting","message":"Resolve sylinks when unmounting\n\nIf the build dir path has a symlink in it we will fail to unmount any of\nthe bind mounted dirs from our chroot. This is because the path we have\nfor the build dir will not match the prefix we check /proc/mounts\nagainst.\n\nChange-Id: I537510c14103933633eaefb08479bc1b36d914cd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/9d01bc7bd3248c4663361ea653b6ed06a6d231ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/9d01bc7bd3248c4663361ea653b6ed06a6d231ad"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}