)]}'
{"tests/dib_functions_test.sh":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"07e0033d4dc97df2db26801931bfcdbb1968730a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a5de9d1_a125feab","updated":"2016-01-28 06:45:38.000000000","message":"Why not add this to our run_tests.sh?","commit_id":"53c57d75c786f7b4f1aa267c93d2c5825e232767"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d371c6dcad5446ae02e1948461bfc612a9b1111b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a5de9d1_af6292ab","in_reply_to":"7a5de9d1_a125feab","updated":"2016-01-28 23:48:13.000000000","message":"so playing with this, i just about already destroyed my system.  i screwed up all my mounts, and then (mea culpa) figured i had to reboot anyway, so i did a \"dnf update\" ... but that created a totally borked initramfs (due to to something or other missing in the mounts i guess) and my system did not like to boot.  i had to pull a bit of recovery magic to get it all going again.\n\nso yeah, not confident :)","commit_id":"53c57d75c786f7b4f1aa267c93d2c5825e232767"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"81dad4bae4a5841844c0712b91a5a6cfd61938c5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# during testing, but not so great for CI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"source ../lib/common-functions"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# Directory mounting and unmounting"},{"line_number":13,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a5de9d1_38c5c78d","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":0},"updated":"2016-01-28 04:02:54.000000000","message":"set -eu? At a glance it looks safe enough for both of them, and if something fails maybe trap with an echo *** FAIL anyway?\n\nFeel free to ignore this bit, I don\u0027t mind.","commit_id":"53c57d75c786f7b4f1aa267c93d2c5825e232767"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"81dad4bae4a5841844c0712b91a5a6cfd61938c5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# umount devices"},{"line_number":38,"context_line":"unmount_dir $TMP_MOUNT_PATH"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"if [ $(grep \"$TMP_DIR\" /proc/mounts | wc -l) -ne 0 ]; then"},{"line_number":41,"context_line":"    echo \"*** FAILED due to mounts being left behind\""},{"line_number":42,"context_line":"    return 1"},{"line_number":43,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a5de9d1_38de276e","line":40,"range":{"start_line":40,"start_character":38,"end_line":40,"end_character":40},"updated":"2016-01-28 04:02:54.000000000","message":"It doesn\u0027t quite need to be this complex:\n\nif grep -q \"$TMP_DIR\" /proc/mounts; then\n\nsince you don\u0027t care about the output","commit_id":"53c57d75c786f7b4f1aa267c93d2c5825e232767"}]}