)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"05587ea9a23df208957a8cc7ca80f0c178f6ed0a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add new cloud-init element"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allows for composable builds"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I16f560ca4b1737c0928f3f3b15ea2580df820e97"},{"line_number":12,"context_line":"Closes-Bug: 1539272"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a5de9d1_24a71cbe","line":9,"updated":"2016-02-02 02:34:03.000000000","message":"presumable you mean the same thing as the \"-minimal\" builds for other platforms?","commit_id":"4c8b6b778d4e0ef90a14869c5c4407944b552704"}],"elements/cloud-init/README.rst":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"05587ea9a23df208957a8cc7ca80f0c178f6ed0a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"cloud-init"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Install\u0027s and enables cloud-init for systems that don\u0027t come with it"},{"line_number":6,"context_line":"pre-installed"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Currently only supports Gentoo."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a5de9d1_79df01d6","line":5,"updated":"2016-02-02 02:34:03.000000000","message":"nit: \"Installs\"","commit_id":"4c8b6b778d4e0ef90a14869c5c4407944b552704"}],"elements/cloud-init/package-installs.yaml":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"b85f6b1d864c276b8f309f10a8457228cc182546","unresolved":false,"context_lines":[{"line_number":1,"context_line":"cloud-init:"},{"line_number":2,"context_line":"  phase: pre-install.d"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a5de9d1_1e2dc8fd","line":2,"updated":"2016-02-01 05:05:32.000000000","message":"Why does this need to be in pre-install.d? If there is a reason it should be commented here, otherwise I\u0027d prefer to not specify a phase.","commit_id":"d04720b26972f90ae9aced2346a755c268737838"}],"elements/cloud-init/post-install.d/20-enable-cloud-init":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"2b7d40771d0205e1d19345b650c12d72c2fdc890","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# gentoo"},{"line_number":4,"context_line":"if [[ \"${DISTRO_NAME}\" \u003d\u003d \"gentoo\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a5de9d1_81809bf8","line":1,"updated":"2016-01-29 20:04:28.000000000","message":"using env to call bash is a bit strange. Is this common practice in cloud-init scripts?","commit_id":"7a8a9991095870bd6abd3dcc29369a6c4a4469ed"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"6939ea96ecf5d541b7443c170115acd434599b52","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then"},{"line_number":4,"context_line":"    set -x"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"set -eu"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a5de9d1_3e33e4ac","line":3,"updated":"2016-02-01 04:21:07.000000000","message":"[[ ]] rather than [ ]","commit_id":"e1792aa1648421512e3baaf8b2757380a8464807"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"813c7a478dcfbe630ae7dd6afd4a4d9407e47721","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then"},{"line_number":4,"context_line":"    set -x"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"set -eu"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a5de9d1_be94b442","line":3,"in_reply_to":"7a5de9d1_3e33e4ac","updated":"2016-02-01 04:32:37.000000000","message":"yo know, I coppied this from other existing modules :P","commit_id":"e1792aa1648421512e3baaf8b2757380a8464807"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"b85f6b1d864c276b8f309f10a8457228cc182546","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ${DIB_DEBUG_TRACE:-0} -gt 0 ]]; then"},{"line_number":4,"context_line":"    set -x"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"set -eu"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a5de9d1_1e9708ed","line":3,"updated":"2016-02-01 05:05:32.000000000","message":"I\u0027m not sure why this was called out in an earlier review, but we actually use test ( [] ) instead of bash conditionals where we can in DIB. There really is no great argument for why, just consistency.\n\nI am not actually -1 for this, just pointing it out.","commit_id":"d04720b26972f90ae9aced2346a755c268737838"}]}