)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"12a9c823f43605be33563fd1bd45d58a72aee8f4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew Thode \u003cmthode@mthode.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-28 18:50:57 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add support for openrc to dib-init-system"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"adds a post-install function that enables installed initscripts, as that is not"},{"line_number":10,"context_line":"  done by default in gentoo."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a5de9d1_a330669f","line":7,"updated":"2016-01-29 04:11:50.000000000","message":"style nit, but please capitalise, and flow comments to 80 chars","commit_id":"e8c4189daecba63cf67f81521287542fe58e24b1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"12a9c823f43605be33563fd1bd45d58a72aee8f4","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I04e8d506ddcbefa8a983dd31ad16df5e13cb26e7"},{"line_number":13,"context_line":"Closes-Bug: 1539276"},{"line_number":14,"context_line":"(cherry picked from commit b6759a2605198f57c33cd273f10cdefacb5fb212)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a5de9d1_c30482c1","line":14,"updated":"2016-01-29 04:11:50.000000000","message":"that\u0027s this commit?  is this left over","commit_id":"e8c4189daecba63cf67f81521287542fe58e24b1"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"25c730ba5fd588a37e0773eb7fda6a4bdd110bb3","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I04e8d506ddcbefa8a983dd31ad16df5e13cb26e7"},{"line_number":13,"context_line":"Closes-Bug: 1539276"},{"line_number":14,"context_line":"(cherry picked from commit b6759a2605198f57c33cd273f10cdefacb5fb212)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a5de9d1_e345feb2","line":14,"in_reply_to":"7a5de9d1_c30482c1","updated":"2016-01-29 04:16:40.000000000","message":"sorry, it\u0027s how I got the depend, just habbit, cherry-pick -x adds it.","commit_id":"e8c4189daecba63cf67f81521287542fe58e24b1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f2b25310a0c284c102a527013bd6eff104643da1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add support for OpenRC to dib-init-system"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds a post-install function that enables installed initscripts,"},{"line_number":10,"context_line":"  as that is not done by default in gentoo."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I04e8d506ddcbefa8a983dd31ad16df5e13cb26e7"},{"line_number":13,"context_line":"Closes-Bug: 1539276"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a5de9d1_a502f1b2","line":10,"updated":"2016-02-02 22:51:35.000000000","message":"if we come back around on this, please flow this to the left","commit_id":"3a9f523f0d9fea4f2de18699c09c2f1c75ea6a5f"}],"elements/dib-init-system/dib-init-system":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7f2c4479312445c28d20c72d691b3331f4e2e9dc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"if [[ -f /sbin/initctl ]]; then"},{"line_number":10,"context_line":"    echo \"upstart\""},{"line_number":11,"context_line":"elif [[ -f /etc/gentoo-release ]]; then"},{"line_number":12,"context_line":"    if [[ \"${PROFILE}\" \u003d~ systemd ]]; then"},{"line_number":13,"context_line":"        echo \"systemd\""},{"line_number":14,"context_line":"    else"},{"line_number":15,"context_line":"        echo \"openrc\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a5de9d1_3cf6e2d7","line":12,"updated":"2016-01-28 23:23:45.000000000","message":"this should probably be stacked on I7fb855249a9e6c9b6497ab5061b4ea3c014f5081 as that exports this","commit_id":"fcb50028b69a20fadaa6087ec590d683222f77f4"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"fcd322a0d2935bc63d6c6c553c89c9aa401a143e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ${DIB_DEBUG_TRACE:-0} -gt 0 ]]; then"},{"line_number":4,"context_line":"    set -x"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"set -eu"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a5de9d1_fea1cc46","line":3,"updated":"2016-02-01 05:06:51.000000000","message":"Please don\u0027t change these to bash builtins unless there is a reason to (like using regex conditionals).","commit_id":"255076152877f05b11057b8b37e5a498a0c9c033"}],"elements/dib-init-system/post-install.d/10-enable-init-scripts":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7f2c4479312445c28d20c72d691b3331f4e2e9dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ${DIB_DEBUG_TRACE:-0} -gt 0 ]]; then"},{"line_number":4,"context_line":"    set -x"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7a5de9d1_7ce1bafd","line":1,"updated":"2016-01-28 23:23:45.000000000","message":"what is this script doing?","commit_id":"fcb50028b69a20fadaa6087ec590d683222f77f4"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"12a9c823f43605be33563fd1bd45d58a72aee8f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ${DIB_DEBUG_TRACE:-0} -gt 0 ]]; then"},{"line_number":4,"context_line":"    set -x"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7a5de9d1_63eb4eb1","line":1,"updated":"2016-01-29 04:11:50.000000000","message":"so these scripts aren\u0027t getting picked up by dib-lint because they don\u0027t start with #!/bin/bash\n\nwhile this isn\u0027t wrong as such, for consistency let\u0027s stick with /bin/bash","commit_id":"e8c4189daecba63cf67f81521287542fe58e24b1"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"25c730ba5fd588a37e0773eb7fda6a4bdd110bb3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ${DIB_DEBUG_TRACE:-0} -gt 0 ]]; then"},{"line_number":4,"context_line":"    set -x"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7a5de9d1_e3ee5eb3","line":1,"in_reply_to":"7a5de9d1_63eb4eb1","updated":"2016-01-29 04:16:40.000000000","message":"booo, but ok","commit_id":"e8c4189daecba63cf67f81521287542fe58e24b1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"533b49bb77e8648d4589aa5407d038e26b356c34","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ${DIB_DEBUG_TRACE:-0} -gt 0 ]]; then"},{"line_number":4,"context_line":"    set -x"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a5de9d1_a9ba87be","line":1,"updated":"2016-01-29 05:40:14.000000000","message":"it seems like this script could do a lot less ... by just matching openrc and copying\n\nprobably, actually, for systemd it could enable the service too.  but for another day","commit_id":"255076152877f05b11057b8b37e5a498a0c9c033"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"77a277a7361aa4f0b9e44f18aaad770271409978","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ${DIB_DEBUG_TRACE:-0} -gt 0 ]]; then"},{"line_number":4,"context_line":"    set -x"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a5de9d1_490d138f","line":1,"in_reply_to":"7a5de9d1_a9ba87be","updated":"2016-01-29 05:43:32.000000000","message":"I wanted to limit this to gentoo, but did allow the other systems to do what they want here as well.  for the future","commit_id":"255076152877f05b11057b8b37e5a498a0c9c033"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"664f52ca34c70779b196f4171c7f072a167d61b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then"},{"line_number":4,"context_line":"    set -x"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a5de9d1_9998bd79","line":1,"updated":"2016-02-02 02:05:32.000000000","message":"looking at this file overall again, I think i\u0027d prefer to see it just restricted to enabling the services on gentoo and leave out the other platforms\n\nif someone is debugging this, they\u0027re going to have to read and parse the whole thing to figure out it\u0027s doing nothing.  better to just have less noise/code and have the script doing nothing, and if other platforms want to support it, they can add in (i think it makes sense for centos/fedora to add this in too ... but just not sure what it would break)","commit_id":"be4fe01c7b92d7dff44f0f2f56d5b5be823b4ad1"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"5595e96a316cf19dbe018ae4d85122fe5ec3fc4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then"},{"line_number":4,"context_line":"    set -x"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a5de9d1_b1547b21","line":1,"in_reply_to":"7a5de9d1_9998bd79","updated":"2016-02-02 21:19:53.000000000","message":"removed refrences to upstart, systemd and sysv","commit_id":"be4fe01c7b92d7dff44f0f2f56d5b5be823b4ad1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"664f52ca34c70779b196f4171c7f072a167d61b6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            DEST\u003d\u0027/etc/init.d\u0027"},{"line_number":17,"context_line":"            # only gentoo needs manual runlevel adding"},{"line_number":18,"context_line":"            for INIT_SCRIPT in \"${SCRIPTS_DIR}\"/*; do"},{"line_number":19,"context_line":"                rc-update add $(basename \"${DEST}${INIT_SCRIPT}\") default"},{"line_number":20,"context_line":"            done"},{"line_number":21,"context_line":"            ;;"},{"line_number":22,"context_line":"        systemd) DEST\u003d\u0027/usr/lib/systemd/system/\u0027 ;;"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a5de9d1_79994178","line":19,"updated":"2016-02-02 02:05:32.000000000","message":"isn\u0027t \"basename ${DEST}${INIT_SCRIPT}\" just equal to ${INIT_SCRIPT}?\n\nif feels like the whole DEST bit can go away","commit_id":"be4fe01c7b92d7dff44f0f2f56d5b5be823b4ad1"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"5595e96a316cf19dbe018ae4d85122fe5ec3fc4a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            DEST\u003d\u0027/etc/init.d\u0027"},{"line_number":17,"context_line":"            # only gentoo needs manual runlevel adding"},{"line_number":18,"context_line":"            for INIT_SCRIPT in \"${SCRIPTS_DIR}\"/*; do"},{"line_number":19,"context_line":"                rc-update add $(basename \"${DEST}${INIT_SCRIPT}\") default"},{"line_number":20,"context_line":"            done"},{"line_number":21,"context_line":"            ;;"},{"line_number":22,"context_line":"        systemd) DEST\u003d\u0027/usr/lib/systemd/system/\u0027 ;;"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a5de9d1_116c6f07","line":19,"in_reply_to":"7a5de9d1_79994178","updated":"2016-02-02 21:19:53.000000000","message":"no, as an example within the base od this git repo (cut off for brevity).\n\n    for element in elements/*; do echo $element; done\n    elements/apt-conf\n    elements/apt-preferences\n\nIt includes the path, so growroot\u0027s case would be as follows.\n\n    /tmp/in_target.d/post-install.d/../init-scripts/openrc//growroot","commit_id":"be4fe01c7b92d7dff44f0f2f56d5b5be823b4ad1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"664f52ca34c70779b196f4171c7f072a167d61b6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    esac"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    if [[ -z \"${DEST}\" ]]; then"},{"line_number":27,"context_line":"        echo \"ERROR: DIB_INIT_SYSTEM (${DIB_INIT_SYSTEM}) is not a unknown type\""},{"line_number":28,"context_line":"        exit 1"},{"line_number":29,"context_line":"    fi"},{"line_number":30,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a5de9d1_f9b531ec","line":27,"updated":"2016-02-02 02:05:32.000000000","message":"nit : grammar ... either \"is unknown\" or \"not a known\"","commit_id":"be4fe01c7b92d7dff44f0f2f56d5b5be823b4ad1"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"5595e96a316cf19dbe018ae4d85122fe5ec3fc4a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    esac"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    if [[ -z \"${DEST}\" ]]; then"},{"line_number":27,"context_line":"        echo \"ERROR: DIB_INIT_SYSTEM (${DIB_INIT_SYSTEM}) is not a unknown type\""},{"line_number":28,"context_line":"        exit 1"},{"line_number":29,"context_line":"    fi"},{"line_number":30,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a5de9d1_b1f8fb4a","line":27,"in_reply_to":"7a5de9d1_f9b531ec","updated":"2016-02-02 21:19:53.000000000","message":"fixed (also fixed the install.d one this was copied from)","commit_id":"be4fe01c7b92d7dff44f0f2f56d5b5be823b4ad1"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"baf6641a1373e661cdff9d8ab06cc661c302a9b0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            DEST\u003d\u0027/etc/init.d\u0027"},{"line_number":16,"context_line":"            # only gentoo needs manual runlevel adding"},{"line_number":17,"context_line":"            for INIT_SCRIPT in \"${SCRIPTS_DIR}\"*; do"},{"line_number":18,"context_line":"                rc-update add $(basename \"${DEST}${INIT_SCRIPT}\") default"},{"line_number":19,"context_line":"            done"},{"line_number":20,"context_line":"            ;;"},{"line_number":21,"context_line":"    esac"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7a5de9d1_2557e1cb","line":18,"updated":"2016-02-02 22:50:15.000000000","message":"i\u0027m still not getting what this is doing?\n\nbasename \"dir/${INIT_SCRIPT}\" is always just going to give you back the last part of ${INIT_SCRIPT}?\n\n${DEST}/$(basename ${INIT_SCRIPT}) might make sense to build the path to the file in /etc/init.d?","commit_id":"3a9f523f0d9fea4f2de18699c09c2f1c75ea6a5f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0d3423007480414e4195d8e68dba06481638a46e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"SCRIPTS_DIR\u003d\"$(dirname $0)/../init-scripts/${DIB_INIT_SYSTEM}/\""},{"line_number":10,"context_line":"if [[ -d \"${SCRIPTS_DIR}\" ]]; then"},{"line_number":11,"context_line":"    # figure out init prefix"},{"line_number":12,"context_line":"    DEST\u003d"},{"line_number":13,"context_line":"    case \"${DIB_INIT_SYSTEM}\" in"},{"line_number":14,"context_line":"        openrc)"},{"line_number":15,"context_line":"            DEST\u003d\u0027/etc/init.d\u0027"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"7a5de9d1_05d8a5ee","line":12,"updated":"2016-02-02 23:12:31.000000000","message":"so at this point, DEST\u003d is unused\n\nlet\u0027s just get rid of it, and move the \"-z ${DEST}\" bit at the end into the *) clause of the case and i think it\u0027s done","commit_id":"acd20a751bcd650db2ecce3ee8443c4e00d62f69"}]}