)]}'
{"elements/simple-init/install.d/50-simple-init":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"5a5556b3f0e1f2e1f2a9537e52d0d639025cdd7c","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"glean-install"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"if [[ -a /etc/gentoo-release ]]; then"},{"line_number":30,"context_line":"    rc-update add glean default"},{"line_number":31,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a5de9d1_be259409","line":29,"updated":"2016-02-01 04:55:31.000000000","message":"Can we just take care of this in glean-install instead?","commit_id":"e102931c0a36367a4c5c0478a2cdf02f989f8c78"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"cfcd8a7be13b9826f359c9283e47e81003bdb3e6","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"glean-install"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"if [[ -a /etc/gentoo-release ]]; then"},{"line_number":30,"context_line":"    rc-update add glean default"},{"line_number":31,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a5de9d1_9e8bf8c2","line":29,"in_reply_to":"7a5de9d1_be259409","updated":"2016-02-01 05:06:52.000000000","message":"technically, yes, but I do think it\u0027s generally good practice to keep installs away from init","commit_id":"e102931c0a36367a4c5c0478a2cdf02f989f8c78"}],"elements/simple-init/install.d/60-simple-init-remove-interfaces":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"f716da33add1fa2316ebb78130b92010f8c23d22","unresolved":false,"context_lines":[{"line_number":19,"context_line":"rm -f /etc/network/interfaces.d/eth0"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Gentoo"},{"line_number":22,"context_line":"rm -f /etc/conf.d/net*"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# /etc/network/interfaces distributions"},{"line_number":25,"context_line":"if [ -f \"/etc/network/interfaces\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a5de9d1_3943976e","line":22,"updated":"2016-02-02 19:59:13.000000000","message":"Is this too general? Like, should we be worried that it might go too far in the future? I imagine currently there\u0027s a default similar to the others. Anyway, just a thought, not a minus one.","commit_id":"4480b5edef28c612acbe2fce4f684f4d2266aed1"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"67112af9db28a9b3fa0eb724cca57e90d345bc99","unresolved":false,"context_lines":[{"line_number":19,"context_line":"rm -f /etc/network/interfaces.d/eth0"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Gentoo"},{"line_number":22,"context_line":"rm -f /etc/conf.d/net*"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# /etc/network/interfaces distributions"},{"line_number":25,"context_line":"if [ -f \"/etc/network/interfaces\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a5de9d1_6445e215","line":22,"in_reply_to":"7a5de9d1_3943976e","updated":"2016-02-02 20:08:57.000000000","message":"I could just not do anything there as they don\u0027t exist by default, but if another element ever adds them they will be missed","commit_id":"4480b5edef28c612acbe2fce4f684f4d2266aed1"}],"elements/simple-init/install.d/simple-init-repo-install/40-glean":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"37664337df7c73bac8f61bc22912840d49ed5e8f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"set -eu"},{"line_number":22,"context_line":"set -o pipefail"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"pip install glean"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a5de9d1_59d2d0d3","line":24,"updated":"2016-01-28 23:07:33.000000000","message":"why have you swapped these around?  the repo install should be getting from\n\n  source-repository-simple-init:glean git /tmp/glean.git https://git.openstack.org/openstack-infra/glean\n\n?","commit_id":"9d2585a2e1d481c91e7a7da0f580541ae6c3d6e4"}]}
